]> git.ipfire.org Git - people/arne_f/kernel.git/commit
cfg80211: check vendor command doit pointer before use
authorJulian Squires <julian@cipht.net>
Mon, 6 Jul 2020 21:13:53 +0000 (17:13 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Aug 2020 07:47:59 +0000 (09:47 +0200)
commitdf1a89577ebbb6165f3f1d9e1da84fda80dd7e01
tree38e0cfa4b18de97726a563902f286a2256058e44
parent59822dace1c9258c22ebf16adb1b49a6eff0bdf2
cfg80211: check vendor command doit pointer before use

[ Upstream commit 4052d3d2e8f47a15053320bbcbe365d15610437d ]

In the case where a vendor command does not implement doit, and has no
flags set, doit would not be validated and a NULL pointer dereference
would occur, for example when invoking the vendor command via iw.

I encountered this while developing new vendor commands.  Perhaps in
practice it is advisable to always implement doit along with dumpit,
but it seems reasonable to me to always check doit anyway, not just
when NEED_WDEV.

Signed-off-by: Julian Squires <julian@cipht.net>
Link: https://lore.kernel.org/r/20200706211353.2366470-1-julian@cipht.net
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/wireless/nl80211.c