]> git.ipfire.org Git - people/arne_f/kernel.git/commit
net: dsa: Fix network device registration order
authorFlorian Fainelli <f.fainelli@gmail.com>
Mon, 25 Sep 2017 22:55:53 +0000 (15:55 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 28 Sep 2017 17:12:53 +0000 (10:12 -0700)
commite804441cfe0b60f6c430901946a69c01eac09df1
treed32fc99880c3e77a1928ae68806475f88e00ca83
parentdb06ae41945b14feb7f696dcafe8048cc37e8a20
net: dsa: Fix network device registration order

We cannot be registering the network device first, then setting its
carrier off and finally connecting it to a PHY, doing that leaves a
window during which the carrier is at best inconsistent, and at worse
the device is not usable without a down/up sequence since the network
device is visible to user space with possibly no PHY device attached.

Re-order steps so that they make logical sense. This fixes some devices
where the port was not usable after e.g: an unbind then bind of the
driver.

Fixes: 0071f56e46da ("dsa: Register netdev before phy")
Fixes: 91da11f870f0 ("net: Distributed Switch Architecture protocol support")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/slave.c