]> git.ipfire.org Git - people/arne_f/kernel.git/commit
leds: 88pm860x: fix use-after-free on unbind
authorJohan Hovold <johan@kernel.org>
Mon, 1 Jun 2020 13:39:45 +0000 (15:39 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Aug 2020 07:47:59 +0000 (09:47 +0200)
commitefe1c042fa521dcce374ca23560480ff6927a58e
treeee46831e907ac049b2585ae1bd3fbfdac93c3724
parent661926601c318c4cf30272ac93ed2bf1c80ff778
leds: 88pm860x: fix use-after-free on unbind

commit eca21c2d8655387823d695b26e6fe78cf3975c05 upstream.

Several MFD child drivers register their class devices directly under
the parent device. This means you cannot blindly do devres conversions
so that deregistration ends up being tied to the parent device,
something which leads to use-after-free on driver unbind when the class
device is released while still being registered.

Fixes: 375446df95ee ("leds: 88pm860x: Use devm_led_classdev_register")
Cc: stable <stable@vger.kernel.org> # 4.6
Cc: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/leds/leds-88pm860x.c