]> git.ipfire.org Git - people/arne_f/kernel.git/commit
iio:adc:ina2xx Fix timestamp alignment issue.
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Wed, 22 Jul 2020 15:51:02 +0000 (16:51 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 31 Aug 2020 09:47:52 +0000 (10:47 +0100)
commitf8cd222feb82ecd82dcf610fcc15186f55f9c2b5
treea2a5284aaf02265a9eb8da218cba29afe146df66
parenta661b571e3682705cb402a5cd1e970586a3ec00f
iio:adc:ina2xx Fix timestamp alignment issue.

One of a class of bugs pointed out by Lars in a recent review.
iio_push_to_buffers_with_timestamp assumes the buffer used is aligned
to the size of the timestamp (8 bytes).  This is not guaranteed in
this driver which uses a 32 byte array of smaller elements on the stack.
As Lars also noted this anti pattern can involve a leak of data to
userspace and that indeed can happen here.  We close both issues by
moving to a suitable structure in the iio_priv() data with alignment
explicitly requested.  This data is allocated with kzalloc so no
data can leak apart from previous readings. The explicit alignment
isn't technically needed here, but it reduced fragility and avoids
cut and paste into drivers where it will be needed.

If we want this in older stables will need manual backport due to
driver reworks.

Fixes: c43a102e67db ("iio: ina2xx: add support for TI INA2xx Power Monitors")
Reported-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: Stefan BrĂ¼ns <stefan.bruens@rwth-aachen.de>
Cc: Marc Titinger <mtitinger@baylibre.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: <Stable@vger.kernel.org>
drivers/iio/adc/ina2xx-adc.c