]> git.ipfire.org Git - people/mfischer/ipfire-2.x.git/commitdiff
dhcp.cgi: Save fixed leases immediately after addition of a new lease
authorBernhard Bitsch <Bernhard.Bitsch@gmx.de>
Tue, 4 Jun 2019 10:24:00 +0000 (12:24 +0200)
committerMichael Tremer <michael.tremer@ipfire.org>
Tue, 4 Jun 2019 23:30:19 +0000 (00:30 +0100)
This changes the behaviour of the script to immediately save the added
lease to file but still remain in edit mode to make changes.

If the user does not make any changes, the lease is immediately saved
and there is no second click required to write it to file.

This a more natural flow that is expected by almost all users of this
feature.

Fixes: #12050
Signed-off-by: Bernhard Bitsch <bbitsch@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
html/cgi-bin/dhcp.cgi

index 675d8001200aa37eb8bfda4c2187f65b51b4cf49..19c55eb6d4c1c0722fd15ee56c75bdb7fe77626c 100644 (file)
@@ -443,6 +443,9 @@ if ($dhcpsettings{'ACTION'} eq $Lang::tr{'add'}.'2') {
        $dhcpsettings{'FIX_ROOTPATH'} = &Header::cleanhtml($dhcpsettings{'FIX_ROOTPATH'});
        if ($dhcpsettings{'KEY2'} eq '') { #add or edit ?
            unshift (@current2, "$dhcpsettings{'FIX_MAC'},$dhcpsettings{'FIX_ADDR'},$dhcpsettings{'FIX_ENABLED'},$dhcpsettings{'FIX_NEXTADDR'},$dhcpsettings{'FIX_FILENAME'},$dhcpsettings{'FIX_ROOTPATH'},$dhcpsettings{'FIX_REMARK'}\n");
+           open(FILE, ">$filename2") or die 'Unable to open fixed lease file.';
+           print FILE @current2;
+           close(FILE);
            &General::log($Lang::tr{'fixed ip lease added'});
 
            # Enter edit mode