]> git.ipfire.org Git - people/ms/linux.git/commit - fs/namespace.c
fs/mount_setattr: always cleanup mount_kattr
authorChristian Brauner <christian.brauner@ubuntu.com>
Thu, 30 Dec 2021 19:23:09 +0000 (20:23 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 30 Dec 2021 23:12:13 +0000 (15:12 -0800)
commit012e332286e2bb9f6ac77d195f17e74b2963d663
tree498edad3b725579e666efa4bec12762c9a071a13
parent74c78b4291b4466b44a57b3b7c3b98ad02628686
fs/mount_setattr: always cleanup mount_kattr

Make sure that finish_mount_kattr() is called after mount_kattr was
succesfully built in both the success and failure case to prevent
leaking any references we took when we built it.  We returned early if
path lookup failed thereby risking to leak an additional reference we
took when building mount_kattr when an idmapped mount was requested.

Cc: linux-fsdevel@vger.kernel.org
Cc: stable@vger.kernel.org
Fixes: 9caccd41541a ("fs: introduce MOUNT_ATTR_IDMAP")
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/namespace.c