]> git.ipfire.org Git - people/ms/linux.git/commit
net: marvell: Fix refcounting bugs in prestera_port_sfp_bind()
authorLiang He <windhl@126.com>
Wed, 21 Sep 2022 13:32:45 +0000 (21:32 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 22 Sep 2022 14:23:58 +0000 (07:23 -0700)
commit3aac7ada64d8c26ccc922f1ca966043c0dae88da
tree9f4e5c6aeffd666c4f87cffb270c8040b6418b42
parentc2e1cfefcac35e0eea229e148c8284088ce437b5
net: marvell: Fix refcounting bugs in prestera_port_sfp_bind()

In prestera_port_sfp_bind(), there are two refcounting bugs:
(1) we should call of_node_get() before of_find_node_by_name() as
it will automaitcally decrease the refcount of 'from' argument;
(2) we should call of_node_put() for the break of the iteration
for_each_child_of_node() as it will automatically increase and
decrease the 'child'.

Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
Signed-off-by: Liang He <windhl@126.com>
Reviewed-by: Yevhen Orlov <yevhen.orlov@plvision.eu>
Link: https://lore.kernel.org/r/20220921133245.4111672-1-windhl@126.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/prestera/prestera_main.c