]> git.ipfire.org Git - people/ms/linux.git/commit
nvme-tcp: always fail a request when sending it failed
authorSagi Grimberg <sagi@grimberg.me>
Sun, 26 Jun 2022 09:24:51 +0000 (12:24 +0300)
committerChristoph Hellwig <hch@lst.de>
Wed, 29 Jun 2022 14:13:45 +0000 (16:13 +0200)
commit41d07df7de841bfbc32725ce21d933ad358f2844
tree888073d35f1f919901025c01dde71a9fd99e371d
parented0691cf55140ce0f3fb100225645d902cce904b
nvme-tcp: always fail a request when sending it failed

queue stoppage and inflight requests cancellation is fully fenced from
io_work and thus failing a request from this context. Hence we don't
need to try to guess from the socket retcode if this failure is because
the queue is about to be torn down or not.

We are perfectly safe to just fail it, the request will not be cancelled
later on.

This solves possible very long shutdown delays when the users issues a
'nvme disconnect-all'

Reported-by: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/tcp.c