]> git.ipfire.org Git - people/ms/linux.git/commit
drm/vkms: Let shadow-plane helpers prepare the plane's FB
authorThomas Zimmermann <tzimmermann@suse.de>
Mon, 5 Jul 2021 07:46:32 +0000 (09:46 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Tue, 13 Jul 2021 11:31:08 +0000 (13:31 +0200)
commitb43e2ec03b0de040d536591713ea9c875ff34ba9
tree131289bf360d2905900a800bbc81cfb5e8b0fb35
parent7602d4221842c12777363591df04672e2c8b6a61
drm/vkms: Let shadow-plane helpers prepare the plane's FB

Replace vkms' prepare_fb and cleanup_fb functions with the generic
code for shadow-buffered planes. No functional changes.

This change also fixes a problem where IGT kms_flip tests would
create a segmentation fault within vkms. The driver's prepare_fb
function did not report an error if a BO's vmap operation failed.
The kernel later tried to operate on the non-mapped memory areas.
The shared shadow-plane helpers handle errors correctly, so that
the driver now avoids the segmantation fault.

v2:
* include paragraph about IGT tests in commit message (Melissa)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Melissa Wen <melissa.srw@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210705074633.9425-4-tzimmermann@suse.de
drivers/gpu/drm/vkms/vkms_plane.c