]> git.ipfire.org Git - people/ms/linux.git/commit
nvme-tcp: fix possible use-after-free in transport error_recovery work
authorSagi Grimberg <sagi@grimberg.me>
Tue, 1 Feb 2022 12:54:20 +0000 (14:54 +0200)
committerChristoph Hellwig <hch@lst.de>
Wed, 2 Feb 2022 08:19:07 +0000 (09:19 +0100)
commitff9fc7ebf5c06de1ef72a69f9b1ab40af8b07f9e
treec6603cffc5eb1d095d64a43715838734144c078d
parent0fa0f99fc84e41057cbdd2efbfe91c6b2f47dd9d
nvme-tcp: fix possible use-after-free in transport error_recovery work

While nvme_tcp_submit_async_event_work is checking the ctrl and queue
state before preparing the AER command and scheduling io_work, in order
to fully prevent a race where this check is not reliable the error
recovery work must flush async_event_work before continuing to destroy
the admin queue after setting the ctrl state to RESETTING such that
there is no race .submit_async_event and the error recovery handler
itself changing the ctrl state.

Tested-by: Chris Leech <cleech@redhat.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
drivers/nvme/host/tcp.c