]> git.ipfire.org Git - people/ms/linux.git/commit
mmc: sdhci-pxav3: fix setting of pdata->clk_delay_cycles
authorJisheng Zhang <jszhang@marvell.com>
Wed, 28 Jan 2015 11:54:12 +0000 (19:54 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Thu, 29 Jan 2015 10:10:11 +0000 (11:10 +0100)
commit14460dbaf7a5a0488963fdb8232ad5c8a8cca7b7
tree9c6c04d64ba6350550e5e0e4afcc1cf8f535b795
parent9608337945a658956b1b871347963d56e246b815
mmc: sdhci-pxav3: fix setting of pdata->clk_delay_cycles

Current code checks "clk_delay_cycles > 0" to know whether the optional
"mrvl,clk_delay_cycles" is set or not. But of_property_read_u32() doesn't
touch clk_delay_cycles if the property is not set. And type of
clk_delay_cycles is u32, so we may always set pdata->clk_delay_cycles as a
random value.

This patch fix this problem by check the return value of of_property_read_u32()
to know whether the optional clk-delay-cycles is set or not.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Cc: <stable@vger.kernel.org> # v3.6+
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-pxav3.c