From 0842edcc7c32b64208dc0be3709d2abeef6d7b19 Mon Sep 17 00:00:00 2001 From: Michael Tremer Date: Fri, 21 Sep 2018 15:00:44 +0200 Subject: [PATCH] Validate input for --offloading flag and throw an error when empty Signed-off-by: Michael Tremer --- src/functions/functions.util | 6 ++++++ src/hooks/ports/bonding | 5 ++++- src/hooks/ports/ethernet | 5 ++++- 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/functions/functions.util b/src/functions/functions.util index a326d239..8831d84b 100644 --- a/src/functions/functions.util +++ b/src/functions/functions.util @@ -266,6 +266,12 @@ enabled() { list_match "${!param}" yes on true 1 } +disabled() { + local param="${1}" + + list_match "${!param}" no off false 0 +} + mac_generate() { local b="$(random 12)" diff --git a/src/hooks/ports/bonding b/src/hooks/ports/bonding index 6248cc15..1a6399e8 100644 --- a/src/hooks/ports/bonding +++ b/src/hooks/ports/bonding @@ -52,8 +52,11 @@ hook_parse_cmdline() { if enabled OFFLOADING; then OFFLOADING="on" - else + elif disabled OFFLOADING; then OFFLOADING="off" + else + error "Invalid value for offloading: ${OFFLOADING}" + return ${EXIT_ERROR} fi ;; +*) diff --git a/src/hooks/ports/ethernet b/src/hooks/ports/ethernet index b782e52f..765d34db 100644 --- a/src/hooks/ports/ethernet +++ b/src/hooks/ports/ethernet @@ -83,8 +83,11 @@ hook_parse_cmdline() { if enabled OFFLOADING; then OFFLOADING="on" - else + elif disabled OFFLOADING; then OFFLOADING="off" + else + error "Invalid value for offloading: ${OFFLOADING}" + return ${EXIT_ERROR} fi ;; -- 2.39.2