]> git.ipfire.org Git - people/ms/u-boot.git/blame - common/cmd_sf.c
mtd, spi: Check if flash pointer is used
[people/ms/u-boot.git] / common / cmd_sf.c
CommitLineData
b6368467
HS
1/*
2 * Command for accessing SPI flash.
3 *
4 * Copyright (C) 2008 Atmel Corporation
0c88a84a
JT
5 *
6 * SPDX-License-Identifier: GPL-2.0+
b6368467 7 */
4166ee58 8
b6368467 9#include <common.h>
381c6e2c 10#include <div64.h>
fbb09918 11#include <dm.h>
8d1af942 12#include <malloc.h>
0eb25b61 13#include <mapmem.h>
ff0960f9 14#include <spi.h>
b6368467 15#include <spi_flash.h>
2ec1a405
HS
16#include <jffs2/jffs2.h>
17#include <linux/mtd/mtd.h>
b6368467
HS
18
19#include <asm/io.h>
fbb09918 20#include <dm/device-internal.h>
b6368467 21
b6368467
HS
22static struct spi_flash *flash;
23
334eb4b0
RR
24/*
25 * This function computes the length argument for the erase command.
26 * The length on which the command is to operate can be given in two forms:
27 * 1. <cmd> offset len - operate on <'offset', 'len')
28 * 2. <cmd> offset +len - operate on <'offset', 'round_up(len)')
29 * If the second form is used and the length doesn't fall on the
30 * sector boundary, than it will be adjusted to the next sector boundary.
31 * If it isn't in the flash, the function will fail (return -1).
32 * Input:
33 * arg: length specification (i.e. both command arguments)
34 * Output:
35 * len: computed length for operation
36 * Return:
37 * 1: success
38 * -1: failure (bad format, bad address).
39 */
40static int sf_parse_len_arg(char *arg, ulong *len)
41{
42 char *ep;
43 char round_up_len; /* indicates if the "+length" form used */
44 ulong len_arg;
45
46 round_up_len = 0;
47 if (*arg == '+') {
48 round_up_len = 1;
49 ++arg;
50 }
51
52 len_arg = simple_strtoul(arg, &ep, 16);
53 if (ep == arg || *ep != '\0')
54 return -1;
55
56 if (round_up_len && flash->sector_size > 0)
155cfb5e 57 *len = ROUND(len_arg, flash->sector_size);
334eb4b0
RR
58 else
59 *len = len_arg;
60
61 return 1;
62}
63
a683c288
JM
64/**
65 * This function takes a byte length and a delta unit of time to compute the
66 * approximate bytes per second
67 *
68 * @param len amount of bytes currently processed
69 * @param start_ms start time of processing in ms
70 * @return bytes per second if OK, 0 on error
71 */
72static ulong bytes_per_second(unsigned int len, ulong start_ms)
73{
74 /* less accurate but avoids overflow */
75 if (len >= ((unsigned int) -1) / 1024)
b4141195 76 return len / (max(get_timer(start_ms) / 1024, 1UL));
a683c288 77 else
b4141195 78 return 1024 * len / max(get_timer(start_ms), 1UL);
a683c288
JM
79}
80
54841ab5 81static int do_spi_flash_probe(int argc, char * const argv[])
b6368467 82{
c1173bd0
EN
83 unsigned int bus = CONFIG_SF_DEFAULT_BUS;
84 unsigned int cs = CONFIG_SF_DEFAULT_CS;
b6368467
HS
85 unsigned int speed = CONFIG_SF_DEFAULT_SPEED;
86 unsigned int mode = CONFIG_SF_DEFAULT_MODE;
87 char *endp;
fbb09918
SG
88#ifdef CONFIG_DM_SPI_FLASH
89 struct udevice *new, *bus_dev;
90 int ret;
91#else
b6368467 92 struct spi_flash *new;
fbb09918 93#endif
b6368467 94
c1173bd0
EN
95 if (argc >= 2) {
96 cs = simple_strtoul(argv[1], &endp, 0);
97 if (*argv[1] == 0 || (*endp != 0 && *endp != ':'))
8a07de03 98 return -1;
c1173bd0
EN
99 if (*endp == ':') {
100 if (endp[1] == 0)
101 return -1;
102
103 bus = cs;
104 cs = simple_strtoul(endp + 1, &endp, 0);
105 if (*endp != 0)
106 return -1;
107 }
b6368467
HS
108 }
109
110 if (argc >= 3) {
111 speed = simple_strtoul(argv[2], &endp, 0);
112 if (*argv[2] == 0 || *endp != 0)
8a07de03 113 return -1;
b6368467
HS
114 }
115 if (argc >= 4) {
6e8d58d3 116 mode = simple_strtoul(argv[3], &endp, 16);
b6368467 117 if (*argv[3] == 0 || *endp != 0)
8a07de03 118 return -1;
b6368467
HS
119 }
120
fbb09918
SG
121#ifdef CONFIG_DM_SPI_FLASH
122 /* Remove the old device, otherwise probe will just be a nop */
123 ret = spi_find_bus_and_cs(bus, cs, &bus_dev, &new);
124 if (!ret) {
125 device_remove(new);
126 device_unbind(new);
127 }
128 flash = NULL;
129 ret = spi_flash_probe_bus_cs(bus, cs, speed, mode, &new);
130 if (ret) {
131 printf("Failed to initialize SPI flash at %u:%u (error %d)\n",
132 bus, cs, ret);
133 return 1;
134 }
135
e564f054 136 flash = dev_get_uclass_priv(new);
fbb09918 137#else
8ee81b7f
HS
138 if (flash)
139 spi_flash_free(flash);
140
b6368467 141 new = spi_flash_probe(bus, cs, speed, mode);
8ee81b7f
HS
142 flash = new;
143
b6368467
HS
144 if (!new) {
145 printf("Failed to initialize SPI flash at %u:%u\n", bus, cs);
146 return 1;
147 }
148
b6368467 149 flash = new;
fbb09918 150#endif
b6368467 151
b6368467 152 return 0;
b6368467
HS
153}
154
8d1af942
SG
155/**
156 * Write a block of data to SPI flash, first checking if it is different from
157 * what is already there.
158 *
159 * If the data being written is the same, then *skipped is incremented by len.
160 *
161 * @param flash flash context pointer
162 * @param offset flash offset to write
163 * @param len number of bytes to write
164 * @param buf buffer to write from
165 * @param cmp_buf read buffer to use to compare data
166 * @param skipped Count of skipped data (incremented by this function)
167 * @return NULL if OK, else a string containing the stage which failed
168 */
169static const char *spi_flash_update_block(struct spi_flash *flash, u32 offset,
170 size_t len, const char *buf, char *cmp_buf, size_t *skipped)
171{
ed62756d
SR
172 char *ptr = (char *)buf;
173
a97f6efd 174 debug("offset=%#x, sector_size=%#x, len=%#zx\n",
402ba1e3 175 offset, flash->sector_size, len);
b95f958d
GF
176 /* Read the entire sector so to allow for rewriting */
177 if (spi_flash_read(flash, offset, flash->sector_size, cmp_buf))
8d1af942 178 return "read";
b95f958d 179 /* Compare only what is meaningful (len) */
8d1af942 180 if (memcmp(cmp_buf, buf, len) == 0) {
a97f6efd 181 debug("Skip region %x size %zx: no change\n",
402ba1e3 182 offset, len);
8d1af942
SG
183 *skipped += len;
184 return NULL;
185 }
34888506
GF
186 /* Erase the entire sector */
187 if (spi_flash_erase(flash, offset, flash->sector_size))
8d1af942 188 return "erase";
ed62756d 189 /* If it's a partial sector, copy the data into the temp-buffer */
b95f958d 190 if (len != flash->sector_size) {
ed62756d
SR
191 memcpy(cmp_buf, buf, len);
192 ptr = cmp_buf;
b95f958d 193 }
ed62756d
SR
194 /* Write one complete sector */
195 if (spi_flash_write(flash, offset, flash->sector_size, ptr))
196 return "write";
b95f958d 197
8d1af942
SG
198 return NULL;
199}
200
201/**
202 * Update an area of SPI flash by erasing and writing any blocks which need
203 * to change. Existing blocks with the correct data are left unchanged.
204 *
205 * @param flash flash context pointer
206 * @param offset flash offset to write
207 * @param len number of bytes to write
208 * @param buf buffer to write from
209 * @return 0 if ok, 1 on error
210 */
211static int spi_flash_update(struct spi_flash *flash, u32 offset,
212 size_t len, const char *buf)
213{
214 const char *err_oper = NULL;
215 char *cmp_buf;
216 const char *end = buf + len;
217 size_t todo; /* number of bytes to do in this pass */
8e8a4bc2 218 size_t skipped = 0; /* statistics */
a683c288
JM
219 const ulong start_time = get_timer(0);
220 size_t scale = 1;
221 const char *start_buf = buf;
222 ulong delta;
8d1af942 223
a683c288
JM
224 if (end - buf >= 200)
225 scale = (end - buf) / 100;
8d1af942
SG
226 cmp_buf = malloc(flash->sector_size);
227 if (cmp_buf) {
a683c288
JM
228 ulong last_update = get_timer(0);
229
8e8a4bc2 230 for (; buf < end && !err_oper; buf += todo, offset += todo) {
b4141195 231 todo = min_t(size_t, end - buf, flash->sector_size);
a683c288
JM
232 if (get_timer(last_update) > 100) {
233 printf(" \rUpdating, %zu%% %lu B/s",
402ba1e3 234 100 - (end - buf) / scale,
a683c288
JM
235 bytes_per_second(buf - start_buf,
236 start_time));
237 last_update = get_timer(0);
238 }
8d1af942
SG
239 err_oper = spi_flash_update_block(flash, offset, todo,
240 buf, cmp_buf, &skipped);
241 }
242 } else {
243 err_oper = "malloc";
244 }
245 free(cmp_buf);
a683c288 246 putc('\r');
8d1af942
SG
247 if (err_oper) {
248 printf("SPI flash failed in %s step\n", err_oper);
249 return 1;
250 }
a683c288
JM
251
252 delta = get_timer(start_time);
253 printf("%zu bytes written, %zu bytes skipped", len - skipped,
402ba1e3 254 skipped);
a683c288 255 printf(" in %ld.%lds, speed %ld B/s\n",
402ba1e3 256 delta / 1000, delta % 1000, bytes_per_second(len, start_time));
8e8a4bc2 257
8d1af942
SG
258 return 0;
259}
260
54841ab5 261static int do_spi_flash_read_write(int argc, char * const argv[])
b6368467
HS
262{
263 unsigned long addr;
b6368467
HS
264 void *buf;
265 char *endp;
60b6614a 266 int ret = 1;
2ec1a405
HS
267 int dev = 0;
268 loff_t offset, len, maxsize;
b6368467 269
2ec1a405 270 if (argc < 3)
8a07de03 271 return -1;
b6368467
HS
272
273 addr = simple_strtoul(argv[1], &endp, 16);
274 if (*argv[1] == 0 || *endp != 0)
8a07de03 275 return -1;
2ec1a405
HS
276
277 if (mtd_arg_off_size(argc - 2, &argv[2], &dev, &offset, &len,
278 &maxsize, MTD_DEV_TYPE_NOR, flash->size))
8a07de03 279 return -1;
b6368467 280
86493994
GF
281 /* Consistency checking */
282 if (offset + len > flash->size) {
283 printf("ERROR: attempting %s past flash size (%#x)\n",
402ba1e3 284 argv[0], flash->size);
86493994
GF
285 return 1;
286 }
287
b6368467
HS
288 buf = map_physmem(addr, len, MAP_WRBACK);
289 if (!buf) {
290 puts("Failed to map physical memory\n");
291 return 1;
292 }
293
402ba1e3 294 if (strcmp(argv[0], "update") == 0) {
8d1af942 295 ret = spi_flash_update(flash, offset, len, buf);
402ba1e3 296 } else if (strncmp(argv[0], "read", 4) == 0 ||
60b6614a
JT
297 strncmp(argv[0], "write", 5) == 0) {
298 int read;
299
300 read = strncmp(argv[0], "read", 4) == 0;
301 if (read)
302 ret = spi_flash_read(flash, offset, len, buf);
303 else
304 ret = spi_flash_write(flash, offset, len, buf);
305
306 printf("SF: %zu bytes @ %#x %s: %s\n", (size_t)len, (u32)offset,
402ba1e3 307 read ? "Read" : "Written", ret ? "ERROR" : "OK");
60b6614a 308 }
b6368467
HS
309
310 unmap_physmem(buf, len);
311
60b6614a 312 return ret == 0 ? 0 : 1;
b6368467
HS
313}
314
54841ab5 315static int do_spi_flash_erase(int argc, char * const argv[])
b6368467 316{
b6368467 317 int ret;
2ec1a405
HS
318 int dev = 0;
319 loff_t offset, len, maxsize;
320 ulong size;
b6368467
HS
321
322 if (argc < 3)
8a07de03 323 return -1;
b6368467 324
2ec1a405
HS
325 if (mtd_arg_off(argv[1], &dev, &offset, &len, &maxsize,
326 MTD_DEV_TYPE_NOR, flash->size))
8a07de03 327 return -1;
334eb4b0 328
2ec1a405 329 ret = sf_parse_len_arg(argv[2], &size);
334eb4b0 330 if (ret != 1)
8a07de03 331 return -1;
b6368467 332
86493994 333 /* Consistency checking */
2ec1a405 334 if (offset + size > flash->size) {
86493994 335 printf("ERROR: attempting %s past flash size (%#x)\n",
402ba1e3 336 argv[0], flash->size);
86493994
GF
337 return 1;
338 }
339
2ec1a405
HS
340 ret = spi_flash_erase(flash, offset, size);
341 printf("SF: %zu bytes @ %#x Erased: %s\n", (size_t)size, (u32)offset,
402ba1e3 342 ret ? "ERROR" : "OK");
b6368467 343
96bbf556 344 return ret == 0 ? 0 : 1;
b6368467
HS
345}
346
24007273
SG
347#ifdef CONFIG_CMD_SF_TEST
348enum {
349 STAGE_ERASE,
350 STAGE_CHECK,
351 STAGE_WRITE,
352 STAGE_READ,
353
354 STAGE_COUNT,
355};
356
357static char *stage_name[STAGE_COUNT] = {
358 "erase",
359 "check",
360 "write",
361 "read",
362};
363
364struct test_info {
365 int stage;
366 int bytes;
367 unsigned base_ms;
368 unsigned time_ms[STAGE_COUNT];
369};
370
371static void show_time(struct test_info *test, int stage)
372{
373 uint64_t speed; /* KiB/s */
374 int bps; /* Bits per second */
375
376 speed = (long long)test->bytes * 1000;
d1f22d4b
SG
377 if (test->time_ms[stage])
378 do_div(speed, test->time_ms[stage] * 1024);
24007273
SG
379 bps = speed * 8;
380
381 printf("%d %s: %d ticks, %d KiB/s %d.%03d Mbps\n", stage,
382 stage_name[stage], test->time_ms[stage],
383 (int)speed, bps / 1000, bps % 1000);
384}
385
386static void spi_test_next_stage(struct test_info *test)
387{
388 test->time_ms[test->stage] = get_timer(test->base_ms);
389 show_time(test, test->stage);
390 test->base_ms = get_timer(0);
391 test->stage++;
392}
393
394/**
395 * Run a test on the SPI flash
396 *
397 * @param flash SPI flash to use
398 * @param buf Source buffer for data to write
399 * @param len Size of data to read/write
400 * @param offset Offset within flash to check
401 * @param vbuf Verification buffer
402 * @return 0 if ok, -1 on error
403 */
1e7133e9
SG
404static int spi_flash_test(struct spi_flash *flash, uint8_t *buf, ulong len,
405 ulong offset, uint8_t *vbuf)
24007273
SG
406{
407 struct test_info test;
408 int i;
409
410 printf("SPI flash test:\n");
411 memset(&test, '\0', sizeof(test));
412 test.base_ms = get_timer(0);
413 test.bytes = len;
414 if (spi_flash_erase(flash, offset, len)) {
415 printf("Erase failed\n");
416 return -1;
417 }
418 spi_test_next_stage(&test);
419
420 if (spi_flash_read(flash, offset, len, vbuf)) {
421 printf("Check read failed\n");
422 return -1;
423 }
424 for (i = 0; i < len; i++) {
425 if (vbuf[i] != 0xff) {
426 printf("Check failed at %d\n", i);
b4141195
MY
427 print_buffer(i, vbuf + i, 1,
428 min_t(uint, len - i, 0x40), 0);
24007273
SG
429 return -1;
430 }
431 }
432 spi_test_next_stage(&test);
433
434 if (spi_flash_write(flash, offset, len, buf)) {
435 printf("Write failed\n");
436 return -1;
437 }
438 memset(vbuf, '\0', len);
439 spi_test_next_stage(&test);
440
441 if (spi_flash_read(flash, offset, len, vbuf)) {
442 printf("Read failed\n");
443 return -1;
444 }
445 spi_test_next_stage(&test);
446
447 for (i = 0; i < len; i++) {
448 if (buf[i] != vbuf[i]) {
449 printf("Verify failed at %d, good data:\n", i);
b4141195
MY
450 print_buffer(i, buf + i, 1,
451 min_t(uint, len - i, 0x40), 0);
24007273 452 printf("Bad data:\n");
b4141195
MY
453 print_buffer(i, vbuf + i, 1,
454 min_t(uint, len - i, 0x40), 0);
24007273
SG
455 return -1;
456 }
457 }
458 printf("Test passed\n");
459 for (i = 0; i < STAGE_COUNT; i++)
460 show_time(&test, i);
461
462 return 0;
463}
464
465static int do_spi_flash_test(int argc, char * const argv[])
466{
467 unsigned long offset;
468 unsigned long len;
d1f22d4b 469 uint8_t *buf, *from;
24007273 470 char *endp;
1e7133e9 471 uint8_t *vbuf;
24007273
SG
472 int ret;
473
d1f22d4b
SG
474 if (argc < 3)
475 return -1;
24007273
SG
476 offset = simple_strtoul(argv[1], &endp, 16);
477 if (*argv[1] == 0 || *endp != 0)
478 return -1;
479 len = simple_strtoul(argv[2], &endp, 16);
480 if (*argv[2] == 0 || *endp != 0)
481 return -1;
482
483 vbuf = malloc(len);
484 if (!vbuf) {
d1f22d4b 485 printf("Cannot allocate memory (%lu bytes)\n", len);
24007273
SG
486 return 1;
487 }
488 buf = malloc(len);
489 if (!buf) {
490 free(vbuf);
d1f22d4b 491 printf("Cannot allocate memory (%lu bytes)\n", len);
24007273
SG
492 return 1;
493 }
494
d1f22d4b
SG
495 from = map_sysmem(CONFIG_SYS_TEXT_BASE, 0);
496 memcpy(buf, from, len);
24007273
SG
497 ret = spi_flash_test(flash, buf, len, offset, vbuf);
498 free(vbuf);
499 free(buf);
500 if (ret) {
501 printf("Test failed\n");
502 return 1;
503 }
504
505 return 0;
506}
507#endif /* CONFIG_CMD_SF_TEST */
508
402ba1e3
JT
509static int do_spi_flash(cmd_tbl_t *cmdtp, int flag, int argc,
510 char * const argv[])
b6368467
HS
511{
512 const char *cmd;
8a07de03 513 int ret;
b6368467
HS
514
515 /* need at least two arguments */
516 if (argc < 2)
517 goto usage;
518
519 cmd = argv[1];
8a07de03
MF
520 --argc;
521 ++argv;
b6368467 522
8a07de03
MF
523 if (strcmp(cmd, "probe") == 0) {
524 ret = do_spi_flash_probe(argc, argv);
525 goto done;
526 }
b6368467
HS
527
528 /* The remaining commands require a selected device */
529 if (!flash) {
530 puts("No SPI flash selected. Please run `sf probe'\n");
531 return 1;
532 }
533
8d1af942
SG
534 if (strcmp(cmd, "read") == 0 || strcmp(cmd, "write") == 0 ||
535 strcmp(cmd, "update") == 0)
8a07de03
MF
536 ret = do_spi_flash_read_write(argc, argv);
537 else if (strcmp(cmd, "erase") == 0)
538 ret = do_spi_flash_erase(argc, argv);
24007273
SG
539#ifdef CONFIG_CMD_SF_TEST
540 else if (!strcmp(cmd, "test"))
541 ret = do_spi_flash_test(argc, argv);
542#endif
8a07de03
MF
543 else
544 ret = -1;
545
546done:
547 if (ret != -1)
548 return ret;
b6368467
HS
549
550usage:
4c12eeb8 551 return CMD_RET_USAGE;
b6368467
HS
552}
553
24007273
SG
554#ifdef CONFIG_CMD_SF_TEST
555#define SF_TEST_HELP "\nsf test offset len " \
556 "- run a very basic destructive test"
557#else
558#define SF_TEST_HELP
559#endif
560
b6368467
HS
561U_BOOT_CMD(
562 sf, 5, 1, do_spi_flash,
2fb2604d 563 "SPI flash sub-system",
c1173bd0 564 "probe [[bus:]cs] [hz] [mode] - init flash device on given SPI bus\n"
b6368467 565 " and chip select\n"
2ec1a405
HS
566 "sf read addr offset|partition len - read `len' bytes starting at\n"
567 " `offset' or from start of mtd\n"
568 " `partition'to memory at `addr'\n"
569 "sf write addr offset|partition len - write `len' bytes from memory\n"
570 " at `addr' to flash at `offset'\n"
571 " or to start of mtd `partition'\n"
572 "sf erase offset|partition [+]len - erase `len' bytes from `offset'\n"
573 " or from start of mtd `partition'\n"
574 " `+len' round up `len' to block size\n"
575 "sf update addr offset|partition len - erase and write `len' bytes from memory\n"
576 " at `addr' to flash at `offset'\n"
577 " or to start of mtd `partition'\n"
24007273 578 SF_TEST_HELP
a89c33db 579);