]> git.ipfire.org Git - people/ms/u-boot.git/blobdiff - cmd/eeprom.c
Convert CONFIG_CMD_EEPROM et al to Kconfig
[people/ms/u-boot.git] / cmd / eeprom.c
index 39ebee8dd9619927bbbf7af859c13ae8777bd944..c61b396a62b5d3eb662d861e53b143691b22592d 100644 (file)
@@ -24,6 +24,7 @@
 #include <config.h>
 #include <command.h>
 #include <i2c.h>
+#include <eeprom_layout.h>
 
 #ifndef        CONFIG_SYS_I2C_SPEED
 #define        CONFIG_SYS_I2C_SPEED    50000
@@ -72,11 +73,9 @@ void eeprom_init(int bus)
 #endif
 
        /* I2C EEPROM */
-#if defined(CONFIG_HARD_I2C) || defined(CONFIG_SYS_I2C)
 #if defined(CONFIG_SYS_I2C)
        if (bus >= 0)
                i2c_set_bus_num(bus);
-#endif
        i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);
 #endif
 }
@@ -207,8 +206,57 @@ int eeprom_write(unsigned dev_addr, unsigned offset,
        return ret;
 }
 
+static int parse_numeric_param(char *str)
+{
+       char *endptr;
+       int value = simple_strtol(str, &endptr, 16);
+
+       return (*endptr != '\0') ? -1 : value;
+}
+
+/**
+ * parse_i2c_bus_addr - parse the i2c bus and i2c devaddr parameters
+ *
+ * @i2c_bus:   address to store the i2c bus
+ * @i2c_addr:  address to store the device i2c address
+ * @argc:      count of command line arguments left to parse
+ * @argv:      command line arguments left to parse
+ * @argc_no_bus_addr:  argc value we expect to see when bus & addr aren't given
+ *
+ * @returns:   number of arguments parsed or CMD_RET_USAGE if error
+ */
+static int parse_i2c_bus_addr(int *i2c_bus, ulong *i2c_addr, int argc,
+                             char * const argv[], int argc_no_bus_addr)
+{
+       int argc_no_bus = argc_no_bus_addr + 1;
+       int argc_bus_addr = argc_no_bus_addr + 2;
+
+#ifdef CONFIG_SYS_DEF_EEPROM_ADDR
+       if (argc == argc_no_bus_addr) {
+               *i2c_bus = -1;
+               *i2c_addr = CONFIG_SYS_DEF_EEPROM_ADDR;
+
+               return 0;
+       }
+#endif
+       if (argc == argc_no_bus) {
+               *i2c_bus = -1;
+               *i2c_addr = parse_numeric_param(argv[0]);
+
+               return 1;
+       }
+
+       if (argc == argc_bus_addr) {
+               *i2c_bus = parse_numeric_param(argv[0]);
+               *i2c_addr = parse_numeric_param(argv[1]);
+
+               return 2;
+       }
+
+       return CMD_RET_USAGE;
+}
+
 #ifdef CONFIG_CMD_EEPROM_LAYOUT
-#include <eeprom_layout.h>
 
 __weak int eeprom_parse_layout_version(char *str)
 {
@@ -217,11 +265,11 @@ __weak int eeprom_parse_layout_version(char *str)
 
 static unsigned char eeprom_buf[CONFIG_SYS_EEPROM_SIZE];
 
-#ifndef CONFIG_EEPROM_LAYOUT_HELP_STRING
-#define CONFIG_EEPROM_LAYOUT_HELP_STRING "<not defined>"
 #endif
 
 enum eeprom_action {
+       EEPROM_READ,
+       EEPROM_WRITE,
        EEPROM_PRINT,
        EEPROM_UPDATE,
        EEPROM_ACTION_INVALID,
@@ -229,33 +277,52 @@ enum eeprom_action {
 
 static enum eeprom_action parse_action(char *cmd)
 {
+       if (!strncmp(cmd, "read", 4))
+               return EEPROM_READ;
+       if (!strncmp(cmd, "write", 5))
+               return EEPROM_WRITE;
+#ifdef CONFIG_CMD_EEPROM_LAYOUT
        if (!strncmp(cmd, "print", 5))
                return EEPROM_PRINT;
        if (!strncmp(cmd, "update", 6))
                return EEPROM_UPDATE;
+#endif
 
        return EEPROM_ACTION_INVALID;
 }
 
-static int parse_numeric_param(char *str)
-{
-       char *endptr;
-       int value = simple_strtol(str, &endptr, 16);
-
-       return (*endptr != '\0') ? -1 : value;
-}
-
 static int eeprom_execute_command(enum eeprom_action action, int i2c_bus,
-                                 int i2c_addr, int layout_ver, char *key,
-                                 char *value)
+                                 ulong i2c_addr, int layout_ver, char *key,
+                                 char *value, ulong addr, ulong off, ulong cnt)
 {
-       int rcode;
+       int rcode = 0;
+       const char *const fmt =
+               "\nEEPROM @0x%lX %s: addr %08lx  off %04lx  count %ld ... ";
+#ifdef CONFIG_CMD_EEPROM_LAYOUT
        struct eeprom_layout layout;
+#endif
 
        if (action == EEPROM_ACTION_INVALID)
                return CMD_RET_USAGE;
 
        eeprom_init(i2c_bus);
+       if (action == EEPROM_READ) {
+               printf(fmt, i2c_addr, "read", addr, off, cnt);
+
+               rcode = eeprom_read(i2c_addr, off, (uchar *)addr, cnt);
+
+               puts("done\n");
+               return rcode;
+       } else if (action == EEPROM_WRITE) {
+               printf(fmt, i2c_addr, "write", addr, off, cnt);
+
+               rcode = eeprom_write(i2c_addr, off, (uchar *)addr, cnt);
+
+               puts("done\n");
+               return rcode;
+       }
+
+#ifdef CONFIG_CMD_EEPROM_LAYOUT
        rcode = eeprom_read(i2c_addr, 0, eeprom_buf, CONFIG_SYS_EEPROM_SIZE);
        if (rcode < 0)
                return rcode;
@@ -271,17 +338,19 @@ static int eeprom_execute_command(enum eeprom_action action, int i2c_bus,
        layout.update(&layout, key, value);
 
        rcode = eeprom_write(i2c_addr, 0, layout.data, CONFIG_SYS_EEPROM_SIZE);
+#endif
 
        return rcode;
 }
 
 #define NEXT_PARAM(argc, index)        { (argc)--; (index)++; }
-static int do_eeprom_layout(cmd_tbl_t *cmdtp, int flag, int argc,
-                           char * const argv[])
+int do_eeprom(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
        int layout_ver = LAYOUT_VERSION_AUTODETECT;
        enum eeprom_action action = EEPROM_ACTION_INVALID;
-       int i2c_bus = -1, i2c_addr = -1, index = 0;
+       int i2c_bus = -1, index = 0;
+       ulong i2c_addr = -1, addr = 0, cnt = 0, off = 0;
+       int ret;
        char *field_name = "";
        char *field_value = "";
 
@@ -293,103 +362,63 @@ static int do_eeprom_layout(cmd_tbl_t *cmdtp, int flag, int argc,
        action = parse_action(argv[index]);
        NEXT_PARAM(argc, index);
 
-       if (argc <= 1)
-               return CMD_RET_USAGE;
-
-       if (!strcmp(argv[index], "-l")) {
-               NEXT_PARAM(argc, index);
-
-               layout_ver = eeprom_parse_layout_version(argv[index]);
-               NEXT_PARAM(argc, index);
-       }
-
-       if (argc <= 1)
+       if (action == EEPROM_ACTION_INVALID)
                return CMD_RET_USAGE;
 
-       i2c_bus = parse_numeric_param(argv[index]);
-       NEXT_PARAM(argc, index);
-
-       i2c_addr = parse_numeric_param(argv[index]);
-       NEXT_PARAM(argc, index);
-
-       if (action == EEPROM_PRINT)
-               goto done;
-
-       if (argc) {
-               field_name = argv[index];
-               NEXT_PARAM(argc, index);
-       }
-
-       if (argc) {
-               field_value = argv[index];
-               NEXT_PARAM(argc, index);
-       }
-
-done:
-       return eeprom_execute_command(action, i2c_bus, i2c_addr, layout_ver,
-                              field_name, field_value);
-}
-
-#endif
-
-static int do_eeprom(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
-{
-       const char *const fmt =
-               "\nEEPROM @0x%lX %s: addr %08lx  off %04lx  count %ld ... ";
-       char * const *args = &argv[2];
-       int rcode;
-       ulong dev_addr, addr, off, cnt;
-       int bus_addr;
-
 #ifdef CONFIG_CMD_EEPROM_LAYOUT
-       if (argc >= 2) {
-               if (!strcmp(argv[1], "update") || !strcmp(argv[1], "print"))
-                       return do_eeprom_layout(cmdtp, flag, argc, argv);
+       if (action == EEPROM_PRINT || action == EEPROM_UPDATE) {
+               if (!strcmp(argv[index], "-l")) {
+                       NEXT_PARAM(argc, index);
+                       layout_ver = eeprom_parse_layout_version(argv[index]);
+                       NEXT_PARAM(argc, index);
+               }
        }
 #endif
 
-       switch (argc) {
-#ifdef CONFIG_SYS_DEF_EEPROM_ADDR
-       case 5:
-               bus_addr = -1;
-               dev_addr = CONFIG_SYS_DEF_EEPROM_ADDR;
+       switch (action) {
+       case EEPROM_READ:
+       case EEPROM_WRITE:
+               ret = parse_i2c_bus_addr(&i2c_bus, &i2c_addr, argc,
+                                        argv + index, 3);
                break;
-#endif
-       case 6:
-               bus_addr = -1;
-               dev_addr = simple_strtoul(*args++, NULL, 16);
+       case EEPROM_PRINT:
+               ret = parse_i2c_bus_addr(&i2c_bus, &i2c_addr, argc,
+                                        argv + index, 0);
                break;
-       case 7:
-               bus_addr = simple_strtoul(*args++, NULL, 16);
-               dev_addr = simple_strtoul(*args++, NULL, 16);
+       case EEPROM_UPDATE:
+               ret = parse_i2c_bus_addr(&i2c_bus, &i2c_addr, argc,
+                                        argv + index, 2);
                break;
        default:
+               /* Get compiler to stop whining */
                return CMD_RET_USAGE;
        }
 
-       addr = simple_strtoul(*args++, NULL, 16);
-       off = simple_strtoul(*args++, NULL, 16);
-       cnt = simple_strtoul(*args++, NULL, 16);
-
-       eeprom_init(bus_addr);
-
-       if (strcmp(argv[1], "read") == 0) {
-               printf(fmt, dev_addr, argv[1], addr, off, cnt);
-
-               rcode = eeprom_read(dev_addr, off, (uchar *)addr, cnt);
+       if (ret == CMD_RET_USAGE)
+               return ret;
 
-               puts("done\n");
-               return rcode;
-       } else if (strcmp(argv[1], "write") == 0) {
-               printf(fmt, dev_addr, argv[1], addr, off, cnt);
+       while (ret--)
+               NEXT_PARAM(argc, index);
 
-               rcode = eeprom_write(dev_addr, off, (uchar *)addr, cnt);
+       if (action == EEPROM_READ || action == EEPROM_WRITE) {
+               addr = parse_numeric_param(argv[index]);
+               NEXT_PARAM(argc, index);
+               off = parse_numeric_param(argv[index]);
+               NEXT_PARAM(argc, index);
+               cnt = parse_numeric_param(argv[index]);
+       }
 
-               puts("done\n");
-               return rcode;
+#ifdef CONFIG_CMD_EEPROM_LAYOUT
+       if (action == EEPROM_UPDATE) {
+               field_name = argv[index];
+               NEXT_PARAM(argc, index);
+               field_value = argv[index];
+               NEXT_PARAM(argc, index);
        }
+#endif
 
-       return CMD_RET_USAGE;
+       return eeprom_execute_command(action, i2c_bus, i2c_addr, layout_ver,
+                                     field_name, field_value, addr, off, cnt);
 }
 
 U_BOOT_CMD(
@@ -400,9 +429,9 @@ U_BOOT_CMD(
        "       - read/write `cnt' bytes from `devaddr` EEPROM at offset `off'"
 #ifdef CONFIG_CMD_EEPROM_LAYOUT
        "\n"
-       "eeprom print [-l <layout_version>] bus devaddr\n"
+       "eeprom print [-l <layout_version>] <bus> <devaddr>\n"
        "       - Print layout fields and their data in human readable format\n"
-       "eeprom update [-l <layout_version>] bus devaddr <field_name> <field_value>\n"
+       "eeprom update [-l <layout_version>] <bus> <devaddr> field_name field_value\n"
        "       - Update a specific eeprom field with new data.\n"
        "         The new data must be written in the same human readable format as shown by the print command.\n"
        "\n"