]> git.ipfire.org Git - people/ms/u-boot.git/blobdiff - common/cmd_nand.c
Merge branch 'master' of git://git.denx.de/u-boot-avr32
[people/ms/u-boot.git] / common / cmd_nand.c
index 9e38bf768f984db114cc755a9e67f311cd297fc5..04b3200e57dd4790f4af1c27981af00aae3cf8fe 100644 (file)
 #include <common.h>
 
 
-#ifndef CFG_NAND_LEGACY
+#ifndef CONFIG_NAND_LEGACY
 /*
  *
  * New NAND support
  *
  */
 #include <common.h>
+#include <linux/mtd/mtd.h>
 
 #if defined(CONFIG_CMD_NAND)
 
 #include <jffs2/jffs2.h>
 #include <nand.h>
 
-#if defined(CONFIG_CMD_JFFS2) && defined(CONFIG_JFFS2_CMDLINE)
+#if defined(CONFIG_CMD_JFFS2) && defined(CONFIG_CMD_MTDPARTS)
 
 /* parition handling routines */
 int mtdparts_init(void);
 int id_parse(const char *id, const char **ret_id, u8 *dev_type, u8 *dev_num);
 int find_dev_and_part(const char *id, struct mtd_device **dev,
-               u8 *part_num, struct part_info **part);
+                     u8 *part_num, struct part_info **part);
 #endif
 
-static int nand_dump_oob(nand_info_t *nand, ulong off)
-{
-       return 0;
-}
-
-static int nand_dump(nand_info_t *nand, ulong off)
+static int nand_dump(nand_info_t *nand, ulong off, int only_oob)
 {
        int i;
-       u_char *buf, *p;
+       u_char *datbuf, *oobbuf, *p;
 
-       buf = malloc(nand->oobblock + nand->oobsize);
-       if (!buf) {
+       datbuf = malloc(nand->writesize + nand->oobsize);
+       oobbuf = malloc(nand->oobsize);
+       if (!datbuf || !oobbuf) {
                puts("No memory for page buffer\n");
                return 1;
        }
-       off &= ~(nand->oobblock - 1);
-       i = nand_read_raw(nand, buf, off, nand->oobblock, nand->oobsize);
+       off &= ~(nand->writesize - 1);
+       loff_t addr = (loff_t) off;
+       struct mtd_oob_ops ops;
+       memset(&ops, 0, sizeof(ops));
+       ops.datbuf = datbuf;
+       ops.oobbuf = oobbuf; /* must exist, but oob data will be appended to ops.datbuf */
+       ops.len = nand->writesize;
+       ops.ooblen = nand->oobsize;
+       ops.mode = MTD_OOB_RAW;
+       i = nand->read_oob(nand, addr, &ops);
        if (i < 0) {
                printf("Error (%d) reading page %08lx\n", i, off);
-               free(buf);
+               free(datbuf);
+               free(oobbuf);
                return 1;
        }
        printf("Page %08lx dump:\n", off);
-       i = nand->oobblock >> 4; p = buf;
+       i = nand->writesize >> 4;
+       p = datbuf;
+
        while (i--) {
-               printf( "\t%02x %02x %02x %02x %02x %02x %02x %02x"
-                       "  %02x %02x %02x %02x %02x %02x %02x %02x\n",
-                       p[0], p[1], p[2], p[3], p[4], p[5], p[6], p[7],
-                       p[8], p[9], p[10], p[11], p[12], p[13], p[14], p[15]);
+               if (!only_oob)
+                       printf("\t%02x %02x %02x %02x %02x %02x %02x %02x"
+                              "  %02x %02x %02x %02x %02x %02x %02x %02x\n",
+                              p[0], p[1], p[2], p[3], p[4], p[5], p[6], p[7],
+                              p[8], p[9], p[10], p[11], p[12], p[13], p[14],
+                              p[15]);
                p += 16;
        }
        puts("OOB:\n");
        i = nand->oobsize >> 3;
        while (i--) {
-               printf( "\t%02x %02x %02x %02x %02x %02x %02x %02x\n",
-                       p[0], p[1], p[2], p[3], p[4], p[5], p[6], p[7]);
+               printf("\t%02x %02x %02x %02x %02x %02x %02x %02x\n",
+                      p[0], p[1], p[2], p[3], p[4], p[5], p[6], p[7]);
                p += 8;
        }
-       free(buf);
+       free(datbuf);
+       free(oobbuf);
 
        return 0;
 }
@@ -94,7 +105,7 @@ static int
 arg_off_size(int argc, char *argv[], nand_info_t *nand, ulong *off, size_t *size)
 {
        int idx = nand_curr_device;
-#if defined(CONFIG_CMD_JFFS2) && defined(CONFIG_JFFS2_CMDLINE)
+#if defined(CONFIG_CMD_JFFS2) && defined(CONFIG_CMD_MTDPARTS)
        struct mtd_device *dev;
        struct part_info *part;
        u8 pnum;
@@ -142,26 +153,67 @@ arg_off_size(int argc, char *argv[], nand_info_t *nand, ulong *off, size_t *size
                *size = nand->size - *off;
        }
 
-#if  defined(CONFIG_CMD_JFFS2) && defined(CONFIG_JFFS2_CMDLINE)
+#if  defined(CONFIG_CMD_JFFS2) && defined(CONFIG_CMD_MTDPARTS)
 out:
 #endif
        printf("device %d ", idx);
        if (*size == nand->size)
                puts("whole chip\n");
        else
-               printf("offset 0x%lx, size 0x%x\n", *off, *size);
+               printf("offset 0x%lx, size 0x%zx\n", *off, *size);
        return 0;
 }
 
+#ifdef CONFIG_CMD_NAND_LOCK_UNLOCK
+static void print_status(ulong start, ulong end, ulong erasesize, int status)
+{
+       printf("%08lx - %08lx: %08lx blocks %s%s%s\n",
+               start,
+               end - 1,
+               (end - start) / erasesize,
+               ((status & NAND_LOCK_STATUS_TIGHT) ?  "TIGHT " : ""),
+               ((status & NAND_LOCK_STATUS_LOCK) ?  "LOCK " : ""),
+               ((status & NAND_LOCK_STATUS_UNLOCK) ?  "UNLOCK " : ""));
+}
+
+static void do_nand_status(nand_info_t *nand)
+{
+       ulong block_start = 0;
+       ulong off;
+       int last_status = -1;
+
+       struct nand_chip *nand_chip = nand->priv;
+       /* check the WP bit */
+       nand_chip->cmdfunc(nand, NAND_CMD_STATUS, -1, -1);
+       printf("device is %swrite protected\n",
+               (nand_chip->read_byte(nand) & 0x80 ?
+               "NOT " : ""));
+
+       for (off = 0; off < nand->size; off += nand->erasesize) {
+               int s = nand_get_lock_status(nand, off);
+
+               /* print message only if status has changed */
+               if (s != last_status && off != 0) {
+                       print_status(block_start, off, nand->erasesize,
+                                       last_status);
+                       block_start = off;
+               }
+               last_status = s;
+       }
+       /* Print the last block info */
+       print_status(block_start, off, nand->erasesize, last_status);
+}
+#endif
+
 int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
 {
-       int i, dev, ret;
+       int i, dev, ret = 0;
        ulong addr, off;
        size_t size;
        char *cmd, *s;
        nand_info_t *nand;
-#ifdef CFG_NAND_QUIET
-       int quiet = CFG_NAND_QUIET;
+#ifdef CONFIG_SYS_NAND_QUIET
+       int quiet = CONFIG_SYS_NAND_QUIET;
 #else
        int quiet = 0;
 #endif
@@ -179,11 +231,11 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
        if (strcmp(cmd, "info") == 0) {
 
                putc('\n');
-               for (i = 0; i < CFG_MAX_NAND_DEVICE; i++) {
+               for (i = 0; i < CONFIG_SYS_MAX_NAND_DEVICE; i++) {
                        if (nand_info[i].name)
                                printf("Device %d: %s, sector size %u KiB\n",
-                                       i, nand_info[i].name,
-                                       nand_info[i].erasesize >> 10);
+                                      i, nand_info[i].name,
+                                      nand_info[i].erasesize >> 10);
                }
                return 0;
        }
@@ -192,15 +244,15 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
 
                if (argc < 3) {
                        if ((nand_curr_device < 0) ||
-                           (nand_curr_device >= CFG_MAX_NAND_DEVICE))
+                           (nand_curr_device >= CONFIG_SYS_MAX_NAND_DEVICE))
                                puts("\nno devices available\n");
                        else
                                printf("\nDevice %d: %s\n", nand_curr_device,
-                                       nand_info[nand_curr_device].name);
+                                      nand_info[nand_curr_device].name);
                        return 0;
                }
                dev = (int)simple_strtoul(argv[2], NULL, 10);
-               if (dev < 0 || dev >= CFG_MAX_NAND_DEVICE || !nand_info[dev].name) {
+               if (dev < 0 || dev >= CONFIG_SYS_MAX_NAND_DEVICE || !nand_info[dev].name) {
                        puts("No such device\n");
                        return 1;
                }
@@ -208,7 +260,7 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                puts("... is now current device\n");
                nand_curr_device = dev;
 
-#ifdef CFG_NAND_SELECT_DEVICE
+#ifdef CONFIG_SYS_NAND_SELECT_DEVICE
                /*
                 * Select the chip in the board/cpu specific driver
                 */
@@ -227,7 +279,7 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                goto usage;
 
        /* the following commands operate on the current device */
-       if (nand_curr_device < 0 || nand_curr_device >= CFG_MAX_NAND_DEVICE ||
+       if (nand_curr_device < 0 || nand_curr_device >= CONFIG_SYS_MAX_NAND_DEVICE ||
            !nand_info[nand_curr_device].name) {
                puts("\nno devices available\n");
                return 1;
@@ -299,15 +351,14 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                off = (int)simple_strtoul(argv[2], NULL, 16);
 
                if (s != NULL && strcmp(s, ".oob") == 0)
-                       ret = nand_dump_oob(nand, off);
+                       ret = nand_dump(nand, off, 1);
                else
-                       ret = nand_dump(nand, off);
+                       ret = nand_dump(nand, off, 0);
 
                return ret == 0 ? 1 : 0;
 
        }
 
-       /* read write */
        if (strncmp(cmd, "read", 4) == 0 || strncmp(cmd, "write", 5) == 0) {
                int read;
 
@@ -322,46 +373,32 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                        return 1;
 
                s = strchr(cmd, '.');
-               if (s != NULL &&
-                   (!strcmp(s, ".jffs2") || !strcmp(s, ".e") || !strcmp(s, ".i"))) {
-                       if (read) {
-                               /* read */
-                               nand_read_options_t opts;
-                               memset(&opts, 0, sizeof(opts));
-                               opts.buffer     = (u_char*) addr;
-                               opts.length     = size;
-                               opts.offset     = off;
-                               opts.quiet      = quiet;
-                               ret = nand_read_opts(nand, &opts);
-                       } else {
-                               /* write */
-                               nand_write_options_t opts;
-                               memset(&opts, 0, sizeof(opts));
-                               opts.buffer     = (u_char*) addr;
-                               opts.length     = size;
-                               opts.offset     = off;
-                               /* opts.forcejffs2 = 1; */
-                               opts.pad        = 1;
-                               opts.blockalign = 1;
-                               opts.quiet      = quiet;
-                               ret = nand_write_opts(nand, &opts);
-                       }
-               } else if (s != NULL && !strcmp(s, ".oob")) {
-                       /* read out-of-band data */
+               if (!s || !strcmp(s, ".jffs2") ||
+                   !strcmp(s, ".e") || !strcmp(s, ".i")) {
                        if (read)
-                               ret = nand->read_oob(nand, off, size, &size,
-                                                    (u_char *) addr);
+                               ret = nand_read_skip_bad(nand, off, &size,
+                                                        (u_char *)addr);
                        else
-                               ret = nand->write_oob(nand, off, size, &size,
-                                                     (u_char *) addr);
-               } else {
+                               ret = nand_write_skip_bad(nand, off, &size,
+                                                         (u_char *)addr);
+               } else if (s != NULL && !strcmp(s, ".oob")) {
+                       /* out-of-band data */
+                       mtd_oob_ops_t ops = {
+                               .oobbuf = (u8 *)addr,
+                               .ooblen = size,
+                               .mode = MTD_OOB_RAW
+                       };
+
                        if (read)
-                               ret = nand_read(nand, off, &size, (u_char *)addr);
+                               ret = nand->read_oob(nand, off, &ops);
                        else
-                               ret = nand_write(nand, off, &size, (u_char *)addr);
+                               ret = nand->write_oob(nand, off, &ops);
+               } else {
+                       printf("Unknown nand command suffix '%s'.\n", s);
+                       return 1;
                }
 
-               printf(" %d bytes %s: %s\n", size,
+               printf(" %zu bytes %s: %s\n", size,
                       read ? "read" : "written", ret ? "ERROR" : "OK");
 
                return ret == 0 ? 0 : 1;
@@ -381,13 +418,15 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                }
                return 1;
        }
+
        if (strcmp(cmd, "biterr") == 0) {
                /* todo */
                return 1;
        }
 
+#ifdef CONFIG_CMD_NAND_LOCK_UNLOCK
        if (strcmp(cmd, "lock") == 0) {
-               int tight  = 0;
+               int tight = 0;
                int status = 0;
                if (argc == 3) {
                        if (!strcmp("tight", argv[2]))
@@ -395,39 +434,8 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                        if (!strcmp("status", argv[2]))
                                status = 1;
                }
-
                if (status) {
-                       ulong block_start = 0;
-                       ulong off;
-                       int last_status = -1;
-
-                       struct nand_chip *nand_chip = nand->priv;
-                       /* check the WP bit */
-                       nand_chip->cmdfunc (nand, NAND_CMD_STATUS, -1, -1);
-                       printf("device is %swrite protected\n",
-                              (nand_chip->read_byte(nand) & 0x80 ?
-                               "NOT " : "" ) );
-
-                       for (off = 0; off < nand->size; off += nand->oobblock) {
-                               int s = nand_get_lock_status(nand, off);
-
-                               /* print message only if status has changed
-                                * or at end of chip
-                                */
-                               if (off == nand->size - nand->oobblock
-                                   || (s != last_status && off != 0))  {
-
-                                       printf("%08lx - %08lx: %8lu pages %s%s%s\n",
-                                              block_start,
-                                              off-1,
-                                              (off-block_start)/nand->oobblock,
-                                              ((last_status & NAND_LOCK_STATUS_TIGHT) ? "TIGHT " : ""),
-                                              ((last_status & NAND_LOCK_STATUS_LOCK) ? "LOCK " : ""),
-                                              ((last_status & NAND_LOCK_STATUS_UNLOCK) ? "UNLOCK " : ""));
-                               }
-
-                               last_status = s;
-                      }
+                       do_nand_status(nand);
                } else {
                        if (!nand_lock(nand, tight)) {
                                puts("NAND flash successfully locked\n");
@@ -452,28 +460,34 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                }
                return 0;
        }
+#endif
 
 usage:
-       printf("Usage:\n%s\n", cmdtp->usage);
+       cmd_usage(cmdtp);
        return 1;
 }
 
 U_BOOT_CMD(nand, 5, 1, do_nand,
-       "nand    - NAND sub-system\n",
-       "info                  - show available NAND devices\n"
-       "nand device [dev]     - show or set current device\n"
-       "nand read[.jffs2]     - addr off|partition size\n"
-       "nand write[.jffs2]    - addr off|partition size - read/write `size' bytes starting\n"
-       "    at offset `off' to/from memory address `addr'\n"
-       "nand erase [clean] [off size] - erase `size' bytes from\n"
-       "    offset `off' (entire device if not specified)\n"
-       "nand bad - show bad blocks\n"
-       "nand dump[.oob] off - dump page\n"
-       "nand scrub - really clean NAND erasing bad blocks (UNSAFE)\n"
-       "nand markbad off - mark bad block at offset (UNSAFE)\n"
-       "nand biterr off - make a bit error at offset (UNSAFE)\n"
-       "nand lock [tight] [status] - bring nand to lock state or display locked pages\n"
-       "nand unlock [offset] [size] - unlock section\n");
+          "NAND sub-system",
+          "info - show available NAND devices\n"
+          "nand device [dev] - show or set current device\n"
+          "nand read - addr off|partition size\n"
+          "nand write - addr off|partition size\n"
+          "    read/write 'size' bytes starting at offset 'off'\n"
+          "    to/from memory address 'addr', skipping bad blocks.\n"
+          "nand erase [clean] [off size] - erase 'size' bytes from\n"
+          "    offset 'off' (entire device if not specified)\n"
+          "nand bad - show bad blocks\n"
+          "nand dump[.oob] off - dump page\n"
+          "nand scrub - really clean NAND erasing bad blocks (UNSAFE)\n"
+          "nand markbad off - mark bad block at offset (UNSAFE)\n"
+          "nand biterr off - make a bit error at offset (UNSAFE)\n"
+#ifdef CONFIG_CMD_NAND_LOCK_UNLOCK
+          "nand lock [tight] [status]\n"
+          "    bring nand to lock state or display locked pages\n"
+          "nand unlock [offset] [size] - unlock section\n"
+#endif
+);
 
 static int nand_load_image(cmd_tbl_t *cmdtp, nand_info_t *nand,
                           ulong offset, ulong addr, char *cmd)
@@ -482,31 +496,22 @@ static int nand_load_image(cmd_tbl_t *cmdtp, nand_info_t *nand,
        char *ep, *s;
        size_t cnt;
        image_header_t *hdr;
-       int jffs2 = 0;
 #if defined(CONFIG_FIT)
        const void *fit_hdr = NULL;
 #endif
 
        s = strchr(cmd, '.');
        if (s != NULL &&
-           (!strcmp(s, ".jffs2") || !strcmp(s, ".e") || !strcmp(s, ".i")))
-               jffs2 = 1;
+           (strcmp(s, ".jffs2") && strcmp(s, ".e") && strcmp(s, ".i"))) {
+               printf("Unknown nand load suffix '%s'\n", s);
+               show_boot_progress(-53);
+               return 1;
+       }
 
        printf("\nLoading from %s, offset 0x%lx\n", nand->name, offset);
 
-       cnt = nand->oobblock;
-       if (jffs2) {
-               nand_read_options_t opts;
-               memset(&opts, 0, sizeof(opts));
-               opts.buffer     = (u_char*) addr;
-               opts.length     = cnt;
-               opts.offset     = offset;
-               opts.quiet      = 1;
-               r = nand_read_opts(nand, &opts);
-       } else {
-               r = nand_read(nand, offset, &cnt, (u_char *) addr);
-       }
-
+       cnt = nand->writesize;
+       r = nand_read_skip_bad(nand, offset, &cnt, (u_char *) addr);
        if (r) {
                puts("** Read error\n");
                show_boot_progress (-56);
@@ -536,19 +541,9 @@ static int nand_load_image(cmd_tbl_t *cmdtp, nand_info_t *nand,
                puts ("** Unknown image type\n");
                return 1;
        }
+       show_boot_progress (57);
 
-       if (jffs2) {
-               nand_read_options_t opts;
-               memset(&opts, 0, sizeof(opts));
-               opts.buffer     = (u_char*) addr;
-               opts.length     = cnt;
-               opts.offset     = offset;
-               opts.quiet      = 1;
-               r = nand_read_opts(nand, &opts);
-       } else {
-               r = nand_read(nand, offset, &cnt, (u_char *) addr);
-       }
-
+       r = nand_read_skip_bad(nand, offset, &cnt, (u_char *) addr);
        if (r) {
                puts("** Read error\n");
                show_boot_progress (-58);
@@ -594,7 +589,7 @@ int do_nandboot(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
        char *boot_device = NULL;
        int idx;
        ulong addr, offset = 0;
-#if defined(CONFIG_CMD_JFFS2) && defined(CONFIG_JFFS2_CMDLINE)
+#if defined(CONFIG_CMD_JFFS2) && defined(CONFIG_CMD_MTDPARTS)
        struct mtd_device *dev;
        struct part_info *part;
        u8 pnum;
@@ -612,7 +607,7 @@ int do_nandboot(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                        if (argc == 3)
                                addr = simple_strtoul(argv[1], NULL, 16);
                        else
-                               addr = CFG_LOAD_ADDR;
+                               addr = CONFIG_SYS_LOAD_ADDR;
                        return nand_load_image(cmdtp, &nand_info[dev->id->num],
                                               part->offset, addr, argv[0]);
                }
@@ -622,7 +617,7 @@ int do_nandboot(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
        show_boot_progress(52);
        switch (argc) {
        case 1:
-               addr = CFG_LOAD_ADDR;
+               addr = CONFIG_SYS_LOAD_ADDR;
                boot_device = getenv("bootdevice");
                break;
        case 2:
@@ -639,10 +634,10 @@ int do_nandboot(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                offset = simple_strtoul(argv[3], NULL, 16);
                break;
        default:
-#if defined(CONFIG_CMD_JFFS2) && defined(CONFIG_JFFS2_CMDLINE)
+#if defined(CONFIG_CMD_JFFS2) && defined(CONFIG_CMD_MTDPARTS)
 usage:
 #endif
-               printf("Usage:\n%s\n", cmdtp->usage);
+               cmd_usage(cmdtp);
                show_boot_progress(-53);
                return 1;
        }
@@ -657,7 +652,7 @@ usage:
 
        idx = simple_strtoul(boot_device, NULL, 16);
 
-       if (idx < 0 || idx >= CFG_MAX_NAND_DEVICE || !nand_info[idx].name) {
+       if (idx < 0 || idx >= CONFIG_SYS_MAX_NAND_DEVICE || !nand_info[idx].name) {
                printf("\n** Device %d not available\n", idx);
                show_boot_progress(-55);
                return 1;
@@ -668,12 +663,12 @@ usage:
 }
 
 U_BOOT_CMD(nboot, 4, 1, do_nandboot,
-       "nboot   - boot from NAND device\n",
-       "[.jffs2] [partition] | [[[loadAddr] dev] offset]\n");
+       "boot from NAND device",
+       "[partition] | [[[loadAddr] dev] offset]\n");
 
 #endif
 
-#else /* CFG_NAND_LEGACY */
+#else /* CONFIG_NAND_LEGACY */
 /*
  *
  * Legacy NAND support - to be phased out
@@ -726,15 +721,15 @@ void archflashwp(void *archdata, int wp);
 #define CONFIG_MTD_NAND_ECC_JFFS2
 
 /* bits for nand_legacy_rw() `cmd'; or together as needed */
-#define NANDRW_READ    0x01
-#define NANDRW_WRITE   0x00
-#define NANDRW_JFFS2   0x02
-#define NANDRW_JFFS2_SKIP      0x04
+#define NANDRW_READ         0x01
+#define NANDRW_WRITE        0x00
+#define NANDRW_JFFS2       0x02
+#define NANDRW_JFFS2_SKIP   0x04
 
 /*
  * Imports from nand_legacy.c
  */
-extern struct nand_chip nand_dev_desc[CFG_MAX_NAND_DEVICE];
+extern struct nand_chip nand_dev_desc[CONFIG_SYS_MAX_NAND_DEVICE];
 extern int curr_device;
 extern int nand_legacy_erase(struct nand_chip *nand, size_t ofs,
                            size_t len, int clean);
@@ -755,7 +750,7 @@ int do_nand (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
        switch (argc) {
        case 0:
        case 1:
-               printf ("Usage:\n%s\n", cmdtp->usage);
+               cmd_usage(cmdtp);
                return 1;
        case 2:
                if (strcmp (argv[1], "info") == 0) {
@@ -763,7 +758,7 @@ int do_nand (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
 
                        putc ('\n');
 
-                       for (i = 0; i < CFG_MAX_NAND_DEVICE; ++i) {
+                       for (i = 0; i < CONFIG_SYS_MAX_NAND_DEVICE; ++i) {
                                if (nand_dev_desc[i].ChipID ==
                                    NAND_ChipID_UNKNOWN)
                                        continue;       /* list only known devices */
@@ -774,7 +769,7 @@ int do_nand (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
 
                } else if (strcmp (argv[1], "device") == 0) {
                        if ((curr_device < 0)
-                           || (curr_device >= CFG_MAX_NAND_DEVICE)) {
+                           || (curr_device >= CONFIG_SYS_MAX_NAND_DEVICE)) {
                                puts ("\nno devices available\n");
                                return 1;
                        }
@@ -784,7 +779,7 @@ int do_nand (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
 
                } else if (strcmp (argv[1], "bad") == 0) {
                        if ((curr_device < 0)
-                           || (curr_device >= CFG_MAX_NAND_DEVICE)) {
+                           || (curr_device >= CONFIG_SYS_MAX_NAND_DEVICE)) {
                                puts ("\nno devices available\n");
                                return 1;
                        }
@@ -793,14 +788,14 @@ int do_nand (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                        return 0;
 
                }
-               printf ("Usage:\n%s\n", cmdtp->usage);
+               cmd_usage(cmdtp);
                return 1;
        case 3:
                if (strcmp (argv[1], "device") == 0) {
                        int dev = (int) simple_strtoul (argv[2], NULL, 10);
 
                        printf ("\nDevice %d: ", dev);
-                       if (dev >= CFG_MAX_NAND_DEVICE) {
+                       if (dev >= CONFIG_SYS_MAX_NAND_DEVICE) {
                                puts ("unknown device\n");
                                return 1;
                        }
@@ -832,18 +827,18 @@ int do_nand (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                        return ret;
                }
 
-               printf ("Usage:\n%s\n", cmdtp->usage);
+               cmd_usage(cmdtp);
                return 1;
        default:
                /* at least 4 args */
 
                if (strncmp (argv[1], "read", 4) == 0 ||
                    strncmp (argv[1], "write", 5) == 0) {
-                       ulong   addr = simple_strtoul (argv[2], NULL, 16);
-                       off_t   off  = simple_strtoul (argv[3], NULL, 16);
-                       size_t  size = simple_strtoul (argv[4], NULL, 16);
-                       int     cmd = (strncmp (argv[1], "read", 4) == 0) ?
-                                       NANDRW_READ : NANDRW_WRITE;
+                       ulong addr = simple_strtoul (argv[2], NULL, 16);
+                       off_t off = simple_strtoul (argv[3], NULL, 16);
+                       size_t size = simple_strtoul (argv[4], NULL, 16);
+                       int cmd = (strncmp (argv[1], "read", 4) == 0) ?
+                                 NANDRW_READ : NANDRW_WRITE;
                        size_t total;
                        int ret;
                        char *cmdtail = strchr (argv[1], '.');
@@ -860,19 +855,18 @@ int do_nand (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                                                              (u_char *) addr);
                                }
                                return ret;
-                       } else if (cmdtail && !strncmp (cmdtail, ".jffs2", 2))
-                               cmd |= NANDRW_JFFS2;    /* skip bad blocks */
-                       else if (cmdtail && !strncmp (cmdtail, ".jffs2s", 2)) {
+                       } else if (cmdtail && !strncmp (cmdtail, ".jffs2s", 7)) {
                                cmd |= NANDRW_JFFS2;    /* skip bad blocks (on read too) */
                                if (cmd & NANDRW_READ)
                                        cmd |= NANDRW_JFFS2_SKIP;       /* skip bad blocks (on read too) */
-                       }
+                       } else if (cmdtail && !strncmp (cmdtail, ".jffs2", 2))
+                               cmd |= NANDRW_JFFS2;    /* skip bad blocks */
 #ifdef SXNI855T
                        /* need ".e" same as ".j" for compatibility with older units */
                        else if (cmdtail && !strcmp (cmdtail, ".e"))
                                cmd |= NANDRW_JFFS2;    /* skip bad blocks */
 #endif
-#ifdef CFG_NAND_SKIP_BAD_DOT_I
+#ifdef CONFIG_SYS_NAND_SKIP_BAD_DOT_I
                        /* need ".i" same as ".jffs2s" for compatibility with older units (esd) */
                        /* ".i" for image -> read skips bad block (no 0xff) */
                        else if (cmdtail && !strcmp (cmdtail, ".i")) {
@@ -880,9 +874,9 @@ int do_nand (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
                                if (cmd & NANDRW_READ)
                                        cmd |= NANDRW_JFFS2_SKIP;       /* skip bad blocks (on read too) */
                        }
-#endif /* CFG_NAND_SKIP_BAD_DOT_I */
+#endif /* CONFIG_SYS_NAND_SKIP_BAD_DOT_I */
                        else if (cmdtail) {
-                               printf ("Usage:\n%s\n", cmdtp->usage);
+                               cmd_usage(cmdtp);
                                return 1;
                        }
 
@@ -892,8 +886,7 @@ int do_nand (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
 
                        ret = nand_legacy_rw (nand_dev_desc + curr_device,
                                              cmd, off, size,
-                                             &total,
-                                             (u_char *) addr);
+                                             &total, (u_char *) addr);
 
                        printf (" %d bytes %s: %s\n", total,
                                (cmd & NANDRW_READ) ? "read" : "written",
@@ -919,7 +912,7 @@ int do_nand (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
 
                        return ret;
                } else {
-                       printf ("Usage:\n%s\n", cmdtp->usage);
+                       cmd_usage(cmdtp);
                        rcode = 1;
                }
 
@@ -929,7 +922,7 @@ int do_nand (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
 
 U_BOOT_CMD(
        nand,   5,      1,      do_nand,
-       "nand    - legacy NAND sub-system\n",
+       "legacy NAND sub-system",
        "info  - show available NAND devices\n"
        "nand device [dev] - show or set current device\n"
        "nand read[.jffs2[s]]  addr off size\n"
@@ -959,7 +952,7 @@ int do_nandboot (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
        show_boot_progress (52);
        switch (argc) {
        case 1:
-               addr = CFG_LOAD_ADDR;
+               addr = CONFIG_SYS_LOAD_ADDR;
                boot_device = getenv ("bootdevice");
                break;
        case 2:
@@ -976,7 +969,7 @@ int do_nandboot (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
                offset = simple_strtoul(argv[3], NULL, 16);
                break;
        default:
-               printf ("Usage:\n%s\n", cmdtp->usage);
+               cmd_usage(cmdtp);
                show_boot_progress (-53);
                return 1;
        }
@@ -991,7 +984,7 @@ int do_nandboot (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 
        dev = simple_strtoul(boot_device, &ep, 16);
 
-       if ((dev >= CFG_MAX_NAND_DEVICE) ||
+       if ((dev >= CONFIG_SYS_MAX_NAND_DEVICE) ||
            (nand_dev_desc[dev].ChipID == NAND_ChipID_UNKNOWN)) {
                printf ("\n** Device %d not available\n", dev);
                show_boot_progress (-55);
@@ -1000,11 +993,11 @@ int do_nandboot (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
        show_boot_progress (55);
 
        printf ("\nLoading from device %d: %s at 0x%lx (offset 0x%lx)\n",
-               dev, nand_dev_desc[dev].name, nand_dev_desc[dev].IO_ADDR,
-               offset);
+           dev, nand_dev_desc[dev].name, nand_dev_desc[dev].IO_ADDR,
+           offset);
 
        if (nand_legacy_rw (nand_dev_desc + dev, NANDRW_READ, offset,
-                       SECTORSIZE, NULL, (u_char *)addr)) {
+                           SECTORSIZE, NULL, (u_char *)addr)) {
                printf ("** Read error on %d\n", dev);
                show_boot_progress (-56);
                return 1;
@@ -1035,8 +1028,8 @@ int do_nandboot (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
        show_boot_progress (57);
 
        if (nand_legacy_rw (nand_dev_desc + dev, NANDRW_READ,
-                       offset + SECTORSIZE, cnt, NULL,
-                       (u_char *)(addr+SECTORSIZE))) {
+                           offset + SECTORSIZE, cnt, NULL,
+                           (u_char *)(addr+SECTORSIZE))) {
                printf ("** Read error on %d\n", dev);
                show_boot_progress (-58);
                return 1;
@@ -1078,10 +1071,10 @@ int do_nandboot (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 
 U_BOOT_CMD(
        nboot,  4,      1,      do_nandboot,
-       "nboot   - boot from NAND device\n",
+       "boot from NAND device",
        "loadAddr dev\n"
 );
 
 #endif
 
-#endif /* CFG_NAND_LEGACY */
+#endif /* CONFIG_NAND_LEGACY */