]> git.ipfire.org Git - people/ms/u-boot.git/blobdiff - net/bootp.c
Merge git://git.denx.de/u-boot-x86
[people/ms/u-boot.git] / net / bootp.c
index 9251e91bf6d3acd382ac327f82bdb3d72c70bcb8..be8f710e0c5ca9bb0a2a884891932966c86d21c6 100644 (file)
 
 #include <common.h>
 #include <command.h>
+#include <efi_loader.h>
 #include <net.h>
+#include <net/tftp.h>
 #include "bootp.h"
-#include "tftp.h"
 #include "nfs.h"
-#ifdef CONFIG_STATUS_LED
+#ifdef CONFIG_LED_STATUS
 #include <status_led.h>
 #endif
 #ifdef CONFIG_BOOTP_RANDOM_DELAY
 #define CONFIG_BOOTP_ID_CACHE_SIZE 4
 #endif
 
-ulong          bootp_ids[CONFIG_BOOTP_ID_CACHE_SIZE];
+u32            bootp_ids[CONFIG_BOOTP_ID_CACHE_SIZE];
 unsigned int   bootp_num_ids;
-int            BootpTry;
+int            bootp_try;
 ulong          bootp_start;
 ulong          bootp_timeout;
 char net_nis_domain[32] = {0,}; /* Our NIS domain */
 char net_hostname[32] = {0,}; /* Our hostname */
 char net_root_path[64] = {0,}; /* Our bootpath */
 
+static ulong time_taken_max;
+
 #if defined(CONFIG_CMD_DHCP)
 static dhcp_state_t dhcp_state = INIT;
-static unsigned long dhcp_leasetime;
+static u32 dhcp_leasetime;
 static struct in_addr dhcp_server_ip;
+static u8 dhcp_option_overload;
+#define OVERLOAD_FILE 1
+#define OVERLOAD_SNAME 2
 static void dhcp_handler(uchar *pkt, unsigned dest, struct in_addr sip,
                        unsigned src, unsigned len);
 
@@ -109,27 +115,26 @@ static bool bootp_match_id(ulong id)
        return false;
 }
 
-static int BootpCheckPkt(uchar *pkt, unsigned dest, unsigned src, unsigned len)
+static int check_reply_packet(uchar *pkt, unsigned dest, unsigned src,
+                             unsigned len)
 {
-       struct Bootp_t *bp = (struct Bootp_t *) pkt;
+       struct bootp_hdr *bp = (struct bootp_hdr *)pkt;
        int retval = 0;
 
        if (dest != PORT_BOOTPC || src != PORT_BOOTPS)
                retval = -1;
-       else if (len < sizeof(struct Bootp_t) - OPT_FIELD_SIZE)
+       else if (len < sizeof(struct bootp_hdr) - OPT_FIELD_SIZE)
                retval = -2;
-       else if (bp->bp_op != OP_BOOTREQUEST &&
-                       bp->bp_op != OP_BOOTREPLY &&
-                       bp->bp_op != DHCP_OFFER &&
-                       bp->bp_op != DHCP_ACK &&
-                       bp->bp_op != DHCP_NAK)
+       else if (bp->bp_op != OP_BOOTREPLY)
                retval = -3;
        else if (bp->bp_htype != HWT_ETHER)
                retval = -4;
        else if (bp->bp_hlen != HWL_ETHER)
                retval = -5;
-       else if (!bootp_match_id(NetReadLong((ulong *)&bp->bp_id)))
+       else if (!bootp_match_id(net_read_u32(&bp->bp_id)))
                retval = -6;
+       else if (memcmp(bp->bp_chaddr, net_ethaddr, HWL_ETHER) != 0)
+               retval = -7;
 
        debug("Filtering pkt = %d\n", retval);
 
@@ -139,7 +144,7 @@ static int BootpCheckPkt(uchar *pkt, unsigned dest, unsigned src, unsigned len)
 /*
  * Copy parameters of interest from BOOTP_REPLY/DHCP_OFFER packet
  */
-static void BootpCopyNetParams(struct Bootp_t *bp)
+static void store_net_params(struct bootp_hdr *bp)
 {
 #if !defined(CONFIG_BOOTP_SERVERIP)
        struct in_addr tmp_ip;
@@ -147,10 +152,16 @@ static void BootpCopyNetParams(struct Bootp_t *bp)
        net_copy_ip(&tmp_ip, &bp->bp_siaddr);
        if (tmp_ip.s_addr != 0)
                net_copy_ip(&net_server_ip, &bp->bp_siaddr);
-       memcpy(NetServerEther, ((struct ethernet_hdr *)NetRxPacket)->et_src, 6);
-       if (strlen(bp->bp_file) > 0)
+       memcpy(net_server_ethaddr,
+              ((struct ethernet_hdr *)net_rx_packet)->et_src, 6);
+       if (
+#if defined(CONFIG_CMD_DHCP)
+           !(dhcp_option_overload & OVERLOAD_FILE) &&
+#endif
+           (strlen(bp->bp_file) > 0)) {
                copy_filename(net_boot_file_name, bp->bp_file,
                              sizeof(net_boot_file_name));
+       }
 
        debug("net_boot_file_name: %s\n", net_boot_file_name);
 
@@ -176,12 +187,12 @@ static int truncate_sz(const char *name, int maxlen, int curlen)
 
 #if !defined(CONFIG_CMD_DHCP)
 
-static void BootpVendorFieldProcess(u8 *ext)
+static void bootp_process_vendor_field(u8 *ext)
 {
        int size = *(ext + 1);
 
        debug("[BOOTP] Processing extension %d... (%d bytes)\n", *ext,
-               *(ext + 1));
+             *(ext + 1));
 
        net_boot_file_expected_size_in_blocks = 0;
 
@@ -284,7 +295,7 @@ static void BootpVendorFieldProcess(u8 *ext)
        }
 }
 
-static void BootpVendorProcess(u8 *ext, int size)
+static void bootp_process_vendor(u8 *ext, int size)
 {
        u8 *end = ext + size;
 
@@ -298,7 +309,7 @@ static void BootpVendorProcess(u8 *ext, int size)
 
                        ext += ext[1] + 2;
                        if (ext <= end)
-                               BootpVendorFieldProcess(opt);
+                               bootp_process_vendor_field(opt);
                }
        }
 
@@ -334,31 +345,31 @@ static void BootpVendorProcess(u8 *ext, int size)
 static void bootp_handler(uchar *pkt, unsigned dest, struct in_addr sip,
                          unsigned src, unsigned len)
 {
-       struct Bootp_t *bp;
+       struct bootp_hdr *bp;
 
        debug("got BOOTP packet (src=%d, dst=%d, len=%d want_len=%zu)\n",
-               src, dest, len, sizeof(struct Bootp_t));
+             src, dest, len, sizeof(struct bootp_hdr));
 
-       bp = (struct Bootp_t *)pkt;
+       bp = (struct bootp_hdr *)pkt;
 
        /* Filter out pkts we don't want */
-       if (BootpCheckPkt(pkt, dest, src, len))
+       if (check_reply_packet(pkt, dest, src, len))
                return;
 
        /*
         *      Got a good BOOTP reply.  Copy the data into our variables.
         */
-#ifdef CONFIG_STATUS_LED
-       status_led_set(STATUS_LED_BOOT, STATUS_LED_OFF);
+#if defined(CONFIG_LED_STATUS) && defined(CONFIG_LED_STATUS_BOOT_ENABLE)
+       status_led_set(CONFIG_LED_STATUS_BOOT, CONFIG_LED_STATUS_OFF);
 #endif
 
-       BootpCopyNetParams(bp);         /* Store net parameters from reply */
+       store_net_params(bp);           /* Store net parameters from reply */
 
        /* Retrieve extended information (we must parse the vendor area) */
-       if (NetReadLong((ulong *)&bp->bp_vend[0]) == htonl(BOOTP_VENDOR_MAGIC))
-               BootpVendorProcess((uchar *)&bp->bp_vend[4], len);
+       if (net_read_u32((u32 *)&bp->bp_vend[0]) == htonl(BOOTP_VENDOR_MAGIC))
+               bootp_process_vendor((uchar *)&bp->bp_vend[4], len);
 
-       NetSetTimeout(0, (thand_f *)0);
+       net_set_timeout_handler(0, (thand_f *)0);
        bootstage_mark_name(BOOTSTAGE_ID_BOOTP_STOP, "bootp_stop");
 
        debug("Got good BOOTP\n");
@@ -370,25 +381,24 @@ static void bootp_handler(uchar *pkt, unsigned dest, struct in_addr sip,
 /*
  *     Timeout on BOOTP/DHCP request.
  */
-static void
-BootpTimeout(void)
+static void bootp_timeout_handler(void)
 {
        ulong time_taken = get_timer(bootp_start);
 
-       if (time_taken >= TIMEOUT_MS) {
+       if (time_taken >= time_taken_max) {
 #ifdef CONFIG_BOOTP_MAY_FAIL
                puts("\nRetry time exceeded\n");
                net_set_state(NETLOOP_FAIL);
 #else
                puts("\nRetry time exceeded; starting again\n");
-               NetStartAgain();
+               net_start_again();
 #endif
        } else {
                bootp_timeout *= 2;
                if (bootp_timeout > 2000)
                        bootp_timeout = 2000;
-               NetSetTimeout(bootp_timeout, BootpTimeout);
-               BootpRequest();
+               net_set_timeout_handler(bootp_timeout, bootp_timeout_handler);
+               bootp_request();
        }
 }
 
@@ -401,6 +411,26 @@ BootpTimeout(void)
                e += vci_strlen;                                \
        } while (0)
 
+static u8 *add_vci(u8 *e)
+{
+       char *vci = NULL;
+       char *env_vci = getenv("bootp_vci");
+
+#if defined(CONFIG_SPL_BUILD) && defined(CONFIG_SPL_NET_VCI_STRING)
+       vci = CONFIG_SPL_NET_VCI_STRING;
+#elif defined(CONFIG_BOOTP_VCI_STRING)
+       vci = CONFIG_BOOTP_VCI_STRING;
+#endif
+
+       if (env_vci)
+               vci = env_vci;
+
+       if (vci)
+               put_vci(e, vci);
+
+       return e;
+}
+
 /*
  *     Initialize BOOTP extension fields in the request.
  */
@@ -410,10 +440,10 @@ static int dhcp_extended(u8 *e, int message_type, struct in_addr server_ip,
 {
        u8 *start = e;
        u8 *cnt;
-#if defined(CONFIG_BOOTP_PXE)
+#ifdef CONFIG_LIB_UUID
        char *uuid;
-       u16 clientarch;
 #endif
+       int clientarch = -1;
 
 #if defined(CONFIG_BOOTP_VENDOREX)
        u8 *x;
@@ -469,12 +499,19 @@ static int dhcp_extended(u8 *e, int message_type, struct in_addr server_ip,
        }
 #endif
 
-#if defined(CONFIG_BOOTP_PXE)
+#ifdef CONFIG_BOOTP_PXE_CLIENTARCH
        clientarch = CONFIG_BOOTP_PXE_CLIENTARCH;
-       *e++ = 93;      /* Client System Architecture */
-       *e++ = 2;
-       *e++ = (clientarch >> 8) & 0xff;
-       *e++ = clientarch & 0xff;
+#endif
+
+       if (getenv("bootp_arch"))
+               clientarch = getenv_ulong("bootp_arch", 16, clientarch);
+
+       if (clientarch > 0) {
+               *e++ = 93;      /* Client System Architecture */
+               *e++ = 2;
+               *e++ = (clientarch >> 8) & 0xff;
+               *e++ = clientarch & 0xff;
+       }
 
        *e++ = 94;      /* Client Network Interface Identifier */
        *e++ = 3;
@@ -482,6 +519,7 @@ static int dhcp_extended(u8 *e, int message_type, struct in_addr server_ip,
        *e++ = 0;       /* major revision */
        *e++ = 0;       /* minor revision */
 
+#ifdef CONFIG_LIB_UUID
        uuid = getenv("pxeuuid");
 
        if (uuid) {
@@ -498,9 +536,7 @@ static int dhcp_extended(u8 *e, int message_type, struct in_addr server_ip,
        }
 #endif
 
-#ifdef CONFIG_BOOTP_VCI_STRING
-       put_vci(e, CONFIG_BOOTP_VCI_STRING);
-#endif
+       e = add_vci(e);
 
 #if defined(CONFIG_BOOTP_VENDOREX)
        x = dhcp_vendorex_prep(e);
@@ -586,14 +622,7 @@ static int bootp_extended(u8 *e)
        *e++ = (576 - 312 + OPT_FIELD_SIZE) & 0xff;
 #endif
 
-#if defined(CONFIG_BOOTP_VCI_STRING) || \
-       (defined(CONFIG_SPL_BUILD) && defined(CONFIG_SPL_NET_VCI_STRING))
-#ifdef CONFIG_SPL_BUILD
-       put_vci(e, CONFIG_SPL_NET_VCI_STRING);
-#else
-       put_vci(e, CONFIG_BOOTP_VCI_STRING);
-#endif
-#endif
+       add_vci(e);
 
 #if defined(CONFIG_BOOTP_SUBNETMASK)
        *e++ = 1;               /* Subnet mask request */
@@ -644,43 +673,58 @@ static int bootp_extended(u8 *e)
 
        *e++ = 255;             /* End of the list */
 
+       /*
+        * If nothing in list, remove it altogether. Some DHCP servers get
+        * upset by this minor faux pas and do not respond at all.
+        */
+       if (e == start + 3) {
+               printf("*** Warning: no DHCP options requested\n");
+               e -= 3;
+       }
+
        return e - start;
 }
 #endif
 
-void BootpReset(void)
+void bootp_reset(void)
 {
        bootp_num_ids = 0;
-       BootpTry = 0;
+       bootp_try = 0;
        bootp_start = get_timer(0);
        bootp_timeout = 250;
 }
 
-void
-BootpRequest(void)
+void bootp_request(void)
 {
        uchar *pkt, *iphdr;
-       struct Bootp_t *bp;
+       struct bootp_hdr *bp;
        int extlen, pktlen, iplen;
        int eth_hdr_size;
 #ifdef CONFIG_BOOTP_RANDOM_DELAY
        ulong rand_ms;
 #endif
-       ulong BootpID;
+       u32 bootp_id;
        struct in_addr zero_ip;
        struct in_addr bcast_ip;
+       char *ep;  /* Environment pointer */
 
        bootstage_mark_name(BOOTSTAGE_ID_BOOTP_START, "bootp_start");
 #if defined(CONFIG_CMD_DHCP)
        dhcp_state = INIT;
 #endif
 
+       ep = getenv("bootpretryperiod");
+       if (ep != NULL)
+               time_taken_max = simple_strtoul(ep, NULL, 10);
+       else
+               time_taken_max = TIMEOUT_MS;
+
 #ifdef CONFIG_BOOTP_RANDOM_DELAY               /* Random BOOTP delay */
-       if (BootpTry == 0)
+       if (bootp_try == 0)
                srand_mac();
 
-       if (BootpTry <= 2)      /* Start with max 1024 * 1ms */
-               rand_ms = rand() >> (22 - BootpTry);
+       if (bootp_try <= 2)     /* Start with max 1024 * 1ms */
+               rand_ms = rand() >> (22 - bootp_try);
        else            /* After 3rd BOOTP request max 8192 * 1ms */
                rand_ms = rand() >> 19;
 
@@ -689,11 +733,11 @@ BootpRequest(void)
 
 #endif /* CONFIG_BOOTP_RANDOM_DELAY */
 
-       printf("BOOTP broadcast %d\n", ++BootpTry);
-       pkt = NetTxPacket;
+       printf("BOOTP broadcast %d\n", ++bootp_try);
+       pkt = net_tx_packet;
        memset((void *)pkt, 0, PKTSIZE);
 
-       eth_hdr_size = NetSetEther(pkt, NetBcastAddr, PROT_IP);
+       eth_hdr_size = net_set_ether(pkt, net_bcast_ethaddr, PROT_IP);
        pkt += eth_hdr_size;
 
        /*
@@ -704,22 +748,26 @@ BootpRequest(void)
         * C. Hallinan, DS4.COM, Inc.
         */
        /* net_set_udp_header(pkt, 0xFFFFFFFFL, PORT_BOOTPS, PORT_BOOTPC,
-               sizeof (struct Bootp_t)); */
+               sizeof (struct bootp_hdr)); */
        iphdr = pkt;    /* We need this later for net_set_udp_header() */
        pkt += IP_UDP_HDR_SIZE;
 
-       bp = (struct Bootp_t *)pkt;
+       bp = (struct bootp_hdr *)pkt;
        bp->bp_op = OP_BOOTREQUEST;
        bp->bp_htype = HWT_ETHER;
        bp->bp_hlen = HWL_ETHER;
        bp->bp_hops = 0;
-       bp->bp_secs = htons(get_timer(0) / 1000);
+       /*
+        * according to RFC1542, should be 0 on first request, secs since
+        * first request otherwise
+        */
+       bp->bp_secs = htons(get_timer(bootp_start) / 1000);
        zero_ip.s_addr = 0;
        net_write_ip(&bp->bp_ciaddr, zero_ip);
        net_write_ip(&bp->bp_yiaddr, zero_ip);
        net_write_ip(&bp->bp_siaddr, zero_ip);
        net_write_ip(&bp->bp_giaddr, zero_ip);
-       memcpy(bp->bp_chaddr, NetOurEther, 6);
+       memcpy(bp->bp_chaddr, net_ethaddr, 6);
        copy_filename(bp->bp_file, net_boot_file_name, sizeof(bp->bp_file));
 
        /* Request additional information from the BOOTP/DHCP server */
@@ -734,14 +782,14 @@ BootpRequest(void)
         *      Bootp ID is the lower 4 bytes of our ethernet address
         *      plus the current time in ms.
         */
-       BootpID = ((ulong)NetOurEther[2] << 24)
-               | ((ulong)NetOurEther[3] << 16)
-               | ((ulong)NetOurEther[4] << 8)
-               | (ulong)NetOurEther[5];
-       BootpID += get_timer(0);
-       BootpID = htonl(BootpID);
-       bootp_add_id(BootpID);
-       NetCopyLong(&bp->bp_id, &BootpID);
+       bootp_id = ((u32)net_ethaddr[2] << 24)
+               | ((u32)net_ethaddr[3] << 16)
+               | ((u32)net_ethaddr[4] << 8)
+               | (u32)net_ethaddr[5];
+       bootp_id += get_timer(0);
+       bootp_id = htonl(bootp_id);
+       bootp_add_id(bootp_id);
+       net_copy_u32(&bp->bp_id, &bootp_id);
 
        /*
         * Calculate proper packet lengths taking into account the
@@ -751,7 +799,7 @@ BootpRequest(void)
        pktlen = eth_hdr_size + IP_UDP_HDR_SIZE + iplen;
        bcast_ip.s_addr = 0xFFFFFFFFL;
        net_set_udp_header(iphdr, bcast_ip, PORT_BOOTPS, PORT_BOOTPC, iplen);
-       NetSetTimeout(bootp_timeout, BootpTimeout);
+       net_set_timeout_handler(bootp_timeout, bootp_timeout_handler);
 
 #if defined(CONFIG_CMD_DHCP)
        dhcp_state = SELECTING;
@@ -759,13 +807,12 @@ BootpRequest(void)
 #else
        net_set_udp_handler(bootp_handler);
 #endif
-       NetSendPacket(NetTxPacket, pktlen);
+       net_send_packet(net_tx_packet, pktlen);
 }
 
 #if defined(CONFIG_CMD_DHCP)
-static void DhcpOptionsProcess(uchar *popt, struct Bootp_t *bp)
+static void dhcp_process_options(uchar *popt, uchar *end)
 {
-       uchar *end = popt + BOOTP_HDR_SIZE;
        int oplen, size;
 #if defined(CONFIG_CMD_SNTP) && defined(CONFIG_BOOTP_TIMEOFFSET)
        int *to_ptr;
@@ -774,14 +821,17 @@ static void DhcpOptionsProcess(uchar *popt, struct Bootp_t *bp)
        while (popt < end && *popt != 0xff) {
                oplen = *(popt + 1);
                switch (*popt) {
+               case 0:
+                       oplen = -1; /* Pad omits len byte */
+                       break;
                case 1:
                        net_copy_ip(&net_netmask, (popt + 2));
                        break;
 #if defined(CONFIG_CMD_SNTP) && defined(CONFIG_BOOTP_TIMEOFFSET)
                case 2:         /* Time offset  */
-                       to_ptr = &NetTimeOffset;
-                       NetCopyLong((ulong *)to_ptr, (ulong *)(popt + 2));
-                       NetTimeOffset = ntohl(NetTimeOffset);
+                       to_ptr = &net_ntp_time_offset;
+                       net_copy_u32((u32 *)to_ptr, (u32 *)(popt + 2));
+                       net_ntp_time_offset = ntohl(net_ntp_time_offset);
                        break;
 #endif
                case 3:
@@ -816,7 +866,10 @@ static void DhcpOptionsProcess(uchar *popt, struct Bootp_t *bp)
                        break;
 #endif
                case 51:
-                       NetCopyLong(&dhcp_leasetime, (ulong *) (popt + 2));
+                       net_copy_u32(&dhcp_leasetime, (u32 *)(popt + 2));
+                       break;
+               case 52:
+                       dhcp_option_overload = popt[2];
                        break;
                case 53:        /* Ignore Message Type Option */
                        break;
@@ -829,31 +882,11 @@ static void DhcpOptionsProcess(uchar *popt, struct Bootp_t *bp)
                        break;
                case 66:        /* Ignore TFTP server name */
                        break;
-               case 67:        /* vendor opt bootfile */
-                       /*
-                        * I can't use dhcp_vendorex_proc here because I need
-                        * to write into the bootp packet - even then I had to
-                        * pass the bootp packet pointer into here as the
-                        * second arg
-                        */
-                       size = truncate_sz("Opt Boot File",
-                                           sizeof(bp->bp_file),
-                                           oplen);
-                       if (bp->bp_file[0] == '\0' && size > 0) {
-                               /*
-                                * only use vendor boot file if we didn't
-                                * receive a boot file in the main non-vendor
-                                * part of the packet - god only knows why
-                                * some vendors chose not to use this perfectly
-                                * good spot to store the boot file (join on
-                                * Tru64 Unix) it seems mind bogglingly crazy
-                                * to me
-                                */
-                               printf("*** WARNING: using vendor "
-                                       "optional boot file\n");
-                               memcpy(bp->bp_file, popt + 2, size);
-                               bp->bp_file[size] = '\0';
-                       }
+               case 67:        /* Bootfile option */
+                       size = truncate_sz("Bootfile",
+                                          sizeof(net_boot_file_name), oplen);
+                       memcpy(&net_boot_file_name, popt + 2, size);
+                       net_boot_file_name[size] = 0;
                        break;
                default:
 #if defined(CONFIG_BOOTP_VENDOREX)
@@ -861,53 +894,88 @@ static void DhcpOptionsProcess(uchar *popt, struct Bootp_t *bp)
                                break;
 #endif
                        printf("*** Unhandled DHCP Option in OFFER/ACK:"
-                               " %d\n", *popt);
+                              " %d\n", *popt);
                        break;
                }
                popt += oplen + 2;      /* Process next option */
        }
 }
 
-static int DhcpMessageType(unsigned char *popt)
+static void dhcp_packet_process_options(struct bootp_hdr *bp)
+{
+       uchar *popt = (uchar *)&bp->bp_vend[4];
+       uchar *end = popt + BOOTP_HDR_SIZE;
+
+       if (net_read_u32((u32 *)&bp->bp_vend[0]) != htonl(BOOTP_VENDOR_MAGIC))
+               return;
+
+       dhcp_option_overload = 0;
+
+       /*
+        * The 'options' field MUST be interpreted first, 'file' next,
+        * 'sname' last.
+        */
+       dhcp_process_options(popt, end);
+
+       if (dhcp_option_overload & OVERLOAD_FILE) {
+               popt = (uchar *)bp->bp_file;
+               end = popt + sizeof(bp->bp_file);
+               dhcp_process_options(popt, end);
+       }
+
+       if (dhcp_option_overload & OVERLOAD_SNAME) {
+               popt = (uchar *)bp->bp_sname;
+               end = popt + sizeof(bp->bp_sname);
+               dhcp_process_options(popt, end);
+       }
+}
+
+static int dhcp_message_type(unsigned char *popt)
 {
-       if (NetReadLong((ulong *)popt) != htonl(BOOTP_VENDOR_MAGIC))
+       if (net_read_u32((u32 *)popt) != htonl(BOOTP_VENDOR_MAGIC))
                return -1;
 
        popt += 4;
        while (*popt != 0xff) {
                if (*popt == 53)        /* DHCP Message Type */
                        return *(popt + 2);
-               popt += *(popt + 1) + 2;        /* Scan through all options */
+               if (*popt == 0) {
+                       /* Pad */
+                       popt += 1;
+               } else {
+                       /* Scan through all options */
+                       popt += *(popt + 1) + 2;
+               }
        }
        return -1;
 }
 
-static void DhcpSendRequestPkt(struct Bootp_t *bp_offer)
+static void dhcp_send_request_packet(struct bootp_hdr *bp_offer)
 {
        uchar *pkt, *iphdr;
-       struct Bootp_t *bp;
+       struct bootp_hdr *bp;
        int pktlen, iplen, extlen;
        int eth_hdr_size;
        struct in_addr offered_ip;
        struct in_addr zero_ip;
        struct in_addr bcast_ip;
 
-       debug("DhcpSendRequestPkt: Sending DHCPREQUEST\n");
-       pkt = NetTxPacket;
+       debug("dhcp_send_request_packet: Sending DHCPREQUEST\n");
+       pkt = net_tx_packet;
        memset((void *)pkt, 0, PKTSIZE);
 
-       eth_hdr_size = NetSetEther(pkt, NetBcastAddr, PROT_IP);
+       eth_hdr_size = net_set_ether(pkt, net_bcast_ethaddr, PROT_IP);
        pkt += eth_hdr_size;
 
        iphdr = pkt;    /* We'll need this later to set proper pkt size */
        pkt += IP_UDP_HDR_SIZE;
 
-       bp = (struct Bootp_t *)pkt;
+       bp = (struct bootp_hdr *)pkt;
        bp->bp_op = OP_BOOTREQUEST;
        bp->bp_htype = HWT_ETHER;
        bp->bp_hlen = HWL_ETHER;
        bp->bp_hops = 0;
-       bp->bp_secs = htons(get_timer(0) / 1000);
+       bp->bp_secs = htons(get_timer(bootp_start) / 1000);
        /* Do not set the client IP, your IP, or server IP yet, since it
         * hasn't been ACK'ed by the server yet */
 
@@ -918,13 +986,14 @@ static void DhcpSendRequestPkt(struct Bootp_t *bp_offer)
        zero_ip.s_addr = 0;
        net_write_ip(&bp->bp_giaddr, zero_ip);
 
-       memcpy(bp->bp_chaddr, NetOurEther, 6);
+       memcpy(bp->bp_chaddr, net_ethaddr, 6);
+       copy_filename(bp->bp_file, net_boot_file_name, sizeof(bp->bp_file));
 
        /*
         * ID is the id of the OFFER packet
         */
 
-       NetCopyLong(&bp->bp_id, &bp_offer->bp_id);
+       net_copy_u32(&bp->bp_id, &bp_offer->bp_id);
 
        /*
         * Copy options from OFFER packet if present
@@ -944,7 +1013,7 @@ static void DhcpSendRequestPkt(struct Bootp_t *bp_offer)
        udelay(CONFIG_BOOTP_DHCP_REQUEST_DELAY);
 #endif /* CONFIG_BOOTP_DHCP_REQUEST_DELAY */
        debug("Transmitting DHCPREQUEST packet: len = %d\n", pktlen);
-       NetSendPacket(NetTxPacket, pktlen);
+       net_send_packet(net_tx_packet, pktlen);
 }
 
 /*
@@ -953,17 +1022,20 @@ static void DhcpSendRequestPkt(struct Bootp_t *bp_offer)
 static void dhcp_handler(uchar *pkt, unsigned dest, struct in_addr sip,
                         unsigned src, unsigned len)
 {
-       struct Bootp_t *bp = (struct Bootp_t *)pkt;
+       struct bootp_hdr *bp = (struct bootp_hdr *)pkt;
 
        debug("DHCPHandler: got packet: (src=%d, dst=%d, len=%d) state: %d\n",
-               src, dest, len, dhcp_state);
+             src, dest, len, dhcp_state);
 
        /* Filter out pkts we don't want */
-       if (BootpCheckPkt(pkt, dest, src, len))
+       if (check_reply_packet(pkt, dest, src, len))
                return;
 
-       debug("DHCPHandler: got DHCP packet: (src=%d, dst=%d, len=%d) state:"
-               " %d\n", src, dest, len, dhcp_state);
+       debug("DHCPHandler: got DHCP packet: (src=%d, dst=%d, len=%d) state: "
+             "%d\n", src, dest, len, dhcp_state);
+
+       if (net_read_ip(&bp->bp_yiaddr).s_addr == 0)
+               return;
 
        switch (dhcp_state) {
        case SELECTING:
@@ -979,16 +1051,14 @@ static void dhcp_handler(uchar *pkt, unsigned dest, struct in_addr sip,
                            CONFIG_SYS_BOOTFILE_PREFIX,
                            strlen(CONFIG_SYS_BOOTFILE_PREFIX)) == 0) {
 #endif /* CONFIG_SYS_BOOTFILE_PREFIX */
+                       dhcp_packet_process_options(bp);
+                       efi_net_set_dhcp_ack(pkt, len);
 
                        debug("TRANSITIONING TO REQUESTING STATE\n");
                        dhcp_state = REQUESTING;
 
-                       if (NetReadLong((ulong *)&bp->bp_vend[0]) ==
-                                               htonl(BOOTP_VENDOR_MAGIC))
-                               DhcpOptionsProcess((u8 *)&bp->bp_vend[4], bp);
-
-                       NetSetTimeout(5000, BootpTimeout);
-                       DhcpSendRequestPkt(bp);
+                       net_set_timeout_handler(5000, bootp_timeout_handler);
+                       dhcp_send_request_packet(bp);
 #ifdef CONFIG_SYS_BOOTFILE_PREFIX
                }
 #endif /* CONFIG_SYS_BOOTFILE_PREFIX */
@@ -998,17 +1068,16 @@ static void dhcp_handler(uchar *pkt, unsigned dest, struct in_addr sip,
        case REQUESTING:
                debug("DHCP State: REQUESTING\n");
 
-               if (DhcpMessageType((u8 *)bp->bp_vend) == DHCP_ACK) {
-                       if (NetReadLong((ulong *)&bp->bp_vend[0]) ==
-                                               htonl(BOOTP_VENDOR_MAGIC))
-                               DhcpOptionsProcess((u8 *)&bp->bp_vend[4], bp);
+               if (dhcp_message_type((u8 *)bp->bp_vend) == DHCP_ACK) {
+                       dhcp_packet_process_options(bp);
                        /* Store net params from reply */
-                       BootpCopyNetParams(bp);
+                       store_net_params(bp);
                        dhcp_state = BOUND;
                        printf("DHCP client bound to address %pI4 (%lu ms)\n",
-                               &net_ip, get_timer(bootp_start));
+                              &net_ip, get_timer(bootp_start));
+                       net_set_timeout_handler(0, (thand_f *)0);
                        bootstage_mark_name(BOOTSTAGE_ID_BOOTP_STOP,
-                               "bootp_stop");
+                                           "bootp_stop");
 
                        net_auto_load();
                        return;
@@ -1021,11 +1090,10 @@ static void dhcp_handler(uchar *pkt, unsigned dest, struct in_addr sip,
                puts("DHCP: INVALID STATE\n");
                break;
        }
-
 }
 
-void DhcpRequest(void)
+void dhcp_request(void)
 {
-       BootpRequest();
+       bootp_request();
 }
 #endif /* CONFIG_CMD_DHCP */