Fix --noheader on fw_printenv

[people/ms/u-boot.git] / tools / env / fw_env_main.c

diff --git a/tools/env/fw_env_main.c b/tools/env/fw_env_main.c
index b8bff264eb4ef5e0da6f90d3aff3b2aed3406d6e..d93a915fd142827e2259cd78b260565e4c4e76e6 100644 (file)
--- a/tools/env/fw_env_main.c
+++ b/tools/env/fw_env_main.c
@@ -34,6 +34,7 @@
 #include <stdlib.h>
 #include <sys/file.h>
 #include <unistd.h>
+#include <version.h>
 #include "fw_env_private.h"
 #include "fw_env.h"
 
@@ -42,12 +43,12 @@
 static int do_printenv;
 
 static struct option long_options[] = {
-       {"aes", required_argument, NULL, 'a'},
        {"config", required_argument, NULL, 'c'},
        {"help", no_argument, NULL, 'h'},
        {"script", required_argument, NULL, 's'},
-       {"noheader", required_argument, NULL, 'n'},
+       {"noheader", no_argument, NULL, 'n'},
        {"lock", required_argument, NULL, 'l'},
+       {"version", no_argument, NULL, 'v'},
        {NULL, 0, NULL, 0}
 };
 
@@ -67,9 +68,7 @@ void usage_printenv(void)
                "Print variables from U-Boot environment\n"
                "\n"
                " -h, --help           print this help.\n"
-#ifdef CONFIG_ENV_AES
-               " -a, --aes            aes key to access environment\n"
-#endif
+               " -v, --version        display version\n"
 #ifdef CONFIG_FILE
                " -c, --config         configuration file, default:" CONFIG_FILE "\n"
 #endif
@@ -78,16 +77,14 @@ void usage_printenv(void)
                "\n");
 }
 
-void usage_setenv(void)
+void usage_env_set(void)
 {
        fprintf(stderr,
                "Usage: fw_setenv [OPTIONS]... [VARIABLE]...\n"
                "Modify variables in U-Boot environment\n"
                "\n"
                " -h, --help           print this help.\n"
-#ifdef CONFIG_ENV_AES
-               " -a, --aes            aes key to access environment\n"
-#endif
+               " -v, --version        display version\n"
 #ifdef CONFIG_FILE
                " -c, --config         configuration file, default:" CONFIG_FILE "\n"
 #endif
@@ -123,16 +120,9 @@ static void parse_common_args(int argc, char *argv[])
        env_opts.config_file = CONFIG_FILE;
 #endif
 
-       while ((c = getopt_long(argc, argv, ":a:c:l:h", long_options, NULL)) !=
+       while ((c = getopt_long(argc, argv, ":a:c:l:h:v", long_options, NULL)) !=
               EOF) {
                switch (c) {
-               case 'a':
-                       if (parse_aes_key(optarg, env_opts.aes_key)) {
-                               fprintf(stderr, "AES key parse error\n");
-                               exit(EXIT_FAILURE);
-                       }
-                       env_opts.aes_flag = 1;
-                       break;
 #ifdef CONFIG_FILE
                case 'c':
                        env_opts.config_file = optarg;
@@ -142,7 +132,11 @@ static void parse_common_args(int argc, char *argv[])
                        env_opts.lockname = optarg;
                        break;
                case 'h':
-                       do_printenv ? usage_printenv() : usage_setenv();
+                       do_printenv ? usage_printenv() : usage_env_set();
+                       exit(EXIT_SUCCESS);
+                       break;
+               case 'v':
+                       fprintf(stderr, "Compiled with " U_BOOT_VERSION "\n");
                        exit(EXIT_SUCCESS);
                        break;
                default:
@@ -162,7 +156,7 @@ int parse_printenv_args(int argc, char *argv[])
 
        parse_common_args(argc, argv);
 
-       while ((c = getopt_long(argc, argv, "a:c:ns:l:h", long_options, NULL))
+       while ((c = getopt_long(argc, argv, "a:c:ns:l:h:v", long_options, NULL))
                != EOF) {
                switch (c) {
                case 'n':
@@ -189,7 +183,7 @@ int parse_setenv_args(int argc, char *argv[])
 
        parse_common_args(argc, argv);
 
-       while ((c = getopt_long(argc, argv, "a:c:ns:l:h", long_options, NULL))
+       while ((c = getopt_long(argc, argv, "a:c:ns:l:h:v", long_options, NULL))
                != EOF) {
                switch (c) {
                case 's':
@@ -202,7 +196,7 @@ int parse_setenv_args(int argc, char *argv[])
                        /* ignore common options */
                        break;
                default: /* '?' */
-                       usage_setenv();
+                       usage_env_set();
                        exit(EXIT_FAILURE);
                        break;
                }
@@ -273,7 +267,7 @@ int main(int argc, char *argv[])
                        retval = EXIT_FAILURE;
        } else {
                if (!script_file) {
-                       if (fw_setenv(argc, argv, &env_opts) != 0)
+                       if (fw_env_set(argc, argv, &env_opts) != 0)
                                retval = EXIT_FAILURE;
                } else {
                        if (fw_parse_script(script_file, &env_opts) != 0)