]> git.ipfire.org Git - people/ms/u-boot.git/commit
am33xx: board: Refactor USB initialization into separate function
authorAlexandru Gagniuc <alex.g@adaptrum.com>
Tue, 7 Feb 2017 03:17:33 +0000 (19:17 -0800)
committerTom Rini <trini@konsulko.com>
Wed, 12 Jul 2017 02:49:39 +0000 (22:49 -0400)
commit409a81ddd46f444c2262bb10c921efc6967feff2
treee20a1f6c0ae210505560179d12567ba6b6f593ab
parent17a21e206a29d714d6da7b8583be6f041ba35d7e
am33xx: board: Refactor USB initialization into separate function

The declaration of otg*_plat and otg*_board_data is guarded by
CONFIG_USB_MUSB_*, but their use in arch_misc_init is not. The
ifdef flow goes something like:

if (CONFIG_USB_MUSB_* && other_conditions)
declare usb_data
if (other_conditions)
use usb_data

Thus when CONFIG_USB_MUSB_* is not declared, we try to use the
data structures, but these structures aren't defined.

To fix this, move the USB initialization code into the same #ifdef
which guards the declaration of the data structures. Since the DM_USB
vs legacy cases are completely different, use two versions of
arch_misc_init(), for readability.

Signed-off-by: Alexandru Gagniuc <alex.g@adaptrum.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
arch/arm/mach-omap2/am33xx/board.c