]> git.ipfire.org Git - people/ms/u-boot.git/commit
arm64: zynqmp: Fix broken architected timer interrupt trigger
authorMichal Simek <michal.simek@xilinx.com>
Thu, 9 Feb 2017 13:45:12 +0000 (14:45 +0100)
committerMichal Simek <michal.simek@xilinx.com>
Tue, 28 Nov 2017 15:09:08 +0000 (16:09 +0100)
commit6db82e09564f2ba6bb017d91e9920cdde0e1fb37
tree5d38c335626c0a6a3ac66cbc0fe08a64c6102e4d
parent19ee402d089622602e19de0357fed9b529f1662e
arm64: zynqmp: Fix broken architected timer interrupt trigger

Extract from Linux mainline patch:
The ARM architected timer specification mandates that the interrupt
associated with each timer is level triggered (which corresponds to
the "counter >= comparator" condition).

A number of DTs are being remarkably creative, declaring the interrupt
to be edge triggered. A quick look at the TRM for the corresponding ARM
CPUs clearly shows that this is wrong, and I've corrected those.
For non-ARM designs (and in the absence of a publicly available TRM),
I've made them active low as well, which can't be completely wrong
as the GIC cannot disinguish between level low and level high.

The respective maintainers are of course welcome to prove me wrong.

While I was at it, I took the liberty to fix a couple of related issue,
such as some spurious affinity bits on ThunderX, and their complete
absence on ls1043a (both of which seem to be related to copy-pasting
from other DTs).

Acked-by: Duc Dang <dhdang@apm.com>
Acked-by: Carlo Caione <carlo@endlessm.com>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Acked-by: Dinh Nguyen <dinguyen@opensource.altera.com>
Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
arch/arm/dts/zynqmp.dtsi