]> git.ipfire.org Git - people/ms/u-boot.git/commitdiff
mx6cuboxi: Avoid calling setup_display() from SPL code
authorFabio Estevam <fabio.estevam@nxp.com>
Sat, 23 Sep 2017 02:45:31 +0000 (23:45 -0300)
committerStefano Babic <sbabic@denx.de>
Thu, 12 Oct 2017 15:30:32 +0000 (17:30 +0200)
There is no need call setup_display() from SPL code, so move it to
board_init(), which executes only in U-Boot proper.

Reported-by: Stefano Babic <sbabic@denx.de>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Reviewed-by: Stefano Babic <sbabic@denx.de>
board/solidrun/mx6cuboxi/mx6cuboxi.c

index 1e4da4a6b1674c4b38fbc217977a919f3bb136ce..ee9e4f7c01ebf0a1088c1bb0a32e109a84596fa9 100644 (file)
@@ -308,13 +308,8 @@ int board_ehci_hcd_init(int port)
 
 int board_early_init_f(void)
 {
-       int ret = 0;
        setup_iomux_uart();
 
-#ifdef CONFIG_VIDEO_IPUV3
-       ret = setup_display();
-#endif
-
 #ifdef CONFIG_CMD_SATA
        setup_sata();
 #endif
@@ -322,15 +317,21 @@ int board_early_init_f(void)
 #ifdef CONFIG_USB_EHCI_MX6
        setup_usb();
 #endif
-       return ret;
+       return 0;
 }
 
 int board_init(void)
 {
+       int ret = 0;
+
        /* address of boot parameters */
        gd->bd->bi_boot_params = CONFIG_SYS_SDRAM_BASE + 0x100;
 
-       return 0;
+#ifdef CONFIG_VIDEO_IPUV3
+       ret = setup_display();
+#endif
+
+       return ret;
 }
 
 static bool is_hummingboard(void)