From d53b128df40d8b2f5dd87cac194163fca2bc17ed Mon Sep 17 00:00:00 2001 From: Alexey Brodkin Date: Thu, 15 Feb 2018 15:34:58 +0300 Subject: [PATCH] arc: Fix final linkage with Elf32 tools ARC Elf32 tools by default enable usage of so-called "small data" section or in ARC PRM parlance "GP-relative addressing". The idea is to put up to 2kB of frequently used data into a separate location and use indirect addressing via dedicated core register (GP). Where GP is used as a base for offset calculation. And so if "-msdata" toggle is passed to the compiler either explicitly or implicitly (that's Elf32 tools case) it will try to put some data in that "small data" area and then to calculate real offset from GP to be encoded in instructions we need to know the base value which liker gets from __SDATA_BEGIN__ symbol in hte linker script. In U-Boot we don't use that feature and linker script doesn't define __SDATA_BEGIN__ which gives us the following linkage error if we use Elf32 tools: ------------------------->8------------------- LD u-boot .../bin/arc-elf32-ld.bfd: Error: Linker symbol __SDATA_BEGIN__ not found .../bin/arc-elf32-ld.bfd: final link failed: Bad value ------------------------->8------------------- Note if uClibc or glibc tools are used that problem doesn't happen because usage of "small data section" is disabled by default as not very useful for bigger executables. Moreover GP is just another name of r26 so we're loosing 1 core register which is not used by the compiler as a generic register with "-msdata". Signed-off-by: Alexey Brodkin --- arch/arc/config.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arc/config.mk b/arch/arc/config.mk index 13676bd0c8..3ed0c282ba 100644 --- a/arch/arc/config.mk +++ b/arch/arc/config.mk @@ -50,7 +50,7 @@ ifdef CONFIG_CPU_ARCHS38 PLATFORM_CPPFLAGS += -mcpu=archs endif -PLATFORM_CPPFLAGS += -ffixed-r25 -D__ARC__ -gdwarf-2 +PLATFORM_CPPFLAGS += -ffixed-r25 -D__ARC__ -gdwarf-2 -mno-sdata # Needed for relocation LDFLAGS_FINAL += -pie -- 2.39.2