]>
Commit | Line | Data |
---|---|---|
00e5a55c BS |
1 | From 208f2a886a2f6cf329c9fcbf8d29a0dd245cc763 Mon Sep 17 00:00:00 2001 |
2 | From: David Milburn <dmilburn@redhat.com> | |
3 | Date: Fri, 20 Mar 2009 14:14:23 -0500 | |
4 | Subject: ahci: correct enclosure LED state save | |
5 | References: bnc#489005 | |
6 | ||
7 | ahci_transmit_led_message saves off the led_state | |
8 | with a value that includes the port number OR'd | |
9 | in, this incorrect value maybe reported back | |
10 | in ahci_led_store. | |
11 | ||
12 | For instance, if you turn off all the leds for | |
13 | port 1 and cat the value back it will report 1 | |
14 | instead of 0. | |
15 | ||
16 | # echo 0 > /sys/class/scsi_host/host1/em_message | |
17 | # cat /sys/class/scsi_host/host1/em_message | |
18 | 1 | |
19 | ||
20 | Signed-off-by: David Milburn <dmilburn@redhat.com> | |
21 | Signed-off-by: Jeff Garzik <jgarzik@redhat.com> | |
22 | Signed-off-by: Tejun Heo <teheo@suse.de> | |
23 | --- | |
24 | drivers/ata/ahci.c | 2 +- | |
25 | 1 file changed, 1 insertion(+), 1 deletion(-) | |
26 | ||
27 | Index: linux-2.6.27-SLE11_BRANCH/drivers/ata/ahci.c | |
28 | =================================================================== | |
29 | --- linux-2.6.27-SLE11_BRANCH.orig/drivers/ata/ahci.c | |
30 | +++ linux-2.6.27-SLE11_BRANCH/drivers/ata/ahci.c | |
31 | @@ -1325,7 +1325,7 @@ static ssize_t ahci_transmit_led_message | |
32 | writel(message[1], mmio + hpriv->em_loc+4); | |
33 | ||
34 | /* save off new led state for port/slot */ | |
35 | - emp->led_state = message[1]; | |
36 | + emp->led_state = state; | |
37 | ||
38 | /* | |
39 | * tell hardware to transmit the message |