src/patches/suse-2.6.27.39/patches.drivers/libfc-improve-fc_rport-c-locki.diff

   1 From: Robert Love <robert.w.love@intel.com>
   2 Subject: Improve fc_rport.c locking comment block
   3 References: 459142
   4
   5 checkpatch.pl was complaining about having spaces
   6 after '*'s. It seemed to be a false positive. I split
   7 the comment block into two blocks and it resolved the
   8 ERROR.
   9
  10 Signed-off-by: Robert Love <robert.w.love@intel.com>
  11 Acked-by: Bernhard Walle <bwalle@suse.de>
  12 ---
  13
  14  drivers/scsi/libfc/fc_rport.c |   17 ++++++++++-------
  15  1 file changed, 10 insertions(+), 7 deletions(-)
  16
  17
  18 --- a/drivers/scsi/libfc/fc_rport.c
  19 +++ b/drivers/scsi/libfc/fc_rport.c
  20 @@ -18,20 +18,23 @@
  21   */
  22
  23  /*
  24 + * RPORT GENERAL INFO
  25 + *
  26   * This file contains all processing regarding fc_rports. It contains the
  27   * rport state machine and does all rport interaction with the transport class.
  28   * There should be no other places in libfc that interact directly with the
  29   * transport class in regards to adding and deleting rports.
  30   *
  31   * fc_rport's represent N_Port's within the fabric.
  32 + */
  33 +
  34 +/*
  35 + * RPORT LOCKING
  36   *
  37 - * rport locking notes:
  38 - *
  39 - * The rport should never hold the rport mutex and then lock the lport
  40 - * mutex. The rport's mutex is considered lesser than the lport's mutex, so
  41 - * the lport mutex can be held before locking the rport mutex, but not the
  42 - * other way around. See the comment block at the top of fc_lport.c for more
  43 - * details.
  44 + * The rport should never hold the rport mutex and then attempt to acquire
  45 + * either the lport or disc mutexes. The rport's mutex is considered lesser
  46 + * than both the lport's mutex and the disc mutex. Refer to fc_lport.c for
  47 + * more comments on the heirarchy.
  48   *
  49   * The locking strategy is similar to the lport's strategy. The lock protects
  50   * the rport's states and is held and released by the entry points to the rport