]> git.ipfire.org Git - people/pmueller/ipfire-2.x.git/commitdiff
Merge remote-tracking branch 'origin/master' into next
authorArne Fitzenreiter <arne_f@ipfire.org>
Thu, 22 Oct 2015 11:11:17 +0000 (13:11 +0200)
committerArne Fitzenreiter <arne_f@ipfire.org>
Thu, 22 Oct 2015 11:11:17 +0000 (13:11 +0200)
98 files changed:
config/firewall/firewall-lib.pl
config/firewall/ipsec-block [new file with mode: 0644]
config/kernel/kernel.config.armv5tel-ipfire-kirkwood
config/kernel/kernel.config.armv5tel-ipfire-multi
config/kernel/kernel.config.armv5tel-ipfire-rpi
config/kernel/kernel.config.i586-ipfire
config/kernel/kernel.config.i586-ipfire-pae
config/kernel/kernel.config.x86_64-ipfire
config/rootfiles/common/armv5tel/initscripts
config/rootfiles/common/i586/initscripts
config/rootfiles/common/procps
config/rootfiles/common/stage2
config/rootfiles/common/strongswan
config/rootfiles/common/udev
config/rootfiles/common/x86_64/initscripts
config/rootfiles/common/x86_64/linux
config/rootfiles/common/x86_64/stage2
config/rootfiles/core/95/exclude [moved from config/rootfiles/core/94/exclude with 100% similarity]
config/rootfiles/core/95/filelists/ddns [new symlink]
config/rootfiles/core/95/filelists/files [new file with mode: 0644]
config/rootfiles/core/95/filelists/i586/strongswan-padlock [new symlink]
config/rootfiles/core/95/filelists/strongswan [new symlink]
config/rootfiles/core/95/meta [moved from config/rootfiles/core/94/meta with 100% similarity]
config/rootfiles/core/95/update.sh [new file with mode: 0644]
config/rootfiles/oldcore/94/exclude [new file with mode: 0644]
config/rootfiles/oldcore/94/filelists/armv5tel/glibc [moved from config/rootfiles/core/94/filelists/armv5tel/glibc with 100% similarity]
config/rootfiles/oldcore/94/filelists/bind [moved from config/rootfiles/core/94/filelists/bind with 100% similarity]
config/rootfiles/oldcore/94/filelists/chkconfig [moved from config/rootfiles/core/94/filelists/chkconfig with 100% similarity]
config/rootfiles/oldcore/94/filelists/coreutils [moved from config/rootfiles/core/94/filelists/coreutils with 100% similarity]
config/rootfiles/oldcore/94/filelists/dma [moved from config/rootfiles/core/94/filelists/dma with 100% similarity]
config/rootfiles/oldcore/94/filelists/dnsmasq [moved from config/rootfiles/core/94/filelists/dnsmasq with 100% similarity]
config/rootfiles/oldcore/94/filelists/file [moved from config/rootfiles/core/94/filelists/file with 100% similarity]
config/rootfiles/oldcore/94/filelists/files [moved from config/rootfiles/core/94/filelists/files with 100% similarity]
config/rootfiles/oldcore/94/filelists/fireinfo [moved from config/rootfiles/core/94/filelists/fireinfo with 100% similarity]
config/rootfiles/oldcore/94/filelists/hdparm [moved from config/rootfiles/core/94/filelists/hdparm with 100% similarity]
config/rootfiles/oldcore/94/filelists/i586/glibc [moved from config/rootfiles/core/94/filelists/i586/glibc with 100% similarity]
config/rootfiles/oldcore/94/filelists/iproute2 [moved from config/rootfiles/core/94/filelists/iproute2 with 100% similarity]
config/rootfiles/oldcore/94/filelists/libgcrypt [moved from config/rootfiles/core/94/filelists/libgcrypt with 100% similarity]
config/rootfiles/oldcore/94/filelists/libgpg-error [moved from config/rootfiles/core/94/filelists/libgpg-error with 100% similarity]
config/rootfiles/oldcore/94/filelists/openssh [moved from config/rootfiles/core/94/filelists/openssh with 100% similarity]
config/rootfiles/oldcore/94/filelists/pcre [moved from config/rootfiles/core/94/filelists/pcre with 100% similarity]
config/rootfiles/oldcore/94/filelists/perl-Email-Date-Format [moved from config/rootfiles/core/94/filelists/perl-Email-Date-Format with 100% similarity]
config/rootfiles/oldcore/94/filelists/perl-MIME-Lite [moved from config/rootfiles/core/94/filelists/perl-MIME-Lite with 100% similarity]
config/rootfiles/oldcore/94/filelists/rrdtool [moved from config/rootfiles/core/94/filelists/rrdtool with 100% similarity]
config/rootfiles/oldcore/94/filelists/setup [moved from config/rootfiles/core/94/filelists/setup with 100% similarity]
config/rootfiles/oldcore/94/filelists/squid [moved from config/rootfiles/core/94/filelists/squid with 100% similarity]
config/rootfiles/oldcore/94/meta [new file with mode: 0644]
config/rootfiles/oldcore/94/update.sh [moved from config/rootfiles/core/94/update.sh with 100% similarity]
config/udev/60-net.rules
config/udev/network-hotplug-vlan [moved from src/initscripts/init.d/network-vlans with 60% similarity]
doc/language_issues.de
doc/language_issues.en
doc/language_issues.es
doc/language_issues.fr
doc/language_issues.it
doc/language_issues.nl
doc/language_issues.pl
doc/language_issues.ru
doc/language_issues.tr
doc/language_missings
html/cgi-bin/connections.cgi
html/cgi-bin/dhcp.cgi
html/cgi-bin/firewall.cgi
html/cgi-bin/logs.cgi/firewalllogcountry.dat
html/cgi-bin/pppsetup.cgi
html/cgi-bin/routing.cgi
html/cgi-bin/tor.cgi
html/cgi-bin/vpnmain.cgi
langs/de/cgi-bin/de.pl
langs/en/cgi-bin/en.pl
langs/es/cgi-bin/es.pl
langs/fr/cgi-bin/fr.pl
langs/it/cgi-bin/it.pl
langs/nl/cgi-bin/nl.pl
langs/pl/cgi-bin/pl.pl
langs/ru/cgi-bin/ru.pl
langs/tr/cgi-bin/tr.pl
lfs/asterisk
lfs/backports
lfs/ddns
lfs/e1000e
lfs/igb
lfs/initscripts
lfs/krb5
lfs/linux
lfs/monit
lfs/sox
lfs/stage2
lfs/strongswan
lfs/tor
lfs/udev
make.sh
src/initscripts/init.d/dnsmasq
src/initscripts/init.d/firewall
src/misc-progs/ipsecctrl.c
src/patches/backports-3.18.1-1_no_dma_sgtable_on_x86_64.patch [new file with mode: 0644]
src/patches/linux-3.10-dvb_tevi_s482.patch [new file with mode: 0644]
src/patches/linux-3.14.54_fix_ip_route_list.patch [new file with mode: 0644]

index b389fac3c351230ec354d27579c692b387249b01..eabd9a42f22d7bab5fd93cf17855120fa6ce1f46 100644 (file)
@@ -391,8 +391,9 @@ sub get_address
        # IPsec networks.
        } elsif ($key ~~ ["ipsec_net_src", "ipsec_net_tgt", "IpSec Network"]) {
                my $network_address = &get_ipsec_net_ip($value, 11);
-               if ($network_address) {
-                       push(@ret, [$network_address, ""]);
+               my @nets = split(/\|/, $network_address);
+               foreach my $net (@nets) {
+                       push(@ret, [$net, ""]);
                }
 
        # The firewall's own IP addresses.
diff --git a/config/firewall/ipsec-block b/config/firewall/ipsec-block
new file mode 100644 (file)
index 0000000..9fa8e1a
--- /dev/null
@@ -0,0 +1,59 @@
+#!/bin/bash
+###############################################################################
+#                                                                             #
+# IPFire.org - A linux based firewall                                         #
+# Copyright (C) 2015 IPFire Team                                              #
+#                                                                             #
+# This program is free software: you can redistribute it and/or modify        #
+# it under the terms of the GNU General Public License as published by        #
+# the Free Software Foundation, either version 3 of the License, or           #
+# (at your option) any later version.                                         #
+#                                                                             #
+# This program is distributed in the hope that it will be useful,             #
+# but WITHOUT ANY WARRANTY; without even the implied warranty of              #
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the               #
+# GNU General Public License for more details.                                #
+#                                                                             #
+# You should have received a copy of the GNU General Public License           #
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.       #
+#                                                                             #
+###############################################################################
+
+VPN_CONFIG="/var/ipfire/vpn/config"
+
+block_subnet() {
+       local subnet="${1}"
+
+       # Don't block a wildcard subnet
+       if [ "${subnet}" = "0.0.0.0/0" ] || [ "${subnet}" = "0.0.0.0/0.0.0.0" ]; then
+               return 0
+       fi
+
+       iptables -A IPSECBLOCK -d "${subnet}" -j REJECT --reject-with icmp-net-unreachable
+}
+
+block_ipsec() {
+       # Flush all exists rules
+       iptables -F IPSECBLOCK
+
+       local id status name lefthost type ctype unknown1 unknown2 unknown3
+       local leftsubnets unknown4 righthost rightsubnets rest
+       while IFS="," read -r id status name lefthost type ctype unkown1 unknown2 unknown3 \
+                       leftsubnets unknown4 righthost rightsubnets rest; do
+               # Check if the connection is enabled
+               [ "${status}" = "on" ] || continue
+
+               # Check if this a net-to-net connection
+               [ "${type}" = "net" ] || continue
+
+               # Split multiple subnets
+               rightsubnets="${rightsubnets//\|/ }"
+
+               local rightsubnet
+               for rightsubnet in ${rightsubnets}; do
+                       block_subnet "${rightsubnet}"
+               done
+       done < "${VPN_CONFIG}"
+}
+
+block_ipsec || exit $?
index cf44486e5ae6c717e55aa5d99d40ef56d111eeea..325add296e0f07daece734a745708323f2af4c51 100644 (file)
@@ -1,6 +1,6 @@
 #
 # Automatically generated file; DO NOT EDIT.
-# Linux/arm 3.14.37 Kernel Configuration
+# Linux/arm 3.14.53 Kernel Configuration
 #
 CONFIG_ARM=y
 CONFIG_SYS_SUPPORTS_APM_EMULATION=y
@@ -924,7 +924,6 @@ CONFIG_IP_NF_SECURITY=m
 CONFIG_IP_NF_ARPTABLES=m
 CONFIG_IP_NF_ARPFILTER=m
 CONFIG_IP_NF_ARP_MANGLE=m
-CONFIG_IP_NF_MATCH_IPP2P=m
 
 #
 # IPv6: Netfilter Configuration
index 25de266d515acaa483bfd87a8043e4e66013e03c..9729903a7d3a42e2d532f211f49a554861536119 100644 (file)
@@ -1,6 +1,6 @@
 #
 # Automatically generated file; DO NOT EDIT.
-# Linux/arm 3.14.37 Kernel Configuration
+# Linux/arm 3.14.53 Kernel Configuration
 #
 CONFIG_ARM=y
 CONFIG_MIGHT_HAVE_PCI=y
@@ -1098,7 +1098,6 @@ CONFIG_IP_NF_SECURITY=m
 CONFIG_IP_NF_ARPTABLES=m
 CONFIG_IP_NF_ARPFILTER=m
 CONFIG_IP_NF_ARP_MANGLE=m
-CONFIG_IP_NF_MATCH_IPP2P=m
 
 #
 # IPv6: Netfilter Configuration
index b25210a17cbf91e2dfccdbda822de42f7d6e03d8..6e584cbfd546e3bc445bdf766ae1741c646a1b94 100644 (file)
@@ -1,6 +1,6 @@
 #
 # Automatically generated file; DO NOT EDIT.
-# Linux/arm 3.14.37 Kernel Configuration
+# Linux/arm 3.14.53 Kernel Configuration
 #
 CONFIG_ARM=y
 CONFIG_SYS_SUPPORTS_APM_EMULATION=y
@@ -863,7 +863,6 @@ CONFIG_IP_NF_SECURITY=m
 CONFIG_IP_NF_ARPTABLES=m
 CONFIG_IP_NF_ARPFILTER=m
 CONFIG_IP_NF_ARP_MANGLE=m
-CONFIG_IP_NF_MATCH_IPP2P=m
 
 #
 # IPv6: Netfilter Configuration
index f5ff73efb8759c9911e74f8266b16afcceadcc45..adac4fb4d4164aeb0cf92204514976c4fe261720 100644 (file)
@@ -1,6 +1,6 @@
 #
 # Automatically generated file; DO NOT EDIT.
-# Linux/x86 3.14.37 Kernel Configuration
+# Linux/x86 3.14.53 Kernel Configuration
 #
 # CONFIG_64BIT is not set
 CONFIG_X86_32=y
@@ -514,6 +514,7 @@ CONFIG_HOTPLUG_CPU=y
 # CONFIG_BOOTPARAM_HOTPLUG_CPU0 is not set
 # CONFIG_DEBUG_HOTPLUG_CPU0 is not set
 # CONFIG_CMDLINE_BOOL is not set
+# CONFIG_DEFAULT_MODIFY_LDT_SYSCALL is not set
 CONFIG_ARCH_ENABLE_MEMORY_HOTPLUG=y
 
 #
@@ -677,10 +678,10 @@ CONFIG_EISA_NAMES=y
 CONFIG_SCx200=m
 CONFIG_SCx200HR_TIMER=m
 # CONFIG_OLPC is not set
-CONFIG_APULED=y
 CONFIG_ALIX=y
 CONFIG_NET5501=y
 CONFIG_GEOS=y
+CONFIG_APULED=y
 CONFIG_AMD_NB=y
 CONFIG_PCCARD=m
 CONFIG_PCMCIA=m
@@ -1068,7 +1069,6 @@ CONFIG_IP_NF_SECURITY=m
 CONFIG_IP_NF_ARPTABLES=m
 CONFIG_IP_NF_ARPFILTER=m
 CONFIG_IP_NF_ARP_MANGLE=m
-CONFIG_IP_NF_MATCH_IPP2P=m
 
 #
 # IPv6: Netfilter Configuration
index 8e7220184af6ba4b55095d7d47acebc96f1141b3..c94a23538bf0a2cf3b7c9987654a8dba06849f7f 100644 (file)
@@ -1,6 +1,6 @@
 #
 # Automatically generated file; DO NOT EDIT.
-# Linux/x86 3.14.37 Kernel Configuration
+# Linux/x86 3.14.53 Kernel Configuration
 #
 # CONFIG_64BIT is not set
 CONFIG_X86_32=y
@@ -527,6 +527,7 @@ CONFIG_HOTPLUG_CPU=y
 # CONFIG_BOOTPARAM_HOTPLUG_CPU0 is not set
 # CONFIG_DEBUG_HOTPLUG_CPU0 is not set
 # CONFIG_CMDLINE_BOOL is not set
+# CONFIG_DEFAULT_MODIFY_LDT_SYSCALL is not set
 CONFIG_ARCH_ENABLE_MEMORY_HOTPLUG=y
 
 #
@@ -691,10 +692,10 @@ CONFIG_EISA_PCI_EISA=y
 CONFIG_EISA_VIRTUAL_ROOT=y
 CONFIG_EISA_NAMES=y
 # CONFIG_SCx200 is not set
-CONFIG_APULED=y
 # CONFIG_ALIX is not set
 # CONFIG_NET5501 is not set
 # CONFIG_GEOS is not set
+CONFIG_APULED=y
 CONFIG_AMD_NB=y
 CONFIG_PCCARD=m
 CONFIG_PCMCIA=m
@@ -1082,7 +1083,6 @@ CONFIG_IP_NF_SECURITY=m
 CONFIG_IP_NF_ARPTABLES=m
 CONFIG_IP_NF_ARPFILTER=m
 CONFIG_IP_NF_ARP_MANGLE=m
-CONFIG_IP_NF_MATCH_IPP2P=m
 
 #
 # IPv6: Netfilter Configuration
index 902b9e114920b115d10be8ddfa052fb35509fcff..cc36ada85f12935ce17261e023e4674c39ebb2f5 100644 (file)
@@ -1,6 +1,6 @@
 #
 # Automatically generated file; DO NOT EDIT.
-# Linux/x86 3.14.43 Kernel Configuration
+# Linux/x86 3.14.53 Kernel Configuration
 #
 CONFIG_64BIT=y
 CONFIG_X86_64=y
@@ -177,9 +177,11 @@ CONFIG_RD_LZ4=y
 # CONFIG_CC_OPTIMIZE_FOR_SIZE is not set
 CONFIG_SYSCTL=y
 CONFIG_ANON_INODES=y
+CONFIG_HAVE_UID16=y
 CONFIG_SYSCTL_EXCEPTION_TRACE=y
 CONFIG_HAVE_PCSPKR_PLATFORM=y
 CONFIG_EXPERT=y
+CONFIG_UID16=y
 # CONFIG_SYSCTL_SYSCALL is not set
 CONFIG_KALLSYMS=y
 CONFIG_KALLSYMS_ALL=y
@@ -244,6 +246,8 @@ CONFIG_ARCH_HAVE_NMI_SAFE_CMPXCHG=y
 CONFIG_HAVE_ALIGNED_STRUCT_PAGE=y
 CONFIG_HAVE_CMPXCHG_LOCAL=y
 CONFIG_HAVE_CMPXCHG_DOUBLE=y
+CONFIG_ARCH_WANT_COMPAT_IPC_PARSE_VERSION=y
+CONFIG_ARCH_WANT_OLD_COMPAT_IPC=y
 CONFIG_HAVE_ARCH_SECCOMP_FILTER=y
 CONFIG_SECCOMP_FILTER=y
 CONFIG_HAVE_CC_STACKPROTECTOR=y
@@ -258,6 +262,8 @@ CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE=y
 CONFIG_HAVE_ARCH_SOFT_DIRTY=y
 CONFIG_MODULES_USE_ELF_RELA=y
 CONFIG_HAVE_IRQ_EXIT_ON_IRQ_STACK=y
+CONFIG_OLD_SIGSUSPEND3=y
+CONFIG_COMPAT_OLD_SIGACTION=y
 
 #
 # GCOV-based kernel profiling
@@ -306,6 +312,7 @@ CONFIG_LDM_PARTITION=y
 CONFIG_EFI_PARTITION=y
 # CONFIG_SYSV68_PARTITION is not set
 # CONFIG_CMDLINE_PARTITION is not set
+CONFIG_BLOCK_COMPAT=y
 
 #
 # IO Schedulers
@@ -335,6 +342,7 @@ CONFIG_FREEZER=y
 #
 CONFIG_ZONE_DMA=y
 CONFIG_SMP=y
+# CONFIG_X86_X2APIC is not set
 CONFIG_X86_MPPARSE=y
 CONFIG_X86_EXTENDED_PLATFORM=y
 # CONFIG_X86_VSMP is not set
@@ -352,7 +360,7 @@ CONFIG_XEN_PVHVM=y
 CONFIG_XEN_MAX_DOMAIN_MEMORY=500
 CONFIG_XEN_SAVE_RESTORE=y
 CONFIG_XEN_DEBUG_FS=y
-# CONFIG_XEN_PVH is not set
+CONFIG_XEN_PVH=y
 CONFIG_KVM_GUEST=y
 # CONFIG_KVM_DEBUG_FS is not set
 CONFIG_PARAVIRT_TIME_ACCOUNTING=y
@@ -371,7 +379,7 @@ CONFIG_X86_CMPXCHG64=y
 CONFIG_X86_CMOV=y
 CONFIG_X86_MINIMUM_CPU_FAMILY=64
 CONFIG_X86_DEBUGCTLMSR=y
-CONFIG_PROCESSOR_SELECT=y
+# CONFIG_PROCESSOR_SELECT is not set
 CONFIG_CPU_SUP_INTEL=y
 CONFIG_CPU_SUP_AMD=y
 CONFIG_CPU_SUP_CENTAUR=y
@@ -484,6 +492,7 @@ CONFIG_HOTPLUG_CPU=y
 # CONFIG_BOOTPARAM_HOTPLUG_CPU0 is not set
 # CONFIG_DEBUG_HOTPLUG_CPU0 is not set
 # CONFIG_CMDLINE_BOOL is not set
+# CONFIG_DEFAULT_MODIFY_LDT_SYSCALL is not set
 CONFIG_ARCH_ENABLE_MEMORY_HOTPLUG=y
 
 #
@@ -591,7 +600,7 @@ CONFIG_INTEL_IDLE=y
 #
 CONFIG_PCI=y
 CONFIG_PCI_DIRECT=y
-# CONFIG_PCI_MMCONFIG is not set
+CONFIG_PCI_MMCONFIG=y
 CONFIG_PCI_XEN=y
 CONFIG_PCI_DOMAINS=y
 # CONFIG_PCI_CNB20LE_QUIRK is not set
@@ -614,8 +623,8 @@ CONFIG_XEN_PCIDEV_FRONTEND=m
 CONFIG_HT_IRQ=y
 CONFIG_PCI_ATS=y
 CONFIG_PCI_IOV=y
-# CONFIG_PCI_PRI is not set
-# CONFIG_PCI_PASID is not set
+CONFIG_PCI_PRI=y
+CONFIG_PCI_PASID=y
 CONFIG_PCI_IOAPIC=y
 CONFIG_PCI_LABEL=y
 
@@ -654,16 +663,24 @@ CONFIG_X86_SYSFB=y
 # Executable file formats / Emulations
 #
 CONFIG_BINFMT_ELF=y
+CONFIG_COMPAT_BINFMT_ELF=y
 CONFIG_ARCH_BINFMT_ELF_RANDOMIZE_PIE=y
 CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS=y
 CONFIG_BINFMT_SCRIPT=y
 # CONFIG_HAVE_AOUT is not set
 CONFIG_BINFMT_MISC=y
 CONFIG_COREDUMP=y
-# CONFIG_IA32_EMULATION is not set
+CONFIG_IA32_EMULATION=y
+CONFIG_IA32_AOUT=m
+# CONFIG_X86_X32 is not set
+CONFIG_COMPAT=y
+CONFIG_COMPAT_FOR_U64_ALIGNMENT=y
+CONFIG_SYSVIPC_COMPAT=y
+CONFIG_KEYS_COMPAT=y
 CONFIG_X86_DEV_DMA_OPS=y
 CONFIG_IOSF_MBI=m
 CONFIG_NET=y
+CONFIG_COMPAT_NETLINK_MESSAGES=y
 
 #
 # Networking options
@@ -1195,7 +1212,7 @@ CONFIG_CGROUP_NET_PRIO=m
 CONFIG_CGROUP_NET_CLASSID=y
 CONFIG_NET_RX_BUSY_POLL=y
 CONFIG_BQL=y
-# CONFIG_BPF_JIT is not set
+CONFIG_BPF_JIT=y
 CONFIG_NET_FLOW_LIMIT=y
 
 #
@@ -1348,7 +1365,7 @@ CONFIG_BLK_DEV_CRYPTOLOOP=m
 # CONFIG_BLK_DEV_DRBD is not set
 # CONFIG_BLK_DEV_NBD is not set
 CONFIG_BLK_DEV_NVME=m
-# CONFIG_BLK_DEV_SKD is not set
+CONFIG_BLK_DEV_SKD=m
 # CONFIG_BLK_DEV_OSD is not set
 CONFIG_BLK_DEV_SX8=m
 CONFIG_BLK_DEV_RAM=y
@@ -1428,13 +1445,13 @@ CONFIG_VMWARE_VMCI=m
 #
 # Intel MIC Host Driver
 #
-# CONFIG_INTEL_MIC_HOST is not set
+CONFIG_INTEL_MIC_HOST=m
 
 #
 # Intel MIC Card Driver
 #
-# CONFIG_INTEL_MIC_CARD is not set
-# CONFIG_GENWQE is not set
+CONFIG_INTEL_MIC_CARD=m
+CONFIG_GENWQE=m
 CONFIG_HAVE_IDE=y
 # CONFIG_IDE is not set
 
@@ -4540,7 +4557,8 @@ CONFIG_EDAC=y
 CONFIG_EDAC_DECODE_MCE=m
 CONFIG_EDAC_MCE_INJ=m
 CONFIG_EDAC_MM_EDAC=m
-# CONFIG_EDAC_AMD64 is not set
+CONFIG_EDAC_AMD64=m
+# CONFIG_EDAC_AMD64_ERROR_INJECTION is not set
 CONFIG_EDAC_E752X=m
 CONFIG_EDAC_I82975X=m
 CONFIG_EDAC_I3000=m
@@ -4551,6 +4569,7 @@ CONFIG_EDAC_I7CORE=m
 CONFIG_EDAC_I5000=m
 CONFIG_EDAC_I5100=m
 CONFIG_EDAC_I7300=m
+CONFIG_EDAC_SBRIDGE=m
 CONFIG_RTC_LIB=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_HCTOSYS=y
@@ -4896,12 +4915,13 @@ CONFIG_CLKBLD_I8253=y
 CONFIG_MAILBOX=y
 CONFIG_IOMMU_API=y
 CONFIG_IOMMU_SUPPORT=y
-# CONFIG_AMD_IOMMU is not set
+CONFIG_AMD_IOMMU=y
+# CONFIG_AMD_IOMMU_STATS is not set
 CONFIG_DMAR_TABLE=y
 CONFIG_INTEL_IOMMU=y
 # CONFIG_INTEL_IOMMU_DEFAULT_ON is not set
 CONFIG_INTEL_IOMMU_FLOPPY_WA=y
-# CONFIG_IRQ_REMAP is not set
+CONFIG_IRQ_REMAP=y
 
 #
 # Remoteproc drivers
@@ -5119,6 +5139,7 @@ CONFIG_QUOTA_TREE=y
 # CONFIG_QFMT_V1 is not set
 CONFIG_QFMT_V2=y
 CONFIG_QUOTACTL=y
+CONFIG_QUOTACTL_COMPAT=y
 CONFIG_AUTOFS4_FS=y
 CONFIG_FUSE_FS=m
 CONFIG_CUSE=m
@@ -5561,10 +5582,11 @@ CONFIG_PAX_USERCOPY=y
 #
 # CONFIG_GRKERNSEC_KMEM is not set
 # CONFIG_GRKERNSEC_IO is not set
+CONFIG_GRKERNSEC_JIT_HARDEN=y
 # CONFIG_GRKERNSEC_PERF_HARDEN is not set
 CONFIG_GRKERNSEC_RAND_THREADSTACK=y
 CONFIG_GRKERNSEC_PROC_MEMMAP=y
-# CONFIG_GRKERNSEC_KSTACKOVERFLOW is not set
+CONFIG_GRKERNSEC_KSTACKOVERFLOW=y
 CONFIG_GRKERNSEC_BRUTE=y
 CONFIG_GRKERNSEC_MODHARDEN=y
 CONFIG_GRKERNSEC_HIDESYM=y
@@ -5747,7 +5769,7 @@ CONFIG_CRYPTO_CRC32C_INTEL=y
 CONFIG_CRYPTO_CRC32=y
 CONFIG_CRYPTO_CRC32_PCLMUL=m
 CONFIG_CRYPTO_CRCT10DIF=y
-# CONFIG_CRYPTO_CRCT10DIF_PCLMUL is not set
+CONFIG_CRYPTO_CRCT10DIF_PCLMUL=m
 CONFIG_CRYPTO_GHASH=m
 CONFIG_CRYPTO_MD4=m
 CONFIG_CRYPTO_MD5=y
index b4cd8f857192a330af409cf004e677fd54fad7c5..a174c5b45051ad7acbf601032937aed8b5dff949 100644 (file)
@@ -62,7 +62,6 @@ etc/rc.d/init.d/mounttmpfs
 #etc/rc.d/init.d/netsnmpd
 etc/rc.d/init.d/network
 etc/rc.d/init.d/network-trigger
-etc/rc.d/init.d/network-vlans
 #etc/rc.d/init.d/networking
 etc/rc.d/init.d/networking/any
 etc/rc.d/init.d/networking/blue
@@ -232,7 +231,6 @@ etc/rc.d/rcsysinit.d/S75firstsetup
 etc/rc.d/rcsysinit.d/S80localnet
 etc/rc.d/rcsysinit.d/S85firewall
 etc/rc.d/rcsysinit.d/S90network-trigger
-etc/rc.d/rcsysinit.d/S91network-vlans
 etc/rc.d/rcsysinit.d/S92rngd
 etc/rc.d/rc3.d/S15fireinfo
 #etc/sysconfig
index 878ba667e540fbf1daaa3e825a7584f0224463a7..84c432a055303b881dc24f642ea39f372ccf16ba 100644 (file)
@@ -64,7 +64,6 @@ etc/rc.d/init.d/mounttmpfs
 #etc/rc.d/init.d/netsnmpd
 etc/rc.d/init.d/network
 etc/rc.d/init.d/network-trigger
-etc/rc.d/init.d/network-vlans
 #etc/rc.d/init.d/networking
 etc/rc.d/init.d/networking/any
 etc/rc.d/init.d/networking/blue
@@ -237,7 +236,6 @@ etc/rc.d/rcsysinit.d/S75firstsetup
 etc/rc.d/rcsysinit.d/S80localnet
 etc/rc.d/rcsysinit.d/S85firewall
 etc/rc.d/rcsysinit.d/S90network-trigger
-etc/rc.d/rcsysinit.d/S91network-vlans
 etc/rc.d/rcsysinit.d/S92rngd
 etc/rc.d/rc3.d/S15fireinfo
 #etc/sysconfig
index d5e5ad3e16c148e0319e12eb90fc7a9ba11f551d..286316799602126a61ac61f40ce06f065f9eb2a6 100644 (file)
@@ -3,7 +3,7 @@ bin/ps
 lib/libproc-3.2.6.so
 sbin/sysctl
 usr/bin/free
-#usr/bin/pgrep
+usr/bin/pgrep
 #usr/bin/pkill
 #usr/bin/pmap
 #usr/bin/pwdx
index 90e28d9c4c26cc7f404ae5766b4088de30215198..4021cafad68643d9ea6bf089d0d7e1452e622cb2 100644 (file)
@@ -73,6 +73,7 @@ run
 #usr/lib
 usr/lib/firewall
 usr/lib/firewall/firewall-lib.pl
+usr/lib/firewall/ipsec-block
 usr/lib/firewall/rules.pl
 #usr/lib/libgcc_s.so
 usr/lib/libgcc_s.so.1
index 7564d38c8b889e63ce9db24c2bf8ba90c5c13acf..f51cc3a9cd55c224189d62acd2b869453de00e26 100644 (file)
@@ -153,6 +153,7 @@ usr/libexec/ipsec/starter
 usr/libexec/ipsec/stroke
 usr/sbin/ipsec
 #usr/share/man/man1/pki---acert.1
+#usr/share/man/man1/pki---dn.1
 #usr/share/man/man1/pki---gen.1
 #usr/share/man/man1/pki---issue.1
 #usr/share/man/man1/pki---keyid.1
index d01c4610158f05d6da4b1febd2f1ac5b1e6ee772..4d519544d96d5e3dde75d5cb73020fd7473ff22f 100644 (file)
@@ -29,6 +29,7 @@ lib/udev
 #lib/udev/init-net-rules.sh
 #lib/udev/mtd_probe
 #lib/udev/network-hotplug-rename
+#lib/udev/network-hotplug-vlan
 #lib/udev/rule_generator.functions
 #lib/udev/rules.d
 #lib/udev/rules.d/25-alsa.rules
index 878ba667e540fbf1daaa3e825a7584f0224463a7..84c432a055303b881dc24f642ea39f372ccf16ba 100644 (file)
@@ -64,7 +64,6 @@ etc/rc.d/init.d/mounttmpfs
 #etc/rc.d/init.d/netsnmpd
 etc/rc.d/init.d/network
 etc/rc.d/init.d/network-trigger
-etc/rc.d/init.d/network-vlans
 #etc/rc.d/init.d/networking
 etc/rc.d/init.d/networking/any
 etc/rc.d/init.d/networking/blue
@@ -237,7 +236,6 @@ etc/rc.d/rcsysinit.d/S75firstsetup
 etc/rc.d/rcsysinit.d/S80localnet
 etc/rc.d/rcsysinit.d/S85firewall
 etc/rc.d/rcsysinit.d/S90network-trigger
-etc/rc.d/rcsysinit.d/S91network-vlans
 etc/rc.d/rcsysinit.d/S92rngd
 etc/rc.d/rc3.d/S15fireinfo
 #etc/sysconfig
index 4f1ac7a59d27600b170b1e7e4e97baf68e402c07..2cae007ad53d78be1e7a01f1a44ea0d9f294c71c 100644 (file)
@@ -18,6 +18,7 @@ lib/modules/KVER-ipfire
 #lib/modules/KVER-ipfire/kernel/arch/x86/crypto/cast5-avx-x86_64.ko
 #lib/modules/KVER-ipfire/kernel/arch/x86/crypto/cast6-avx-x86_64.ko
 #lib/modules/KVER-ipfire/kernel/arch/x86/crypto/crc32-pclmul.ko
+#lib/modules/KVER-ipfire/kernel/arch/x86/crypto/crct10dif-pclmul.ko
 #lib/modules/KVER-ipfire/kernel/arch/x86/crypto/ghash-clmulni-intel.ko
 #lib/modules/KVER-ipfire/kernel/arch/x86/crypto/salsa20-x86_64.ko
 #lib/modules/KVER-ipfire/kernel/arch/x86/crypto/serpent-avx-x86_64.ko
@@ -29,6 +30,8 @@ lib/modules/KVER-ipfire
 #lib/modules/KVER-ipfire/kernel/arch/x86/crypto/twofish-avx-x86_64.ko
 #lib/modules/KVER-ipfire/kernel/arch/x86/crypto/twofish-x86_64-3way.ko
 #lib/modules/KVER-ipfire/kernel/arch/x86/crypto/twofish-x86_64.ko
+#lib/modules/KVER-ipfire/kernel/arch/x86/ia32
+#lib/modules/KVER-ipfire/kernel/arch/x86/ia32/ia32_aout.ko
 #lib/modules/KVER-ipfire/kernel/arch/x86/kernel
 #lib/modules/KVER-ipfire/kernel/arch/x86/kernel/cpu
 #lib/modules/KVER-ipfire/kernel/arch/x86/kernel/cpu/microcode
@@ -207,6 +210,7 @@ lib/modules/KVER-ipfire
 #lib/modules/KVER-ipfire/kernel/drivers/block/nvme.ko
 #lib/modules/KVER-ipfire/kernel/drivers/block/rsxx
 #lib/modules/KVER-ipfire/kernel/drivers/block/rsxx/rsxx.ko
+#lib/modules/KVER-ipfire/kernel/drivers/block/skd.ko
 #lib/modules/KVER-ipfire/kernel/drivers/block/sx8.ko
 #lib/modules/KVER-ipfire/kernel/drivers/block/umem.ko
 #lib/modules/KVER-ipfire/kernel/drivers/block/virtio_blk.ko
@@ -279,6 +283,7 @@ lib/modules/KVER-ipfire
 #lib/modules/KVER-ipfire/kernel/drivers/dma/pch_dma.ko
 #lib/modules/KVER-ipfire/kernel/drivers/dma/timb_dma.ko
 #lib/modules/KVER-ipfire/kernel/drivers/edac
+#lib/modules/KVER-ipfire/kernel/drivers/edac/amd64_edac_mod.ko
 #lib/modules/KVER-ipfire/kernel/drivers/edac/e752x_edac.ko
 #lib/modules/KVER-ipfire/kernel/drivers/edac/edac_core.ko
 #lib/modules/KVER-ipfire/kernel/drivers/edac/edac_mce_amd.ko
@@ -291,6 +296,7 @@ lib/modules/KVER-ipfire
 #lib/modules/KVER-ipfire/kernel/drivers/edac/i7core_edac.ko
 #lib/modules/KVER-ipfire/kernel/drivers/edac/i82975x_edac.ko
 #lib/modules/KVER-ipfire/kernel/drivers/edac/mce_amd_inj.ko
+#lib/modules/KVER-ipfire/kernel/drivers/edac/sb_edac.ko
 #lib/modules/KVER-ipfire/kernel/drivers/edac/x38_edac.ko
 #lib/modules/KVER-ipfire/kernel/drivers/firewire
 #lib/modules/KVER-ipfire/kernel/drivers/firewire/firewire-core.ko
@@ -1342,12 +1348,19 @@ lib/modules/KVER-ipfire
 #lib/modules/KVER-ipfire/kernel/drivers/misc/eeprom/max6875.ko
 #lib/modules/KVER-ipfire/kernel/drivers/misc/enclosure.ko
 #lib/modules/KVER-ipfire/kernel/drivers/misc/fsa9480.ko
+#lib/modules/KVER-ipfire/kernel/drivers/misc/genwqe
+#lib/modules/KVER-ipfire/kernel/drivers/misc/genwqe/genwqe_card.ko
 #lib/modules/KVER-ipfire/kernel/drivers/misc/hpilo.ko
 #lib/modules/KVER-ipfire/kernel/drivers/misc/ibmasm
 #lib/modules/KVER-ipfire/kernel/drivers/misc/ibmasm/ibmasm.ko
 #lib/modules/KVER-ipfire/kernel/drivers/misc/ics932s401.ko
 #lib/modules/KVER-ipfire/kernel/drivers/misc/lis3lv02d
 #lib/modules/KVER-ipfire/kernel/drivers/misc/lis3lv02d/lis3lv02d.ko
+#lib/modules/KVER-ipfire/kernel/drivers/misc/mic
+#lib/modules/KVER-ipfire/kernel/drivers/misc/mic/card
+#lib/modules/KVER-ipfire/kernel/drivers/misc/mic/card/mic_card.ko
+#lib/modules/KVER-ipfire/kernel/drivers/misc/mic/host
+#lib/modules/KVER-ipfire/kernel/drivers/misc/mic/host/mic_host.ko
 #lib/modules/KVER-ipfire/kernel/drivers/misc/pch_phub.ko
 #lib/modules/KVER-ipfire/kernel/drivers/misc/ti-st
 #lib/modules/KVER-ipfire/kernel/drivers/misc/ti-st/st_drv.ko
index 0ac9ab55ac418421f6b24b1c6b6131aed017085b..531daaadd39c80d5c0ebf2e9a3de6cd916591e7d 100644 (file)
@@ -74,6 +74,7 @@ run
 #usr/lib
 usr/lib/firewall
 usr/lib/firewall/firewall-lib.pl
+usr/lib/firewall/ipsec-block
 usr/lib/firewall/rules.pl
 #usr/lib/libgcc_s.so
 usr/lib/libgcc_s.so.1
diff --git a/config/rootfiles/core/95/filelists/ddns b/config/rootfiles/core/95/filelists/ddns
new file mode 120000 (symlink)
index 0000000..7395164
--- /dev/null
@@ -0,0 +1 @@
+../../../common/ddns
\ No newline at end of file
diff --git a/config/rootfiles/core/95/filelists/files b/config/rootfiles/core/95/filelists/files
new file mode 100644 (file)
index 0000000..dfecbaf
--- /dev/null
@@ -0,0 +1,17 @@
+etc/system-release
+etc/issue
+etc/rc.d/init.d/dnsmasq
+etc/rc.d/init.d/firewall
+lib/udev/network-hotplug-vlan
+lib/udev/rules.d/60-net.rules
+srv/web/ipfire/cgi-bin/connections.cgi
+srv/web/ipfire/cgi-bin/dhcp.cgi
+srv/web/ipfire/cgi-bin/firewall.cgi
+srv/web/ipfire/cgi-bin/logs.cgi/firewalllogcountry.dat
+srv/web/ipfire/cgi-bin/pppsetup.cgi
+srv/web/ipfire/cgi-bin/routing.cgi
+srv/web/ipfire/cgi-bin/vpnmain.cgi
+usr/lib/firewall/firewall-lib.pl
+usr/lib/firewall/ipsec-block
+usr/local/bin/ipsecctrl
+var/ipfire/langs
diff --git a/config/rootfiles/core/95/filelists/i586/strongswan-padlock b/config/rootfiles/core/95/filelists/i586/strongswan-padlock
new file mode 120000 (symlink)
index 0000000..2412824
--- /dev/null
@@ -0,0 +1 @@
+../../../../common/i586/strongswan-padlock
\ No newline at end of file
diff --git a/config/rootfiles/core/95/filelists/strongswan b/config/rootfiles/core/95/filelists/strongswan
new file mode 120000 (symlink)
index 0000000..90c727e
--- /dev/null
@@ -0,0 +1 @@
+../../../common/strongswan
\ No newline at end of file
diff --git a/config/rootfiles/core/95/update.sh b/config/rootfiles/core/95/update.sh
new file mode 100644 (file)
index 0000000..a34a3fe
--- /dev/null
@@ -0,0 +1,65 @@
+#!/bin/bash
+############################################################################
+#                                                                          #
+# This file is part of the IPFire Firewall.                                #
+#                                                                          #
+# IPFire is free software; you can redistribute it and/or modify           #
+# it under the terms of the GNU General Public License as published by     #
+# the Free Software Foundation; either version 3 of the License, or        #
+# (at your option) any later version.                                      #
+#                                                                          #
+# IPFire is distributed in the hope that it will be useful,                #
+# but WITHOUT ANY WARRANTY; without even the implied warranty of           #
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the            #
+# GNU General Public License for more details.                             #
+#                                                                          #
+# You should have received a copy of the GNU General Public License        #
+# along with IPFire; if not, write to the Free Software                    #
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA #
+#                                                                          #
+# Copyright (C) 2015 IPFire-Team <info@ipfire.org>.                        #
+#                                                                          #
+############################################################################
+#
+. /opt/pakfire/lib/functions.sh
+/usr/local/bin/backupctrl exclude >/dev/null 2>&1
+
+# Remove old core updates from pakfire cache to save space...
+core=95
+for (( i=1; i<=$core; i++ ))
+do
+       rm -f /var/cache/pakfire/core-upgrade-*-$i.ipfire
+done
+
+# Remove files
+rm -f /etc/rc.d/init.d/network-vlans
+rm -f /etc/rc.d/rcsysinit.d/S91network-vlans
+
+# Stop services
+/etc/init.d/ipsec stop
+
+# Extract files
+extract_files
+
+# Update Language cache
+/usr/local/bin/update-lang-cache
+
+# Start services
+if [ `grep "ENABLED=on" /var/ipfire/vpn/settings` ]; then
+       /etc/init.d/ipsec start
+fi
+
+# This update need a reboot...
+#touch /var/run/need_reboot
+
+# Finish
+/etc/init.d/fireinfo start
+sendprofile
+# Update grub config to display new core version
+if [ -e /boot/grub/grub.cfg ]; then
+       grub-mkconfig -o /boot/grub/grub.cfg
+fi
+sync
+
+# Don't report the exitcode last command
+exit 0
diff --git a/config/rootfiles/oldcore/94/exclude b/config/rootfiles/oldcore/94/exclude
new file mode 100644 (file)
index 0000000..4c7aa5a
--- /dev/null
@@ -0,0 +1,22 @@
+boot/config.txt
+etc/alternatives
+etc/collectd.custom
+etc/ipsec.conf
+etc/ipsec.secrets
+etc/ipsec.user.conf
+etc/ipsec.user.secrets
+etc/localtime
+etc/shadow
+etc/ssh/ssh_config
+etc/ssh/sshd_config
+etc/ssl/openssl.cnf
+etc/sudoers
+etc/sysconfig/firewall.local
+etc/sysconfig/rc.local
+etc/udev/rules.d/30-persistent-network.rules
+srv/web/ipfire/html/proxy.pac
+var/ipfire/ovpn
+var/lib/alternatives
+var/log/cache
+var/state/dhcp/dhcpd.leases
+var/updatecache
diff --git a/config/rootfiles/oldcore/94/meta b/config/rootfiles/oldcore/94/meta
new file mode 100644 (file)
index 0000000..d547fa8
--- /dev/null
@@ -0,0 +1 @@
+DEPS=""
index 4f22a1e306ee105561c389fb1ded8c042275d69f..dc39ff09b3c6440ef314cf0a8d11fb9460e3cc19 100644 (file)
@@ -1,3 +1,7 @@
 # Call a script that checks for the right name of the new device.
 # If it matches the configuration it will be renamed accordingly.
 ACTION=="add", SUBSYSTEM=="net", PROGRAM="/lib/udev/network-hotplug-rename", RESULT=="?*", NAME="$result"
+
+# Call a script that will create all virtual devices for a parent device
+# that has just come up.
+ACTION=="add", SUBSYSTEM=="net", PROGRAM="/lib/udev/network-hotplug-vlan"
similarity index 60%
rename from src/initscripts/init.d/network-vlans
rename to config/udev/network-hotplug-vlan
index a6a75c35f8a85aff2e43a073b98dcb6a8bb11b11..f7b6a9de1525dc5eb35604e06f8775b18696fc26 100644 (file)
 # along with IPFire; if not, write to the Free Software                    #
 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA #
 #                                                                          #
-# Copyright (C) 2012 IPFire Team <info@ipfire.org>                         #
+# Copyright (C) 2015 IPFire Team <info@ipfire.org>                         #
 #                                                                          #
 ############################################################################
 
+[ -n "${INTERFACE}" ] || exit 2
+
 CONFIG_FILE="/var/ipfire/ethernet/vlans"
 
 # Skip immediately if no configuration file has been found.
@@ -28,9 +30,6 @@ CONFIG_FILE="/var/ipfire/ethernet/vlans"
 
 eval $(/usr/local/bin/readhash ${CONFIG_FILE})
 
-# This is start or stop.
-action=${1}
-
 for interface in green0 red0 blue0 orange0; do
        case "${interface}" in
                green*)
@@ -55,59 +54,34 @@ for interface in green0 red0 blue0 orange0; do
                        ;;
        esac
 
-       case "${action}" in
-               start)
-                       # If no parent device has been configured, we assume
-                       # that this interface is not set up for VLANs and
-                       # silently go on.
-                       [ -z "${PARENT_DEV}" ] && continue
-
-                       # Check if the interface does already exists.
-                       # If so, we skip creating it.
-                       if [ -d "/sys/class/net/${interface}" ]; then
-                               echo "Interface ${interface} already exists." >&2
-                               continue
-                       fi
-
-                       # Check if the parent interface exists.
-                       if [ ! -d "/sys/class/net/${PARENT_DEV}" ]; then
-                               echo "${interface}: Parent device is not set or does not exist: ${PARENT_DEV}" >&2
-                               continue
-                       fi
-
-                       if [ -z "${VLAN_ID}" ]; then
-                               echo "${interface}: You did not set the VLAN ID." >&2
-                               continue
-                       fi
+       # If the parent device does not match the interface that
+       # has just come up, we will go on for the next one.
+       [ "${PARENT_DEV}" = "${INTERFACE}" ] || continue
 
-                       # Build command line.
-                       command="ip link add link ${PARENT_DEV} name ${interface}"
-                       if [ -n "${MAC_ADDRESS}" ]; then
-                               command="${command} address ${MAC_ADDRESS}"
-                       fi
-                       command="${command} type vlan id ${VLAN_ID}"
+       # Check if the interface does already exists.
+       # If so, we skip creating it.
+       if [ -d "/sys/class/net/${interface}" ]; then
+               echo "Interface ${interface} already exists." >&2
+               continue
+       fi
 
-                       echo "Creating VLAN interface ${interface}..."
-                       ${command}
+       if [ -z "${VLAN_ID}" ]; then
+               echo "${interface}: You did not set the VLAN ID." >&2
+               continue
+       fi
 
-                       # Bring up the parent device.
-                       ip link set ${PARENT_DEV} up
-                       ;;
+       # Build command line.
+       command="ip link add link ${PARENT_DEV} name ${interface}"
+       if [ -n "${MAC_ADDRESS}" ]; then
+               command="${command} address ${MAC_ADDRESS}"
+       fi
+       command="${command} type vlan id ${VLAN_ID}"
 
-               stop)
-                       if [ ! -e "/proc/net/vlan/${interface}" ]; then
-                               echo "${interface} is not a VLAN interface. Skipping."
-                               continue
-                       fi
+       echo "Creating VLAN interface ${interface}..."
+       ${command}
 
-                       echo "Removing VLAN interface ${interface}..."
-                       ip link set ${interface} down
-                       ip link delete ${interface}
-                       ;;
-               
-               *)
-                       echo "Invalid action: ${action}"
-                       exit 1
-                       ;;
-       esac
+       # Bring up the parent device.
+       ip link set ${PARENT_DEV} up
 done
+
+exit 0
index 54d9de99280afdc7674c2060f7696c579eb89b62..6c471840410b312fa064b3817a224cae59a7c128 100644 (file)
@@ -82,6 +82,7 @@ WARNING: translation string unused: cache management
 WARNING: translation string unused: cache size
 WARNING: translation string unused: calamaris report interval (in minutes)
 WARNING: translation string unused: calc traffic all x minutes
+WARNING: translation string unused: cannot enable both nat traversal and compression
 WARNING: translation string unused: cant enable xtaccess
 WARNING: translation string unused: capsinactive
 WARNING: translation string unused: ccd err iroute
index 95477de8b8867e14e91b401eee8e1680eaf3638d..68e351cab212c41420982c73e0554b316cb764a7 100644 (file)
@@ -100,6 +100,7 @@ WARNING: translation string unused: cache management
 WARNING: translation string unused: cache size
 WARNING: translation string unused: calamaris report interval (in minutes)
 WARNING: translation string unused: calc traffic all x minutes
+WARNING: translation string unused: cannot enable both nat traversal and compression
 WARNING: translation string unused: cant enable xtaccess
 WARNING: translation string unused: capsinactive
 WARNING: translation string unused: ccd err iroute
index 91945ffb713843e2d1f9c3f3ebbe801c90bb282c..84298f4c60280835a7af9dc7e0f570503dfd7f80 100644 (file)
@@ -95,6 +95,7 @@ WARNING: translation string unused: cache management
 WARNING: translation string unused: cache size
 WARNING: translation string unused: calamaris report interval (in minutes)
 WARNING: translation string unused: calc traffic all x minutes
+WARNING: translation string unused: cannot enable both nat traversal and compression
 WARNING: translation string unused: cant enable xtaccess
 WARNING: translation string unused: capsinactive
 WARNING: translation string unused: cfg restart
@@ -668,6 +669,11 @@ WARNING: untranslated string: dh key move failed
 WARNING: untranslated string: dh key warn
 WARNING: untranslated string: dh key warn1
 WARNING: untranslated string: dh parameter
+WARNING: untranslated string: dhcp dns enable update
+WARNING: untranslated string: dhcp dns key name
+WARNING: untranslated string: dhcp dns update
+WARNING: untranslated string: dhcp dns update algo
+WARNING: untranslated string: dhcp dns update secret
 WARNING: untranslated string: dnat address
 WARNING: untranslated string: dns servers
 WARNING: untranslated string: dnsforward
@@ -989,6 +995,7 @@ WARNING: untranslated string: proxy reports weekly
 WARNING: untranslated string: qos enter bandwidths
 WARNING: untranslated string: random number generator daemon
 WARNING: untranslated string: red1
+WARNING: untranslated string: required field
 WARNING: untranslated string: route config changed
 WARNING: untranslated string: routing config added
 WARNING: untranslated string: routing config changed
index 344ef07a3284b24eca362e06025c7ac9d00eebd4..e9915c85be893411357b22169d27ef6975c63d26 100644 (file)
@@ -95,6 +95,7 @@ WARNING: translation string unused: cache management
 WARNING: translation string unused: cache size
 WARNING: translation string unused: calamaris report interval (in minutes)
 WARNING: translation string unused: calc traffic all x minutes
+WARNING: translation string unused: cannot enable both nat traversal and compression
 WARNING: translation string unused: cant enable xtaccess
 WARNING: translation string unused: capsinactive
 WARNING: translation string unused: cfg restart
@@ -675,6 +676,11 @@ WARNING: untranslated string: dh key move failed
 WARNING: untranslated string: dh key warn
 WARNING: untranslated string: dh key warn1
 WARNING: untranslated string: dh parameter
+WARNING: untranslated string: dhcp dns enable update
+WARNING: untranslated string: dhcp dns key name
+WARNING: untranslated string: dhcp dns update
+WARNING: untranslated string: dhcp dns update algo
+WARNING: untranslated string: dhcp dns update secret
 WARNING: untranslated string: dnat address
 WARNING: untranslated string: dns address deleted txt
 WARNING: untranslated string: dns servers
@@ -1000,6 +1006,7 @@ WARNING: untranslated string: proxy reports weekly
 WARNING: untranslated string: qos enter bandwidths
 WARNING: untranslated string: random number generator daemon
 WARNING: untranslated string: red1
+WARNING: untranslated string: required field
 WARNING: untranslated string: route config changed
 WARNING: untranslated string: routing config added
 WARNING: untranslated string: routing config changed
index 38614d69f521f25325797c7649f9375b4a935350..420a46c8a5b5df50f87eaf557555770cf1d7470b 100644 (file)
@@ -99,6 +99,7 @@ WARNING: translation string unused: cache management
 WARNING: translation string unused: cache size
 WARNING: translation string unused: calamaris report interval (in minutes)
 WARNING: translation string unused: calc traffic all x minutes
+WARNING: translation string unused: cannot enable both nat traversal and compression
 WARNING: translation string unused: cant enable xtaccess
 WARNING: translation string unused: capsinactive
 WARNING: translation string unused: ccd err iroute
@@ -674,6 +675,11 @@ WARNING: untranslated string: advproxy group access control
 WARNING: untranslated string: advproxy group required
 WARNING: untranslated string: bytes
 WARNING: untranslated string: check all
+WARNING: untranslated string: dhcp dns enable update
+WARNING: untranslated string: dhcp dns key name
+WARNING: untranslated string: dhcp dns update
+WARNING: untranslated string: dhcp dns update algo
+WARNING: untranslated string: dhcp dns update secret
 WARNING: untranslated string: email config
 WARNING: untranslated string: email empty field
 WARNING: untranslated string: email invalid
@@ -729,6 +735,7 @@ WARNING: untranslated string: ovpn add conf
 WARNING: untranslated string: pptp netconfig
 WARNING: untranslated string: pptp peer
 WARNING: untranslated string: pptp route
+WARNING: untranslated string: required field
 WARNING: untranslated string: route config changed
 WARNING: untranslated string: routing config added
 WARNING: untranslated string: routing config changed
index 2d3c78b985f790de599df397853b10da921f4f81..c8769872bc7fbd27c79a1628da1ada180169b464 100644 (file)
@@ -99,6 +99,7 @@ WARNING: translation string unused: cache management
 WARNING: translation string unused: cache size
 WARNING: translation string unused: calamaris report interval (in minutes)
 WARNING: translation string unused: calc traffic all x minutes
+WARNING: translation string unused: cannot enable both nat traversal and compression
 WARNING: translation string unused: cant enable xtaccess
 WARNING: translation string unused: capsinactive
 WARNING: translation string unused: ccd err iroute
@@ -679,6 +680,11 @@ WARNING: untranslated string: dh key move failed
 WARNING: untranslated string: dh key warn
 WARNING: untranslated string: dh key warn1
 WARNING: untranslated string: dh parameter
+WARNING: untranslated string: dhcp dns enable update
+WARNING: untranslated string: dhcp dns key name
+WARNING: untranslated string: dhcp dns update
+WARNING: untranslated string: dhcp dns update algo
+WARNING: untranslated string: dhcp dns update secret
 WARNING: untranslated string: dns servers
 WARNING: untranslated string: dnssec aware
 WARNING: untranslated string: dnssec information
@@ -771,6 +777,7 @@ WARNING: untranslated string: pptp netconfig
 WARNING: untranslated string: pptp peer
 WARNING: untranslated string: pptp route
 WARNING: untranslated string: random number generator daemon
+WARNING: untranslated string: required field
 WARNING: untranslated string: route config changed
 WARNING: untranslated string: routing config added
 WARNING: untranslated string: routing config changed
index 91945ffb713843e2d1f9c3f3ebbe801c90bb282c..84298f4c60280835a7af9dc7e0f570503dfd7f80 100644 (file)
@@ -95,6 +95,7 @@ WARNING: translation string unused: cache management
 WARNING: translation string unused: cache size
 WARNING: translation string unused: calamaris report interval (in minutes)
 WARNING: translation string unused: calc traffic all x minutes
+WARNING: translation string unused: cannot enable both nat traversal and compression
 WARNING: translation string unused: cant enable xtaccess
 WARNING: translation string unused: capsinactive
 WARNING: translation string unused: cfg restart
@@ -668,6 +669,11 @@ WARNING: untranslated string: dh key move failed
 WARNING: untranslated string: dh key warn
 WARNING: untranslated string: dh key warn1
 WARNING: untranslated string: dh parameter
+WARNING: untranslated string: dhcp dns enable update
+WARNING: untranslated string: dhcp dns key name
+WARNING: untranslated string: dhcp dns update
+WARNING: untranslated string: dhcp dns update algo
+WARNING: untranslated string: dhcp dns update secret
 WARNING: untranslated string: dnat address
 WARNING: untranslated string: dns servers
 WARNING: untranslated string: dnsforward
@@ -989,6 +995,7 @@ WARNING: untranslated string: proxy reports weekly
 WARNING: untranslated string: qos enter bandwidths
 WARNING: untranslated string: random number generator daemon
 WARNING: untranslated string: red1
+WARNING: untranslated string: required field
 WARNING: untranslated string: route config changed
 WARNING: untranslated string: routing config added
 WARNING: untranslated string: routing config changed
index 45316709d799369127372b8cb2a5198decda04a1..a03f30072889eee82c5596e50a776f2dd6deb891 100644 (file)
@@ -95,6 +95,7 @@ WARNING: translation string unused: cache management
 WARNING: translation string unused: cache size
 WARNING: translation string unused: calamaris report interval (in minutes)
 WARNING: translation string unused: calc traffic all x minutes
+WARNING: translation string unused: cannot enable both nat traversal and compression
 WARNING: translation string unused: cant enable xtaccess
 WARNING: translation string unused: capsinactive
 WARNING: translation string unused: cfg restart
@@ -669,6 +670,11 @@ WARNING: untranslated string: dh key move failed
 WARNING: untranslated string: dh key warn
 WARNING: untranslated string: dh key warn1
 WARNING: untranslated string: dh parameter
+WARNING: untranslated string: dhcp dns enable update
+WARNING: untranslated string: dhcp dns key name
+WARNING: untranslated string: dhcp dns update
+WARNING: untranslated string: dhcp dns update algo
+WARNING: untranslated string: dhcp dns update secret
 WARNING: untranslated string: disk access per
 WARNING: untranslated string: dnat address
 WARNING: untranslated string: dns servers
@@ -983,6 +989,7 @@ WARNING: untranslated string: proxy reports weekly
 WARNING: untranslated string: qos enter bandwidths
 WARNING: untranslated string: random number generator daemon
 WARNING: untranslated string: red1
+WARNING: untranslated string: required field
 WARNING: untranslated string: route config changed
 WARNING: untranslated string: routing config added
 WARNING: untranslated string: routing config changed
index 672a49d7434d15ac4896a88ef7492c8b74fbde76..5d1ceb70787c58b1da579f7c35921b50fbb9f510 100644 (file)
@@ -99,6 +99,7 @@ WARNING: translation string unused: cache management
 WARNING: translation string unused: cache size
 WARNING: translation string unused: calamaris report interval (in minutes)
 WARNING: translation string unused: calc traffic all x minutes
+WARNING: translation string unused: cannot enable both nat traversal and compression
 WARNING: translation string unused: cant enable xtaccess
 WARNING: translation string unused: capsinactive
 WARNING: translation string unused: ccd err iroute
@@ -666,6 +667,11 @@ WARNING: translation string unused: yearly firewallhits
 WARNING: untranslated string: Scan for Songs
 WARNING: untranslated string: bytes
 WARNING: untranslated string: check all
+WARNING: untranslated string: dhcp dns enable update
+WARNING: untranslated string: dhcp dns key name
+WARNING: untranslated string: dhcp dns update
+WARNING: untranslated string: dhcp dns update algo
+WARNING: untranslated string: dhcp dns update secret
 WARNING: untranslated string: email config
 WARNING: untranslated string: email empty field
 WARNING: untranslated string: email invalid
@@ -708,6 +714,7 @@ WARNING: untranslated string: ovpn add conf
 WARNING: untranslated string: pptp netconfig
 WARNING: untranslated string: pptp peer
 WARNING: untranslated string: pptp route
+WARNING: untranslated string: required field
 WARNING: untranslated string: route config changed
 WARNING: untranslated string: routing config added
 WARNING: untranslated string: routing config changed
index 97e2d1832d34807ac04d1e85888463192256ea0d..9da01227d7fbd927b53e7da8509dfb9d51ae425e 100644 (file)
 < deprecated fs warn
 < details
 < dh
+< dhcp dns enable update
+< dhcp dns key name
+< dhcp dns update
+< dhcp dns update algo
+< dhcp dns update secret
 < dh key move failed
 < dh key warn
 < dh key warn1
 < qos enter bandwidths
 < random number generator daemon
 < red1
+< required field
 < samba join a domain
 < samba join domain
 < search
 < deprecated fs warn
 < details
 < dh
+< dhcp dns enable update
+< dhcp dns key name
+< dhcp dns update
+< dhcp dns update algo
+< dhcp dns update secret
 < dh key move failed
 < dh key warn
 < dh key warn1
 < qos enter bandwidths
 < random number generator daemon
 < red1
+< required field
 < samba join a domain
 < samba join domain
 < search
 < deprecated fs warn
 < details
 < dh
+< dhcp dns enable update
+< dhcp dns key name
+< dhcp dns update
+< dhcp dns update algo
+< dhcp dns update secret
 < dh key move failed
 < dh key warn
 < dh key warn1
 < qos enter bandwidths
 < random number generator daemon
 < red1
+< required field
 < samba join a domain
 < samba join domain
 < search
 < deprecated fs warn
 < details
 < dh
+< dhcp dns enable update
+< dhcp dns key name
+< dhcp dns update
+< dhcp dns update algo
+< dhcp dns update secret
 < dh key move failed
 < dh key warn
 < dh key warn1
 < qos enter bandwidths
 < random number generator daemon
 < red1
+< required field
 < samba join a domain
 < samba join domain
 < search
index 4eb9cd7bfe8a8cfadc953facfce9eee53e3acc5a..85a9cd74501452edc39ac6111218f1c88a9e410e 100644 (file)
@@ -261,15 +261,19 @@ close(IPSEC);
 
 foreach my $line (@ipsec) {
        my @vpn = split(',', $line);
-       my ($network, $mask) = split("/", $vpn[12]);
 
-       if (!&General::validip($mask)) {
-               $mask = ipv4_cidr2msk($mask);
-       }
+       my @subnets = split('|', $vpn[12]);
+       for my $subnet (@subnets) {
+               my ($network, $mask) = split("/", $subnet);
+
+               if (!&General::validip($mask)) {
+                       $mask = ipv4_cidr2msk($mask);
+               }
 
-       push(@network, $network);
-       push(@masklen, $mask);
-       push(@colour, ${Header::colourvpn});
+               push(@network, $network);
+               push(@masklen, $mask);
+               push(@colour, ${Header::colourvpn});
+       }
 }
 
 if (-e "${General::swroot}/ovpn/n2nconf") {
index a22bcd4ebd641d632f56f19cd849ae8b320312b0..3eb5349a9f70ec7efee12ff0a40f2f5ae11041c7 100644 (file)
@@ -70,11 +70,17 @@ foreach my $itf (@ITFs) {
     $dhcpsettings{"NTP2_${itf}"} = '';
     $dhcpsettings{"NEXT_${itf}"} = '';
     $dhcpsettings{"FILE_${itf}"} = '';
+    $dhcpsettings{"DNS_UPDATE_KEY_NAME_${itf}"} = '';
+    $dhcpsettings{"DNS_UPDATE_KEY_SECRET_${itf}"} = '';
+    $dhcpsettings{"DNS_UPDATE_KEY_ALGO_${itf}"} = '';
 }
 
 $dhcpsettings{'SORT_FLEASELIST'} = 'FIPADDR';
 $dhcpsettings{'SORT_LEASELIST'} = 'IPADDR';
 
+# DNS Update settings
+$dhcpsettings{'DNS_UPDATE_ENABLED'} = 'off';
+
 #Settings2 for editing the multi-line list
 #Must not be saved with writehash !
 $dhcpsettings{'FIX_MAC'} = '';
@@ -596,6 +602,78 @@ print <<END
     <td width='40%' align='right'><input type='submit' name='ACTION' value='$Lang::tr{'save'}' /></td>
 </tr>
 </table>
+END
+;
+&Header::closebox();
+
+# DHCP DNS update support (RFC2136)
+&Header::openbox('100%', 'left', $Lang::tr{'dhcp dns update'});
+
+my %checked = ();
+$checked{'DNS_UPDATE_ENABLED'}{'on'} = ( $dhcpsettings{'DNS_UPDATE_ENABLED'} ne 'on') ? '' : "checked='checked'";
+
+print <<END
+<table  width='100%'>
+       <tr>
+               <td width='25%' class='boldbase'>$Lang::tr{'dhcp dns enable update'}</td>
+               <td class='base'><input type='checkbox' name='DNS_UPDATE_ENABLED' $checked{'DNS_UPDATE_ENABLED'}{'on'}>
+               </td>
+       <tr>
+</table>
+
+<table width='100%'>
+END
+;
+       my @domains = ();
+
+       # Print options for each interface.
+       foreach my $itf (@ITFs) {
+               # Check if DHCP for this interface is enabled.
+               if ($dhcpsettings{"ENABLE_${itf}"} eq 'on') {
+                       # Check for same domain name.
+                       next if ($dhcpsettings{"DOMAIN_NAME_${itf}"} ~~ @domains);
+                       my $lc_itf = lc($itf);
+
+                       # Select previously configured update algorithm.
+                       my %selected = ();
+                       $selected{'DNS_UPDATE_ALGO_${inf}'}{$dhcpsettings{'DNS_UPDATE_ALGO_${inf}'}} = 'selected';
+
+print <<END
+       <tr>
+               <td colspan='6'>&nbsp;</td>
+       </tr>
+       <tr>
+               <td colspan='6' class='boldbase'><b>$dhcpsettings{"DOMAIN_NAME_${itf}"}</b></td>
+       </tr>
+       <tr>
+               <td width='10%' class='boldbase'>$Lang::tr{'dhcp dns key name'}:</td>
+               <td width='20%'><input type='text' name='DNS_UPDATE_KEY_NAME_${itf}' value='$dhcpsettings{"DNS_UPDATE_KEY_NAME_${itf}"}'></td>
+               <td width='10%' class='boldbase' align='right'>$Lang::tr{'dhcp dns update secret'}:&nbsp;&nbsp;</td>
+               <td width='20%'><input type='password' name='DNS_UPDATE_KEY_SECRET_${itf}' value='$dhcpsettings{"DNS_UPDATE_KEY_SECRET_${itf}"}'></td>
+               <td width='10%' class='boldbase' align='right'>$Lang::tr{'dhcp dns update algo'}:&nbsp;&nbsp;</td>
+               <td width='20%'>
+                       <select name='DNS_UPDATE_KEY_ALGO_${itf}'>
+                               <!-- <option value='hmac-sha1' $selected{'DNS_UPDATE_KEY_ALGO_${itf}'}{'hmac-sha1'}>HMAC-SHA1</option> -->
+                               <option value='hmac-md5' $selected{'DNS_UPDATE_KEY_ALGO_${itf}'}{'hmac-md5'}>HMAC-MD5</option>
+                       </select>
+               </td>
+       </tr>
+END
+;
+       }
+
+       # Store configured domain based on the interface
+       # in the temporary variable.
+       push(@domains, $dhcpsettings{"DOMAIN_NAME_${itf}"});
+}
+print <<END
+</table>
+<hr>
+<table width='100%'>
+       <tr>
+               <td align='right'><input type='submit' name='ACTION' value='$Lang::tr{'save'}' /></td>
+       </tr>
+</table>
 </form>
 END
 ;
@@ -1131,9 +1209,19 @@ sub buildconf {
     flock(FILE, 2);
 
     # Global settings
-    print FILE "ddns-update-style none;\n";
     print FILE "deny bootp;    #default\n";
     print FILE "authoritative;\n";
+
+    # DNS Update settings
+    if ($dhcpsettings{'DNS_UPDATE_ENABLED'} eq 'on') {
+        print FILE "ddns-updates           on;\n";
+        print FILE "ddns-update-style      interim;\n";
+        print FILE "ddns-ttl               60; # 1 min\n";
+        print FILE "ignore                 client-updates;\n";
+        print FILE "update-static-leases   on;\n";
+    } else {
+        print FILE "ddns-update-style none;\n";
+    }
     
     # Write first new option definition
     foreach my $line (@current1) {
@@ -1162,12 +1250,13 @@ sub buildconf {
            }
        }# on    
     }# foreach line
+    print FILE "\n";
 
     #Subnet range definition
     foreach my $itf (@ITFs) {
        my $lc_itf=lc($itf);
        if ($dhcpsettings{"ENABLE_${itf}"} eq 'on' ){
-           print FILE "\nsubnet " . $netsettings{"${itf}_NETADDRESS"} . " netmask ". $netsettings{"${itf}_NETMASK"} . " #$itf\n";
+           print FILE "subnet " . $netsettings{"${itf}_NETADDRESS"} . " netmask ". $netsettings{"${itf}_NETMASK"} . " #$itf\n";
            print FILE "{\n";
            print FILE "\trange " . $dhcpsettings{"START_ADDR_${itf}"} . ' ' . $dhcpsettings{"END_ADDR_${itf}"}.";\n" if ($dhcpsettings{"START_ADDR_${itf}"});
            print FILE "\toption subnet-mask "   . $netsettings{"${itf}_NETMASK"} . ";\n";
@@ -1204,7 +1293,18 @@ sub buildconf {
                    }
                }# on    
            }# foreach line
-           print FILE "} #$itf\n";
+           print FILE "} #$itf\n\n";
+
+           if (($dhcpsettings{"DNS_UPDATE_ENABLED"} eq "on") && ($dhcpsettings{"DNS_UPDATE_KEY_NAME_${itf}"} ne "")) {
+               print FILE "key " . $dhcpsettings{"DNS_UPDATE_KEY_NAME_${itf}"} . " {\n";
+               print FILE "\talgorithm " . $dhcpsettings{"DNS_UPDATE_KEY_ALGO_${itf}"} . ";\n";
+               print FILE "\tsecret \"" . $dhcpsettings{"DNS_UPDATE_KEY_SECRET_${itf}"} . "\";\n";
+               print FILE "};\n\n";
+
+               print FILE "zone " . $dhcpsettings{"DOMAIN_NAME_${itf}"} . ". {\n";
+               print FILE "\tkey " . $dhcpsettings{"DNS_UPDATE_KEY_NAME_${itf}"} . ";\n";
+               print FILE "}\n\n";
+           }
 
            system ('/usr/bin/touch', "${General::swroot}/dhcp/enable_${lc_itf}");
            &General::log("DHCP on ${itf}: " . $Lang::tr{'dhcp server enabled'})
index c207ec74873aff8c68185fe199eb9ca30afcdb7d..682c2855c6101694952eb495b0abb487a8b9928a 100644 (file)
@@ -597,7 +597,7 @@ sub checktarget
                &General::readhasharray("$confighost", \%customhost);
                foreach my $grpkey (sort keys %customgrp){
                        foreach my $hostkey (sort keys %customhost){
-                               if ($customgrp{$grpkey}[2] eq $customhost{$hostkey}[0] && $customhost{$hostkey}[1] eq 'mac'){
+                               if ($customgrp{$grpkey}[2] eq $customhost{$hostkey}[0] && $customgrp{$grpkey}[2] eq $fwdfwsettings{$fwdfwsettings{'grp2'}} && $customhost{$hostkey}[1] eq 'mac'){
                                        $hint=$Lang::tr{'fwdfw hint mac'};
                                        return $hint;
                                }
index 29c0842188b8974e1e08b3812e65be2bb18bfa52..f998a6201f344b01a56a3d4e137a3828fd0c3556 100644 (file)
@@ -456,7 +456,17 @@ for($s=0;$s<$lines;$s++)
   $color++;
   print "<tr>";
 
-  print "<td align='center' $col><form method='post' action='showrequestfromcountry.dat'><input type='hidden' name='MONTH' value='$cgiparams{'MONTH'}'> <input type='hidden' name='DAY' value='$cgiparams{'DAY'}'> <input type='hidden' name='country' value='$key[$s]'> <input type='submit' value='details'></form></td>";
+  print "<td align='center' $col>";
+
+  # Dont show details button for "unknown" location.
+  if ($key[$s] ne 'unknown') {
+       print"<form method='post' action='showrequestfromcountry.dat'>";
+       print"<input type='hidden' name='MONTH' value='$cgiparams{'MONTH'}'>";
+       print"<input type='hidden' name='DAY' value='$cgiparams{'DAY'}'>";
+       print"<input type='hidden' name='country' value='$key[$s]'>";
+       print"<input type='submit' value='details'></form>";
+  }
+
   if($key[$s] eq 'blue0' || $key[$s] eq 'green0' || $key[$s] eq 'orange0') {
       print "<td align='center' $col>$key[$s]</td>";
   }
index b3e8e6c00629c3413c664d4096bd7c63b2d9c9c7..36d0ced90db1d2df274ede47fb15dd8f0339ab7d 100644 (file)
@@ -980,12 +980,14 @@ print <<END
         <td colspan='2' width='50%'>$Lang::tr{'legend'}:</td>
         <td colspan='2' width='50%'><img src='/blob.gif' alt='*' />&nbsp;$Lang::tr{'required field'}</td>
 </tr>
-</table>
 END
 ;
-&Header::closebox();
 }
 
+print "</table>";
+
+&Header::closebox();
+
 print "</form>\n";
 
 &Header::closebigbox();
index c460a74e7ca1ab56d4d2dd44f8ecc9d69f9df6c2..2c60f67cdfc4e7982ea7d5c60ad0d446eb17b24c 100644 (file)
@@ -118,12 +118,16 @@ if ($settings{'ACTION'} eq $Lang::tr{'toggle enable disable'}) {
 }
 
 if ($settings{'ACTION'} eq $Lang::tr{'add'}) {
-       # Convert subnet masks to CIDR notation.
-       $settings{'IP'} = &General::iporsubtocidr($settings{'IP'});
 
-# Validate inputs
-       if (( !&General::validip($settings{'IP'})) and ( !&General::validipandmask($settings{'IP'}))){
+       # Validate inputs
+       if (!&General::validipandmask($settings{'IP'}))){
        $errormessage = $Lang::tr{'invalid ip'}." / ".$Lang::tr{'invalid netmask'};
+       }else{
+               #set networkip if not already correctly defined
+               my($ip,$cidr) = split(/\//,$settings{'IP'});
+               $cidr = &General::iporsubtocidr($cidr);
+               my $netip=&General::getnetworkip($ip,$cidr);
+               $settings{'IP'} = "$netip/$cidr";
        }
 
        if ($settings{'IP'} =~ /^0\.0\.0\.0/){
index 91f4b45feb9c6fd1541c13d3d29c223d20e43502..193e4059f6de97a9481d6c36a48d0d6ddc3e4af9 100644 (file)
@@ -27,6 +27,7 @@ use warnings;
 use CGI::Carp 'fatalsToBrowser';
 
 require '/var/ipfire/general-functions.pl';
+require "${General::swroot}/geoip-functions.pl";
 require "${General::swroot}/lang.pl";
 require "${General::swroot}/header.pl";
 
@@ -619,10 +620,14 @@ END
 END
 
                                if (exists($node->{'country_code'})) {
-                                       if (!$node->{'country_code'} or $node->{'country_code'} eq '??') {
-                                               print "<img src='/images/flags/blank.png' border='0' align='absmiddle'/>";
+                                       # Get the flag icon of the country.
+                                       my $flag_icon = &GeoIP::get_flag_icon($node->{'country_code'});
+
+                                       # Check if a flag for the given country is available.
+                                       if ($flag_icon) {
+                                               print "<a href='country.cgi#$node->{'country_code'}'><img src='$flag_icon' border='0' align='absmiddle' alt='$node->{'country_code'}'></a>";
                                        } else {
-                                               print "<a href='country.cgi#$node->{'country_code'}'><img src='/images/flags/$node->{'country_code'}.png' border='0' align='absmiddle' alt='$node->{'country_code'}'></a>";
+                                               print "<img src='/images/flags/blank.png' border='0' align='absmiddle'/>";
                                        }
                                }
 
index 65fc80ff851a3adb9f302073a19142b1f5c9f1c8..f1cffb88448155cc2a9f5c8ad4793e6b8c187b5e 100644 (file)
@@ -40,8 +40,7 @@ undef (@dummy);
 ###
 ### Initialize variables
 ###
-my $sleepDelay = 4;    # after a call to ipsecctrl S or R, wait this delay (seconds) before reading status
-                       # (let the ipsec do its job)
+my $sleepDelay = 4; # after a call to ipsecctrl S or R, wait this delay (seconds) before reading status (let the ipsec do its job)
 my %netsettings=();
 our %cgiparams=();
 our %vpnsettings=();
@@ -132,306 +131,300 @@ sub valid_dns_host {
 ### Just return true is one interface is vpn enabled
 ###
 sub vpnenabled {
-    return ($vpnsettings{'ENABLED'} eq 'on');
+       return ($vpnsettings{'ENABLED'} eq 'on');
 }
 ###
-### old version: maintain serial number to one, without explication. 
-### this            : let the counter go, so that each cert is numbered.
+### old version: maintain serial number to one, without explication.
+### this: let the counter go, so that each cert is numbered.
 ###
-sub cleanssldatabase
-{
-    if (open(FILE, ">${General::swroot}/certs/serial")) {
-       print FILE "01";
-       close FILE;
-    }
-    if (open(FILE, ">${General::swroot}/certs/index.txt")) {
-       print FILE "";
-       close FILE;
-    }
-    unlink ("${General::swroot}/certs/index.txt.old");
-    unlink ("${General::swroot}/certs/serial.old");
-    unlink ("${General::swroot}/certs/01.pem");
+sub cleanssldatabase {
+       if (open(FILE, ">${General::swroot}/certs/serial")) {
+               print FILE "01";
+               close FILE;
+       }
+       if (open(FILE, ">${General::swroot}/certs/index.txt")) {
+               print FILE "";
+               close FILE;
+       }
+       unlink ("${General::swroot}/certs/index.txt.old");
+       unlink ("${General::swroot}/certs/serial.old");
+       unlink ("${General::swroot}/certs/01.pem");
 }
-sub newcleanssldatabase
-{
-    if (! -s "${General::swroot}/certs/serial" )  {
-        open(FILE, ">${General::swroot}/certs/serial");
-       print FILE "01";
-       close FILE;
-    }
-    if (! -s ">${General::swroot}/certs/index.txt") {
-       system ("touch ${General::swroot}/certs/index.txt");
-    }
-    unlink ("${General::swroot}/certs/index.txt.old");
-    unlink ("${General::swroot}/certs/serial.old");
-#   unlink ("${General::swroot}/certs/01.pem");                numbering evolves. Wrong place to delete
+sub newcleanssldatabase {
+       if (! -s "${General::swroot}/certs/serial" ) {
+               open(FILE, ">${General::swroot}/certs/serial");
+               print FILE "01";
+               close FILE;
+       }
+       if (! -s ">${General::swroot}/certs/index.txt") {
+               system ("touch ${General::swroot}/certs/index.txt");
+       }
+       unlink ("${General::swroot}/certs/index.txt.old");
+       unlink ("${General::swroot}/certs/serial.old");
+#      unlink ("${General::swroot}/certs/01.pem");             numbering evolves. Wrong place to delete
 }
 
 ###
 ### Call openssl and return errormessage if any
 ###
 sub callssl ($) {
-    my $opt = shift;
-    my $retssl =  `/usr/bin/openssl $opt 2>&1`;        #redirect stderr
-    my $ret = '';
-    foreach my $line (split (/\n/, $retssl)) {
-       &General::log("ipsec", "$line") if (0);         # 1 for verbose logging
-       $ret .= '<br>'.$line if ( $line =~ /error|unknown/ );
-    }
-    if ($ret) {
-        $ret= &Header::cleanhtml($ret);
-    }
-    return $ret ? "$Lang::tr{'openssl produced an error'}: $ret" : '' ;
+       my $opt = shift;
+       my $retssl = `/usr/bin/openssl $opt 2>&1`; #redirect stderr
+       my $ret = '';
+       foreach my $line (split (/\n/, $retssl)) {
+               &General::log("ipsec", "$line") if (0); # 1 for verbose logging
+               $ret .= '<br>'.$line if ( $line =~ /error|unknown/ );
+       }
+       if ($ret) {
+               $ret= &Header::cleanhtml($ret);
+       }
+       return $ret ? "$Lang::tr{'openssl produced an error'}: $ret" : '' ;
 }
 ###
 ### Obtain a CN from given cert
 ###
 sub getCNfromcert ($) {
-    #&General::log("ipsec", "Extracting name from $_[0]...");
-    my $temp = `/usr/bin/openssl x509 -text -in $_[0]`;
-    $temp =~ /Subject:.*CN=(.*)[\n]/;
-    $temp = $1;
-    $temp =~ s+/Email+, E+;
-    $temp =~ s/ ST=/ S=/;
-    $temp =~ s/,//g;
-    $temp =~ s/\'//g;
-    return $temp;
+       #&General::log("ipsec", "Extracting name from $_[0]...");
+       my $temp = `/usr/bin/openssl x509 -text -in $_[0]`;
+       $temp =~ /Subject:.*CN=(.*)[\n]/;
+       $temp = $1;
+       $temp =~ s+/Email+, E+;
+       $temp =~ s/ ST=/ S=/;
+       $temp =~ s/,//g;
+       $temp =~ s/\'//g;
+       return $temp;
 }
 ###
 ### Obtain Subject from given cert
 ###
 sub getsubjectfromcert ($) {
-    #&General::log("ipsec", "Extracting subject from $_[0]...");
-    my $temp = `/usr/bin/openssl x509 -text -in $_[0]`;
-    $temp =~ /Subject: (.*)[\n]/;
-    $temp = $1;
-    $temp =~ s+/Email+, E+;
-    $temp =~ s/ ST=/ S=/;
-    return $temp;
+       #&General::log("ipsec", "Extracting subject from $_[0]...");
+       my $temp = `/usr/bin/openssl x509 -text -in $_[0]`;
+       $temp =~ /Subject: (.*)[\n]/;
+       $temp = $1;
+       $temp =~ s+/Email+, E+;
+       $temp =~ s/ ST=/ S=/;
+       return $temp;
 }
 ###
-### Combine local subnet and connection name to make a unique name for each connection section 
+### Combine local subnet and connection name to make a unique name for each connection section
 ### (this sub is not used now)
 ###
 sub makeconnname ($) {
-    my $conn = shift;
-    my $subnet = shift;
-
-    $subnet =~ /^(.*?)\/(.*?)$/;       # $1=IP $2=mask
-    my $ip = unpack('N', &Socket::inet_aton($1));
-    if (length ($2) > 2) {
-       my $mm =  unpack('N', &Socket::inet_aton($2));
-       while ( ($mm & 1)==0 ) {
-           $ip >>= 1; 
-           $mm >>= 1;
-       };
-    } else {
-       $ip >>=  (32 - $2);
-    }
-    return sprintf ("%s-%X", $conn, $ip);
+       my $conn = shift;
+       my $subnet = shift;
+
+       $subnet =~ /^(.*?)\/(.*?)$/; # $1=IP $2=mask
+       my $ip = unpack('N', &Socket::inet_aton($1));
+       if (length ($2) > 2) {
+               my $mm = unpack('N', &Socket::inet_aton($2));
+               while ( ($mm & 1)==0 ) {
+                       $ip >>= 1;
+                       $mm >>= 1;
+               };
+       } else {
+               $ip >>= (32 - $2);
+       }
+       return sprintf ("%s-%X", $conn, $ip);
 }
 ###
 ### Write a config file.
 ###
 ###Type=Host : GUI can choose the interface used (RED,GREEN,BLUE) and
 ###            the side is always defined as 'left'.
-###            configihash[14]: 'VHOST' is allowed
 ###
 
 sub writeipsecfiles {
-    my %lconfighash = ();
-    my %lvpnsettings = ();
-    &General::readhasharray("${General::swroot}/vpn/config", \%lconfighash);
-    &General::readhash("${General::swroot}/vpn/settings", \%lvpnsettings);
-
-    open(CONF,    ">${General::swroot}/vpn/ipsec.conf") or die "Unable to open ${General::swroot}/vpn/ipsec.conf: $!";
-    open(SECRETS, ">${General::swroot}/vpn/ipsec.secrets") or die "Unable to open ${General::swroot}/vpn/ipsec.secrets: $!";
-    flock CONF, 2;
-    flock SECRETS, 2;
-    print CONF "version 2\n\n";
-    print CONF "conn %default\n";
-    print CONF "\tkeyingtries=%forever\n";
-    print CONF "\n";
-
-    # Add user includes to config file
-    if (-e "/etc/ipsec.user.conf") {
-        print CONF "include /etc/ipsec.user.conf\n";
-        print CONF "\n";
-    }
-
-    print SECRETS "include /etc/ipsec.user.secrets\n";
-
-    if (-f "${General::swroot}/certs/hostkey.pem") {
-        print SECRETS ": RSA ${General::swroot}/certs/hostkey.pem\n"
-    }
-    my $last_secrets = ''; # old the less specifics connections
-    
-    foreach my $key (keys %lconfighash) {
-       next if ($lconfighash{$key}[0] ne 'on');
-
-       #remote peer is not set? => use '%any'
-       $lconfighash{$key}[10] = '%any' if ($lconfighash{$key}[10] eq '');
-
-       my $localside;
-       if ($lconfighash{$key}[26] eq 'BLUE') {
-               $localside = $netsettings{'BLUE_ADDRESS'};
-       } elsif ($lconfighash{$key}[26] eq 'GREEN') {
-               $localside = $netsettings{'GREEN_ADDRESS'};
-       } elsif ($lconfighash{$key}[26] eq 'ORANGE') {
-               $localside = $netsettings{'ORANGE_ADDRESS'};
-       } else {        # it is RED
-               $localside = $lvpnsettings{'VPN_IP'};
-       }
-
-       print CONF "conn $lconfighash{$key}[1]\n";
-       print CONF "\tleft=$localside\n";
-       my $cidr_net=&General::ipcidr($lconfighash{$key}[8]);
-       print CONF "\tleftsubnet=$cidr_net\n";
-       print CONF "\tleftfirewall=yes\n";
-       print CONF "\tlefthostaccess=yes\n";
-
-       print CONF "\tright=$lconfighash{$key}[10]\n";
-       if ($lconfighash{$key}[3] eq 'net') {
-           my $cidr_net=&General::ipcidr($lconfighash{$key}[11]);
-           print CONF "\trightsubnet=$cidr_net\n";
-       } elsif ($lconfighash{$key}[10] eq '%any' && $lconfighash{$key}[14] eq 'on') { #vhost allowed for roadwarriors?
-           print CONF "\trightsubnet=vhost:%no,%priv\n";
-       }
-
-       # Local Cert and Remote Cert (unless auth is DN dn-auth)
-       if ($lconfighash{$key}[4] eq 'cert') {
-           print CONF "\tleftcert=${General::swroot}/certs/hostcert.pem\n";
-           print CONF "\trightcert=${General::swroot}/certs/$lconfighash{$key}[1]cert.pem\n" if ($lconfighash{$key}[2] ne '%auth-dn');
-       }
-
-       # Local and Remote IDs
-       print CONF "\tleftid=\"$lconfighash{$key}[7]\"\n" if ($lconfighash{$key}[7]);
-       print CONF "\trightid=\"$lconfighash{$key}[9]\"\n" if ($lconfighash{$key}[9]);
-
-       # Is PFS enabled?
-       my $pfs = $lconfighash{$key}[28] eq 'on' ? 'on' : 'off';
-
-       # Algorithms
-       if ($lconfighash{$key}[18] && $lconfighash{$key}[19] && $lconfighash{$key}[20]) {
-               my @encs   = split('\|', $lconfighash{$key}[18]);
-               my @ints   = split('\|', $lconfighash{$key}[19]);
-               my @groups = split('\|', $lconfighash{$key}[20]);
-
-               my @algos = &make_algos("ike", \@encs, \@ints, \@groups, 1);
-               print CONF "\tike=" . join(",", @algos);
-
-               if ($lconfighash{$key}[24] eq 'on') {   #only proposed algorythms?
-                       print CONF "!\n";
-               } else {
-                       print CONF "\n";
-               }
+       my %lconfighash = ();
+       my %lvpnsettings = ();
+       &General::readhasharray("${General::swroot}/vpn/config", \%lconfighash);
+       &General::readhash("${General::swroot}/vpn/settings", \%lvpnsettings);
+
+       open(CONF, ">${General::swroot}/vpn/ipsec.conf") or die "Unable to open ${General::swroot}/vpn/ipsec.conf: $!";
+       open(SECRETS, ">${General::swroot}/vpn/ipsec.secrets") or die "Unable to open ${General::swroot}/vpn/ipsec.secrets: $!";
+       flock CONF, 2;
+       flock SECRETS, 2;
+       print CONF "version 2\n\n";
+       print CONF "conn %default\n";
+       print CONF "\tkeyingtries=%forever\n";
+       print CONF "\n";
+
+       # Add user includes to config file
+       if (-e "/etc/ipsec.user.conf") {
+               print CONF "include /etc/ipsec.user.conf\n";
+               print CONF "\n";
        }
 
-       if ($lconfighash{$key}[21] && $lconfighash{$key}[22]) {
-               my @encs   = split('\|', $lconfighash{$key}[21]);
-               my @ints   = split('\|', $lconfighash{$key}[22]);
-               my @groups = split('\|', $lconfighash{$key}[23]);
+       print SECRETS "include /etc/ipsec.user.secrets\n";
+
+       if (-f "${General::swroot}/certs/hostkey.pem") {
+               print SECRETS ": RSA ${General::swroot}/certs/hostkey.pem\n"
+       }
+       my $last_secrets = ''; # old the less specifics connections
 
-               # Use IKE grouptype if no ESP group type has been selected
-               # (for backwards compatibility)
-               if ($lconfighash{$key}[23] eq "") {
-                       @groups = split('\|', $lconfighash{$key}[20]);
+       foreach my $key (keys %lconfighash) {
+               next if ($lconfighash{$key}[0] ne 'on');
+
+               #remote peer is not set? => use '%any'
+               $lconfighash{$key}[10] = '%any' if ($lconfighash{$key}[10] eq '');
+
+               my $localside;
+               if ($lconfighash{$key}[26] eq 'BLUE') {
+                       $localside = $netsettings{'BLUE_ADDRESS'};
+               } elsif ($lconfighash{$key}[26] eq 'GREEN') {
+                       $localside = $netsettings{'GREEN_ADDRESS'};
+               } elsif ($lconfighash{$key}[26] eq 'ORANGE') {
+                       $localside = $netsettings{'ORANGE_ADDRESS'};
+               } else { # it is RED
+                       $localside = $lvpnsettings{'VPN_IP'};
                }
 
-               my @algos = &make_algos("esp", \@encs, \@ints, \@groups, ($pfs eq "on"));
-               print CONF "\tesp=" . join(",", @algos);
+               print CONF "conn $lconfighash{$key}[1]\n";
+               print CONF "\tleft=$localside\n";
+               print CONF "\tleftsubnet=" . &make_subnets($lconfighash{$key}[8]) . "\n";
+               print CONF "\tleftfirewall=yes\n";
+               print CONF "\tlefthostaccess=yes\n";
+               print CONF "\tright=$lconfighash{$key}[10]\n";
 
-               if ($lconfighash{$key}[24] eq 'on') {   #only proposed algorythms?
-                       print CONF "!\n";
-               } else {
-                       print CONF "\n";
+               if ($lconfighash{$key}[3] eq 'net') {
+                       print CONF "\trightsubnet=" . &make_subnets($lconfighash{$key}[11]) . "\n";
                }
-       }
 
-       # IKE V1 or V2
-       if (! $lconfighash{$key}[29]) {
-          $lconfighash{$key}[29] = "ikev1";
-       }
-       print CONF "\tkeyexchange=$lconfighash{$key}[29]\n";
+               # Local Cert and Remote Cert (unless auth is DN dn-auth)
+               if ($lconfighash{$key}[4] eq 'cert') {
+                       print CONF "\tleftcert=${General::swroot}/certs/hostcert.pem\n";
+                       print CONF "\trightcert=${General::swroot}/certs/$lconfighash{$key}[1]cert.pem\n" if ($lconfighash{$key}[2] ne '%auth-dn');
+               }
 
-       # Lifetimes
-       print CONF "\tikelifetime=$lconfighash{$key}[16]h\n" if ($lconfighash{$key}[16]);
-       print CONF "\tkeylife=$lconfighash{$key}[17]h\n" if ($lconfighash{$key}[17]);
+               # Local and Remote IDs
+               print CONF "\tleftid=\"$lconfighash{$key}[7]\"\n" if ($lconfighash{$key}[7]);
+               print CONF "\trightid=\"$lconfighash{$key}[9]\"\n" if ($lconfighash{$key}[9]);
 
-       # Compression
-       print CONF "\tcompress=yes\n" if ($lconfighash{$key}[13] eq 'on');
+               # Is PFS enabled?
+               my $pfs = $lconfighash{$key}[28] eq 'on' ? 'on' : 'off';
 
-       # Force MOBIKE?
-       if (($lconfighash{$key}[29] eq "ikev2") && ($lconfighash{$key}[32] eq 'on')) {
-               print CONF "\tmobike=yes\n";
-       }
+               # Algorithms
+               if ($lconfighash{$key}[18] && $lconfighash{$key}[19] && $lconfighash{$key}[20]) {
+                       my @encs        = split('\|', $lconfighash{$key}[18]);
+                       my @ints        = split('\|', $lconfighash{$key}[19]);
+                       my @groups      = split('\|', $lconfighash{$key}[20]);
 
-       # Dead Peer Detection
-       my $dpdaction = $lconfighash{$key}[27];
-       print CONF "\tdpdaction=$dpdaction\n";
+                       my @algos = &make_algos("ike", \@encs, \@ints, \@groups, 1);
+                       print CONF "\tike=" . join(",", @algos);
 
-       # If the dead peer detection is disabled and IKEv2 is used,
-       # dpddelay must be set to zero, too.
-       if ($dpdaction eq "none") {
-               if ($lconfighash{$key}[29] eq "ikev2") {
-                       print CONF "\tdpddelay=0\n";
+                       if ($lconfighash{$key}[24] eq 'on') { #only proposed algorythms?
+                               print CONF "!\n";
+                       } else {
+                               print CONF "\n";
+                       }
                }
-       } else {
-               my $dpddelay = $lconfighash{$key}[31];
-               if (!$dpddelay) {
-                       $dpddelay = 30;
-               }
-               print CONF "\tdpddelay=$dpddelay\n";
-               my $dpdtimeout = $lconfighash{$key}[30];
-               if (!$dpdtimeout) {
-                       $dpdtimeout = 120;
-               }
-               print CONF "\tdpdtimeout=$dpdtimeout\n";
-       }
-
-       # Build Authentication details:  LEFTid RIGHTid : PSK psk
-       my $psk_line;
-       if ($lconfighash{$key}[4] eq 'psk') {
-           $psk_line = ($lconfighash{$key}[7] ? $lconfighash{$key}[7] : $localside) . " " ;
-           $psk_line .= $lconfighash{$key}[9] ? $lconfighash{$key}[9] : $lconfighash{$key}[10];  #remoteid or remote address?
-           $psk_line .= " : PSK '$lconfighash{$key}[5]'\n";
-           # if the line contains %any, it is less specific than two IP or ID, so move it at end of file.
-           if ($psk_line =~ /%any/) {
-               $last_secrets .= $psk_line;
-           } else {
-               print SECRETS $psk_line;
-           }
-           print CONF "\tauthby=secret\n";
-       } else {
-           print CONF "\tauthby=rsasig\n";
-           print CONF "\tleftrsasigkey=%cert\n";
-           print CONF "\trightrsasigkey=%cert\n";
-       }
 
-       # Automatically start only if a net-to-net connection
-       if ($lconfighash{$key}[3] eq 'host') {
-           print CONF "\tauto=add\n";
-           print CONF "\trightsourceip=$lvpnsettings{'RW_NET'}\n";
-       } else {
-           print CONF "\tauto=start\n";
-       }
+               if ($lconfighash{$key}[21] && $lconfighash{$key}[22]) {
+                       my @encs        = split('\|', $lconfighash{$key}[21]);
+                       my @ints        = split('\|', $lconfighash{$key}[22]);
+                       my @groups      = split('\|', $lconfighash{$key}[23]);
+
+                       # Use IKE grouptype if no ESP group type has been selected
+                       # (for backwards compatibility)
+                       if ($lconfighash{$key}[23] eq "") {
+                               @groups = split('\|', $lconfighash{$key}[20]);
+                       }
 
-       # Fragmentation
-       print CONF "\tfragmentation=yes\n";
+                       my @algos = &make_algos("esp", \@encs, \@ints, \@groups, ($pfs eq "on"));
+                       print CONF "\tesp=" . join(",", @algos);
 
-       print CONF "\n";
-    }#foreach key
-
-    # Add post user includes to config file
-    # After the GUI-connections allows to patch connections.
-    if (-e "/etc/ipsec.user-post.conf") {
-        print CONF "include /etc/ipsec.user-post.conf\n";
-        print CONF "\n";
-    }
-
-    print SECRETS $last_secrets if ($last_secrets);
-    close(CONF);
-    close(SECRETS);
+                       if ($lconfighash{$key}[24] eq 'on') { #only proposed algorythms?
+                               print CONF "!\n";
+                       } else {
+                               print CONF "\n";
+                       }
+               }
+
+               # IKE V1 or V2
+               if (! $lconfighash{$key}[29]) {
+                       $lconfighash{$key}[29] = "ikev1";
+               }
+
+               print CONF "\tkeyexchange=$lconfighash{$key}[29]\n";
+
+               # Lifetimes
+               print CONF "\tikelifetime=$lconfighash{$key}[16]h\n" if ($lconfighash{$key}[16]);
+               print CONF "\tkeylife=$lconfighash{$key}[17]h\n" if ($lconfighash{$key}[17]);
+
+               # Compression
+               print CONF "\tcompress=yes\n" if ($lconfighash{$key}[13] eq 'on');
+
+               # Force MOBIKE?
+               if (($lconfighash{$key}[29] eq "ikev2") && ($lconfighash{$key}[32] eq 'on')) {
+                       print CONF "\tmobike=yes\n";
+               }
+
+               # Dead Peer Detection
+               my $dpdaction = $lconfighash{$key}[27];
+               print CONF "\tdpdaction=$dpdaction\n";
+
+               # If the dead peer detection is disabled and IKEv2 is used,
+               # dpddelay must be set to zero, too.
+               if ($dpdaction eq "none") {
+                       if ($lconfighash{$key}[29] eq "ikev2") {
+                               print CONF "\tdpddelay=0\n";
+                       }
+               } else {
+                       my $dpddelay = $lconfighash{$key}[31];
+                       if (!$dpddelay) {
+                               $dpddelay = 30;
+                       }
+                       print CONF "\tdpddelay=$dpddelay\n";
+                       my $dpdtimeout = $lconfighash{$key}[30];
+                       if (!$dpdtimeout) {
+                               $dpdtimeout = 120;
+                       }
+                       print CONF "\tdpdtimeout=$dpdtimeout\n";
+               }
+
+               # Build Authentication details: LEFTid RIGHTid : PSK psk
+               my $psk_line;
+               if ($lconfighash{$key}[4] eq 'psk') {
+                       $psk_line = ($lconfighash{$key}[7] ? $lconfighash{$key}[7] : $localside) . " " ;
+                       $psk_line .= $lconfighash{$key}[9] ? $lconfighash{$key}[9] : $lconfighash{$key}[10]; #remoteid or remote address?
+                       $psk_line .= " : PSK '$lconfighash{$key}[5]'\n";
+                       # if the line contains %any, it is less specific than two IP or ID, so move it at end of file.
+                       if ($psk_line =~ /%any/) {
+                               $last_secrets .= $psk_line;
+                       } else {
+                               print SECRETS $psk_line;
+                       }
+                       print CONF "\tauthby=secret\n";
+               } else {
+                       print CONF "\tauthby=rsasig\n";
+                       print CONF "\tleftrsasigkey=%cert\n";
+                       print CONF "\trightrsasigkey=%cert\n";
+               }
+
+               # Automatically start only if a net-to-net connection
+               if ($lconfighash{$key}[3] eq 'host') {
+                       print CONF "\tauto=add\n";
+                       print CONF "\trightsourceip=$lvpnsettings{'RW_NET'}\n";
+               } else {
+                       print CONF "\tauto=start\n";
+               }
+
+               # Fragmentation
+               print CONF "\tfragmentation=yes\n";
+
+               print CONF "\n";
+       } #foreach key
+
+       # Add post user includes to config file
+       # After the GUI-connections allows to patch connections.
+       if (-e "/etc/ipsec.user-post.conf") {
+               print CONF "include /etc/ipsec.user-post.conf\n";
+               print CONF "\n";
+       }
+
+       print SECRETS $last_secrets if ($last_secrets);
+       close(CONF);
+       close(SECRETS);
 }
 
 # Hook to regenerate the configuration files.
@@ -444,779 +437,779 @@ if ($ENV{"REMOTE_ADDR"} eq "") {
 ### Save main settings
 ###
 if ($cgiparams{'ACTION'} eq $Lang::tr{'save'} && $cgiparams{'TYPE'} eq '' && $cgiparams{'KEY'} eq '') {
-    &General::readhash("${General::swroot}/vpn/settings", \%vpnsettings);
-    unless (&General::validfqdn($cgiparams{'VPN_IP'}) || &General::validip($cgiparams{'VPN_IP'})
-           || $cgiparams{'VPN_IP'} eq '%defaultroute' ) {
-       $errormessage = $Lang::tr{'invalid input for hostname'};
-       goto SAVE_ERROR;
-    }
-
-    unless ($cgiparams{'VPN_DELAYED_START'} =~ /^[0-9]{1,3}$/ ) { #allow 0-999 seconds !
-       $errormessage = $Lang::tr{'invalid time period'};
-       goto SAVE_ERROR;
-    }
-
-    if ( $cgiparams{'RW_NET'} ne '' and !&General::validipandmask($cgiparams{'RW_NET'}) ) {
-       $errormessage = $Lang::tr{'urlfilter invalid ip or mask error'};
-       goto SAVE_ERROR;
-    }
-
-    $vpnsettings{'ENABLED'} = $cgiparams{'ENABLED'};
-    $vpnsettings{'VPN_IP'} = $cgiparams{'VPN_IP'};
-    $vpnsettings{'VPN_DELAYED_START'} = $cgiparams{'VPN_DELAYED_START'};
-    $vpnsettings{'RW_NET'} = $cgiparams{'RW_NET'};
-    &General::writehash("${General::swroot}/vpn/settings", \%vpnsettings);
-    &writeipsecfiles();
-    if (&vpnenabled) {
-       system('/usr/local/bin/ipsecctrl', 'S');
-    } else {
-       system('/usr/local/bin/ipsecctrl', 'D');
-    }
-    sleep $sleepDelay;
-    SAVE_ERROR:
+       &General::readhash("${General::swroot}/vpn/settings", \%vpnsettings);
+
+       unless (&General::validfqdn($cgiparams{'VPN_IP'}) || &General::validip($cgiparams{'VPN_IP'})
+       || $cgiparams{'VPN_IP'} eq '%defaultroute' ) {
+               $errormessage = $Lang::tr{'invalid input for hostname'};
+               goto SAVE_ERROR;
+       }
+
+       unless ($cgiparams{'VPN_DELAYED_START'} =~ /^[0-9]{1,3}$/ ) { #allow 0-999 seconds !
+               $errormessage = $Lang::tr{'invalid time period'};
+               goto SAVE_ERROR;
+       }
+
+       if ( $cgiparams{'RW_NET'} ne '' and !&General::validipandmask($cgiparams{'RW_NET'}) ) {
+               $errormessage = $Lang::tr{'urlfilter invalid ip or mask error'};
+               goto SAVE_ERROR;
+       }
+
+       $vpnsettings{'ENABLED'} = $cgiparams{'ENABLED'};
+       $vpnsettings{'VPN_IP'} = $cgiparams{'VPN_IP'};
+       $vpnsettings{'VPN_DELAYED_START'} = $cgiparams{'VPN_DELAYED_START'};
+       $vpnsettings{'RW_NET'} = $cgiparams{'RW_NET'};
+       &General::writehash("${General::swroot}/vpn/settings", \%vpnsettings);
+       &writeipsecfiles();
+       if (&vpnenabled) {
+               system('/usr/local/bin/ipsecctrl', 'S');
+       } else {
+               system('/usr/local/bin/ipsecctrl', 'D');
+       }
+       sleep $sleepDelay;
+       SAVE_ERROR:
 ###
 ### Reset all step 2
 ###
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'remove x509'} && $cgiparams{'AREUSURE'} eq 'yes') {
-    &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
-
-    foreach my $key (keys %confighash) {
-       if ($confighash{$key}[4] eq 'cert') {
-           delete $confighash{$key};
-       }
-    }
-    while (my $file = glob("${General::swroot}/{ca,certs,crls,private}/*")) {
-       unlink $file
-    }
-    &cleanssldatabase();
-    if (open(FILE, ">${General::swroot}/vpn/caconfig")) {
-        print FILE "";
-        close FILE;
-    }
-    &General::writehasharray("${General::swroot}/vpn/config", \%confighash);
-    &writeipsecfiles();
-    system('/usr/local/bin/ipsecctrl', 'R');
-    sleep $sleepDelay;
+       &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
+
+       foreach my $key (keys %confighash) {
+               if ($confighash{$key}[4] eq 'cert') {
+                       delete $confighash{$key};
+               }
+       }
+       while (my $file = glob("${General::swroot}/{ca,certs,crls,private}/*")) {
+               unlink $file
+       }
+       &cleanssldatabase();
+       if (open(FILE, ">${General::swroot}/vpn/caconfig")) {
+               print FILE "";
+               close FILE;
+       }
+       &General::writehasharray("${General::swroot}/vpn/config", \%confighash);
+       &writeipsecfiles();
+       system('/usr/local/bin/ipsecctrl', 'R');
+       sleep $sleepDelay;
 
 ###
 ### Reset all step 1
 ###
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'remove x509'}) {
-    &Header::showhttpheaders();
-    &Header::openpage($Lang::tr{'ipsec'}, 1, '');
-    &Header::openbigbox('100%', 'left', '', '');
-    &Header::openbox('100%', 'left', $Lang::tr{'are you sure'});
-    print <<END
+       &Header::showhttpheaders();
+       &Header::openpage($Lang::tr{'ipsec'}, 1, '');
+       &Header::openbigbox('100%', 'left', '', '');
+       &Header::openbox('100%', 'left', $Lang::tr{'are you sure'});
+       print <<END
        <form method='post' action='$ENV{'SCRIPT_NAME'}'>
-       <table width='100%'>
-           <tr>
-               <td align='center'>
-               <input type='hidden' name='AREUSURE' value='yes' />
-               <b><font color='${Header::colourred}'>$Lang::tr{'capswarning'}</font></b>:
-               $Lang::tr{'resetting the vpn configuration will remove the root ca, the host certificate and all certificate based connections'}</td>
-           </tr><tr>
-               <td align='center'>
-               <input type='submit' name='ACTION' value='$Lang::tr{'remove x509'}' />
+               <table width='100%'>
+                       <tr>
+                               <td align='center'>
+                                       <input type='hidden' name='AREUSURE' value='yes' />
+                                       <b><font color='${Header::colourred}'>$Lang::tr{'capswarning'}</font></b>:&nbsp;$Lang::tr{'resetting the vpn configuration will remove the root ca, the host certificate and all certificate based connections'}
+                               </td>
+                       </tr><tr>
+                               <td align='center'>
+                                       <input type='submit' name='ACTION' value='$Lang::tr{'remove x509'}' />
                <input type='submit' name='ACTION' value='$Lang::tr{'cancel'}' /></td>
-           </tr>
-       </table>
+                       </tr>
+               </table>
        </form>
 END
-    ;
-    &Header::closebox();
-    &Header::closebigbox();
-    &Header::closepage();
-    exit (0);
+;
+       &Header::closebox();
+       &Header::closebigbox();
+       &Header::closepage();
+       exit (0);
 
 ###
 ### Upload CA Certificate
 ###
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'upload ca certificate'}) {
-    &General::readhasharray("${General::swroot}/vpn/caconfig", \%cahash);
-
-    if ($cgiparams{'CA_NAME'} !~ /^[a-zA-Z0-9]+$/) {
-       $errormessage = $Lang::tr{'name must only contain characters'};
-       goto UPLOADCA_ERROR;
-    }
-
-    if (length($cgiparams{'CA_NAME'}) >60) {
-       $errormessage = $Lang::tr{'name too long'};
-       goto VPNCONF_ERROR;
-    }
-
-    if ($cgiparams{'CA_NAME'} eq 'ca') {
-       $errormessage = $Lang::tr{'name is invalid'};
-       goto UPLOAD_CA_ERROR;
-    }
-
-    # Check if there is no other entry with this name
-    foreach my $key (keys %cahash) {
-       if ($cahash{$key}[0] eq $cgiparams{'CA_NAME'}) {
-           $errormessage = $Lang::tr{'a ca certificate with this name already exists'};
-           goto UPLOADCA_ERROR;
-       }
-    }
-
-    if (ref ($cgiparams{'FH'}) ne 'Fh') {
-       $errormessage = $Lang::tr{'there was no file upload'};
-       goto UPLOADCA_ERROR;
-    }
-    # Move uploaded ca to a temporary file
-    (my $fh, my $filename) = tempfile( );
-    if (copy ($cgiparams{'FH'}, $fh) != 1) {
-       $errormessage = $!;
-       goto UPLOADCA_ERROR;
-    }
-    my $temp = `/usr/bin/openssl x509 -text -in $filename`;
-    if ($temp !~ /CA:TRUE/i) {
-       $errormessage = $Lang::tr{'not a valid ca certificate'};
-       unlink ($filename);
-       goto UPLOADCA_ERROR;
-    } else {
-       move($filename, "${General::swroot}/ca/$cgiparams{'CA_NAME'}cert.pem");
-       if ($? ne 0) {
-           $errormessage = "$Lang::tr{'certificate file move failed'}: $!";
-           unlink ($filename);
-           goto UPLOADCA_ERROR;
-       }
-    }
-
-    my $key = &General::findhasharraykey (\%cahash);
-    $cahash{$key}[0] = $cgiparams{'CA_NAME'};
-    $cahash{$key}[1] = &Header::cleanhtml(getsubjectfromcert ("${General::swroot}/ca/$cgiparams{'CA_NAME'}cert.pem"));
-    &General::writehasharray("${General::swroot}/vpn/caconfig", \%cahash);
-
-    system('/usr/local/bin/ipsecctrl', 'R');
-    sleep $sleepDelay;
-
-    UPLOADCA_ERROR:
+       &General::readhasharray("${General::swroot}/vpn/caconfig", \%cahash);
+
+       if ($cgiparams{'CA_NAME'} !~ /^[a-zA-Z0-9]+$/) {
+               $errormessage = $Lang::tr{'name must only contain characters'};
+               goto UPLOADCA_ERROR;
+       }
+
+       if (length($cgiparams{'CA_NAME'}) >60) {
+               $errormessage = $Lang::tr{'name too long'};
+               goto VPNCONF_ERROR;
+       }
+
+       if ($cgiparams{'CA_NAME'} eq 'ca') {
+               $errormessage = $Lang::tr{'name is invalid'};
+               goto UPLOAD_CA_ERROR;
+       }
+
+       # Check if there is no other entry with this name
+       foreach my $key (keys %cahash) {
+               if ($cahash{$key}[0] eq $cgiparams{'CA_NAME'}) {
+                       $errormessage = $Lang::tr{'a ca certificate with this name already exists'};
+                       goto UPLOADCA_ERROR;
+               }
+       }
+
+       if (ref ($cgiparams{'FH'}) ne 'Fh') {
+               $errormessage = $Lang::tr{'there was no file upload'};
+               goto UPLOADCA_ERROR;
+       }
+       # Move uploaded ca to a temporary file
+       (my $fh, my $filename) = tempfile( );
+       if (copy ($cgiparams{'FH'}, $fh) != 1) {
+               $errormessage = $!;
+               goto UPLOADCA_ERROR;
+       }
+       my $temp = `/usr/bin/openssl x509 -text -in $filename`;
+       if ($temp !~ /CA:TRUE/i) {
+               $errormessage = $Lang::tr{'not a valid ca certificate'};
+               unlink ($filename);
+               goto UPLOADCA_ERROR;
+       } else {
+               move($filename, "${General::swroot}/ca/$cgiparams{'CA_NAME'}cert.pem");
+               if ($? ne 0) {
+                       $errormessage = "$Lang::tr{'certificate file move failed'}: $!";
+                       unlink ($filename);
+                       goto UPLOADCA_ERROR;
+               }
+       }
+
+       my $key = &General::findhasharraykey (\%cahash);
+       $cahash{$key}[0] = $cgiparams{'CA_NAME'};
+       $cahash{$key}[1] = &Header::cleanhtml(getsubjectfromcert ("${General::swroot}/ca/$cgiparams{'CA_NAME'}cert.pem"));
+       &General::writehasharray("${General::swroot}/vpn/caconfig", \%cahash);
+
+       system('/usr/local/bin/ipsecctrl', 'R');
+       sleep $sleepDelay;
+
+       UPLOADCA_ERROR:
 
 ###
 ### Display ca certificate
 ###
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'show ca certificate'}) {
-    &General::readhasharray("${General::swroot}/vpn/caconfig", \%cahash);
-
-    if ( -f "${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem") {
-       &Header::showhttpheaders();
-       &Header::openpage($Lang::tr{'ipsec'}, 1, '');
-       &Header::openbigbox('100%', 'left', '', '');
-       &Header::openbox('100%', 'left', "$Lang::tr{'ca certificate'}:");
-       my $output = `/usr/bin/openssl x509 -text -in ${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem`;
-       $output = &Header::cleanhtml($output,"y");
-       print "<pre>$output</pre>\n";
-       &Header::closebox();
-       print "<div align='center'><a href='/cgi-bin/vpnmain.cgi'>$Lang::tr{'back'}</a></div>";
-       &Header::closebigbox();
-       &Header::closepage();
-       exit(0);
-    } else {
-       $errormessage = $Lang::tr{'invalid key'};
-    }
+       &General::readhasharray("${General::swroot}/vpn/caconfig", \%cahash);
+
+       if ( -f "${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem") {
+               &Header::showhttpheaders();
+               &Header::openpage($Lang::tr{'ipsec'}, 1, '');
+               &Header::openbigbox('100%', 'left', '', '');
+               &Header::openbox('100%', 'left', "$Lang::tr{'ca certificate'}:");
+               my $output = `/usr/bin/openssl x509 -text -in ${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem`;
+               $output = &Header::cleanhtml($output,"y");
+               print "<pre>$output</pre>\n";
+               &Header::closebox();
+               print "<div align='center'><a href='/cgi-bin/vpnmain.cgi'>$Lang::tr{'back'}</a></div>";
+               &Header::closebigbox();
+               &Header::closepage();
+               exit(0);
+       } else {
+               $errormessage = $Lang::tr{'invalid key'};
+       }
 
 ###
 ### Export ca certificate to browser
 ###
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'download ca certificate'}) {
-    &General::readhasharray("${General::swroot}/vpn/caconfig", \%cahash);
-
-    if ( -f "${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem" ) {
-       print "Content-Type: application/force-download\n";
-       print "Content-Type: application/octet-stream\r\n";
-       print "Content-Disposition: attachment; filename=$cahash{$cgiparams{'KEY'}}[0]cert.pem\r\n\r\n";
-       print `/usr/bin/openssl x509 -in ${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem`;
-       exit(0);
-    } else {
-       $errormessage = $Lang::tr{'invalid key'};
-    }
+       &General::readhasharray("${General::swroot}/vpn/caconfig", \%cahash);
+
+       if ( -f "${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem" ) {
+               print "Content-Type: application/force-download\n";
+               print "Content-Type: application/octet-stream\r\n";
+               print "Content-Disposition: attachment; filename=$cahash{$cgiparams{'KEY'}}[0]cert.pem\r\n\r\n";
+               print `/usr/bin/openssl x509 -in ${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem`;
+               exit(0);
+       } else {
+               $errormessage = $Lang::tr{'invalid key'};
+       }
 
 ###
 ### Remove ca certificate (step 2)
 ###
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'remove ca certificate'} && $cgiparams{'AREUSURE'} eq 'yes') {
-    &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
-    &General::readhasharray("${General::swroot}/vpn/caconfig", \%cahash);
-
-    if ( -f "${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem" ) {
-       foreach my $key (keys %confighash) {
-           my $test = `/usr/bin/openssl verify -CAfile ${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem ${General::swroot}/certs/$confighash{$key}[1]cert.pem`;
-           if ($test =~ /: OK/) {
-               # Delete connection
-               system('/usr/local/bin/ipsecctrl', 'D', $key) if (&vpnenabled);
-               unlink ("${General::swroot}/certs/$confighash{$key}[1]cert.pem");
-               unlink ("${General::swroot}/certs/$confighash{$key}[1].p12");
-               delete $confighash{$key};
-               &General::writehasharray("${General::swroot}/vpn/config", \%confighash);
-               &writeipsecfiles();
-           }
+       &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
+       &General::readhasharray("${General::swroot}/vpn/caconfig", \%cahash);
+
+       if ( -f "${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem" ) {
+               foreach my $key (keys %confighash) {
+                       my $test = `/usr/bin/openssl verify -CAfile ${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem ${General::swroot}/certs/$confighash{$key}[1]cert.pem`;
+                       if ($test =~ /: OK/) {
+                               # Delete connection
+                               system('/usr/local/bin/ipsecctrl', 'D', $key) if (&vpnenabled);
+                               unlink ("${General::swroot}/certs/$confighash{$key}[1]cert.pem");
+                               unlink ("${General::swroot}/certs/$confighash{$key}[1].p12");
+                               delete $confighash{$key};
+                               &General::writehasharray("${General::swroot}/vpn/config", \%confighash);
+                               &writeipsecfiles();
+                       }
+               }
+               unlink ("${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem");
+               delete $cahash{$cgiparams{'KEY'}};
+               &General::writehasharray("${General::swroot}/vpn/caconfig", \%cahash);
+               system('/usr/local/bin/ipsecctrl', 'R');
+               sleep $sleepDelay;
+       } else {
+               $errormessage = $Lang::tr{'invalid key'};
        }
-       unlink ("${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem");
-       delete $cahash{$cgiparams{'KEY'}};
-       &General::writehasharray("${General::swroot}/vpn/caconfig", \%cahash);
-       system('/usr/local/bin/ipsecctrl', 'R');
-       sleep $sleepDelay;
-    } else {
-       $errormessage = $Lang::tr{'invalid key'};
-    }
 ###
 ### Remove ca certificate (step 1)
 ###
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'remove ca certificate'}) {
-    &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
-    &General::readhasharray("${General::swroot}/vpn/caconfig", \%cahash);
-
-    my $assignedcerts = 0;
-    if ( -f "${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem" ) {
-       foreach my $key (keys %confighash) {
-           my $test = `/usr/bin/openssl verify -CAfile ${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem ${General::swroot}/certs/$confighash{$key}[1]cert.pem`;
-           if ($test =~ /: OK/) {
-               $assignedcerts++;
-           }
-       }
-       if ($assignedcerts) {
-           &Header::showhttpheaders();
-           &Header::openpage($Lang::tr{'ipsec'}, 1, '');
-           &Header::openbigbox('100%', 'left', '', '');
-           &Header::openbox('100%', 'left', $Lang::tr{'are you sure'});
-           print <<END
-           <form method='post' action='$ENV{'SCRIPT_NAME'}'>
-           <table width='100%'>
-               <tr>
-                   <td align='center'>
-                   <input type='hidden' name='KEY' value='$cgiparams{'KEY'}' />
-                   <input type='hidden' name='AREUSURE' value='yes' /></td>
-               </tr><tr>
-                   <td align='center'>
-                   <b><font color='${Header::colourred}'>$Lang::tr{'capswarning'}</font></b>
-                   $Lang::tr{'connections are associated with this ca.  deleting the ca will delete these connections as well.'}</td>
-               </tr><tr>
-                   <td align='center'>
-                   <input type='submit' name='ACTION' value='$Lang::tr{'remove ca certificate'}' />
-                   <input type='submit' name='ACTION' value='$Lang::tr{'cancel'}' /></td>
-               </tr>
-           </table>
-           </form>
+       &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
+       &General::readhasharray("${General::swroot}/vpn/caconfig", \%cahash);
+
+       my $assignedcerts = 0;
+       if ( -f "${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem" ) {
+               foreach my $key (keys %confighash) {
+                       my $test = `/usr/bin/openssl verify -CAfile ${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem ${General::swroot}/certs/$confighash{$key}[1]cert.pem`;
+                       if ($test =~ /: OK/) {
+                               $assignedcerts++;
+                       }
+               }
+               if ($assignedcerts) {
+                       &Header::showhttpheaders();
+                       &Header::openpage($Lang::tr{'ipsec'}, 1, '');
+                       &Header::openbigbox('100%', 'left', '', '');
+                       &Header::openbox('100%', 'left', $Lang::tr{'are you sure'});
+                       print <<END
+                       <form method='post' action='$ENV{'SCRIPT_NAME'}'>
+                               <table width='100%'>
+                                       <tr>
+                                               <td align='center'>
+                                                       <input type='hidden' name='KEY' value='$cgiparams{'KEY'}' />
+                       <input type='hidden' name='AREUSURE' value='yes' /></td>
+                                       </tr><tr>
+                                               <td align='center'>
+                                                       <b><font color='${Header::colourred}'>$Lang::tr{'capswarning'}</font></b>&nbsp;$Lang::tr{'connections are associated with this ca.  deleting the ca will delete these connections as well.'}</td>
+                                       </tr><tr>
+                                               <td align='center'>
+                                                       <input type='submit' name='ACTION' value='$Lang::tr{'remove ca certificate'}' />
+                       <input type='submit' name='ACTION' value='$Lang::tr{'cancel'}' /></td>
+                                       </tr>
+                               </table>
+                       </form>
 END
-           ;
-           &Header::closebox();
-           &Header::closebigbox();
-           &Header::closepage();
-           exit (0);
+;
+                       &Header::closebox();
+                       &Header::closebigbox();
+                       &Header::closepage();
+                       exit (0);
+               } else {
+                       unlink ("${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem");
+                       delete $cahash{$cgiparams{'KEY'}};
+                       &General::writehasharray("${General::swroot}/vpn/caconfig", \%cahash);
+                       system('/usr/local/bin/ipsecctrl', 'R');
+                       sleep $sleepDelay;
+               }
        } else {
-           unlink ("${General::swroot}/ca/$cahash{$cgiparams{'KEY'}}[0]cert.pem");
-           delete $cahash{$cgiparams{'KEY'}};
-           &General::writehasharray("${General::swroot}/vpn/caconfig", \%cahash);
-           system('/usr/local/bin/ipsecctrl', 'R');
-           sleep $sleepDelay;
+               $errormessage = $Lang::tr{'invalid key'};
        }
-    } else {
-       $errormessage = $Lang::tr{'invalid key'};
-    }
 
 ###
 ### Display root certificate
 ###
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'show root certificate'} ||
        $cgiparams{'ACTION'} eq $Lang::tr{'show host certificate'}) {
-    my $output;
-    &Header::showhttpheaders();
-    &Header::openpage($Lang::tr{'ipsec'}, 1, '');
-    &Header::openbigbox('100%', 'left', '', '');
-    if ($cgiparams{'ACTION'} eq $Lang::tr{'show root certificate'}) {
-       &Header::openbox('100%', 'left', "$Lang::tr{'root certificate'}:");
-       $output = `/usr/bin/openssl x509 -text -in ${General::swroot}/ca/cacert.pem`;
-    } else {
-       &Header::openbox('100%', 'left', "$Lang::tr{'host certificate'}:");
-       $output = `/usr/bin/openssl x509 -text -in ${General::swroot}/certs/hostcert.pem`;
-    }
-    $output = &Header::cleanhtml($output,"y");
-    print "<pre>$output</pre>\n";
-    &Header::closebox();
-    print "<div align='center'><a href='/cgi-bin/vpnmain.cgi'>$Lang::tr{'back'}</a></div>";
-    &Header::closebigbox();
-    &Header::closepage();
-    exit(0);
+       my $output;
+       &Header::showhttpheaders();
+       &Header::openpage($Lang::tr{'ipsec'}, 1, '');
+       &Header::openbigbox('100%', 'left', '', '');
+       if ($cgiparams{'ACTION'} eq $Lang::tr{'show root certificate'}) {
+               &Header::openbox('100%', 'left', "$Lang::tr{'root certificate'}:");
+               $output = `/usr/bin/openssl x509 -text -in ${General::swroot}/ca/cacert.pem`;
+       } else {
+               &Header::openbox('100%', 'left', "$Lang::tr{'host certificate'}:");
+               $output = `/usr/bin/openssl x509 -text -in ${General::swroot}/certs/hostcert.pem`;
+       }
+       $output = &Header::cleanhtml($output,"y");
+       print "<pre>$output</pre>\n";
+       &Header::closebox();
+       print "<div align='center'><a href='/cgi-bin/vpnmain.cgi'>$Lang::tr{'back'}</a></div>";
+       &Header::closebigbox();
+       &Header::closepage();
+       exit(0);
 
 ###
 ### Export root certificate to browser
 ###
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'download root certificate'}) {
-    if ( -f "${General::swroot}/ca/cacert.pem" ) {
-       print "Content-Type: application/force-download\n";
-       print "Content-Disposition: attachment; filename=cacert.pem\r\n\r\n";
-       print `/usr/bin/openssl x509 -in ${General::swroot}/ca/cacert.pem`;
-       exit(0);
-    }
+       if ( -f "${General::swroot}/ca/cacert.pem" ) {
+               print "Content-Type: application/force-download\n";
+               print "Content-Disposition: attachment; filename=cacert.pem\r\n\r\n";
+               print `/usr/bin/openssl x509 -in ${General::swroot}/ca/cacert.pem`;
+               exit(0);
+       }
 ###
 ### Export host certificate to browser
 ###
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'download host certificate'}) {
-    if ( -f "${General::swroot}/certs/hostcert.pem" ) {
-       print "Content-Type: application/force-download\n";
-       print "Content-Disposition: attachment; filename=hostcert.pem\r\n\r\n";
-       print `/usr/bin/openssl x509 -in ${General::swroot}/certs/hostcert.pem`;
-       exit(0);
-    }
+       if ( -f "${General::swroot}/certs/hostcert.pem" ) {
+               print "Content-Type: application/force-download\n";
+               print "Content-Disposition: attachment; filename=hostcert.pem\r\n\r\n";
+               print `/usr/bin/openssl x509 -in ${General::swroot}/certs/hostcert.pem`;
+               exit(0);
+       }
 ###
 ### Form for generating/importing the caroot+host certificate
 ###
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'generate root/host certificates'} ||
-        $cgiparams{'ACTION'} eq $Lang::tr{'upload p12 file'}) {
-
-    if (-f "${General::swroot}/ca/cacert.pem") {
-       $errormessage = $Lang::tr{'valid root certificate already exists'};
-       goto ROOTCERT_SKIP;
-    }
-
-    &General::readhash("${General::swroot}/vpn/settings", \%vpnsettings);
-    # fill in initial values
-    if ($cgiparams{'ROOTCERT_HOSTNAME'} eq '') {
-       if (-e "${General::swroot}/red/active" && open(IPADDR, "${General::swroot}/red/local-ipaddress")) {
-           my $ipaddr = <IPADDR>;
-           close IPADDR;
-           chomp ($ipaddr);
-           $cgiparams{'ROOTCERT_HOSTNAME'} = (gethostbyaddr(pack("C4", split(/\./, $ipaddr)), 2))[0];
-           if ($cgiparams{'ROOTCERT_HOSTNAME'} eq '') {
-               $cgiparams{'ROOTCERT_HOSTNAME'} = $ipaddr;
-           }
-       }
-       $cgiparams{'ROOTCERT_COUNTRY'} = $vpnsettings{'ROOTCERT_COUNTRY'} if (!$cgiparams{'ROOTCERT_COUNTRY'});
-    } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'upload p12 file'}) {
-       &General::log("ipsec", "Importing from p12...");
+       $cgiparams{'ACTION'} eq $Lang::tr{'upload p12 file'}) {
+
+       if (-f "${General::swroot}/ca/cacert.pem") {
+               $errormessage = $Lang::tr{'valid root certificate already exists'};
+               goto ROOTCERT_SKIP;
+       }
+
+       &General::readhash("${General::swroot}/vpn/settings", \%vpnsettings);
+       # fill in initial values
+       if ($cgiparams{'ROOTCERT_HOSTNAME'} eq '') {
+               if (-e "${General::swroot}/red/active" && open(IPADDR, "${General::swroot}/red/local-ipaddress")) {
+                       my $ipaddr = <IPADDR>;
+                       close IPADDR;
+                       chomp ($ipaddr);
+                       $cgiparams{'ROOTCERT_HOSTNAME'} = (gethostbyaddr(pack("C4", split(/\./, $ipaddr)), 2))[0];
+                       if ($cgiparams{'ROOTCERT_HOSTNAME'} eq '') {
+                               $cgiparams{'ROOTCERT_HOSTNAME'} = $ipaddr;
+                       }
+               }
+               $cgiparams{'ROOTCERT_COUNTRY'} = $vpnsettings{'ROOTCERT_COUNTRY'} if (!$cgiparams{'ROOTCERT_COUNTRY'});
+       } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'upload p12 file'}) {
+               &General::log("ipsec", "Importing from p12...");
 
-       if (ref ($cgiparams{'FH'}) ne 'Fh') {
-           $errormessage = $Lang::tr{'there was no file upload'};
-           goto ROOTCERT_ERROR;
-       }
+               if (ref ($cgiparams{'FH'}) ne 'Fh') {
+                       $errormessage = $Lang::tr{'there was no file upload'};
+                       goto ROOTCERT_ERROR;
+               }
 
-       # Move uploaded certificate request to a temporary file
-       (my $fh, my $filename) = tempfile( );
-       if (copy ($cgiparams{'FH'}, $fh) != 1) {
-           $errormessage = $!;
-           goto ROOTCERT_ERROR;
-       }
+               # Move uploaded certificate request to a temporary file
+               (my $fh, my $filename) = tempfile( );
+               if (copy ($cgiparams{'FH'}, $fh) != 1) {
+                       $errormessage = $!;
+                       goto ROOTCERT_ERROR;
+               }
 
-       # Extract the CA certificate from the file
-       &General::log("ipsec", "Extracting caroot from p12...");
-       if (open(STDIN, "-|")) {
-           my  $opt  = " pkcs12 -cacerts -nokeys";
-               $opt .= " -in $filename";
-               $opt .= " -out /tmp/newcacert";
-           $errormessage = &callssl ($opt);
-       } else {        #child
-           print "$cgiparams{'P12_PASS'}\n";
-           exit (0);
-       }
-
-       # Extract the Host certificate from the file
-       if (!$errormessage) {
-           &General::log("ipsec", "Extracting host cert from p12...");
-           if (open(STDIN, "-|")) {
-               my  $opt  = " pkcs12 -clcerts -nokeys";
-                   $opt .= " -in $filename";
-                   $opt .= " -out /tmp/newhostcert";
-               $errormessage = &callssl ($opt);
-           } else {    #child
-               print "$cgiparams{'P12_PASS'}\n";
-               exit (0);
-           }
-       }
-
-       # Extract the Host key from the file
-       if (!$errormessage) {
-           &General::log("ipsec", "Extracting private key from p12...");
-           if (open(STDIN, "-|")) {
-               my  $opt  = " pkcs12 -nocerts -nodes";
-                   $opt .= " -in $filename";
-                   $opt .= " -out /tmp/newhostkey";
-               $errormessage = &callssl ($opt);
-           } else {    #child
-               print "$cgiparams{'P12_PASS'}\n";
-               exit (0);
-           }
-       }
-
-       if (!$errormessage) {
-           &General::log("ipsec", "Moving cacert...");
-           move("/tmp/newcacert", "${General::swroot}/ca/cacert.pem");
-           $errormessage = "$Lang::tr{'certificate file move failed'}: $!" if ($? ne 0);
-       }
-
-       if (!$errormessage) {
-           &General::log("ipsec", "Moving host cert...");
-           move("/tmp/newhostcert", "${General::swroot}/certs/hostcert.pem");
-           $errormessage = "$Lang::tr{'certificate file move failed'}: $!" if ($? ne 0);
-        }
-
-       if (!$errormessage) {
-           &General::log("ipsec", "Moving private key...");
-           move("/tmp/newhostkey", "${General::swroot}/certs/hostkey.pem");
-           $errormessage = "$Lang::tr{'certificate file move failed'}: $!" if ($? ne 0);
-        }
-       
-       #cleanup temp files
-       unlink ($filename);
-       unlink ('/tmp/newcacert');
-       unlink ('/tmp/newhostcert');
-       unlink ('/tmp/newhostkey');
-       if ($errormessage) {
-           unlink ("${General::swroot}/ca/cacert.pem");
-           unlink ("${General::swroot}/certs/hostcert.pem");
-           unlink ("${General::swroot}/certs/hostkey.pem");
-           goto ROOTCERT_ERROR;
-       }
+               # Extract the CA certificate from the file
+               &General::log("ipsec", "Extracting caroot from p12...");
+               if (open(STDIN, "-|")) {
+                       my $opt = " pkcs12 -cacerts -nokeys";
+                       $opt .= " -in $filename";
+                       $opt .= " -out /tmp/newcacert";
+                       $errormessage = &callssl ($opt);
+               } else { #child
+                       print "$cgiparams{'P12_PASS'}\n";
+                       exit (0);
+               }
 
-       # Create empty CRL cannot be done because we don't have
-       # the private key for this CAROOT
-       # IPFire can only import certificates
+               # Extract the Host certificate from the file
+               if (!$errormessage) {
+                       &General::log("ipsec", "Extracting host cert from p12...");
+                       if (open(STDIN, "-|")) {
+                               my $opt = " pkcs12 -clcerts -nokeys";
+                               $opt .= " -in $filename";
+                               $opt .= " -out /tmp/newhostcert";
+                               $errormessage = &callssl ($opt);
+                       } else { #child
+                               print "$cgiparams{'P12_PASS'}\n";
+                               exit (0);
+                       }
+               }
 
-       &General::log("ipsec", "p12 import completed!");
-       &cleanssldatabase();
-       goto ROOTCERT_SUCCESS;
-
-    } elsif ($cgiparams{'ROOTCERT_COUNTRY'} ne '') {
-
-       # Validate input since the form was submitted
-       if ($cgiparams{'ROOTCERT_ORGANIZATION'} eq ''){
-           $errormessage = $Lang::tr{'organization cant be empty'};
-           goto ROOTCERT_ERROR;
-       }
-       if (length($cgiparams{'ROOTCERT_ORGANIZATION'}) >60) {
-           $errormessage = $Lang::tr{'organization too long'};
-           goto ROOTCERT_ERROR;
-       }
-       if ($cgiparams{'ROOTCERT_ORGANIZATION'} !~ /^[a-zA-Z0-9 ,\.\-_]*$/) {
-           $errormessage = $Lang::tr{'invalid input for organization'};
-           goto ROOTCERT_ERROR;
-       }
-       if ($cgiparams{'ROOTCERT_HOSTNAME'} eq ''){
-           $errormessage = $Lang::tr{'hostname cant be empty'};
-           goto ROOTCERT_ERROR;
-       }
-       unless (&General::validfqdn($cgiparams{'ROOTCERT_HOSTNAME'}) || &General::validip($cgiparams{'ROOTCERT_HOSTNAME'})) {
-           $errormessage = $Lang::tr{'invalid input for hostname'};
-           goto ROOTCERT_ERROR;
-       }
-       if ($cgiparams{'ROOTCERT_EMAIL'} ne '' && (! &General::validemail($cgiparams{'ROOTCERT_EMAIL'}))) {
-           $errormessage = $Lang::tr{'invalid input for e-mail address'};
-           goto ROOTCERT_ERROR;
-       }
-       if (length($cgiparams{'ROOTCERT_EMAIL'}) > 40) {
-           $errormessage = $Lang::tr{'e-mail address too long'};
-           goto ROOTCERT_ERROR;
-       }
-       if ($cgiparams{'ROOTCERT_OU'} ne '' && $cgiparams{'ROOTCERT_OU'} !~ /^[a-zA-Z0-9 ,\.\-_]*$/) {
-           $errormessage = $Lang::tr{'invalid input for department'};
-           goto ROOTCERT_ERROR;
-       }
-       if ($cgiparams{'ROOTCERT_CITY'} ne '' && $cgiparams{'ROOTCERT_CITY'} !~ /^[a-zA-Z0-9 ,\.\-_]*$/) {
-           $errormessage = $Lang::tr{'invalid input for city'};
-           goto ROOTCERT_ERROR;
-       }
-       if ($cgiparams{'ROOTCERT_STATE'} ne '' && $cgiparams{'ROOTCERT_STATE'} !~ /^[a-zA-Z0-9 ,\.\-_]*$/) {
-           $errormessage = $Lang::tr{'invalid input for state or province'};
-           goto ROOTCERT_ERROR;
-       }
-       if ($cgiparams{'ROOTCERT_COUNTRY'} !~ /^[A-Z]*$/) {
-           $errormessage = $Lang::tr{'invalid input for country'};
-           goto ROOTCERT_ERROR;
-       }
-       #the exact syntax is a list comma separated of 
-       #  email:any-validemail
-       #       URI: a uniform resource indicator
-       #   DNS: a DNS domain name
-       #   RID: a registered OBJECT IDENTIFIER
-       #   IP: an IP address
-       # example: email:franck@foo.com,IP:10.0.0.10,DNS:franck.foo.com
-
-       if ($cgiparams{'SUBJECTALTNAME'} ne '' && $cgiparams{'SUBJECTALTNAME'} !~ /^(email|URI|DNS|RID|IP):[a-zA-Z0-9 :\/,\.\-_@]*$/) {
-           $errormessage = $Lang::tr{'vpn altname syntax'};
-           goto VPNCONF_ERROR;
-       }
-
-       # Copy the cgisettings to vpnsettings and save the configfile
-       $vpnsettings{'ROOTCERT_ORGANIZATION'}   = $cgiparams{'ROOTCERT_ORGANIZATION'};
-       $vpnsettings{'ROOTCERT_HOSTNAME'}       = $cgiparams{'ROOTCERT_HOSTNAME'};
-       $vpnsettings{'ROOTCERT_EMAIL'}          = $cgiparams{'ROOTCERT_EMAIL'};
-       $vpnsettings{'ROOTCERT_OU'}             = $cgiparams{'ROOTCERT_OU'};
-       $vpnsettings{'ROOTCERT_CITY'}           = $cgiparams{'ROOTCERT_CITY'};
-       $vpnsettings{'ROOTCERT_STATE'}          = $cgiparams{'ROOTCERT_STATE'};
-       $vpnsettings{'ROOTCERT_COUNTRY'}        = $cgiparams{'ROOTCERT_COUNTRY'};
-       &General::writehash("${General::swroot}/vpn/settings", \%vpnsettings);
+               # Extract the Host key from the file
+               if (!$errormessage) {
+                       &General::log("ipsec", "Extracting private key from p12...");
+                       if (open(STDIN, "-|")) {
+                               my $opt = " pkcs12 -nocerts -nodes";
+                               $opt .= " -in $filename";
+                               $opt .= " -out /tmp/newhostkey";
+                               $errormessage = &callssl ($opt);
+                       } else { #child
+                               print "$cgiparams{'P12_PASS'}\n";
+                               exit (0);
+                       }
+               }
 
-       # Replace empty strings with a .
-       (my $ou = $cgiparams{'ROOTCERT_OU'}) =~ s/^\s*$/\./;
-       (my $city = $cgiparams{'ROOTCERT_CITY'}) =~ s/^\s*$/\./;
-       (my $state = $cgiparams{'ROOTCERT_STATE'}) =~ s/^\s*$/\./;
-
-       # Create the CA certificate
-       if (!$errormessage) {
-           &General::log("ipsec", "Creating cacert...");
-           if (open(STDIN, "-|")) {
-               my $opt  = " req -x509 -sha256 -nodes";
-                  $opt .= " -days 999999";
-                  $opt .= " -newkey rsa:4096";
-                  $opt .= " -keyout ${General::swroot}/private/cakey.pem";
-                  $opt .= " -out ${General::swroot}/ca/cacert.pem";
-
-               $errormessage = &callssl ($opt);
-           } else {    #child
-               print  "$cgiparams{'ROOTCERT_COUNTRY'}\n";
-               print  "$state\n";
-               print  "$city\n";
-               print  "$cgiparams{'ROOTCERT_ORGANIZATION'}\n";
-               print  "$ou\n";
-               print  "$cgiparams{'ROOTCERT_ORGANIZATION'} CA\n";
-               print  "$cgiparams{'ROOTCERT_EMAIL'}\n";
-               exit (0);
-           }
-       }
-
-       # Create the Host certificate request
-       if (!$errormessage) {
-           &General::log("ipsec", "Creating host cert...");
-           if (open(STDIN, "-|")) {
-               my $opt  = " req -sha256 -nodes";
-                  $opt .= " -newkey rsa:2048";
-                  $opt .= " -keyout ${General::swroot}/certs/hostkey.pem";
-                  $opt .= " -out ${General::swroot}/certs/hostreq.pem";
-               $errormessage = &callssl ($opt);
-           } else {    #child
-               print  "$cgiparams{'ROOTCERT_COUNTRY'}\n";
-               print  "$state\n";
-               print  "$city\n";
-               print  "$cgiparams{'ROOTCERT_ORGANIZATION'}\n";
-               print  "$ou\n";
-               print  "$cgiparams{'ROOTCERT_HOSTNAME'}\n";
-               print  "$cgiparams{'ROOTCERT_EMAIL'}\n";
-               print  ".\n";
-               print  ".\n";
-               exit (0);
-           }
-       }
+               if (!$errormessage) {
+                       &General::log("ipsec", "Moving cacert...");
+                       move("/tmp/newcacert", "${General::swroot}/ca/cacert.pem");
+                       $errormessage = "$Lang::tr{'certificate file move failed'}: $!" if ($? ne 0);
+               }
+
+               if (!$errormessage) {
+                       &General::log("ipsec", "Moving host cert...");
+                       move("/tmp/newhostcert", "${General::swroot}/certs/hostcert.pem");
+                       $errormessage = "$Lang::tr{'certificate file move failed'}: $!" if ($? ne 0);
+               }
+
+               if (!$errormessage) {
+                       &General::log("ipsec", "Moving private key...");
+                       move("/tmp/newhostkey", "${General::swroot}/certs/hostkey.pem");
+                       $errormessage = "$Lang::tr{'certificate file move failed'}: $!" if ($? ne 0);
+               }
+
+               #cleanup temp files
+               unlink ($filename);
+               unlink ('/tmp/newcacert');
+               unlink ('/tmp/newhostcert');
+               unlink ('/tmp/newhostkey');
+               if ($errormessage) {
+                       unlink ("${General::swroot}/ca/cacert.pem");
+                       unlink ("${General::swroot}/certs/hostcert.pem");
+                       unlink ("${General::swroot}/certs/hostkey.pem");
+                       goto ROOTCERT_ERROR;
+               }
 
-       # Sign the host certificate request
-       if (!$errormessage) {
-           &General::log("ipsec", "Self signing host cert...");
+               # Create empty CRL cannot be done because we don't have
+               # the private key for this CAROOT
+               # IPFire can only import certificates
 
-           #No easy way for specifying the contain of subjectAltName without writing a config file...
-           my ($fh, $v3extname) = tempfile ('/tmp/XXXXXXXX');
-           print $fh <<END
-           basicConstraints=CA:FALSE
-           nsComment="OpenSSL Generated Certificate"
-           subjectKeyIdentifier=hash
-           authorityKeyIdentifier=keyid,issuer:always
-           extendedKeyUsage = serverAuth
+               &General::log("ipsec", "p12 import completed!");
+               &cleanssldatabase();
+               goto ROOTCERT_SUCCESS;
+
+       } elsif ($cgiparams{'ROOTCERT_COUNTRY'} ne '') {
+
+               # Validate input since the form was submitted
+               if ($cgiparams{'ROOTCERT_ORGANIZATION'} eq ''){
+                       $errormessage = $Lang::tr{'organization cant be empty'};
+                       goto ROOTCERT_ERROR;
+               }
+               if (length($cgiparams{'ROOTCERT_ORGANIZATION'}) >60) {
+                       $errormessage = $Lang::tr{'organization too long'};
+                       goto ROOTCERT_ERROR;
+               }
+               if ($cgiparams{'ROOTCERT_ORGANIZATION'} !~ /^[a-zA-Z0-9 ,\.\-_]*$/) {
+                       $errormessage = $Lang::tr{'invalid input for organization'};
+                       goto ROOTCERT_ERROR;
+               }
+               if ($cgiparams{'ROOTCERT_HOSTNAME'} eq ''){
+                       $errormessage = $Lang::tr{'hostname cant be empty'};
+                       goto ROOTCERT_ERROR;
+               }
+               unless (&General::validfqdn($cgiparams{'ROOTCERT_HOSTNAME'}) || &General::validip($cgiparams{'ROOTCERT_HOSTNAME'})) {
+                       $errormessage = $Lang::tr{'invalid input for hostname'};
+                       goto ROOTCERT_ERROR;
+               }
+               if ($cgiparams{'ROOTCERT_EMAIL'} ne '' && (! &General::validemail($cgiparams{'ROOTCERT_EMAIL'}))) {
+                       $errormessage = $Lang::tr{'invalid input for e-mail address'};
+                       goto ROOTCERT_ERROR;
+               }
+               if (length($cgiparams{'ROOTCERT_EMAIL'}) > 40) {
+                       $errormessage = $Lang::tr{'e-mail address too long'};
+                       goto ROOTCERT_ERROR;
+               }
+               if ($cgiparams{'ROOTCERT_OU'} ne '' && $cgiparams{'ROOTCERT_OU'} !~ /^[a-zA-Z0-9 ,\.\-_]*$/) {
+                       $errormessage = $Lang::tr{'invalid input for department'};
+                       goto ROOTCERT_ERROR;
+               }
+               if ($cgiparams{'ROOTCERT_CITY'} ne '' && $cgiparams{'ROOTCERT_CITY'} !~ /^[a-zA-Z0-9 ,\.\-_]*$/) {
+                       $errormessage = $Lang::tr{'invalid input for city'};
+                       goto ROOTCERT_ERROR;
+               }
+               if ($cgiparams{'ROOTCERT_STATE'} ne '' && $cgiparams{'ROOTCERT_STATE'} !~ /^[a-zA-Z0-9 ,\.\-_]*$/) {
+                       $errormessage = $Lang::tr{'invalid input for state or province'};
+                       goto ROOTCERT_ERROR;
+               }
+               if ($cgiparams{'ROOTCERT_COUNTRY'} !~ /^[A-Z]*$/) {
+                       $errormessage = $Lang::tr{'invalid input for country'};
+                       goto ROOTCERT_ERROR;
+               }
+               #the exact syntax is a list comma separated of
+               #       email:any-validemail
+               #       URI: a uniform resource indicator
+               #       DNS: a DNS domain name
+               #       RID: a registered OBJECT IDENTIFIER
+               #       IP: an IP address
+               # example: email:franck@foo.com,IP:10.0.0.10,DNS:franck.foo.com
+
+               if ($cgiparams{'SUBJECTALTNAME'} ne '' && $cgiparams{'SUBJECTALTNAME'} !~ /^(email|URI|DNS|RID|IP):[a-zA-Z0-9 :\/,\.\-_@]*$/) {
+                       $errormessage = $Lang::tr{'vpn altname syntax'};
+                       goto VPNCONF_ERROR;
+               }
+
+               # Copy the cgisettings to vpnsettings and save the configfile
+               $vpnsettings{'ROOTCERT_ORGANIZATION'}   = $cgiparams{'ROOTCERT_ORGANIZATION'};
+               $vpnsettings{'ROOTCERT_HOSTNAME'}               = $cgiparams{'ROOTCERT_HOSTNAME'};
+               $vpnsettings{'ROOTCERT_EMAIL'}                  = $cgiparams{'ROOTCERT_EMAIL'};
+               $vpnsettings{'ROOTCERT_OU'}                             = $cgiparams{'ROOTCERT_OU'};
+               $vpnsettings{'ROOTCERT_CITY'}                   = $cgiparams{'ROOTCERT_CITY'};
+               $vpnsettings{'ROOTCERT_STATE'}                  = $cgiparams{'ROOTCERT_STATE'};
+               $vpnsettings{'ROOTCERT_COUNTRY'}                = $cgiparams{'ROOTCERT_COUNTRY'};
+               &General::writehash("${General::swroot}/vpn/settings", \%vpnsettings);
+
+               # Replace empty strings with a .
+               (my $ou = $cgiparams{'ROOTCERT_OU'}) =~ s/^\s*$/\./;
+               (my $city = $cgiparams{'ROOTCERT_CITY'}) =~ s/^\s*$/\./;
+               (my $state = $cgiparams{'ROOTCERT_STATE'}) =~ s/^\s*$/\./;
+
+               # Create the CA certificate
+               if (!$errormessage) {
+                       &General::log("ipsec", "Creating cacert...");
+                       if (open(STDIN, "-|")) {
+                               my $opt = " req -x509 -sha256 -nodes";
+                               $opt .= " -days 999999";
+                               $opt .= " -newkey rsa:4096";
+                               $opt .= " -keyout ${General::swroot}/private/cakey.pem";
+                               $opt .= " -out ${General::swroot}/ca/cacert.pem";
+
+                               $errormessage = &callssl ($opt);
+                       } else { #child
+                               print "$cgiparams{'ROOTCERT_COUNTRY'}\n";
+                               print "$state\n";
+                               print "$city\n";
+                               print "$cgiparams{'ROOTCERT_ORGANIZATION'}\n";
+                               print "$ou\n";
+                               print "$cgiparams{'ROOTCERT_ORGANIZATION'} CA\n";
+                               print "$cgiparams{'ROOTCERT_EMAIL'}\n";
+                               exit (0);
+                       }
+               }
+
+               # Create the Host certificate request
+               if (!$errormessage) {
+                       &General::log("ipsec", "Creating host cert...");
+                       if (open(STDIN, "-|")) {
+                               my $opt = " req -sha256 -nodes";
+                               $opt .= " -newkey rsa:2048";
+                               $opt .= " -keyout ${General::swroot}/certs/hostkey.pem";
+                               $opt .= " -out ${General::swroot}/certs/hostreq.pem";
+                               $errormessage = &callssl ($opt);
+                       } else { #child
+                               print "$cgiparams{'ROOTCERT_COUNTRY'}\n";
+                               print "$state\n";
+                               print "$city\n";
+                               print "$cgiparams{'ROOTCERT_ORGANIZATION'}\n";
+                               print "$ou\n";
+                               print "$cgiparams{'ROOTCERT_HOSTNAME'}\n";
+                               print "$cgiparams{'ROOTCERT_EMAIL'}\n";
+                               print ".\n";
+                               print ".\n";
+                               exit (0);
+                       }
+               }
+
+               # Sign the host certificate request
+               if (!$errormessage) {
+                       &General::log("ipsec", "Self signing host cert...");
+
+                       #No easy way for specifying the contain of subjectAltName without writing a config file...
+                       my ($fh, $v3extname) = tempfile ('/tmp/XXXXXXXX');
+                       print $fh <<END
+                       basicConstraints=CA:FALSE
+                       nsComment="OpenSSL Generated Certificate"
+                       subjectKeyIdentifier=hash
+                       authorityKeyIdentifier=keyid,issuer:always
+                       extendedKeyUsage = serverAuth
 END
 ;
-           print $fh "subjectAltName=$cgiparams{'SUBJECTALTNAME'}" if ($cgiparams{'SUBJECTALTNAME'});
-           close ($fh);
-           
-           my  $opt  = " ca -md sha256 -days 999999";
-               $opt .= " -batch -notext";
-               $opt .= " -in ${General::swroot}/certs/hostreq.pem";
-               $opt .= " -out ${General::swroot}/certs/hostcert.pem";
-               $opt .= " -extfile $v3extname";
-           $errormessage = &callssl ($opt);
-           unlink ("${General::swroot}/certs/hostreq.pem"); #no more needed
-           unlink ($v3extname);
-       }
-
-       # Create an empty CRL
-       if (!$errormessage) {
-           &General::log("ipsec", "Creating emptycrl...");
-           my  $opt  = " ca -gencrl";
-               $opt .= " -out ${General::swroot}/crls/cacrl.pem";
-           $errormessage = &callssl ($opt);
-       }
-       
-       # Successfully build CA / CERT!
-       if (!$errormessage) {
-           &cleanssldatabase();
-           goto ROOTCERT_SUCCESS;
-       }
-       
-       #Cleanup
-       unlink ("${General::swroot}/ca/cacert.pem");
-       unlink ("${General::swroot}/certs/hostkey.pem");
-       unlink ("${General::swroot}/certs/hostcert.pem");
-       unlink ("${General::swroot}/crls/cacrl.pem");
-       &cleanssldatabase();
-    }
-
-    ROOTCERT_ERROR:
-    &Header::showhttpheaders();
-    &Header::openpage($Lang::tr{'ipsec'}, 1, '');
-    &Header::openbigbox('100%', 'left', '', $errormessage);
-    if ($errormessage) {
-        &Header::openbox('100%', 'left', $Lang::tr{'error messages'});
-        print "<class name='base'>$errormessage";
-        print "&nbsp;</class>";
-        &Header::closebox();
-    }
-    &Header::openbox('100%', 'left', "$Lang::tr{'generate root/host certificates'}:");
-    print <<END
-    <form method='post' enctype='multipart/form-data' action='$ENV{'SCRIPT_NAME'}'>
-    <table width='100%' border='0' cellspacing='1' cellpadding='0'>
-    <tr><td width='40%' class='base'>$Lang::tr{'organization name'}:&nbsp;<img src='/blob.gif' alt='*' /></td>
-        <td width='60%' class='base' nowrap='nowrap'><input type='text' name='ROOTCERT_ORGANIZATION' value='$cgiparams{'ROOTCERT_ORGANIZATION'}' size='32' /></td></tr>
-    <tr><td class='base'>$Lang::tr{'ipfires hostname'}:&nbsp;<img src='/blob.gif' alt='*' /></td>
-        <td class='base' nowrap='nowrap'><input type='text' name='ROOTCERT_HOSTNAME' value='$cgiparams{'ROOTCERT_HOSTNAME'}' size='32' /></td></tr>
-    <tr><td class='base'>$Lang::tr{'your e-mail'}:</td>
-        <td class='base' nowrap='nowrap'><input type='text' name='ROOTCERT_EMAIL' value='$cgiparams{'ROOTCERT_EMAIL'}' size='32' /></td></tr>
-    <tr><td class='base'>$Lang::tr{'your department'}:</td>
-        <td class='base' nowrap='nowrap'><input type='text' name='ROOTCERT_OU' value='$cgiparams{'ROOTCERT_OU'}' size='32' /></td></tr>
-    <tr><td class='base'>$Lang::tr{'city'}:</td>
-        <td class='base' nowrap='nowrap'><input type='text' name='ROOTCERT_CITY' value='$cgiparams{'ROOTCERT_CITY'}' size='32' /></td></tr>
-    <tr><td class='base'>$Lang::tr{'state or province'}:</td>
-        <td class='base' nowrap='nowrap'><input type='text' name='ROOTCERT_STATE' value='$cgiparams{'ROOTCERT_STATE'}' size='32' /></td></tr>
-    <tr><td class='base'>$Lang::tr{'country'}:</td>
-        <td class='base'><select name='ROOTCERT_COUNTRY'>
+                       print $fh "subjectAltName=$cgiparams{'SUBJECTALTNAME'}" if ($cgiparams{'SUBJECTALTNAME'});
+                       close ($fh);
+
+                       my $opt = " ca -md sha256 -days 999999";
+                       $opt .= " -batch -notext";
+                       $opt .= " -in ${General::swroot}/certs/hostreq.pem";
+                       $opt .= " -out ${General::swroot}/certs/hostcert.pem";
+                       $opt .= " -extfile $v3extname";
+                       $errormessage = &callssl ($opt);
+                       unlink ("${General::swroot}/certs/hostreq.pem"); #no more needed
+                       unlink ($v3extname);
+               }
+
+               # Create an empty CRL
+               if (!$errormessage) {
+                       &General::log("ipsec", "Creating emptycrl...");
+                       my $opt = " ca -gencrl";
+                       $opt .= " -out ${General::swroot}/crls/cacrl.pem";
+                       $errormessage = &callssl ($opt);
+               }
+
+               # Successfully build CA / CERT!
+               if (!$errormessage) {
+                       &cleanssldatabase();
+                       goto ROOTCERT_SUCCESS;
+               }
+
+               #Cleanup
+               unlink ("${General::swroot}/ca/cacert.pem");
+               unlink ("${General::swroot}/certs/hostkey.pem");
+               unlink ("${General::swroot}/certs/hostcert.pem");
+               unlink ("${General::swroot}/crls/cacrl.pem");
+               &cleanssldatabase();
+       }
+
+       ROOTCERT_ERROR:
+       &Header::showhttpheaders();
+       &Header::openpage($Lang::tr{'ipsec'}, 1, '');
+       &Header::openbigbox('100%', 'left', '', $errormessage);
+       if ($errormessage) {
+               &Header::openbox('100%', 'left', $Lang::tr{'error messages'});
+               print "<class name='base'>$errormessage";
+               print "&nbsp;</class>";
+               &Header::closebox();
+       }
+       &Header::openbox('100%', 'left', "$Lang::tr{'generate root/host certificates'}:");
+       print <<END
+       <form method='post' enctype='multipart/form-data' action='$ENV{'SCRIPT_NAME'}'>
+               <table width='100%' border='0' cellspacing='1' cellpadding='0'>
+       <tr><td width='40%' class='base'>$Lang::tr{'organization name'}:&nbsp;<img src='/blob.gif' alt='*' /></td>
+               <td width='60%' class='base' nowrap='nowrap'><input type='text' name='ROOTCERT_ORGANIZATION' value='$cgiparams{'ROOTCERT_ORGANIZATION'}' size='32' /></td></tr>
+       <tr><td class='base'>$Lang::tr{'ipfires hostname'}:&nbsp;<img src='/blob.gif' alt='*' /></td>
+               <td class='base' nowrap='nowrap'><input type='text' name='ROOTCERT_HOSTNAME' value='$cgiparams{'ROOTCERT_HOSTNAME'}' size='32' /></td></tr>
+       <tr><td class='base'>$Lang::tr{'your e-mail'}:</td>
+               <td class='base' nowrap='nowrap'><input type='text' name='ROOTCERT_EMAIL' value='$cgiparams{'ROOTCERT_EMAIL'}' size='32' /></td></tr>
+       <tr><td class='base'>$Lang::tr{'your department'}:</td>
+               <td class='base' nowrap='nowrap'><input type='text' name='ROOTCERT_OU' value='$cgiparams{'ROOTCERT_OU'}' size='32' /></td></tr>
+       <tr><td class='base'>$Lang::tr{'city'}:</td>
+               <td class='base' nowrap='nowrap'><input type='text' name='ROOTCERT_CITY' value='$cgiparams{'ROOTCERT_CITY'}' size='32' /></td></tr>
+       <tr><td class='base'>$Lang::tr{'state or province'}:</td>
+               <td class='base' nowrap='nowrap'><input type='text' name='ROOTCERT_STATE' value='$cgiparams{'ROOTCERT_STATE'}' size='32' /></td></tr>
+       <tr><td class='base'>$Lang::tr{'country'}:</td>
+               <td class='base'><select name='ROOTCERT_COUNTRY'>
 END
-    ;
-    foreach my $country (sort keys %{Countries::countries}) {
-        print "<option value='$Countries::countries{$country}'";
-        if ( $Countries::countries{$country} eq $cgiparams{'ROOTCERT_COUNTRY'} ) {
-            print " selected='selected'";
-        }
-        print ">$country</option>";
-    }
-    print <<END
-        </select></td></tr>
-    <tr><td class='base'>$Lang::tr{'vpn subjectaltname'} (subjectAltName=email:*,URI:*,DNS:*,RID:*)</td>
+;
+       foreach my $country (sort keys %{Countries::countries}) {
+               print "<option value='$Countries::countries{$country}'";
+               if ( $Countries::countries{$country} eq $cgiparams{'ROOTCERT_COUNTRY'} ) {
+                       print " selected='selected'";
+               }
+               print ">$country</option>";
+       }
+       print <<END
+               </select></td></tr>
+       <tr><td class='base'>$Lang::tr{'vpn subjectaltname'} (subjectAltName=email:*,URI:*,DNS:*,RID:*)</td>
        <td class='base' nowrap='nowrap'><input type='text' name='SUBJECTALTNAME' value='$cgiparams{'SUBJECTALTNAME'}' size='32' /></td></tr>
-    <tr><td>&nbsp;</td>
-        <td><br /><input type='submit' name='ACTION' value='$Lang::tr{'generate root/host certificates'}' /><br /><br /></td></tr>
-    <tr><td class='base' colspan='2' align='left'>
-        <b><font color='${Header::colourred}'>$Lang::tr{'capswarning'}</font></b>: 
-        $Lang::tr{'generating the root and host certificates may take a long time. it can take up to several minutes on older hardware. please be patient'}
-    </td></tr>
-    <tr><td colspan='2'><hr></td></tr>
-    <tr><td class='base' nowrap='nowrap'>$Lang::tr{'upload p12 file'}:</td>
-        <td nowrap='nowrap'><input type='file' name='FH' size='32' /></td></tr>
-    <tr><td class='base'>$Lang::tr{'pkcs12 file password'}:</td>
-        <td class='base' nowrap='nowrap'><input type='password' name='P12_PASS' value='$cgiparams{'P12_PASS'}' size='32' /></td></tr>
-    <tr><td>&nbsp;</td>
-        <td><input type='submit' name='ACTION' value='$Lang::tr{'upload p12 file'}' /></td></tr>
-    <tr><td class='base' colspan='2' align='left'>
-        <img src='/blob.gif' alt='*' />&nbsp;$Lang::tr{'required field'}</td></tr>
-    </table></form>
+       <tr><td>&nbsp;</td>
+               <td><br /><input type='submit' name='ACTION' value='$Lang::tr{'generate root/host certificates'}' /><br /><br /></td></tr>
+       <tr><td class='base' colspan='2' align='left'>
+               <b><font color='${Header::colourred}'>$Lang::tr{'capswarning'}</font></b>:
+               $Lang::tr{'generating the root and host certificates may take a long time. it can take up to several minutes on older hardware. please be patient'}
+       </td></tr>
+       <tr><td colspan='2'><hr></td></tr>
+       <tr><td class='base' nowrap='nowrap'>$Lang::tr{'upload p12 file'}:</td>
+               <td nowrap='nowrap'><input type='file' name='FH' size='32' /></td></tr>
+       <tr><td class='base'>$Lang::tr{'pkcs12 file password'}:</td>
+               <td class='base' nowrap='nowrap'><input type='password' name='P12_PASS' value='$cgiparams{'P12_PASS'}' size='32' /></td></tr>
+       <tr><td>&nbsp;</td>
+               <td><input type='submit' name='ACTION' value='$Lang::tr{'upload p12 file'}' /></td></tr>
+       <tr><td class='base' colspan='2' align='left'>
+               <img src='/blob.gif' alt='*' />&nbsp;$Lang::tr{'required field'}</td></tr>
+       </table></form>
 END
-    ;
-    &Header::closebox();
-    &Header::closebigbox();
-    &Header::closepage();
-    exit(0);
-
-    ROOTCERT_SUCCESS:
-    if (&vpnenabled) {
-       system('/usr/local/bin/ipsecctrl', 'S');
-       sleep $sleepDelay;
-    }
-    ROOTCERT_SKIP:
+;
+       &Header::closebox();
+       &Header::closebigbox();
+       &Header::closepage();
+       exit(0);
+
+       ROOTCERT_SUCCESS:
+       if (&vpnenabled) {
+               system('/usr/local/bin/ipsecctrl', 'S');
+               sleep $sleepDelay;
+       }
+       ROOTCERT_SKIP:
 ###
 ### Export PKCS12 file to browser
 ###
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'download pkcs12 file'}) {
-    &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
-    print "Content-Type: application/force-download\n";
-    print "Content-Disposition: attachment; filename=" . $confighash{$cgiparams{'KEY'}}[1] . ".p12\r\n";
-    print "Content-Type: application/octet-stream\r\n\r\n";
-    print `/bin/cat ${General::swroot}/certs/$confighash{$cgiparams{'KEY'}}[1].p12`;
-    exit (0);
+       &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
+       print "Content-Type: application/force-download\n";
+       print "Content-Disposition: attachment; filename=" . $confighash{$cgiparams{'KEY'}}[1] . ".p12\r\n";
+       print "Content-Type: application/octet-stream\r\n\r\n";
+       print `/bin/cat ${General::swroot}/certs/$confighash{$cgiparams{'KEY'}}[1].p12`;
+       exit (0);
 
 ###
 ### Display certificate
 ###
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'show certificate'}) {
-    &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
-
-    if ( -f "${General::swroot}/certs/$confighash{$cgiparams{'KEY'}}[1]cert.pem") {
-       &Header::showhttpheaders();
-       &Header::openpage($Lang::tr{'ipsec'}, 1, '');
-       &Header::openbigbox('100%', 'left', '', '');
-       &Header::openbox('100%', 'left', "$Lang::tr{'cert'}:");
-       my $output = `/usr/bin/openssl x509 -text -in ${General::swroot}/certs/$confighash{$cgiparams{'KEY'}}[1]cert.pem`;
-       $output = &Header::cleanhtml($output,"y");
-       print "<pre>$output</pre>\n";
-       &Header::closebox();
-       print "<div align='center'><a href='/cgi-bin/vpnmain.cgi'>$Lang::tr{'back'}</a></div>";
-       &Header::closebigbox();
-       &Header::closepage();
-       exit(0);
-    }
+       &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
+
+       if ( -f "${General::swroot}/certs/$confighash{$cgiparams{'KEY'}}[1]cert.pem") {
+               &Header::showhttpheaders();
+               &Header::openpage($Lang::tr{'ipsec'}, 1, '');
+               &Header::openbigbox('100%', 'left', '', '');
+               &Header::openbox('100%', 'left', "$Lang::tr{'cert'}:");
+               my $output = `/usr/bin/openssl x509 -text -in ${General::swroot}/certs/$confighash{$cgiparams{'KEY'}}[1]cert.pem`;
+               $output = &Header::cleanhtml($output,"y");
+               print "<pre>$output</pre>\n";
+               &Header::closebox();
+               print "<div align='center'><a href='/cgi-bin/vpnmain.cgi'>$Lang::tr{'back'}</a></div>";
+               &Header::closebigbox();
+               &Header::closepage();
+               exit(0);
+       }
 
 ###
 ### Export Certificate to browser
 ###
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'download certificate'}) {
-    &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
+       &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
 
-    if ( -f "${General::swroot}/certs/$confighash{$cgiparams{'KEY'}}[1]cert.pem") {
-       print "Content-Type: application/force-download\n";
-       print "Content-Disposition: attachment; filename=" . $confighash{$cgiparams{'KEY'}}[1] . "cert.pem\n\n";
-       print `/bin/cat ${General::swroot}/certs/$confighash{$cgiparams{'KEY'}}[1]cert.pem`;
-       exit (0);
-    }
+       if ( -f "${General::swroot}/certs/$confighash{$cgiparams{'KEY'}}[1]cert.pem") {
+               print "Content-Type: application/force-download\n";
+               print "Content-Disposition: attachment; filename=" . $confighash{$cgiparams{'KEY'}}[1] . "cert.pem\n\n";
+               print `/bin/cat ${General::swroot}/certs/$confighash{$cgiparams{'KEY'}}[1]cert.pem`;
+               exit (0);
+       }
 
 ###
 ### Enable/Disable connection
 ###
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'toggle enable disable'}) {
-    
-    &General::readhash("${General::swroot}/vpn/settings", \%vpnsettings);
-    &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
-
-    if ($confighash{$cgiparams{'KEY'}}) {
-       if ($confighash{$cgiparams{'KEY'}}[0] eq 'off') {
-           $confighash{$cgiparams{'KEY'}}[0] = 'on';
-           &General::writehasharray("${General::swroot}/vpn/config", \%confighash);
-           &writeipsecfiles();
-           system('/usr/local/bin/ipsecctrl', 'S', $cgiparams{'KEY'}) if (&vpnenabled);
+
+       &General::readhash("${General::swroot}/vpn/settings", \%vpnsettings);
+       &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
+
+       if ($confighash{$cgiparams{'KEY'}}) {
+               if ($confighash{$cgiparams{'KEY'}}[0] eq 'off') {
+                       $confighash{$cgiparams{'KEY'}}[0] = 'on';
+                       &General::writehasharray("${General::swroot}/vpn/config", \%confighash);
+                       &writeipsecfiles();
+                       system('/usr/local/bin/ipsecctrl', 'S', $cgiparams{'KEY'}) if (&vpnenabled);
+               } else {
+                       system('/usr/local/bin/ipsecctrl', 'D', $cgiparams{'KEY'}) if (&vpnenabled);
+                       $confighash{$cgiparams{'KEY'}}[0] = 'off';
+                       &General::writehasharray("${General::swroot}/vpn/config", \%confighash);
+                       &writeipsecfiles();
+               }
+               sleep $sleepDelay;
        } else {
-           system('/usr/local/bin/ipsecctrl', 'D', $cgiparams{'KEY'}) if (&vpnenabled);
-           $confighash{$cgiparams{'KEY'}}[0] = 'off';
-           &General::writehasharray("${General::swroot}/vpn/config", \%confighash);
-           &writeipsecfiles();
+               $errormessage = $Lang::tr{'invalid key'};
        }
-       sleep $sleepDelay;
-    } else {
-       $errormessage = $Lang::tr{'invalid key'};
-    }
 
 ###
 ### Restart connection
 ###
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'restart'}) {
-    &General::readhash("${General::swroot}/vpn/settings", \%vpnsettings);
-    &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
+       &General::readhash("${General::swroot}/vpn/settings", \%vpnsettings);
+       &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
 
-    if ($confighash{$cgiparams{'KEY'}}) {
-       if (&vpnenabled) {
-           system('/usr/local/bin/ipsecctrl', 'S', $cgiparams{'KEY'});
-           sleep $sleepDelay;
+       if ($confighash{$cgiparams{'KEY'}}) {
+               if (&vpnenabled) {
+                       system('/usr/local/bin/ipsecctrl', 'S', $cgiparams{'KEY'});
+                       sleep $sleepDelay;
+               }
+       } else {
+               $errormessage = $Lang::tr{'invalid key'};
        }
-    } else {
-       $errormessage = $Lang::tr{'invalid key'};
-    }
 
 ###
 ### Remove connection
 ###
 } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'remove'}) {
-    &General::readhash("${General::swroot}/vpn/settings", \%vpnsettings);
-    &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
-
-    if ($confighash{$cgiparams{'KEY'}}) {
-       system('/usr/local/bin/ipsecctrl', 'D', $cgiparams{'KEY'}) if (&vpnenabled);
-       unlink ("${General::swroot}/certs/$confighash{$cgiparams{'KEY'}}[1]cert.pem");
-       unlink ("${General::swroot}/certs/$confighash{$cgiparams{'KEY'}}[1].p12");
-       delete $confighash{$cgiparams{'KEY'}};
-       &General::writehasharray("${General::swroot}/vpn/config", \%confighash);
-       &writeipsecfiles();
-    } else {
-       $errormessage = $Lang::tr{'invalid key'};
-    }
+       &General::readhash("${General::swroot}/vpn/settings", \%vpnsettings);
+       &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
+
+       if ($confighash{$cgiparams{'KEY'}}) {
+               system('/usr/local/bin/ipsecctrl', 'D', $cgiparams{'KEY'}) if (&vpnenabled);
+               unlink ("${General::swroot}/certs/$confighash{$cgiparams{'KEY'}}[1]cert.pem");
+               unlink ("${General::swroot}/certs/$confighash{$cgiparams{'KEY'}}[1].p12");
+               delete $confighash{$cgiparams{'KEY'}};
+               &General::writehasharray("${General::swroot}/vpn/config", \%confighash);
+               &writeipsecfiles();
+       } else {
+               $errormessage = $Lang::tr{'invalid key'};
+       }
        &General::firewall_reload();
 ###
 ### Choose between adding a host-net or net-net connection
@@ -1227,535 +1220,545 @@ END
        &Header::openbigbox('100%', 'left', '', '');
        &Header::openbox('100%', 'left', $Lang::tr{'connection type'});
        print <<END
-           <form method='post' action='$ENV{'SCRIPT_NAME'}'>
-           <b>$Lang::tr{'connection type'}:</b><br />
-           <table>
-           <tr><td><input type='radio' name='TYPE' value='host' checked='checked' /></td>
+               <form method='post' action='$ENV{'SCRIPT_NAME'}'>
+               <b>$Lang::tr{'connection type'}:</b><br />
+               <table>
+               <tr><td><input type='radio' name='TYPE' value='host' checked='checked' /></td>
                <td class='base'>$Lang::tr{'host to net vpn'}</td>
-           </tr><tr>
+               </tr><tr>
                <td><input type='radio' name='TYPE' value='net' /></td>
                <td class='base'>$Lang::tr{'net to net vpn'}</td>
-           </tr><tr>
+               </tr><tr>
                <td align='center' colspan='2'><input type='submit' name='ACTION' value='$Lang::tr{'add'}' /></td>
-           </tr>
-           </table></form>
+               </tr>
+               </table></form>
 END
-       ;
+;
        &Header::closebox();
        &Header::closebigbox();
        &Header::closepage();
        exit (0);
 ###
-### Adding/Editing/Saving a  connection
+### Adding/Editing/Saving a connection
 ###
 } elsif (($cgiparams{'ACTION'} eq $Lang::tr{'add'}) ||
-        ($cgiparams{'ACTION'} eq $Lang::tr{'edit'}) ||
-        ($cgiparams{'ACTION'} eq $Lang::tr{'save'} && $cgiparams{'ADVANCED'} eq '')) {
-
-    &General::readhash("${General::swroot}/vpn/settings", \%vpnsettings);
-    &General::readhasharray("${General::swroot}/vpn/caconfig", \%cahash);
-    &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
-
-    if ($cgiparams{'ACTION'} eq $Lang::tr{'edit'}) {
-       if (! $confighash{$cgiparams{'KEY'}}[0]) {
-           $errormessage = $Lang::tr{'invalid key'};
-           goto VPNCONF_END;
-       }
-       $cgiparams{'ENABLED'}           = $confighash{$cgiparams{'KEY'}}[0];
-       $cgiparams{'NAME'}              = $confighash{$cgiparams{'KEY'}}[1];
-       $cgiparams{'TYPE'}              = $confighash{$cgiparams{'KEY'}}[3];
-       $cgiparams{'AUTH'}              = $confighash{$cgiparams{'KEY'}}[4];
-       $cgiparams{'PSK'}               = $confighash{$cgiparams{'KEY'}}[5];
-       #$cgiparams{'free'}             = $confighash{$cgiparams{'KEY'}}[6];
-       $cgiparams{'LOCAL_ID'}          = $confighash{$cgiparams{'KEY'}}[7];
-       $cgiparams{'LOCAL_SUBNET'}      = $confighash{$cgiparams{'KEY'}}[8];
-       $cgiparams{'REMOTE_ID'}         = $confighash{$cgiparams{'KEY'}}[9];
-       $cgiparams{'REMOTE'}            = $confighash{$cgiparams{'KEY'}}[10];
-       $cgiparams{'REMOTE_SUBNET'}     = $confighash{$cgiparams{'KEY'}}[11];
-       $cgiparams{'REMARK'}            = $confighash{$cgiparams{'KEY'}}[25];
-       $cgiparams{'DPD_ACTION'}        = $confighash{$cgiparams{'KEY'}}[27];
-       $cgiparams{'IKE_VERSION'}       = $confighash{$cgiparams{'KEY'}}[29];
-       $cgiparams{'IKE_ENCRYPTION'}    = $confighash{$cgiparams{'KEY'}}[18];
-       $cgiparams{'IKE_INTEGRITY'}     = $confighash{$cgiparams{'KEY'}}[19];
-       $cgiparams{'IKE_GROUPTYPE'}     = $confighash{$cgiparams{'KEY'}}[20];
-       $cgiparams{'IKE_LIFETIME'}      = $confighash{$cgiparams{'KEY'}}[16];
-       $cgiparams{'ESP_ENCRYPTION'}    = $confighash{$cgiparams{'KEY'}}[21];
-       $cgiparams{'ESP_INTEGRITY'}     = $confighash{$cgiparams{'KEY'}}[22];
-       $cgiparams{'ESP_GROUPTYPE'}     = $confighash{$cgiparams{'KEY'}}[23];
-       if ($cgiparams{'ESP_GROUPTYPE'} eq "") {
-               $cgiparams{'ESP_GROUPTYPE'} = $cgiparams{'IKE_GROUPTYPE'};
-       }
-       $cgiparams{'ESP_KEYLIFE'}       = $confighash{$cgiparams{'KEY'}}[17];
-       $cgiparams{'COMPRESSION'}       = $confighash{$cgiparams{'KEY'}}[13];
-       $cgiparams{'ONLY_PROPOSED'}     = $confighash{$cgiparams{'KEY'}}[24];
-       $cgiparams{'PFS'}               = $confighash{$cgiparams{'KEY'}}[28];
-       $cgiparams{'VHOST'}             = $confighash{$cgiparams{'KEY'}}[14];
-       $cgiparams{'DPD_TIMEOUT'}               = $confighash{$cgiparams{'KEY'}}[30];
-       $cgiparams{'DPD_DELAY'}         = $confighash{$cgiparams{'KEY'}}[31];
-       $cgiparams{'FORCE_MOBIKE'}      = $confighash{$cgiparams{'KEY'}}[32];
+       ($cgiparams{'ACTION'} eq $Lang::tr{'edit'}) ||
+       ($cgiparams{'ACTION'} eq $Lang::tr{'save'} && $cgiparams{'ADVANCED'} eq '')) {
 
-       if (!$cgiparams{'DPD_DELAY'}) {
-               $cgiparams{'DPD_DELAY'} = 30;
-       }
+       &General::readhash("${General::swroot}/vpn/settings", \%vpnsettings);
+       &General::readhasharray("${General::swroot}/vpn/caconfig", \%cahash);
+       &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
 
-       if (!$cgiparams{'DPD_TIMEOUT'}) {
-               $cgiparams{'DPD_TIMEOUT'} = 120;
-       }
+       if ($cgiparams{'ACTION'} eq $Lang::tr{'edit'}) {
+               if (! $confighash{$cgiparams{'KEY'}}[0]) {
+                       $errormessage = $Lang::tr{'invalid key'};
+                       goto VPNCONF_END;
+               }
+               $cgiparams{'ENABLED'}                   = $confighash{$cgiparams{'KEY'}}[0];
+               $cgiparams{'NAME'}                              = $confighash{$cgiparams{'KEY'}}[1];
+               $cgiparams{'TYPE'}                              = $confighash{$cgiparams{'KEY'}}[3];
+               $cgiparams{'AUTH'}                              = $confighash{$cgiparams{'KEY'}}[4];
+               $cgiparams{'PSK'}                               = $confighash{$cgiparams{'KEY'}}[5];
+               #$cgiparams{'free'}                             = $confighash{$cgiparams{'KEY'}}[6];
+               $cgiparams{'LOCAL_ID'}                  = $confighash{$cgiparams{'KEY'}}[7];
+               my @local_subnets = split(",", $confighash{$cgiparams{'KEY'}}[8]);
+               $cgiparams{'LOCAL_SUBNET'}              = join(/\|/, @local_subnets);
+               $cgiparams{'REMOTE_ID'}                 = $confighash{$cgiparams{'KEY'}}[9];
+               $cgiparams{'REMOTE'}                    = $confighash{$cgiparams{'KEY'}}[10];
+               my @remote_subnets = split(",", $confighash{$cgiparams{'KEY'}}[11]);
+               $cgiparams{'REMOTE_SUBNET'}             = join(/\|/, @remote_subnets);
+               $cgiparams{'REMARK'}                    = $confighash{$cgiparams{'KEY'}}[25];
+               $cgiparams{'DPD_ACTION'}                = $confighash{$cgiparams{'KEY'}}[27];
+               $cgiparams{'IKE_VERSION'}               = $confighash{$cgiparams{'KEY'}}[29];
+               $cgiparams{'IKE_ENCRYPTION'}    = $confighash{$cgiparams{'KEY'}}[18];
+               $cgiparams{'IKE_INTEGRITY'}             = $confighash{$cgiparams{'KEY'}}[19];
+               $cgiparams{'IKE_GROUPTYPE'}             = $confighash{$cgiparams{'KEY'}}[20];
+               $cgiparams{'IKE_LIFETIME'}              = $confighash{$cgiparams{'KEY'}}[16];
+               $cgiparams{'ESP_ENCRYPTION'}    = $confighash{$cgiparams{'KEY'}}[21];
+               $cgiparams{'ESP_INTEGRITY'}             = $confighash{$cgiparams{'KEY'}}[22];
+               $cgiparams{'ESP_GROUPTYPE'}             = $confighash{$cgiparams{'KEY'}}[23];
+               if ($cgiparams{'ESP_GROUPTYPE'} eq "") {
+                       $cgiparams{'ESP_GROUPTYPE'}     = $cgiparams{'IKE_GROUPTYPE'};
+               }
+               $cgiparams{'ESP_KEYLIFE'}               = $confighash{$cgiparams{'KEY'}}[17];
+               $cgiparams{'COMPRESSION'}               = $confighash{$cgiparams{'KEY'}}[13];
+               $cgiparams{'ONLY_PROPOSED'}             = $confighash{$cgiparams{'KEY'}}[24];
+               $cgiparams{'PFS'}                               = $confighash{$cgiparams{'KEY'}}[28];
+               $cgiparams{'DPD_TIMEOUT'}               = $confighash{$cgiparams{'KEY'}}[30];
+               $cgiparams{'DPD_DELAY'}                 = $confighash{$cgiparams{'KEY'}}[31];
+               $cgiparams{'FORCE_MOBIKE'}              = $confighash{$cgiparams{'KEY'}}[32];
+
+               if (!$cgiparams{'DPD_DELAY'}) {
+                       $cgiparams{'DPD_DELAY'} = 30;
+               }
 
-    } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'save'}) {
-       $cgiparams{'REMARK'} = &Header::cleanhtml($cgiparams{'REMARK'});
-       if ($cgiparams{'TYPE'} !~ /^(host|net)$/) {
-           $errormessage = $Lang::tr{'connection type is invalid'};
-           goto VPNCONF_ERROR;
-       }
+               if (!$cgiparams{'DPD_TIMEOUT'}) {
+                       $cgiparams{'DPD_TIMEOUT'} = 120;
+               }
 
-       if ($cgiparams{'NAME'} !~ /^[a-zA-Z0-9]+$/) {
-           $errormessage = $Lang::tr{'name must only contain characters'};
-           goto VPNCONF_ERROR;
-       }
+       } elsif ($cgiparams{'ACTION'} eq $Lang::tr{'save'}) {
+               $cgiparams{'REMARK'} = &Header::cleanhtml($cgiparams{'REMARK'});
+               if ($cgiparams{'TYPE'} !~ /^(host|net)$/) {
+                       $errormessage = $Lang::tr{'connection type is invalid'};
+                       goto VPNCONF_ERROR;
+               }
 
-       if ($cgiparams{'NAME'} =~ /^(host|01|block|private|clear|packetdefault)$/) {
-           $errormessage = $Lang::tr{'name is invalid'};
-           goto VPNCONF_ERROR;
-       }
+               if ($cgiparams{'NAME'} !~ /^[a-zA-Z0-9]+$/) {
+                       $errormessage = $Lang::tr{'name must only contain characters'};
+                       goto VPNCONF_ERROR;
+               }
 
-       if (length($cgiparams{'NAME'}) >60) {
-           $errormessage = $Lang::tr{'name too long'};
-           goto VPNCONF_ERROR;
-       }
+               if ($cgiparams{'NAME'} =~ /^(host|01|block|private|clear|packetdefault)$/) {
+                       $errormessage = $Lang::tr{'name is invalid'};
+                       goto VPNCONF_ERROR;
+               }
 
-       # Check if there is no other entry with this name
-       if (! $cgiparams{'KEY'}) {  #only for add
-           foreach my $key (keys %confighash) {
-               if ($confighash{$key}[1] eq $cgiparams{'NAME'}) {
-                   $errormessage = $Lang::tr{'a connection with this name already exists'};
-                   goto VPNCONF_ERROR;
+               if (length($cgiparams{'NAME'}) >60) {
+                       $errormessage = $Lang::tr{'name too long'};
+                       goto VPNCONF_ERROR;
                }
-           }
-       }
 
-       if (($cgiparams{'TYPE'} eq 'net') && (! $cgiparams{'REMOTE'})) {
-           $errormessage = $Lang::tr{'invalid input for remote host/ip'};
-           goto VPNCONF_ERROR;
-       }
+               # Check if there is no other entry with this name
+               if (! $cgiparams{'KEY'}) { #only for add
+                       foreach my $key (keys %confighash) {
+                               if ($confighash{$key}[1] eq $cgiparams{'NAME'}) {
+                                       $errormessage = $Lang::tr{'a connection with this name already exists'};
+                                       goto VPNCONF_ERROR;
+                               }
+                       }
+               }
 
-       if ($cgiparams{'REMOTE'}) {
-           if (($cgiparams{'REMOTE'} ne '%any') && (! &General::validip($cgiparams{'REMOTE'}))) {
-               if (! &General::validfqdn ($cgiparams{'REMOTE'}))  {
-                   $errormessage = $Lang::tr{'invalid input for remote host/ip'};
-                   goto VPNCONF_ERROR;
-               } else {
-                   if (&valid_dns_host($cgiparams{'REMOTE'})) {
-                       $warnmessage = "$Lang::tr{'check vpn lr'} $cgiparams{'REMOTE'}. $Lang::tr{'dns check failed'}";
-                   }
+               if (($cgiparams{'TYPE'} eq 'net') && (! $cgiparams{'REMOTE'})) {
+                       $errormessage = $Lang::tr{'invalid input for remote host/ip'};
+                       goto VPNCONF_ERROR;
                }
-           }
-       }
 
-        unless (&General::validipandmask($cgiparams{'LOCAL_SUBNET'})) {
-            $errormessage = $Lang::tr{'local subnet is invalid'};
-           goto VPNCONF_ERROR;
-       }
+               if ($cgiparams{'REMOTE'}) {
+                       if (($cgiparams{'REMOTE'} ne '%any') && (! &General::validip($cgiparams{'REMOTE'}))) {
+                               if (! &General::validfqdn ($cgiparams{'REMOTE'})) {
+                                       $errormessage = $Lang::tr{'invalid input for remote host/ip'};
+                                       goto VPNCONF_ERROR;
+                               } else {
+                                       if (&valid_dns_host($cgiparams{'REMOTE'})) {
+                                               $warnmessage = "$Lang::tr{'check vpn lr'} $cgiparams{'REMOTE'}. $Lang::tr{'dns check failed'}";
+                                       }
+                               }
+                       }
+               }
 
-       # Allow only one roadwarrior/psk without remote IP-address
-       if ($cgiparams{'REMOTE'} eq '' && $cgiparams{'AUTH'} eq 'psk') {
-           foreach my $key (keys %confighash) {
-               if ( ($cgiparams{'KEY'} ne $key) && 
-                     ($confighash{$key}[4] eq 'psk') && 
-                     ($confighash{$key}[10] eq '') ) {
-                       $errormessage = $Lang::tr{'you can only define one roadwarrior connection when using pre-shared key authentication'};
-                       goto VPNCONF_ERROR;
+               my @local_subnets = split(",", $cgiparams{'LOCAL_SUBNET'});
+               foreach my $subnet (@local_subnets) {
+                       unless (&Network::check_subnet($subnet)) {
+                               $errormessage = $Lang::tr{'local subnet is invalid'};
+                               goto VPNCONF_ERROR;
+                       }
                }
-           }
-       }
-       if (($cgiparams{'TYPE'} eq 'net') && (! &General::validipandmask($cgiparams{'REMOTE_SUBNET'}))) {
-            $errormessage = $Lang::tr{'remote subnet is invalid'};
-           goto VPNCONF_ERROR;
-       }
 
-       if ($cgiparams{'ENABLED'} !~ /^(on|off)$/) {
-           $errormessage = $Lang::tr{'invalid input'};
-           goto VPNCONF_ERROR;
-       }
-       if ($cgiparams{'EDIT_ADVANCED'} !~ /^(on|off)$/) {
-           $errormessage = $Lang::tr{'invalid input'};
-           goto VPNCONF_ERROR;
-       }
+               # Allow only one roadwarrior/psk without remote IP-address
+               if ($cgiparams{'REMOTE'} eq '' && $cgiparams{'AUTH'} eq 'psk') {
+                       foreach my $key (keys %confighash) {
+                               if ( ($cgiparams{'KEY'} ne $key) &&
+                                       ($confighash{$key}[4] eq 'psk') &&
+                                       ($confighash{$key}[10] eq '') ) {
+                                       $errormessage = $Lang::tr{'you can only define one roadwarrior connection when using pre-shared key authentication'};
+                                       goto VPNCONF_ERROR;
+                               }
+                       }
+               }
 
-       # Allow nothing or a string (DN,FDQN,) beginning with @
-       # with no comma but slashes between RID eg @O=FR/C=Paris/OU=myhome/CN=franck
-       if ( ($cgiparams{'LOCAL_ID'} !~ /^(|[\w.-]*@[\w. =*\/-]+|\d+\.\d+\.\d+\.\d+)$/) ||
-           ($cgiparams{'REMOTE_ID'} !~ /^(|[\w.-]*@[\w. =*\/-]+|\d+\.\d+\.\d+\.\d+)$/) ||
-           (($cgiparams{'REMOTE_ID'} eq $cgiparams{'LOCAL_ID'}) && ($cgiparams{'LOCAL_ID'} ne ''))
-          ) {
-           $errormessage = $Lang::tr{'invalid local-remote id'} . '<br />' .
-           'DER_ASN1_DN: @c=FR/ou=Paris/ou=Home/cn=*<br />' .
-           'FQDN: @ipfire.org<br />' .
-           'USER_FQDN: info@ipfire.org<br />' .
-           'IPV4_ADDR: 123.123.123.123';
-           goto VPNCONF_ERROR;
-       }
-       # If Auth is DN, verify existance of Remote ID.
-       if ( $cgiparams{'REMOTE_ID'} eq '' && (
-               $cgiparams{'AUTH'} eq 'auth-dn'||                  # while creation
-               $confighash{$cgiparams{'KEY'}}[2] eq '%auth-dn')){ # while editing
-           $errormessage = $Lang::tr{'vpn missing remote id'};
-           goto VPNCONF_ERROR;
-       }
+               if ($cgiparams{'TYPE'} eq 'net') {
+                       my @remote_subnets = split(",", $cgiparams{'REMOTE_SUBNET'});
+                       foreach my $subnet (@remote_subnets) {
+                               unless (&Network::check_subnet($subnet)) {
+                                       $errormessage = $Lang::tr{'remote subnet is invalid'};
+                                       goto VPNCONF_ERROR;
+                               }
+                       }
+               }
 
-       if ($cgiparams{'TYPE'} eq 'net'){
-               $warnmessage=&General::checksubnets('',$cgiparams{'REMOTE_SUBNET'},'ipsec');
-               if ($warnmessage ne ''){
-                       $warnmessage=$Lang::tr{'remote subnet'}." ($cgiparams{'REMOTE_SUBNET'}) <br>".$warnmessage;
+               if ($cgiparams{'ENABLED'} !~ /^(on|off)$/) {
+                       $errormessage = $Lang::tr{'invalid input'};
+                       goto VPNCONF_ERROR;
+               }
+               if ($cgiparams{'EDIT_ADVANCED'} !~ /^(on|off)$/) {
+                       $errormessage = $Lang::tr{'invalid input'};
+                       goto VPNCONF_ERROR;
                }
-       }
 
-       if ($cgiparams{'AUTH'} eq 'psk') {
-           if (! length($cgiparams{'PSK'}) ) {
-               $errormessage = $Lang::tr{'pre-shared key is too short'};
-               goto VPNCONF_ERROR;
-           }
-           if ($cgiparams{'PSK'} =~ /'/) {
-                $cgiparams{'PSK'} =~ tr/'/ /;
-               $errormessage = $Lang::tr{'invalid characters found in pre-shared key'};
-               goto VPNCONF_ERROR;
-           }
+               # Allow nothing or a string (DN,FDQN,) beginning with @
+               # with no comma but slashes between RID eg @O=FR/C=Paris/OU=myhome/CN=franck
+               if ( ($cgiparams{'LOCAL_ID'} !~ /^(|[\w.-]*@[\w. =*\/-]+|\d+\.\d+\.\d+\.\d+)$/) ||
+                       ($cgiparams{'REMOTE_ID'} !~ /^(|[\w.-]*@[\w. =*\/-]+|\d+\.\d+\.\d+\.\d+)$/) ||
+                       (($cgiparams{'REMOTE_ID'} eq $cgiparams{'LOCAL_ID'}) && ($cgiparams{'LOCAL_ID'} ne ''))
+               ) {
+                       $errormessage = $Lang::tr{'invalid local-remote id'} . '<br />' .
+                       'DER_ASN1_DN: @c=FR/ou=Paris/ou=Home/cn=*<br />' .
+                       'FQDN: @ipfire.org<br />' .
+                       'USER_FQDN: info@ipfire.org<br />' .
+                       'IPV4_ADDR: 123.123.123.123';
+                       goto VPNCONF_ERROR;
+               }
+               # If Auth is DN, verify existance of Remote ID.
+               if ( $cgiparams{'REMOTE_ID'} eq '' && (
+                       $cgiparams{'AUTH'} eq 'auth-dn'|| # while creation
+                       $confighash{$cgiparams{'KEY'}}[2] eq '%auth-dn')){ # while editing
+                               $errormessage = $Lang::tr{'vpn missing remote id'};
+                               goto VPNCONF_ERROR;
+               }
+
+               if ($cgiparams{'TYPE'} eq 'net'){
+                       $warnmessage=&General::checksubnets('',$cgiparams{'REMOTE_SUBNET'},'ipsec');
+                       if ($warnmessage ne ''){
+                               $warnmessage=$Lang::tr{'remote subnet'}." ($cgiparams{'REMOTE_SUBNET'}) <br>".$warnmessage;
+                       }
+               }
+
+               if ($cgiparams{'AUTH'} eq 'psk') {
+                       if (! length($cgiparams{'PSK'}) ) {
+                               $errormessage = $Lang::tr{'pre-shared key is too short'};
+                               goto VPNCONF_ERROR;
+                       }
+                       if ($cgiparams{'PSK'} =~ /'/) {
+                               $cgiparams{'PSK'} =~ tr/'/ /;
+                               $errormessage = $Lang::tr{'invalid characters found in pre-shared key'};
+                               goto VPNCONF_ERROR;
+                       }
        } elsif ($cgiparams{'AUTH'} eq 'certreq') {
-           if ($cgiparams{'KEY'}) {
-               $errormessage = $Lang::tr{'cant change certificates'};
-               goto VPNCONF_ERROR;
-           }
-           if (ref ($cgiparams{'FH'}) ne 'Fh') {
-               $errormessage = $Lang::tr{'there was no file upload'};
-               goto VPNCONF_ERROR;
-           }
+               if ($cgiparams{'KEY'}) {
+                       $errormessage = $Lang::tr{'cant change certificates'};
+                       goto VPNCONF_ERROR;
+               }
+               if (ref ($cgiparams{'FH'}) ne 'Fh') {
+                       $errormessage = $Lang::tr{'there was no file upload'};
+                       goto VPNCONF_ERROR;
+               }
 
-           # Move uploaded certificate request to a temporary file
-           (my $fh, my $filename) = tempfile( );
-           if (copy ($cgiparams{'FH'}, $fh) != 1) {
-               $errormessage = $!;
-               goto VPNCONF_ERROR;
-           }
+               # Move uploaded certificate request to a temporary file
+               (my $fh, my $filename) = tempfile( );
+               if (copy ($cgiparams{'FH'}, $fh) != 1) {
+                       $errormessage = $!;
+                       goto VPNCONF_ERROR;
+               }
 
-           # Sign the certificate request
-           &General::log("ipsec", "Signing your cert $cgiparams{'NAME'}...");
-           my  $opt  = " ca -md sha256 -days 999999";
+               # Sign the certificate request
+               &General::log("ipsec", "Signing your cert $cgiparams{'NAME'}...");
+               my $opt = " ca -md sha256 -days 999999";
                $opt .= " -batch -notext";
                $opt .= " -in $filename";
                $opt .= " -out ${General::swroot}/certs/$cgiparams{'NAME'}cert.pem";
 
-           if ( $errormessage = &callssl ($opt) ) {
-               unlink ($filename);
-               unlink ("${General::swroot}/certs/$cgiparams{'NAME'}cert.pem");
-               &cleanssldatabase();
-               goto VPNCONF_ERROR;
-           } else {
-               unlink ($filename);
-               &cleanssldatabase();
-           }
-
-           $cgiparams{'CERT_NAME'} = getCNfromcert ("${General::swroot}/certs/$cgiparams{'NAME'}cert.pem");
-           if ($cgiparams{'CERT_NAME'} eq '') {
-               $errormessage = $Lang::tr{'could not retrieve common name from certificate'};
-               goto VPNCONF_ERROR;
-           }
+               if ( $errormessage = &callssl ($opt) ) {
+                       unlink ($filename);
+                       unlink ("${General::swroot}/certs/$cgiparams{'NAME'}cert.pem");
+                       &cleanssldatabase();
+                       goto VPNCONF_ERROR;
+               } else {
+                       unlink ($filename);
+                       &cleanssldatabase();
+               }
+
+               $cgiparams{'CERT_NAME'} = getCNfromcert ("${General::swroot}/certs/$cgiparams{'NAME'}cert.pem");
+               if ($cgiparams{'CERT_NAME'} eq '') {
+                       $errormessage = $Lang::tr{'could not retrieve common name from certificate'};
+                       goto VPNCONF_ERROR;
+               }
        } elsif ($cgiparams{'AUTH'} eq 'pkcs12') {
                &General::log("ipsec", "Importing from p12...");
 
                if (ref ($cgiparams{'FH'}) ne 'Fh') {
-                   $errormessage = $Lang::tr{'there was no file upload'};
-                   goto ROOTCERT_ERROR;
+                       $errormessage = $Lang::tr{'there was no file upload'};
+                       goto ROOTCERT_ERROR;
                }
 
                # Move uploaded certificate request to a temporary file
                (my $fh, my $filename) = tempfile( );
                if (copy ($cgiparams{'FH'}, $fh) != 1) {
-                   $errormessage = $!;
-                   goto ROOTCERT_ERROR;
+                       $errormessage = $!;
+                       goto ROOTCERT_ERROR;
                }
 
                # Extract the CA certificate from the file
                &General::log("ipsec", "Extracting caroot from p12...");
                if (open(STDIN, "-|")) {
-                   my  $opt  = " pkcs12 -cacerts -nokeys";
+                       my $opt = " pkcs12 -cacerts -nokeys";
                        $opt .= " -in $filename";
                        $opt .= " -out /tmp/newcacert";
-                   $errormessage = &callssl ($opt);
-               } else {        #child
-                   print "$cgiparams{'P12_PASS'}\n";
-                   exit (0);
-               }
-
-               # Extract the Host certificate from the file
-               if (!$errormessage) {
-                   &General::log("ipsec", "Extracting host cert from p12...");
-                   if (open(STDIN, "-|")) {
-                       my  $opt  = " pkcs12 -clcerts -nokeys";
-                       $opt .= " -in $filename";
-                       $opt .= " -out /tmp/newhostcert";
                        $errormessage = &callssl ($opt);
-                   } else {    #child
+               } else { #child
                        print "$cgiparams{'P12_PASS'}\n";
                        exit (0);
-                   }
-               }
-
-               if (!$errormessage) {           
-                   &General::log("ipsec", "Moving cacert...");
-                   #If CA have new subject, add it to our list of CA
-                   my $casubject = &Header::cleanhtml(getsubjectfromcert ('/tmp/newcacert'));
-                   my @names;
-                   foreach my $x (keys %cahash) {
-                       $casubject='' if ($cahash{$x}[1] eq $casubject);
-                       unshift (@names,$cahash{$x}[0]);
-                   }
-                   if ($casubject) { # a new one!
-                       my $temp = `/usr/bin/openssl x509 -text -in /tmp/newcacert`;
-                       if ($temp !~ /CA:TRUE/i) {
-                           $errormessage = $Lang::tr{'not a valid ca certificate'};
-                       } else {
-                           #compute a name for it
-                           my $idx=0;
-                           while (grep(/Imported-$idx/, @names) ) {$idx++};
-                           $cgiparams{'CA_NAME'}="Imported-$idx";
-                           $cgiparams{'CERT_NAME'}=&Header::cleanhtml(getCNfromcert ('/tmp/newhostcert'));
-                           move("/tmp/newcacert", "${General::swroot}/ca/$cgiparams{'CA_NAME'}cert.pem");
-                           $errormessage = "$Lang::tr{'certificate file move failed'}: $!" if ($? ne 0);
-                           if (!$errormessage) {
-                               my $key = &General::findhasharraykey (\%cahash);
-                               $cahash{$key}[0] = $cgiparams{'CA_NAME'};
-                               $cahash{$key}[1] = $casubject;
-                               &General::writehasharray("${General::swroot}/vpn/caconfig", \%cahash);
-                               system('/usr/local/bin/ipsecctrl', 'R');
-                           }
-                       }
-                   }   
+               }
+
+               # Extract the Host certificate from the file
+               if (!$errormessage) {
+                       &General::log("ipsec", "Extracting host cert from p12...");
+                       if (open(STDIN, "-|")) {
+                               my $opt = " pkcs12 -clcerts -nokeys";
+                               $opt .= " -in $filename";
+                               $opt .= " -out /tmp/newhostcert";
+                               $errormessage = &callssl ($opt);
+                       } else { #child
+                               print "$cgiparams{'P12_PASS'}\n";
+                               exit (0);
+                       }
+               }
+
+               if (!$errormessage) {
+                       &General::log("ipsec", "Moving cacert...");
+                       #If CA have new subject, add it to our list of CA
+                       my $casubject = &Header::cleanhtml(getsubjectfromcert ('/tmp/newcacert'));
+                       my @names;
+                       foreach my $x (keys %cahash) {
+                               $casubject='' if ($cahash{$x}[1] eq $casubject);
+                               unshift (@names,$cahash{$x}[0]);
+                       }
+                       if ($casubject) { # a new one!
+                               my $temp = `/usr/bin/openssl x509 -text -in /tmp/newcacert`;
+                               if ($temp !~ /CA:TRUE/i) {
+                                       $errormessage = $Lang::tr{'not a valid ca certificate'};
+                               } else {
+                                       #compute a name for it
+                                       my $idx=0;
+                                       while (grep(/Imported-$idx/, @names) ) {$idx++};
+                                       $cgiparams{'CA_NAME'}="Imported-$idx";
+                                       $cgiparams{'CERT_NAME'}=&Header::cleanhtml(getCNfromcert ('/tmp/newhostcert'));
+                                       move("/tmp/newcacert", "${General::swroot}/ca/$cgiparams{'CA_NAME'}cert.pem");
+                                       $errormessage = "$Lang::tr{'certificate file move failed'}: $!" if ($? ne 0);
+                                       if (!$errormessage) {
+                                               my $key = &General::findhasharraykey (\%cahash);
+                                               $cahash{$key}[0] = $cgiparams{'CA_NAME'};
+                                               $cahash{$key}[1] = $casubject;
+                                               &General::writehasharray("${General::swroot}/vpn/caconfig", \%cahash);
+                                               system('/usr/local/bin/ipsecctrl', 'R');
+                                       }
+                               }
+                       }
                }
                if (!$errormessage) {
-                   &General::log("ipsec", "Moving host cert...");
-                   move("/tmp/newhostcert", "${General::swroot}/certs/$cgiparams{'NAME'}cert.pem");
-                   $errormessage = "$Lang::tr{'certificate file move failed'}: $!" if ($? ne 0);
-               }
+                       &General::log("ipsec", "Moving host cert...");
+                       move("/tmp/newhostcert", "${General::swroot}/certs/$cgiparams{'NAME'}cert.pem");
+                       $errormessage = "$Lang::tr{'certificate file move failed'}: $!" if ($? ne 0);
+               }
 
                #cleanup temp files
                unlink ($filename);
                unlink ('/tmp/newcacert');
                unlink ('/tmp/newhostcert');
                if ($errormessage) {
-                   unlink ("${General::swroot}/ca/$cgiparams{'CA_NAME'}cert.pem");
-                   unlink ("${General::swroot}/certs/$cgiparams{'NAME'}cert.pem");
-                   goto VPNCONF_ERROR;
+                       unlink ("${General::swroot}/ca/$cgiparams{'CA_NAME'}cert.pem");
+                       unlink ("${General::swroot}/certs/$cgiparams{'NAME'}cert.pem");
+                       goto VPNCONF_ERROR;
                }
                &General::log("ipsec", "p12 import completed!");
        } elsif ($cgiparams{'AUTH'} eq 'certfile') {
-           if ($cgiparams{'KEY'}) {
-               $errormessage = $Lang::tr{'cant change certificates'};
-               goto VPNCONF_ERROR;
-           }
-           if (ref ($cgiparams{'FH'}) ne 'Fh') {
-               $errormessage = $Lang::tr{'there was no file upload'};
-               goto VPNCONF_ERROR;
-           }
-           # Move uploaded certificate to a temporary file
-           (my $fh, my $filename) = tempfile( );
-           if (copy ($cgiparams{'FH'}, $fh) != 1) {
-               $errormessage = $!;
-               goto VPNCONF_ERROR;
-           }
-
-           # Verify the certificate has a valid CA and move it
-           &General::log("ipsec", "Validating imported cert against our known CA...");
-           my $validca = 1;  #assume ok
-           my $test = `/usr/bin/openssl verify -CAfile ${General::swroot}/ca/cacert.pem $filename`;
-           if ($test !~ /: OK/) {
-               my $validca = 0;
-               foreach my $key (keys %cahash) {
-                   $test = `/usr/bin/openssl verify -CAfile ${General::swroot}/ca/$cahash{$key}[0]cert.pem $filename`;
-                   if ($test =~ /: OK/) {
-                       $validca = 1;
-                       last;
-                   }
-               }
-           }
-           if (! $validca) {
-               $errormessage = $Lang::tr{'certificate does not have a valid ca associated with it'};
-               unlink ($filename);
-               goto VPNCONF_ERROR;
-           } else {
-               move($filename, "${General::swroot}/certs/$cgiparams{'NAME'}cert.pem");
-               if ($? ne 0) {
-                   $errormessage = "$Lang::tr{'certificate file move failed'}: $!";
-                   unlink ($filename);
-                   goto VPNCONF_ERROR;
+               if ($cgiparams{'KEY'}) {
+                       $errormessage = $Lang::tr{'cant change certificates'};
+                       goto VPNCONF_ERROR;
+               }
+               if (ref ($cgiparams{'FH'}) ne 'Fh') {
+                       $errormessage = $Lang::tr{'there was no file upload'};
+                       goto VPNCONF_ERROR;
+               }
+               # Move uploaded certificate to a temporary file
+               (my $fh, my $filename) = tempfile( );
+               if (copy ($cgiparams{'FH'}, $fh) != 1) {
+                       $errormessage = $!;
+                       goto VPNCONF_ERROR;
                }
-           }
 
-           $cgiparams{'CERT_NAME'} = getCNfromcert ("${General::swroot}/certs/$cgiparams{'NAME'}cert.pem");
-           if ($cgiparams{'CERT_NAME'} eq '') {
-               unlink ("${General::swroot}/certs/$cgiparams{'NAME'}cert.pem");
-               $errormessage = $Lang::tr{'could not retrieve common name from certificate'};
-               goto VPNCONF_ERROR;
-           }
+               # Verify the certificate has a valid CA and move it
+               &General::log("ipsec", "Validating imported cert against our known CA...");
+               my $validca = 1; #assume ok
+               my $test = `/usr/bin/openssl verify -CAfile ${General::swroot}/ca/cacert.pem $filename`;
+               if ($test !~ /: OK/) {
+                       my $validca = 0;
+                       foreach my $key (keys %cahash) {
+                               $test = `/usr/bin/openssl verify -CAfile ${General::swroot}/ca/$cahash{$key}[0]cert.pem $filename`;
+                               if ($test =~ /: OK/) {
+                                       $validca = 1;
+                                       last;
+                               }
+                       }
+               }
+               if (! $validca) {
+                       $errormessage = $Lang::tr{'certificate does not have a valid ca associated with it'};
+                       unlink ($filename);
+                       goto VPNCONF_ERROR;
+               } else {
+                       move($filename, "${General::swroot}/certs/$cgiparams{'NAME'}cert.pem");
+                       if ($? ne 0) {
+                               $errormessage = "$Lang::tr{'certificate file move failed'}: $!";
+                               unlink ($filename);
+                               goto VPNCONF_ERROR;
+                       }
+               }
+
+               $cgiparams{'CERT_NAME'} = getCNfromcert ("${General::swroot}/certs/$cgiparams{'NAME'}cert.pem");
+               if ($cgiparams{'CERT_NAME'} eq '') {
+                       unlink ("${General::swroot}/certs/$cgiparams{'NAME'}cert.pem");
+                       $errormessage = $Lang::tr{'could not retrieve common name from certificate'};
+                       goto VPNCONF_ERROR;
+               }
        } elsif ($cgiparams{'AUTH'} eq 'certgen') {
-           if ($cgiparams{'KEY'}) {
-               $errormessage = $Lang::tr{'cant change certificates'};
-               goto VPNCONF_ERROR;
-           }
-           # Validate input since the form was submitted
-           if (length($cgiparams{'CERT_NAME'}) >60) {
-               $errormessage = $Lang::tr{'name too long'};
-               goto VPNCONF_ERROR;
-           }
-           if ($cgiparams{'CERT_NAME'} !~ /^[a-zA-Z0-9 ,\.\-_]+$/) {
-               $errormessage = $Lang::tr{'invalid input for name'};
-               goto VPNCONF_ERROR;
-           }
-           if ($cgiparams{'CERT_EMAIL'} ne '' && (! &General::validemail($cgiparams{'CERT_EMAIL'}))) {
-               $errormessage = $Lang::tr{'invalid input for e-mail address'};
-               goto VPNCONF_ERROR;
-           }
-           if (length($cgiparams{'CERT_EMAIL'}) > 40) {
-               $errormessage = $Lang::tr{'e-mail address too long'};
-               goto VPNCONF_ERROR;
-           }
-           if ($cgiparams{'CERT_OU'} ne '' && $cgiparams{'CERT_OU'} !~ /^[a-zA-Z0-9 ,\.\-_]*$/) {
-               $errormessage = $Lang::tr{'invalid input for department'};
-               goto VPNCONF_ERROR;
-           }
-           if (length($cgiparams{'CERT_ORGANIZATION'}) >60) {
-               $errormessage = $Lang::tr{'organization too long'};
-               goto VPNCONF_ERROR;
-           }
-           if ($cgiparams{'CERT_ORGANIZATION'} !~ /^[a-zA-Z0-9 ,\.\-_]+$/) {
-               $errormessage = $Lang::tr{'invalid input for organization'};
-               goto VPNCONF_ERROR;
-           }
-           if ($cgiparams{'CERT_CITY'} ne '' && $cgiparams{'CERT_CITY'} !~ /^[a-zA-Z0-9 ,\.\-_]*$/) {
-               $errormessage = $Lang::tr{'invalid input for city'};
-               goto VPNCONF_ERROR;
-           }
-           if ($cgiparams{'CERT_STATE'} ne '' && $cgiparams{'CERT_STATE'} !~ /^[a-zA-Z0-9 ,\.\-_]*$/) {
-               $errormessage = $Lang::tr{'invalid input for state or province'};
-               goto VPNCONF_ERROR;
-           }
-           if ($cgiparams{'CERT_COUNTRY'} !~ /^[A-Z]*$/) {
-               $errormessage = $Lang::tr{'invalid input for country'};
-               goto VPNCONF_ERROR;
-           }
-           #the exact syntax is a list comma separated of 
-           #  email:any-validemail
-           #   URI: a uniform resource indicator
-           #   DNS: a DNS domain name
-           #   RID: a registered OBJECT IDENTIFIER
-           #   IP: an IP address
-           # example: email:franck@foo.com,IP:10.0.0.10,DNS:franck.foo.com
-
-           if ($cgiparams{'SUBJECTALTNAME'} ne '' && $cgiparams{'SUBJECTALTNAME'} !~ /^(email|URI|DNS|RID|IP):[a-zA-Z0-9 :\/,\.\-_@]*$/) {
-               $errormessage = $Lang::tr{'vpn altname syntax'};
-               goto VPNCONF_ERROR;
-           }
+               if ($cgiparams{'KEY'}) {
+                       $errormessage = $Lang::tr{'cant change certificates'};
+                       goto VPNCONF_ERROR;
+               }
+               # Validate input since the form was submitted
+               if (length($cgiparams{'CERT_NAME'}) >60) {
+                       $errormessage = $Lang::tr{'name too long'};
+                       goto VPNCONF_ERROR;
+               }
+               if ($cgiparams{'CERT_NAME'} !~ /^[a-zA-Z0-9 ,\.\-_]+$/) {
+                       $errormessage = $Lang::tr{'invalid input for name'};
+                       goto VPNCONF_ERROR;
+               }
+               if ($cgiparams{'CERT_EMAIL'} ne '' && (! &General::validemail($cgiparams{'CERT_EMAIL'}))) {
+                       $errormessage = $Lang::tr{'invalid input for e-mail address'};
+                       goto VPNCONF_ERROR;
+               }
+               if (length($cgiparams{'CERT_EMAIL'}) > 40) {
+                       $errormessage = $Lang::tr{'e-mail address too long'};
+                       goto VPNCONF_ERROR;
+               }
+               if ($cgiparams{'CERT_OU'} ne '' && $cgiparams{'CERT_OU'} !~ /^[a-zA-Z0-9 ,\.\-_]*$/) {
+                       $errormessage = $Lang::tr{'invalid input for department'};
+                       goto VPNCONF_ERROR;
+               }
+               if (length($cgiparams{'CERT_ORGANIZATION'}) >60) {
+                       $errormessage = $Lang::tr{'organization too long'};
+                       goto VPNCONF_ERROR;
+               }
+               if ($cgiparams{'CERT_ORGANIZATION'} !~ /^[a-zA-Z0-9 ,\.\-_]+$/) {
+                       $errormessage = $Lang::tr{'invalid input for organization'};
+                       goto VPNCONF_ERROR;
+               }
+               if ($cgiparams{'CERT_CITY'} ne '' && $cgiparams{'CERT_CITY'} !~ /^[a-zA-Z0-9 ,\.\-_]*$/) {
+                       $errormessage = $Lang::tr{'invalid input for city'};
+                       goto VPNCONF_ERROR;
+               }
+               if ($cgiparams{'CERT_STATE'} ne '' && $cgiparams{'CERT_STATE'} !~ /^[a-zA-Z0-9 ,\.\-_]*$/) {
+                       $errormessage = $Lang::tr{'invalid input for state or province'};
+                       goto VPNCONF_ERROR;
+               }
+               if ($cgiparams{'CERT_COUNTRY'} !~ /^[A-Z]*$/) {
+                       $errormessage = $Lang::tr{'invalid input for country'};
+                       goto VPNCONF_ERROR;
+               }
+               #the exact syntax is a list comma separated of
+               #       email:any-validemail
+               #       URI: a uniform resource indicator
+               #       DNS: a DNS domain name
+               #       RID: a registered OBJECT IDENTIFIER
+               #       IP: an IP address
+               # example: email:franck@foo.com,IP:10.0.0.10,DNS:franck.foo.com
+
+               if ($cgiparams{'SUBJECTALTNAME'} ne '' && $cgiparams{'SUBJECTALTNAME'} !~ /^(email|URI|DNS|RID|IP):[a-zA-Z0-9 :\/,\.\-_@]*$/) {
+                       $errormessage = $Lang::tr{'vpn altname syntax'};
+                       goto VPNCONF_ERROR;
+               }
 
-           if (length($cgiparams{'CERT_PASS1'}) < 5) {
-               $errormessage = $Lang::tr{'password too short'};
-               goto VPNCONF_ERROR;
-           }
-           if ($cgiparams{'CERT_PASS1'} ne $cgiparams{'CERT_PASS2'}) {
-               $errormessage = $Lang::tr{'passwords do not match'};
-               goto VPNCONF_ERROR;
-           }
+               if (length($cgiparams{'CERT_PASS1'}) < 5) {
+                       $errormessage = $Lang::tr{'password too short'};
+                       goto VPNCONF_ERROR;
+               }
+               if ($cgiparams{'CERT_PASS1'} ne $cgiparams{'CERT_PASS2'}) {
+                       $errormessage = $Lang::tr{'passwords do not match'};
+                       goto VPNCONF_ERROR;
+               }
 
-           # Replace empty strings with a .
-           (my $ou = $cgiparams{'CERT_OU'}) =~ s/^\s*$/\./;
-           (my $city = $cgiparams{'CERT_CITY'}) =~ s/^\s*$/\./;
-           (my $state = $cgiparams{'CERT_STATE'}) =~ s/^\s*$/\./;
+               # Replace empty strings with a .
+               (my $ou = $cgiparams{'CERT_OU'}) =~ s/^\s*$/\./;
+               (my $city = $cgiparams{'CERT_CITY'}) =~ s/^\s*$/\./;
+               (my $state = $cgiparams{'CERT_STATE'}) =~ s/^\s*$/\./;
 
-           # Create the Client certificate request
-           &General::log("ipsec", "Creating a cert...");
+               # Create the Client certificate request
+               &General::log("ipsec", "Creating a cert...");
 
-           if (open(STDIN, "-|")) {
-               my $opt  = " req -nodes -rand /proc/interrupts:/proc/net/rt_cache";
-                  $opt .= " -newkey rsa:2048";
-                  $opt .= " -keyout ${General::swroot}/certs/$cgiparams{'NAME'}key.pem";
-                  $opt .= " -out ${General::swroot}/certs/$cgiparams{'NAME'}req.pem";
+               if (open(STDIN, "-|")) {
+                       my $opt = " req -nodes -rand /proc/interrupts:/proc/net/rt_cache";
+                       $opt .= " -newkey rsa:2048";
+                       $opt .= " -keyout ${General::swroot}/certs/$cgiparams{'NAME'}key.pem";
+                       $opt .= " -out ${General::swroot}/certs/$cgiparams{'NAME'}req.pem";
+
+                       if ( $errormessage = &callssl ($opt) ) {
+                               unlink ("${General::swroot}/certs/$cgiparams{'NAME'}key.pem");
+                               unlink ("${General::swroot}/certs/$cgiparams{'NAME'}req.pem");
+                               goto VPNCONF_ERROR;
+                       }
+               } else { #child
+                       print "$cgiparams{'CERT_COUNTRY'}\n";
+                       print "$state\n";
+                       print "$city\n";
+                       print "$cgiparams{'CERT_ORGANIZATION'}\n";
+                       print "$ou\n";
+                       print "$cgiparams{'CERT_NAME'}\n";
+                       print "$cgiparams{'CERT_EMAIL'}\n";
+                       print ".\n";
+                       print ".\n";
+                       exit (0);
+               }
 
-               if ( $errormessage = &callssl ($opt) ) {
-                   unlink ("${General::swroot}/certs/$cgiparams{'NAME'}key.pem");
-                   unlink ("${General::swroot}/certs/$cgiparams{'NAME'}req.pem");
-                   goto VPNCONF_ERROR;
-               }
-           } else {    #child
-               print  "$cgiparams{'CERT_COUNTRY'}\n";
-               print  "$state\n";
-               print  "$city\n";
-               print  "$cgiparams{'CERT_ORGANIZATION'}\n";
-               print  "$ou\n";
-               print  "$cgiparams{'CERT_NAME'}\n";
-               print  "$cgiparams{'CERT_EMAIL'}\n";
-               print  ".\n";
-               print  ".\n";
-               exit (0);
-           }
-           
-           # Sign the client certificate request
-           &General::log("ipsec", "Signing the cert $cgiparams{'NAME'}...");
-
-           #No easy way for specifying the contain of subjectAltName without writing a config file...
-           my ($fh, $v3extname) = tempfile ('/tmp/XXXXXXXX');
-           print $fh <<END
-           basicConstraints=CA:FALSE
-           nsComment="OpenSSL Generated Certificate"
-           subjectKeyIdentifier=hash
-           extendedKeyUsage=clientAuth
-           authorityKeyIdentifier=keyid,issuer:always
+               # Sign the client certificate request
+               &General::log("ipsec", "Signing the cert $cgiparams{'NAME'}...");
+
+               #No easy way for specifying the contain of subjectAltName without writing a config file...
+               my ($fh, $v3extname) = tempfile ('/tmp/XXXXXXXX');
+               print $fh <<END
+               basicConstraints=CA:FALSE
+               nsComment="OpenSSL Generated Certificate"
+               subjectKeyIdentifier=hash
+               extendedKeyUsage=clientAuth
+               authorityKeyIdentifier=keyid,issuer:always
 END
 ;
-           print $fh "subjectAltName=$cgiparams{'SUBJECTALTNAME'}" if ($cgiparams{'SUBJECTALTNAME'});
-           close ($fh);
-
-           my $opt  = " ca -md sha256 -days 999999 -batch -notext";
-              $opt .= " -in ${General::swroot}/certs/$cgiparams{'NAME'}req.pem";
-              $opt .= " -out ${General::swroot}/certs/$cgiparams{'NAME'}cert.pem";
-              $opt .= " -extfile $v3extname";
-
-           if ( $errormessage = &callssl ($opt) ) {
-               unlink ($v3extname);
-               unlink ("${General::swroot}/certs/$cgiparams{'NAME'}key.pem");
-               unlink ("${General::swroot}/certs/$cgiparams{'NAME'}req.pem");
-               unlink ("${General::swroot}/certs/$cgiparams{'NAME'}cert.pem");
-               &cleanssldatabase();
-               goto VPNCONF_ERROR;
-           } else {
-               unlink ($v3extname);
-               unlink ("${General::swroot}/certs/$cgiparams{'NAME'}req.pem");
-               &cleanssldatabase();
-           }
-
-           # Create the pkcs12 file
-           &General::log("ipsec", "Packing a pkcs12 file...");
-              $opt  = " pkcs12 -export"; 
-              $opt .= " -inkey ${General::swroot}/certs/$cgiparams{'NAME'}key.pem";
-              $opt .= " -in ${General::swroot}/certs/$cgiparams{'NAME'}cert.pem";
-              $opt .= " -name \"$cgiparams{'NAME'}\"";
-              $opt .= " -passout pass:$cgiparams{'CERT_PASS1'}";
-              $opt .= " -certfile ${General::swroot}/ca/cacert.pem";
-              $opt .= " -caname \"$vpnsettings{'ROOTCERT_ORGANIZATION'} CA\"";
-              $opt .= " -out ${General::swroot}/certs/$cgiparams{'NAME'}.p12";
-
-           if ( $errormessage = &callssl ($opt) ) {
-               unlink ("${General::swroot}/certs/$cgiparams{'NAME'}key.pem");
-               unlink ("${General::swroot}/certs/$cgiparams{'NAME'}cert.pem");
-               unlink ("${General::swroot}/certs/$cgiparams{'NAME'}.p12");
-               goto VPNCONF_ERROR;
-           } else {
-               unlink ("${General::swroot}/certs/$cgiparams{'NAME'}key.pem");
-           }
+               print $fh "subjectAltName=$cgiparams{'SUBJECTALTNAME'}" if ($cgiparams{'SUBJECTALTNAME'});
+               close ($fh);
+
+               my $opt = " ca -md sha256 -days 999999 -batch -notext";
+               $opt .= " -in ${General::swroot}/certs/$cgiparams{'NAME'}req.pem";
+               $opt .= " -out ${General::swroot}/certs/$cgiparams{'NAME'}cert.pem";
+               $opt .= " -extfile $v3extname";
+
+               if ( $errormessage = &callssl ($opt) ) {
+                       unlink ($v3extname);
+                       unlink ("${General::swroot}/certs/$cgiparams{'NAME'}key.pem");
+                       unlink ("${General::swroot}/certs/$cgiparams{'NAME'}req.pem");
+                       unlink ("${General::swroot}/certs/$cgiparams{'NAME'}cert.pem");
+                       &cleanssldatabase();
+                       goto VPNCONF_ERROR;
+               } else {
+                       unlink ($v3extname);
+                       unlink ("${General::swroot}/certs/$cgiparams{'NAME'}req.pem");
+                       &cleanssldatabase();
+               }
+
+               # Create the pkcs12 file
+               &General::log("ipsec", "Packing a pkcs12 file...");
+               $opt = " pkcs12 -export";
+               $opt .= " -inkey ${General::swroot}/certs/$cgiparams{'NAME'}key.pem";
+               $opt .= " -in ${General::swroot}/certs/$cgiparams{'NAME'}cert.pem";
+               $opt .= " -name \"$cgiparams{'NAME'}\"";
+               $opt .= " -passout pass:$cgiparams{'CERT_PASS1'}";
+               $opt .= " -certfile ${General::swroot}/ca/cacert.pem";
+               $opt .= " -caname \"$vpnsettings{'ROOTCERT_ORGANIZATION'} CA\"";
+               $opt .= " -out ${General::swroot}/certs/$cgiparams{'NAME'}.p12";
+
+               if ( $errormessage = &callssl ($opt) ) {
+                       unlink ("${General::swroot}/certs/$cgiparams{'NAME'}key.pem");
+                       unlink ("${General::swroot}/certs/$cgiparams{'NAME'}cert.pem");
+                       unlink ("${General::swroot}/certs/$cgiparams{'NAME'}.p12");
+                       goto VPNCONF_ERROR;
+               } else {
+                       unlink ("${General::swroot}/certs/$cgiparams{'NAME'}key.pem");
+               }
        } elsif ($cgiparams{'AUTH'} eq 'cert') {
-           ;# Nothing, just editing
+               ;# Nothing, just editing
        } elsif ($cgiparams{'AUTH'} eq 'auth-dn') {
-           $cgiparams{'CERT_NAME'} = '%auth-dn';       # a special value saying 'no cert file'     
+               $cgiparams{'CERT_NAME'} = '%auth-dn'; # a special value saying 'no cert file'
        } else {
-           $errormessage = $Lang::tr{'invalid input for authentication method'};
-           goto VPNCONF_ERROR;
+               $errormessage = $Lang::tr{'invalid input for authentication method'};
+               goto VPNCONF_ERROR;
        }
 
        # 1)Error message here is not accurate.
@@ -1763,37 +1766,39 @@ END
        # 3)Present since initial version (1.3.2.11), it isn't a bug correction
        # Check if there is no other entry with this certificate name
        #if ((! $cgiparams{'KEY'}) && ($cgiparams{'AUTH'} ne 'psk') && ($cgiparams{'AUTH'} ne 'auth-dn')) {
-       #    foreach my $key (keys %confighash) {
+       #       foreach my $key (keys %confighash) {
        #       if ($confighash{$key}[2] eq $cgiparams{'CERT_NAME'}) {
-       #           $errormessage = $Lang::tr{'a connection with this common name already exists'};
-       #           goto VPNCONF_ERROR;
+       #               $errormessage = $Lang::tr{'a connection with this common name already exists'};
+       #               goto VPNCONF_ERROR;
+       #       }
        #       }
-       #    }
        #}
-        # Save the config
+               # Save the config
 
        my $key = $cgiparams{'KEY'};
        if (! $key) {
-           $key = &General::findhasharraykey (\%confighash);
-           foreach my $i (0 .. 32) { $confighash{$key}[$i] = "";}
+               $key = &General::findhasharraykey (\%confighash);
+               foreach my $i (0 .. 32) { $confighash{$key}[$i] = "";}
        }
        $confighash{$key}[0] = $cgiparams{'ENABLED'};
        $confighash{$key}[1] = $cgiparams{'NAME'};
        if ((! $cgiparams{'KEY'}) && $cgiparams{'AUTH'} ne 'psk') {
-           $confighash{$key}[2] = $cgiparams{'CERT_NAME'};
+               $confighash{$key}[2] = $cgiparams{'CERT_NAME'};
        }
        $confighash{$key}[3] = $cgiparams{'TYPE'};
        if ($cgiparams{'AUTH'} eq 'psk') {
-           $confighash{$key}[4] = 'psk';
-           $confighash{$key}[5] = $cgiparams{'PSK'};
+               $confighash{$key}[4] = 'psk';
+               $confighash{$key}[5] = $cgiparams{'PSK'};
        } else {
-           $confighash{$key}[4] = 'cert';
+               $confighash{$key}[4] = 'cert';
        }
        if ($cgiparams{'TYPE'} eq 'net') {
-           $confighash{$key}[11] = $cgiparams{'REMOTE_SUBNET'};
+               my @remote_subnets = split(",", $cgiparams{'REMOTE_SUBNET'});
+               $confighash{$key}[11] = join('|', @remote_subnets);
        }
        $confighash{$key}[7] = $cgiparams{'LOCAL_ID'};
-       $confighash{$key}[8] = $cgiparams{'LOCAL_SUBNET'};
+       my @local_subnets = split(",", $cgiparams{'LOCAL_SUBNET'});
+       $confighash{$key}[8] = join('|', @local_subnets);
        $confighash{$key}[9] = $cgiparams{'REMOTE_ID'};
        $confighash{$key}[10] = $cgiparams{'REMOTE'};
        $confighash{$key}[25] = $cgiparams{'REMARK'};
@@ -1801,7 +1806,7 @@ END
        $confighash{$key}[27] = $cgiparams{'DPD_ACTION'};
        $confighash{$key}[29] = $cgiparams{'IKE_VERSION'};
 
-       #dont forget advanced value
+       # don't forget advanced value
        $confighash{$key}[18] = $cgiparams{'IKE_ENCRYPTION'};
        $confighash{$key}[19] = $cgiparams{'IKE_INTEGRITY'};
        $confighash{$key}[20] = $cgiparams{'IKE_GROUPTYPE'};
@@ -1814,44 +1819,43 @@ END
        $confighash{$key}[13] = $cgiparams{'COMPRESSION'};
        $confighash{$key}[24] = $cgiparams{'ONLY_PROPOSED'};
        $confighash{$key}[28] = $cgiparams{'PFS'};
-       $confighash{$key}[14] = $cgiparams{'VHOST'};
        $confighash{$key}[30] = $cgiparams{'DPD_TIMEOUT'};
        $confighash{$key}[31] = $cgiparams{'DPD_DELAY'};
        $confighash{$key}[32] = $cgiparams{'FORCE_MOBIKE'};
 
-       #free unused fields!
+       # free unused fields!
        $confighash{$key}[6] = 'off';
        $confighash{$key}[15] = 'off';
 
        &General::writehasharray("${General::swroot}/vpn/config", \%confighash);
        &writeipsecfiles();
        if (&vpnenabled) {
-           system('/usr/local/bin/ipsecctrl', 'S', $key);
-           sleep $sleepDelay;
+               system('/usr/local/bin/ipsecctrl', 'S', $key);
+               sleep $sleepDelay;
        }
        if ($cgiparams{'EDIT_ADVANCED'} eq 'on') {
-           $cgiparams{'KEY'} = $key;
-           $cgiparams{'ACTION'} = $Lang::tr{'advanced'};
+               $cgiparams{'KEY'} = $key;
+               $cgiparams{'ACTION'} = $Lang::tr{'advanced'};
        }
        goto VPNCONF_END;
-    } else { # add new connection
-        $cgiparams{'ENABLED'} = 'on';
+} else { # add new connection
+       $cgiparams{'ENABLED'} = 'on';
        if ( ! -f "${General::swroot}/private/cakey.pem" ) {
-           $cgiparams{'AUTH'} = 'psk';
+               $cgiparams{'AUTH'} = 'psk';
        } elsif ( ! -f "${General::swroot}/ca/cacert.pem") {
-           $cgiparams{'AUTH'} = 'certfile';
+               $cgiparams{'AUTH'} = 'certfile';
        } else {
-            $cgiparams{'AUTH'} = 'certgen';
+               $cgiparams{'AUTH'} = 'certgen';
        }
-       $cgiparams{'LOCAL_SUBNET'}      ="$netsettings{'GREEN_NETADDRESS'}/$netsettings{'GREEN_NETMASK'}";
-       $cgiparams{'CERT_EMAIL'}        = $vpnsettings{'ROOTCERT_EMAIL'};
-       $cgiparams{'CERT_OU'}           = $vpnsettings{'ROOTCERT_OU'};
-       $cgiparams{'CERT_ORGANIZATION'} = $vpnsettings{'ROOTCERT_ORGANIZATION'};
-       $cgiparams{'CERT_CITY'}         = $vpnsettings{'ROOTCERT_CITY'};
-       $cgiparams{'CERT_STATE'}        = $vpnsettings{'ROOTCERT_STATE'};
-       $cgiparams{'CERT_COUNTRY'}      = $vpnsettings{'ROOTCERT_COUNTRY'};
+       $cgiparams{'LOCAL_SUBNET'}              = "$netsettings{'GREEN_NETADDRESS'}/$netsettings{'GREEN_NETMASK'}";
+       $cgiparams{'CERT_EMAIL'}                = $vpnsettings{'ROOTCERT_EMAIL'};
+       $cgiparams{'CERT_OU'}                   = $vpnsettings{'ROOTCERT_OU'};
+       $cgiparams{'CERT_ORGANIZATION'} = $vpnsettings{'ROOTCERT_ORGANIZATION'};
+       $cgiparams{'CERT_CITY'}                 = $vpnsettings{'ROOTCERT_CITY'};
+       $cgiparams{'CERT_STATE'}                = $vpnsettings{'ROOTCERT_STATE'};
+       $cgiparams{'CERT_COUNTRY'}              = $vpnsettings{'ROOTCERT_COUNTRY'};
 
-       # choose appropriate dpd action 
+       # choose appropriate dpd action
        if ($cgiparams{'TYPE'} eq 'host') {
                $cgiparams{'DPD_ACTION'} = 'clear';
        } else {
@@ -1872,64 +1876,63 @@ END
 
        # Default IKE Version to v2
        if (!$cgiparams{'IKE_VERSION'}) {
-           $cgiparams{'IKE_VERSION'} = 'ikev2';
+               $cgiparams{'IKE_VERSION'} = 'ikev2';
        }
 
        # ID are empty
-       $cgiparams{'LOCAL_ID'}  = '';
+       $cgiparams{'LOCAL_ID'} = '';
        $cgiparams{'REMOTE_ID'} = '';
 
        #use default advanced value
-       $cgiparams{'IKE_ENCRYPTION'} = 'aes256gcm128|aes256gcm96|aes256gcm64|aes256|aes192gcm128|aes192gcm96|aes192gcm64|aes192|aes128gcm128|aes128gcm96|aes128gcm64|aes128';   #[18];
-       $cgiparams{'IKE_INTEGRITY'}  = 'sha2_512|sha2_256|sha'; #[19];
-       $cgiparams{'IKE_GROUPTYPE'}  = '4096|3072|2048|1536|1024';              #[20];
-       $cgiparams{'IKE_LIFETIME'}   = '3';             #[16];
-       $cgiparams{'ESP_ENCRYPTION'} = 'aes256gcm128|aes256gcm96|aes256gcm64|aes256|aes192gcm128|aes192gcm96|aes192gcm64|aes192|aes128gcm128|aes128gcm96|aes128gcm64|aes128';   #[21];
-       $cgiparams{'ESP_INTEGRITY'}  = 'sha2_512|sha2_256|sha1';        #[22];
-       $cgiparams{'ESP_GROUPTYPE'}  = '4096|3072|2048|1536|1024';              #[23];
-       $cgiparams{'ESP_KEYLIFE'}    = '1';             #[17];
-       $cgiparams{'COMPRESSION'}    = 'on';            #[13];
-       $cgiparams{'ONLY_PROPOSED'}  = 'off';           #[24];
-       $cgiparams{'PFS'}            = 'on';            #[28];
-       $cgiparams{'VHOST'}          = 'on';            #[14];
-    }
-
-    VPNCONF_ERROR:
-    $checked{'ENABLED'}{'off'} = '';
-    $checked{'ENABLED'}{'on'} = '';
-    $checked{'ENABLED'}{$cgiparams{'ENABLED'}} = "checked='checked'";
-
-    $checked{'EDIT_ADVANCED'}{'off'} = '';
-    $checked{'EDIT_ADVANCED'}{'on'} = '';
-    $checked{'EDIT_ADVANCED'}{$cgiparams{'EDIT_ADVANCED'}} = "checked='checked'";
-
-    $checked{'AUTH'}{'psk'} = '';
-    $checked{'AUTH'}{'certreq'} = '';
-    $checked{'AUTH'}{'certgen'} = '';
-    $checked{'AUTH'}{'certfile'} = '';
-    $checked{'AUTH'}{'pkcs12'} = '';
-    $checked{'AUTH'}{'auth-dn'} = '';
-    $checked{'AUTH'}{$cgiparams{'AUTH'}} = "checked='checked'";
-
-    &Header::showhttpheaders();
-    &Header::openpage($Lang::tr{'ipsec'}, 1, '');
-    &Header::openbigbox('100%', 'left', '', $errormessage);
-    if ($errormessage) {
-       &Header::openbox('100%', 'left', $Lang::tr{'error messages'});
-       print "<class name='base'>$errormessage";
-       print "&nbsp;</class>";
-       &Header::closebox();
-    }
+       $cgiparams{'IKE_ENCRYPTION'}    = 'aes256gcm128|aes256gcm96|aes256gcm64|aes256|aes192gcm128|aes192gcm96|aes192gcm64|aes192|aes128gcm128|aes128gcm96|aes128gcm64|aes128'; #[18];
+       $cgiparams{'IKE_INTEGRITY'}             = 'sha2_512|sha2_256|sha'; #[19];
+       $cgiparams{'IKE_GROUPTYPE'}             = '4096|3072|2048|1536|1024'; #[20];
+       $cgiparams{'IKE_LIFETIME'}              = '3'; #[16];
+       $cgiparams{'ESP_ENCRYPTION'}    = 'aes256gcm128|aes256gcm96|aes256gcm64|aes256|aes192gcm128|aes192gcm96|aes192gcm64|aes192|aes128gcm128|aes128gcm96|aes128gcm64|aes128'; #[21];
+       $cgiparams{'ESP_INTEGRITY'}             = 'sha2_512|sha2_256|sha1'; #[22];
+       $cgiparams{'ESP_GROUPTYPE'}             = '4096|3072|2048|1536|1024'; #[23];
+       $cgiparams{'ESP_KEYLIFE'}               = '1'; #[17];
+       $cgiparams{'COMPRESSION'}               = 'on'; #[13];
+       $cgiparams{'ONLY_PROPOSED'}             = 'off'; #[24];
+       $cgiparams{'PFS'}                               = 'on'; #[28];
+}
 
-    if ($warnmessage) {
-       &Header::openbox('100%', 'left', "$Lang::tr{'warning messages'}:");
-       print "<class name='base'>$warnmessage";
-       print "&nbsp;</class>";
-       &Header::closebox();
-    }
+VPNCONF_ERROR:
+       $checked{'ENABLED'}{'off'} = '';
+       $checked{'ENABLED'}{'on'} = '';
+       $checked{'ENABLED'}{$cgiparams{'ENABLED'}} = "checked='checked'";
+
+       $checked{'EDIT_ADVANCED'}{'off'} = '';
+       $checked{'EDIT_ADVANCED'}{'on'} = '';
+       $checked{'EDIT_ADVANCED'}{$cgiparams{'EDIT_ADVANCED'}} = "checked='checked'";
+
+       $checked{'AUTH'}{'psk'} = '';
+       $checked{'AUTH'}{'certreq'} = '';
+       $checked{'AUTH'}{'certgen'} = '';
+       $checked{'AUTH'}{'certfile'} = '';
+       $checked{'AUTH'}{'pkcs12'} = '';
+       $checked{'AUTH'}{'auth-dn'} = '';
+       $checked{'AUTH'}{$cgiparams{'AUTH'}} = "checked='checked'";
+
+       &Header::showhttpheaders();
+       &Header::openpage($Lang::tr{'ipsec'}, 1, '');
+       &Header::openbigbox('100%', 'left', '', $errormessage);
+       if ($errormessage) {
+               &Header::openbox('100%', 'left', $Lang::tr{'error messages'});
+               print "<class name='base'>$errormessage";
+               print "&nbsp;</class>";
+               &Header::closebox();
+       }
+
+       if ($warnmessage) {
+               &Header::openbox('100%', 'left', "$Lang::tr{'warning messages'}:");
+               print "<class name='base'>$warnmessage";
+               print "&nbsp;</class>";
+               &Header::closebox();
+       }
 
-    print "<form method='post' enctype='multipart/form-data' action='$ENV{'SCRIPT_NAME'}'>";
-    print<<END
+       print "<form method='post' enctype='multipart/form-data' action='$ENV{'SCRIPT_NAME'}'>";
+       print<<END
        <input type='hidden' name='TYPE' value='$cgiparams{'TYPE'}' />
        <input type='hidden' name='IKE_VERSION' value='$cgiparams{'IKE_VERSION'}' />
        <input type='hidden' name='IKE_ENCRYPTION' value='$cgiparams{'IKE_ENCRYPTION'}' />
@@ -1943,178 +1946,183 @@ END
        <input type='hidden' name='COMPRESSION' value='$cgiparams{'COMPRESSION'}' />
        <input type='hidden' name='ONLY_PROPOSED' value='$cgiparams{'ONLY_PROPOSED'}' />
        <input type='hidden' name='PFS' value='$cgiparams{'PFS'}' />
-       <input type='hidden' name='VHOST' value='$cgiparams{'VHOST'}' />
        <input type='hidden' name='DPD_ACTION' value='$cgiparams{'DPD_ACTION'}' />
        <input type='hidden' name='DPD_DELAY' value='$cgiparams{'DPD_DELAY'}' />
        <input type='hidden' name='DPD_TIMEOUT' value='$cgiparams{'DPD_TIMEOUT'}' />
        <input type='hidden' name='FORCE_MOBIKE' value='$cgiparams{'FORCE_MOBIKE'}' />
 END
-    ;
-    if ($cgiparams{'KEY'}) {
-       print "<input type='hidden' name='KEY' value='$cgiparams{'KEY'}' />";
-       print "<input type='hidden' name='NAME' value='$cgiparams{'NAME'}' />";
-       print "<input type='hidden' name='AUTH' value='$cgiparams{'AUTH'}' />";
-    }
-
-    &Header::openbox('100%', 'left', "$Lang::tr{'connection'}: $cgiparams{'NAME'}");
-    print "<table width='100%'>";
-    if (!$cgiparams{'KEY'}) {
-       print <<EOF;
-               <tr>
-                       <td width='20%'>$Lang::tr{'name'}:&nbsp;<img src='/blob.gif' alt='*' /></td>
-                       <td width='30%'>
-                               <input type='text' name='NAME' value='$cgiparams{'NAME'}' size='25' />
-                       </td>
-                       <td colspan="2"></td>
-               </tr>
+;
+       if ($cgiparams{'KEY'}) {
+               print "<input type='hidden' name='KEY' value='$cgiparams{'KEY'}' />";
+               print "<input type='hidden' name='NAME' value='$cgiparams{'NAME'}' />";
+               print "<input type='hidden' name='AUTH' value='$cgiparams{'AUTH'}' />";
+       }
+
+       &Header::openbox('100%', 'left', "$Lang::tr{'connection'}: $cgiparams{'NAME'}");
+       print "<table width='100%'>";
+       if (!$cgiparams{'KEY'}) {
+               print <<EOF;
+                       <tr>
+                               <td width='20%'>$Lang::tr{'name'}:&nbsp;<img src='/blob.gif' alt='*' /></td>
+                               <td width='30%'>
+                                       <input type='text' name='NAME' value='$cgiparams{'NAME'}' size='25' />
+                               </td>
+                               <td colspan="2"></td>
+                       </tr>
 EOF
-    }
+       }
 
-    my $disabled;
-    my $blob;
-    if ($cgiparams{'TYPE'} eq 'host') {
+       my $disabled;
+       my $blob;
+       if ($cgiparams{'TYPE'} eq 'host') {
                $disabled = "disabled='disabled'";
-    } elsif ($cgiparams{'TYPE'} eq 'net') {
+       } elsif ($cgiparams{'TYPE'} eq 'net') {
                $blob = "<img src='/blob.gif' alt='*' />";
-    };
+       };
 
-    print <<END
+       my @local_subnets = split(/\|/, $cgiparams{'LOCAL_SUBNET'});
+       my $local_subnets = join(",", @local_subnets);
+
+       my @remote_subnets = split(/\|/, $cgiparams{'REMOTE_SUBNET'});
+       my $remote_subnets = join(",", @remote_subnets);
+
+       print <<END
        <tr>
                <td width='20%'>$Lang::tr{'enabled'}</td>
                <td width='30%'>
-                       <input type='checkbox' name='ENABLED' $checked{'ENABLED'}{'on'} />
+                       <input type='checkbox' name='ENABLED' $checked{'ENABLED'}{'on'} />
+               </td>
+               <td class='boldbase' nowrap='nowrap' width='20%'>$Lang::tr{'local subnet'}&nbsp;<img src='/blob.gif' alt='*' /></td>
+               <td width='30%'>
+                       <input type='text' name='LOCAL_SUBNET' value='$local_subnets' />
+               </td>
+       </tr>
+       <tr>
+               <td class='boldbase' width='20%'>$Lang::tr{'remote host/ip'}:&nbsp;$blob</td>
+               <td width='30%'>
+                       <input type='text' name='REMOTE' value='$cgiparams{'REMOTE'}' size="25" />
+               </td>
+               <td class='boldbase' nowrap='nowrap' width='20%'>$Lang::tr{'remote subnet'}&nbsp;$blob</td>
+               <td width='30%'>
+                       <input $disabled type='text' name='REMOTE_SUBNET' value='$remote_subnets' />
                </td>
-           <td class='boldbase' nowrap='nowrap' width='20%'>$Lang::tr{'local subnet'}&nbsp;<img src='/blob.gif' alt='*' /></td>
-           <td width='30%'>
-               <input type='text' name='LOCAL_SUBNET' value='$cgiparams{'LOCAL_SUBNET'}' size="25" />
-           </td>
-       </tr>
-       <tr>
-           <td class='boldbase' width='20%'>$Lang::tr{'remote host/ip'}:&nbsp;$blob</td>
-           <td width='30%'>
-               <input type='text' name='REMOTE' value='$cgiparams{'REMOTE'}' size="25" />
-           </td>
-           <td class='boldbase' nowrap='nowrap' width='20%'>$Lang::tr{'remote subnet'}&nbsp;$blob</td>
-           <td width='30%'>
-               <input $disabled type='text' name='REMOTE_SUBNET' value='$cgiparams{'REMOTE_SUBNET'}' size="25" />
-           </td>
        </tr>
        <tr>
-           <td class='boldbase' width='20%'>$Lang::tr{'vpn local id'}:</td>
-           <td width='30%'>
-               <input type='text' name='LOCAL_ID' value='$cgiparams{'LOCAL_ID'}' size="25" />
-           </td>
-           <td class='boldbase' width='20%'>$Lang::tr{'vpn remote id'}:</td>
-           <td width='30%'>
-               <input type='text' name='REMOTE_ID' value='$cgiparams{'REMOTE_ID'}' size="25" />
-           </td>
+               <td class='boldbase' width='20%'>$Lang::tr{'vpn local id'}:</td>
+               <td width='30%'>
+                       <input type='text' name='LOCAL_ID' value='$cgiparams{'LOCAL_ID'}' size="25" />
+               </td>
+               <td class='boldbase' width='20%'>$Lang::tr{'vpn remote id'}:</td>
+               <td width='30%'>
+                       <input type='text' name='REMOTE_ID' value='$cgiparams{'REMOTE_ID'}' size="25" />
+               </td>
        </tr>
        <tr><td colspan="4"><br /></td></tr>
        <tr>
-           <td class='boldbase' width='20%'>$Lang::tr{'remark title'}</td>
-           <td colspan='3'>
-               <input type='text' name='REMARK' value='$cgiparams{'REMARK'}' maxlength='50' size="73" />
-           </td>
-       </tr>
-END
-    ;
-    if (!$cgiparams{'KEY'}) {
-        print "<tr><td colspan='3'><input type='checkbox' name='EDIT_ADVANCED' $checked{'EDIT_ADVANCED'}{'on'} /> $Lang::tr{'edit advanced settings when done'}</td></tr>";
-    }
-    print "</table>";
-    &Header::closebox();
-       
-    if ($cgiparams{'KEY'} && $cgiparams{'AUTH'} eq 'psk') {
-       &Header::openbox('100%', 'left', $Lang::tr{'authentication'});
-       print <<END
-       <table width='100%' cellpadding='0' cellspacing='5' border='0'>
-       <tr><td class='base' width='50%'>$Lang::tr{'use a pre-shared key'}</td>
-           <td class='base' width='50%'><input type='password' name='PSK' size='30' value='$cgiparams{'PSK'}' /></td>
+               <td class='boldbase' width='20%'>$Lang::tr{'remark title'}</td>
+               <td colspan='3'>
+                       <input type='text' name='REMARK' value='$cgiparams{'REMARK'}' maxlength='50' size="73" />
+               </td>
        </tr>
-       </table>
 END
-       ;
+;
+       if (!$cgiparams{'KEY'}) {
+               print "<tr><td colspan='3'><input type='checkbox' name='EDIT_ADVANCED' $checked{'EDIT_ADVANCED'}{'on'} /> $Lang::tr{'edit advanced settings when done'}</td></tr>";
+       }
+       print "</table>";
        &Header::closebox();
-    } elsif (! $cgiparams{'KEY'}) {
-       my $cakeydisabled = ( ! -f "${General::swroot}/private/cakey.pem" ) ? "disabled='disabled'" : '';
-        $cgiparams{'CERT_NAME'} = $Lang::tr{'vpn no full pki'} if ($cakeydisabled);
-       my $cacrtdisabled = ( ! -f "${General::swroot}/ca/cacert.pem" ) ? "disabled='disabled'" : '';
 
-       &Header::openbox('100%', 'left', $Lang::tr{'authentication'});
-       print <<END
-       <table width='100%' cellpadding='0' cellspacing='5' border='0'>
-       <tr><td width='5%'><input type='radio' name='AUTH' value='psk' $checked{'AUTH'}{'psk'} /></td>
-           <td class='base' width='55%'>$Lang::tr{'use a pre-shared key'}</td>
-           <td class='base' width='40%'><input type='password' name='PSK' size='30' value='$cgiparams{'PSK'}' /></td></tr>
-       <tr><td colspan='3' bgcolor='#000000'></td></tr>
-       <tr><td><input type='radio' name='AUTH' value='certreq' $checked{'AUTH'}{'certreq'} $cakeydisabled /></td>
-           <td class='base'><hr />$Lang::tr{'upload a certificate request'}</td>
-           <td class='base' rowspan='3' valign='middle'><input type='file' name='FH' size='30' $cacrtdisabled /></td></tr>
-       <tr><td><input type='radio' name='AUTH' value='certfile' $checked{'AUTH'}{'certfile'} $cacrtdisabled /></td>
-           <td class='base'>$Lang::tr{'upload a certificate'}</td></tr>
-       <tr><td><input type='radio' name='AUTH' value='pkcs12' $cacrtdisabled /></td>
-           <td class='base'>$Lang::tr{'upload p12 file'} $Lang::tr{'pkcs12 file password'}:<input type='password' name='P12_PASS'/></td></tr>
-       <tr><td><input type='radio' name='AUTH' value='auth-dn' $checked{'AUTH'}{'auth-dn'} $cacrtdisabled /></td>
-           <td class='base'><hr />$Lang::tr{'vpn auth-dn'}</td></tr>
-       <tr><td colspan='3' bgcolor='#000000'></td></tr>
-       <tr><td><input type='radio' name='AUTH' value='certgen' $checked{'AUTH'}{'certgen'} $cakeydisabled /></td>
-           <td class='base'><hr />$Lang::tr{'generate a certificate'}</td><td>&nbsp;</td></tr>
-       <tr><td>&nbsp;</td>
-           <td class='base'>$Lang::tr{'users fullname or system hostname'}:&nbsp;<img src='/blob.gif' alt='*' /></td>
-           <td class='base' nowrap='nowrap'><input type='text' name='CERT_NAME' value='$cgiparams{'CERT_NAME'}' size='32' $cakeydisabled /></td></tr>
-       <tr><td>&nbsp;</td>
-           <td class='base'>$Lang::tr{'users email'}:</td>
-           <td class='base' nowrap='nowrap'><input type='text' name='CERT_EMAIL' value='$cgiparams{'CERT_EMAIL'}' size='32' $cakeydisabled /></td></tr>
-       <tr><td>&nbsp;</td>
-           <td class='base'>$Lang::tr{'users department'}:</td>
-           <td class='base' nowrap='nowrap'><input type='text' name='CERT_OU' value='$cgiparams{'CERT_OU'}' size='32' $cakeydisabled /></td></tr>
-       <tr><td>&nbsp;</td>
-           <td class='base'>$Lang::tr{'organization name'}:</td>
-           <td class='base' nowrap='nowrap'><input type='text' name='CERT_ORGANIZATION' value='$cgiparams{'CERT_ORGANIZATION'}' size='32' $cakeydisabled /></td></tr>
-       <tr><td>&nbsp;</td>
-           <td class='base'>$Lang::tr{'city'}:</td>
-           <td class='base' nowrap='nowrap'><input type='text' name='CERT_CITY' value='$cgiparams{'CERT_CITY'}' size='32' $cakeydisabled /></td></tr>
-       <tr><td>&nbsp;</td>
-           <td class='base'>$Lang::tr{'state or province'}:</td>
-           <td class='base' nowrap='nowrap'><input type='text' name='CERT_STATE' value='$cgiparams{'CERT_STATE'}' size='32' $cakeydisabled /></td></tr>
-       <tr><td>&nbsp;</td>
-           <td class='base'>$Lang::tr{'country'}:</td>
-           <td class='base'><select name='CERT_COUNTRY' $cakeydisabled>
+       if ($cgiparams{'KEY'} && $cgiparams{'AUTH'} eq 'psk') {
+               &Header::openbox('100%', 'left', $Lang::tr{'authentication'});
+               print <<END
+               <table width='100%' cellpadding='0' cellspacing='5' border='0'>
+               <tr><td class='base' width='50%'>$Lang::tr{'use a pre-shared key'}</td>
+                       <td class='base' width='50%'><input type='password' name='PSK' size='30' value='$cgiparams{'PSK'}' /></td>
+               </tr>
+               </table>
 END
-       ;
-       foreach my $country (sort keys %{Countries::countries}) {
-           print "\t\t\t<option value='$Countries::countries{$country}'";
-           if ( $Countries::countries{$country} eq $cgiparams{'CERT_COUNTRY'} ) {
-               print " selected='selected'";
-           }
-           print ">$country</option>\n";
+;
+               &Header::closebox();
+       } elsif (! $cgiparams{'KEY'}) {
+               my $cakeydisabled = ( ! -f "${General::swroot}/private/cakey.pem" ) ? "disabled='disabled'" : '';
+               $cgiparams{'CERT_NAME'} = $Lang::tr{'vpn no full pki'} if ($cakeydisabled);
+               my $cacrtdisabled = ( ! -f "${General::swroot}/ca/cacert.pem" ) ? "disabled='disabled'" : '';
+
+               &Header::openbox('100%', 'left', $Lang::tr{'authentication'});
+               print <<END
+               <table width='100%' cellpadding='0' cellspacing='5' border='0'>
+               <tr><td width='5%'><input type='radio' name='AUTH' value='psk' $checked{'AUTH'}{'psk'} /></td>
+                       <td class='base' width='55%'>$Lang::tr{'use a pre-shared key'}</td>
+                       <td class='base' width='40%'><input type='password' name='PSK' size='30' value='$cgiparams{'PSK'}' /></td></tr>
+               <tr><td colspan='3' bgcolor='#000000'></td></tr>
+               <tr><td><input type='radio' name='AUTH' value='certreq' $checked{'AUTH'}{'certreq'} $cakeydisabled /></td>
+                       <td class='base'><hr />$Lang::tr{'upload a certificate request'}</td>
+                       <td class='base' rowspan='3' valign='middle'><input type='file' name='FH' size='30' $cacrtdisabled /></td></tr>
+               <tr><td><input type='radio' name='AUTH' value='certfile' $checked{'AUTH'}{'certfile'} $cacrtdisabled /></td>
+                       <td class='base'>$Lang::tr{'upload a certificate'}</td></tr>
+               <tr><td><input type='radio' name='AUTH' value='pkcs12' $cacrtdisabled /></td>
+                       <td class='base'>$Lang::tr{'upload p12 file'} $Lang::tr{'pkcs12 file password'}:<input type='password' name='P12_PASS'/></td></tr>
+               <tr><td><input type='radio' name='AUTH' value='auth-dn' $checked{'AUTH'}{'auth-dn'} $cacrtdisabled /></td>
+                       <td class='base'><hr />$Lang::tr{'vpn auth-dn'}</td></tr>
+               <tr><td colspan='3' bgcolor='#000000'></td></tr>
+               <tr><td><input type='radio' name='AUTH' value='certgen' $checked{'AUTH'}{'certgen'} $cakeydisabled /></td>
+                       <td class='base'><hr />$Lang::tr{'generate a certificate'}</td><td>&nbsp;</td></tr>
+               <tr><td>&nbsp;</td>
+                       <td class='base'>$Lang::tr{'users fullname or system hostname'}:&nbsp;<img src='/blob.gif' alt='*' /></td>
+                       <td class='base' nowrap='nowrap'><input type='text' name='CERT_NAME' value='$cgiparams{'CERT_NAME'}' size='32' $cakeydisabled /></td></tr>
+               <tr><td>&nbsp;</td>
+                       <td class='base'>$Lang::tr{'users email'}:</td>
+                       <td class='base' nowrap='nowrap'><input type='text' name='CERT_EMAIL' value='$cgiparams{'CERT_EMAIL'}' size='32' $cakeydisabled /></td></tr>
+               <tr><td>&nbsp;</td>
+                       <td class='base'>$Lang::tr{'users department'}:</td>
+                       <td class='base' nowrap='nowrap'><input type='text' name='CERT_OU' value='$cgiparams{'CERT_OU'}' size='32' $cakeydisabled /></td></tr>
+               <tr><td>&nbsp;</td>
+                       <td class='base'>$Lang::tr{'organization name'}:&nbsp;<img src='/blob.gif' alt='*' /></td>
+                       <td class='base' nowrap='nowrap'><input type='text' name='CERT_ORGANIZATION' value='$cgiparams{'CERT_ORGANIZATION'}' size='32' $cakeydisabled /></td></tr>
+               <tr><td>&nbsp;</td>
+                       <td class='base'>$Lang::tr{'city'}:</td>
+                       <td class='base' nowrap='nowrap'><input type='text' name='CERT_CITY' value='$cgiparams{'CERT_CITY'}' size='32' $cakeydisabled /></td></tr>
+               <tr><td>&nbsp;</td>
+                       <td class='base'>$Lang::tr{'state or province'}:</td>
+                       <td class='base' nowrap='nowrap'><input type='text' name='CERT_STATE' value='$cgiparams{'CERT_STATE'}' size='32' $cakeydisabled /></td></tr>
+               <tr><td>&nbsp;</td>
+                       <td class='base'>$Lang::tr{'country'}:</td>
+                       <td class='base'><select name='CERT_COUNTRY' $cakeydisabled>
+END
+;
+               foreach my $country (sort keys %{Countries::countries}) {
+                       print "\t\t\t<option value='$Countries::countries{$country}'";
+                       if ( $Countries::countries{$country} eq $cgiparams{'CERT_COUNTRY'} ) {
+                               print " selected='selected'";
+                       }
+                       print ">$country</option>\n";
+               }
+               print <<END
+                       </select></td></tr>
+
+               <tr><td>&nbsp;</td><td class='base'>$Lang::tr{'vpn subjectaltname'} (subjectAltName=email:*,URI:*,DNS:*,RID:*)</td>
+                       <td class='base' nowrap='nowrap'><input type='text' name='SUBJECTALTNAME' value='$cgiparams{'SUBJECTALTNAME'}' size='32' $cakeydisabled /></td></tr>
+               <tr><td>&nbsp;</td>
+                       <td class='base'>$Lang::tr{'pkcs12 file password'}:&nbsp;<img src='/blob.gif' alt='*' /></td>
+                       <td class='base' nowrap='nowrap'><input type='password' name='CERT_PASS1' value='$cgiparams{'CERT_PASS1'}' size='32' $cakeydisabled /></td></tr>
+               <tr><td>&nbsp;</td><td class='base'>$Lang::tr{'pkcs12 file password'}&nbsp;($Lang::tr{'confirmation'}):&nbsp;<img src='/blob.gif' alt='*' /></td>
+                       <td class='base' nowrap='nowrap'><input type='password' name='CERT_PASS2' value='$cgiparams{'CERT_PASS2'}' size='32' $cakeydisabled /></td></tr>
+               </table>
+END
+;
+               &Header::closebox();
        }
-       print <<END
-           </select></td></tr>
 
-       <tr><td>&nbsp;</td><td class='base'>$Lang::tr{'vpn subjectaltname'} (subjectAltName=email:*,URI:*,DNS:*,RID:*)</td>
-           <td class='base' nowrap='nowrap'><input type='text' name='SUBJECTALTNAME' value='$cgiparams{'SUBJECTALTNAME'}' size='32' $cakeydisabled /></td></tr>
-       <tr><td>&nbsp;</td>
-           <td class='base'>$Lang::tr{'pkcs12 file password'}:&nbsp;<img src='/blob.gif' alt='*' /></td>
-           <td class='base' nowrap='nowrap'><input type='password' name='CERT_PASS1' value='$cgiparams{'CERT_PASS1'}' size='32' $cakeydisabled /></td></tr>
-       <tr><td>&nbsp;</td><td class='base'>$Lang::tr{'pkcs12 file password'}&nbsp;($Lang::tr{'confirmation'}):&nbsp;<img src='/blob.gif' alt='*' /></td>
-           <td class='base' nowrap='nowrap'><input type='password' name='CERT_PASS2' value='$cgiparams{'CERT_PASS2'}' size='32' $cakeydisabled /></td></tr>
-       </table>
-END
-       ;
-       &Header::closebox();
-    }
-
-    print "<div align='center'><input type='submit' name='ACTION' value='$Lang::tr{'save'}' />";
-    if ($cgiparams{'KEY'}) {
-        print "<input type='submit' name='ACTION' value='$Lang::tr{'advanced'}' />";
-    }
-    print "<input type='submit' name='ACTION' value='$Lang::tr{'cancel'}' /></div></form>";
-    &Header::closebigbox();
-    &Header::closepage();
-    exit (0);
-    
-    VPNCONF_END:
+       print "<div align='center'><input type='submit' name='ACTION' value='$Lang::tr{'save'}' />";
+       if ($cgiparams{'KEY'}) {
+               print "<input type='submit' name='ACTION' value='$Lang::tr{'advanced'}' />";
+       }
+       print "<input type='submit' name='ACTION' value='$Lang::tr{'cancel'}' /></div></form>";
+       &Header::closebigbox();
+       &Header::closepage();
+       exit (0);
+
+       VPNCONF_END:
 }
 
 ###
@@ -2122,303 +2130,288 @@ END
 ###
 if(($cgiparams{'ACTION'} eq $Lang::tr{'advanced'}) ||
        ($cgiparams{'ACTION'} eq $Lang::tr{'save'} && $cgiparams{'ADVANCED'} eq 'yes')) {
-    &General::readhash("${General::swroot}/vpn/settings", \%vpnsettings);
-    &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
-    if (! $confighash{$cgiparams{'KEY'}}) {
-       $errormessage = $Lang::tr{'invalid key'};
-       goto ADVANCED_END;
-    }
-
-    if ($cgiparams{'ACTION'} eq $Lang::tr{'save'}) {
-       # I didn't read any incompatibilities here....
-       #if ($cgiparams{'VHOST'} eq 'on' && $cgiparams{'COMPRESSION'} eq 'on') {
-       #    $errormessage = $Lang::tr{'cannot enable both nat traversal and compression'};
-       #    goto ADVANCED_ERROR;
-       #}
-       my @temp = split('\|', $cgiparams{'IKE_ENCRYPTION'});
-       if ($#temp < 0) {
-           $errormessage = $Lang::tr{'invalid input'};
-           goto ADVANCED_ERROR;
-       }
-       foreach my $val (@temp) {
-           if ($val !~ /^(aes(256|192|128)(gcm(128|96|64))?|3des|camellia(256|192|128))$/) {
-               $errormessage = $Lang::tr{'invalid input'};
-               goto ADVANCED_ERROR;
-           }
+       &General::readhash("${General::swroot}/vpn/settings", \%vpnsettings);
+       &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
+       if (! $confighash{$cgiparams{'KEY'}}) {
+               $errormessage = $Lang::tr{'invalid key'};
+               goto ADVANCED_END;
+       }
+
+       if ($cgiparams{'ACTION'} eq $Lang::tr{'save'}) {
+               my @temp = split('\|', $cgiparams{'IKE_ENCRYPTION'});
+               if ($#temp < 0) {
+                       $errormessage = $Lang::tr{'invalid input'};
+                       goto ADVANCED_ERROR;
+               }
+               foreach my $val (@temp) {
+                       if ($val !~ /^(aes(256|192|128)(gcm(128|96|64))?|3des|camellia(256|192|128))$/) {
+                               $errormessage = $Lang::tr{'invalid input'};
+                               goto ADVANCED_ERROR;
+                       }
+               }
+               @temp = split('\|', $cgiparams{'IKE_INTEGRITY'});
+               if ($#temp < 0) {
+                       $errormessage = $Lang::tr{'invalid input'};
+                       goto ADVANCED_ERROR;
+               }
+               foreach my $val (@temp) {
+                       if ($val !~ /^(sha2_(512|384|256)|sha|md5|aesxcbc)$/) {
+                               $errormessage = $Lang::tr{'invalid input'};
+                               goto ADVANCED_ERROR;
+                       }
+               }
+               @temp = split('\|', $cgiparams{'IKE_GROUPTYPE'});
+               if ($#temp < 0) {
+                       $errormessage = $Lang::tr{'invalid input'};
+                       goto ADVANCED_ERROR;
+               }
+               foreach my $val (@temp) {
+                       if ($val !~ /^(e521|e384|e256|e224|e192|e512bp|e384bp|e256bp|e224bp|1024|1536|2048|2048s256|2048s224|2048s160|3072|4096|6144|8192)$/) {
+                               $errormessage = $Lang::tr{'invalid input'};
+                               goto ADVANCED_ERROR;
+                       }
+               }
+               if ($cgiparams{'IKE_LIFETIME'} !~ /^\d+$/) {
+                       $errormessage = $Lang::tr{'invalid input for ike lifetime'};
+                       goto ADVANCED_ERROR;
+               }
+               if ($cgiparams{'IKE_LIFETIME'} < 1 || $cgiparams{'IKE_LIFETIME'} > 8) {
+                       $errormessage = $Lang::tr{'ike lifetime should be between 1 and 8 hours'};
+                       goto ADVANCED_ERROR;
+               }
+               @temp = split('\|', $cgiparams{'ESP_ENCRYPTION'});
+               if ($#temp < 0) {
+                       $errormessage = $Lang::tr{'invalid input'};
+                       goto ADVANCED_ERROR;
+               }
+               foreach my $val (@temp) {
+                       if ($val !~ /^(aes(256|192|128)(gcm(128|96|64))?|3des|camellia(256|192|128))$/) {
+                               $errormessage = $Lang::tr{'invalid input'};
+                               goto ADVANCED_ERROR;
+                       }
+               }
+               @temp = split('\|', $cgiparams{'ESP_INTEGRITY'});
+               if ($#temp < 0) {
+                       $errormessage = $Lang::tr{'invalid input'};
+                       goto ADVANCED_ERROR;
+               }
+               foreach my $val (@temp) {
+                       if ($val !~ /^(sha2_(512|384|256)|sha1|md5|aesxcbc)$/) {
+                               $errormessage = $Lang::tr{'invalid input'};
+                               goto ADVANCED_ERROR;
+                       }
+               }
+               @temp = split('\|', $cgiparams{'ESP_GROUPTYPE'});
+               if ($#temp < 0) {
+                       $errormessage = $Lang::tr{'invalid input'};
+                       goto ADVANCED_ERROR;
+               }
+               foreach my $val (@temp) {
+                       if ($val !~ /^(e521|e384|e256|e224|e192|e512bp|e384bp|e256bp|e224bp|1024|1536|2048|2048s256|2048s224|2048s160|3072|4096|6144|8192|none)$/) {
+                               $errormessage = $Lang::tr{'invalid input'};
+                               goto ADVANCED_ERROR;
+                       }
+               }
+               if ($cgiparams{'ESP_KEYLIFE'} !~ /^\d+$/) {
+                       $errormessage = $Lang::tr{'invalid input for esp keylife'};
+                       goto ADVANCED_ERROR;
+               }
+               if ($cgiparams{'ESP_KEYLIFE'} < 1 || $cgiparams{'ESP_KEYLIFE'} > 24) {
+                       $errormessage = $Lang::tr{'esp keylife should be between 1 and 24 hours'};
+                       goto ADVANCED_ERROR;
+               }
+
+               if (($cgiparams{'COMPRESSION'} !~ /^(|on|off)$/) ||
+                       ($cgiparams{'FORCE_MOBIKE'} !~ /^(|on|off)$/) ||
+                       ($cgiparams{'ONLY_PROPOSED'} !~ /^(|on|off)$/) ||
+                       ($cgiparams{'PFS'} !~ /^(|on|off)$/)) {
+                       $errormessage = $Lang::tr{'invalid input'};
+                       goto ADVANCED_ERROR;
+               }
+
+               if ($cgiparams{'DPD_DELAY'} !~ /^\d+$/) {
+                       $errormessage = $Lang::tr{'invalid input for dpd delay'};
+                       goto ADVANCED_ERROR;
+               }
+
+               if ($cgiparams{'DPD_TIMEOUT'} !~ /^\d+$/) {
+                       $errormessage = $Lang::tr{'invalid input for dpd timeout'};
+                       goto ADVANCED_ERROR;
+               }
+
+               $confighash{$cgiparams{'KEY'}}[29] = $cgiparams{'IKE_VERSION'};
+               $confighash{$cgiparams{'KEY'}}[18] = $cgiparams{'IKE_ENCRYPTION'};
+               $confighash{$cgiparams{'KEY'}}[19] = $cgiparams{'IKE_INTEGRITY'};
+               $confighash{$cgiparams{'KEY'}}[20] = $cgiparams{'IKE_GROUPTYPE'};
+               $confighash{$cgiparams{'KEY'}}[16] = $cgiparams{'IKE_LIFETIME'};
+               $confighash{$cgiparams{'KEY'}}[21] = $cgiparams{'ESP_ENCRYPTION'};
+               $confighash{$cgiparams{'KEY'}}[22] = $cgiparams{'ESP_INTEGRITY'};
+               $confighash{$cgiparams{'KEY'}}[23] = $cgiparams{'ESP_GROUPTYPE'};
+               $confighash{$cgiparams{'KEY'}}[17] = $cgiparams{'ESP_KEYLIFE'};
+               $confighash{$cgiparams{'KEY'}}[12] = 'off'; #$cgiparams{'AGGRMODE'};
+               $confighash{$cgiparams{'KEY'}}[13] = $cgiparams{'COMPRESSION'};
+               $confighash{$cgiparams{'KEY'}}[24] = $cgiparams{'ONLY_PROPOSED'};
+               $confighash{$cgiparams{'KEY'}}[28] = $cgiparams{'PFS'};
+               $confighash{$cgiparams{'KEY'}}[27] = $cgiparams{'DPD_ACTION'};
+               $confighash{$cgiparams{'KEY'}}[30] = $cgiparams{'DPD_TIMEOUT'};
+               $confighash{$cgiparams{'KEY'}}[31] = $cgiparams{'DPD_DELAY'};
+               $confighash{$cgiparams{'KEY'}}[32] = $cgiparams{'FORCE_MOBIKE'};
+               &General::writehasharray("${General::swroot}/vpn/config", \%confighash);
+               &writeipsecfiles();
+               if (&vpnenabled) {
+                       system('/usr/local/bin/ipsecctrl', 'S', $cgiparams{'KEY'});
+                       sleep $sleepDelay;
+               }
+               goto ADVANCED_END;
+       } else {
+               $cgiparams{'IKE_VERSION'}               = $confighash{$cgiparams{'KEY'}}[29];
+               $cgiparams{'IKE_ENCRYPTION'}    = $confighash{$cgiparams{'KEY'}}[18];
+               $cgiparams{'IKE_INTEGRITY'}             = $confighash{$cgiparams{'KEY'}}[19];
+               $cgiparams{'IKE_GROUPTYPE'}             = $confighash{$cgiparams{'KEY'}}[20];
+               $cgiparams{'IKE_LIFETIME'}              = $confighash{$cgiparams{'KEY'}}[16];
+               $cgiparams{'ESP_ENCRYPTION'}    = $confighash{$cgiparams{'KEY'}}[21];
+               $cgiparams{'ESP_INTEGRITY'}             = $confighash{$cgiparams{'KEY'}}[22];
+               $cgiparams{'ESP_GROUPTYPE'}             = $confighash{$cgiparams{'KEY'}}[23];
+               if ($cgiparams{'ESP_GROUPTYPE'} eq "") {
+                       $cgiparams{'ESP_GROUPTYPE'}     = $cgiparams{'IKE_GROUPTYPE'};
+               }
+               $cgiparams{'ESP_KEYLIFE'}               = $confighash{$cgiparams{'KEY'}}[17];
+               $cgiparams{'COMPRESSION'}               = $confighash{$cgiparams{'KEY'}}[13];
+               $cgiparams{'ONLY_PROPOSED'}             = $confighash{$cgiparams{'KEY'}}[24];
+               $cgiparams{'PFS'}                               = $confighash{$cgiparams{'KEY'}}[28];
+               $cgiparams{'DPD_ACTION'}                = $confighash{$cgiparams{'KEY'}}[27];
+               $cgiparams{'DPD_TIMEOUT'}               = $confighash{$cgiparams{'KEY'}}[30];
+               $cgiparams{'DPD_DELAY'}                 = $confighash{$cgiparams{'KEY'}}[31];
+               $cgiparams{'FORCE_MOBIKE'}              = $confighash{$cgiparams{'KEY'}}[32];
+
+               if (!$cgiparams{'DPD_DELAY'}) {
+                       $cgiparams{'DPD_DELAY'} = 30;
+               }
+
+               if (!$cgiparams{'DPD_TIMEOUT'}) {
+                       $cgiparams{'DPD_TIMEOUT'} = 120;
+               }
        }
+
+       ADVANCED_ERROR:
+       $checked{'IKE_ENCRYPTION'}{'aes256'} = '';
+       $checked{'IKE_ENCRYPTION'}{'aes192'} = '';
+       $checked{'IKE_ENCRYPTION'}{'aes128'} = '';
+       $checked{'IKE_ENCRYPTION'}{'aes256gcm128'} = '';
+       $checked{'IKE_ENCRYPTION'}{'aes192gcm128'} = '';
+       $checked{'IKE_ENCRYPTION'}{'aes128gcm128'} = '';
+       $checked{'IKE_ENCRYPTION'}{'aes256gcm96'} = '';
+       $checked{'IKE_ENCRYPTION'}{'aes192gcm96'} = '';
+       $checked{'IKE_ENCRYPTION'}{'aes128gcm96'} = '';
+       $checked{'IKE_ENCRYPTION'}{'aes256gcm64'} = '';
+       $checked{'IKE_ENCRYPTION'}{'aes192gcm64'} = '';
+       $checked{'IKE_ENCRYPTION'}{'aes128gcm64'} = '';
+       $checked{'IKE_ENCRYPTION'}{'3des'} = '';
+       $checked{'IKE_ENCRYPTION'}{'camellia256'} = '';
+       $checked{'IKE_ENCRYPTION'}{'camellia192'} = '';
+       $checked{'IKE_ENCRYPTION'}{'camellia128'} = '';
+       my @temp = split('\|', $cgiparams{'IKE_ENCRYPTION'});
+       foreach my $key (@temp) {$checked{'IKE_ENCRYPTION'}{$key} = "selected='selected'"; }
+       $checked{'IKE_INTEGRITY'}{'sha2_512'} = '';
+       $checked{'IKE_INTEGRITY'}{'sha2_384'} = '';
+       $checked{'IKE_INTEGRITY'}{'sha2_256'} = '';
+       $checked{'IKE_INTEGRITY'}{'sha'} = '';
+       $checked{'IKE_INTEGRITY'}{'md5'} = '';
+       $checked{'IKE_INTEGRITY'}{'aesxcbc'} = '';
        @temp = split('\|', $cgiparams{'IKE_INTEGRITY'});
-       if ($#temp < 0) {
-           $errormessage = $Lang::tr{'invalid input'};
-           goto ADVANCED_ERROR;
-       }
-       foreach my $val (@temp) {
-           if ($val !~ /^(sha2_(512|384|256)|sha|md5|aesxcbc)$/) {
-               $errormessage = $Lang::tr{'invalid input'};
-               goto ADVANCED_ERROR;
-           }
-       }
+       foreach my $key (@temp) {$checked{'IKE_INTEGRITY'}{$key} = "selected='selected'"; }
+       $checked{'IKE_GROUPTYPE'}{'768'} = '';
+       $checked{'IKE_GROUPTYPE'}{'1024'} = '';
+       $checked{'IKE_GROUPTYPE'}{'1536'} = '';
+       $checked{'IKE_GROUPTYPE'}{'2048'} = '';
+       $checked{'IKE_GROUPTYPE'}{'3072'} = '';
+       $checked{'IKE_GROUPTYPE'}{'4096'} = '';
+       $checked{'IKE_GROUPTYPE'}{'6144'} = '';
+       $checked{'IKE_GROUPTYPE'}{'8192'} = '';
        @temp = split('\|', $cgiparams{'IKE_GROUPTYPE'});
-       if ($#temp < 0) {
-           $errormessage = $Lang::tr{'invalid input'};
-           goto ADVANCED_ERROR;
-       }
-       foreach my $val (@temp) {
-           if ($val !~ /^(e521|e384|e256|e224|e192|e512bp|e384bp|e256bp|e224bp|1024|1536|2048|2048s256|2048s224|2048s160|3072|4096|6144|8192)$/) {
-               $errormessage = $Lang::tr{'invalid input'};
-               goto ADVANCED_ERROR;
-           }
-       }
-       if ($cgiparams{'IKE_LIFETIME'} !~ /^\d+$/) {
-           $errormessage = $Lang::tr{'invalid input for ike lifetime'};
-           goto ADVANCED_ERROR;
-       }
-       if ($cgiparams{'IKE_LIFETIME'} < 1 || $cgiparams{'IKE_LIFETIME'} > 8) {
-           $errormessage = $Lang::tr{'ike lifetime should be between 1 and 8 hours'};
-           goto ADVANCED_ERROR;
-       }
+       foreach my $key (@temp) {$checked{'IKE_GROUPTYPE'}{$key} = "selected='selected'"; }
+
+       # 768 is not supported by strongswan
+       $checked{'IKE_GROUPTYPE'}{'768'} = '';
+
+       $checked{'ESP_ENCRYPTION'}{'aes256'} = '';
+       $checked{'ESP_ENCRYPTION'}{'aes192'} = '';
+       $checked{'ESP_ENCRYPTION'}{'aes128'} = '';
+       $checked{'ESP_ENCRYPTION'}{'aes256gcm128'} = '';
+       $checked{'ESP_ENCRYPTION'}{'aes192gcm128'} = '';
+       $checked{'ESP_ENCRYPTION'}{'aes128gcm128'} = '';
+       $checked{'ESP_ENCRYPTION'}{'aes256gcm96'} = '';
+       $checked{'ESP_ENCRYPTION'}{'aes192gcm96'} = '';
+       $checked{'ESP_ENCRYPTION'}{'aes128gcm96'} = '';
+       $checked{'ESP_ENCRYPTION'}{'aes256gcm64'} = '';
+       $checked{'ESP_ENCRYPTION'}{'aes192gcm64'} = '';
+       $checked{'ESP_ENCRYPTION'}{'aes128gcm64'} = '';
+       $checked{'ESP_ENCRYPTION'}{'3des'} = '';
+       $checked{'ESP_ENCRYPTION'}{'camellia256'} = '';
+       $checked{'ESP_ENCRYPTION'}{'camellia192'} = '';
+       $checked{'ESP_ENCRYPTION'}{'camellia128'} = '';
        @temp = split('\|', $cgiparams{'ESP_ENCRYPTION'});
-       if ($#temp < 0) {
-           $errormessage = $Lang::tr{'invalid input'};
-           goto ADVANCED_ERROR;
-       }
-       foreach my $val (@temp) {
-           if ($val !~ /^(aes(256|192|128)(gcm(128|96|64))?|3des|camellia(256|192|128))$/) {
-               $errormessage = $Lang::tr{'invalid input'};
-               goto ADVANCED_ERROR;
-           }
-       }
+       foreach my $key (@temp) {$checked{'ESP_ENCRYPTION'}{$key} = "selected='selected'"; }
+       $checked{'ESP_INTEGRITY'}{'sha2_512'} = '';
+       $checked{'ESP_INTEGRITY'}{'sha2_384'} = '';
+       $checked{'ESP_INTEGRITY'}{'sha2_256'} = '';
+       $checked{'ESP_INTEGRITY'}{'sha1'} = '';
+       $checked{'ESP_INTEGRITY'}{'md5'} = '';
+       $checked{'ESP_INTEGRITY'}{'aesxcbc'} = '';
        @temp = split('\|', $cgiparams{'ESP_INTEGRITY'});
-       if ($#temp < 0) {
-           $errormessage = $Lang::tr{'invalid input'};
-           goto ADVANCED_ERROR;
-       }
-       foreach my $val (@temp) {
-           if ($val !~ /^(sha2_(512|384|256)|sha1|md5|aesxcbc)$/) {
-               $errormessage = $Lang::tr{'invalid input'};
-               goto ADVANCED_ERROR;
-           }
-       }
+       foreach my $key (@temp) {$checked{'ESP_INTEGRITY'}{$key} = "selected='selected'"; }
+       $checked{'ESP_GROUPTYPE'}{'768'} = '';
+       $checked{'ESP_GROUPTYPE'}{'1024'} = '';
+       $checked{'ESP_GROUPTYPE'}{'1536'} = '';
+       $checked{'ESP_GROUPTYPE'}{'2048'} = '';
+       $checked{'ESP_GROUPTYPE'}{'3072'} = '';
+       $checked{'ESP_GROUPTYPE'}{'4096'} = '';
+       $checked{'ESP_GROUPTYPE'}{'6144'} = '';
+       $checked{'ESP_GROUPTYPE'}{'8192'} = '';
+       $checked{'ESP_GROUPTYPE'}{'none'} = '';
        @temp = split('\|', $cgiparams{'ESP_GROUPTYPE'});
-       if ($#temp < 0) {
-           $errormessage = $Lang::tr{'invalid input'};
-           goto ADVANCED_ERROR;
-       }
-       foreach my $val (@temp) {
-           if ($val !~ /^(e521|e384|e256|e224|e192|e512bp|e384bp|e256bp|e224bp|1024|1536|2048|2048s256|2048s224|2048s160|3072|4096|6144|8192|none)$/) {
-               $errormessage = $Lang::tr{'invalid input'};
-               goto ADVANCED_ERROR;
-           }
-       }
-       if ($cgiparams{'ESP_KEYLIFE'} !~ /^\d+$/) {
-           $errormessage = $Lang::tr{'invalid input for esp keylife'};
-           goto ADVANCED_ERROR;
-       }
-       if ($cgiparams{'ESP_KEYLIFE'} < 1 || $cgiparams{'ESP_KEYLIFE'} > 24) {
-           $errormessage = $Lang::tr{'esp keylife should be between 1 and 24 hours'};
-           goto ADVANCED_ERROR;
-       }
-
-       if (
-           ($cgiparams{'COMPRESSION'} !~ /^(|on|off)$/) ||
-           ($cgiparams{'FORCE_MOBIKE'} !~ /^(|on|off)$/) ||
-           ($cgiparams{'ONLY_PROPOSED'} !~ /^(|on|off)$/) ||
-           ($cgiparams{'PFS'} !~ /^(|on|off)$/) ||
-           ($cgiparams{'VHOST'} !~ /^(|on|off)$/)
-       ){
-           $errormessage = $Lang::tr{'invalid input'};
-           goto ADVANCED_ERROR;
-       }
-
-       if ($cgiparams{'DPD_DELAY'} !~ /^\d+$/) {
-           $errormessage = $Lang::tr{'invalid input for dpd delay'};
-           goto ADVANCED_ERROR;
-       }
-
-       if ($cgiparams{'DPD_TIMEOUT'} !~ /^\d+$/) {
-           $errormessage = $Lang::tr{'invalid input for dpd timeout'};
-           goto ADVANCED_ERROR;
-       }
-
-       $confighash{$cgiparams{'KEY'}}[29] = $cgiparams{'IKE_VERSION'};
-       $confighash{$cgiparams{'KEY'}}[18] = $cgiparams{'IKE_ENCRYPTION'};
-       $confighash{$cgiparams{'KEY'}}[19] = $cgiparams{'IKE_INTEGRITY'};
-       $confighash{$cgiparams{'KEY'}}[20] = $cgiparams{'IKE_GROUPTYPE'};
-       $confighash{$cgiparams{'KEY'}}[16] = $cgiparams{'IKE_LIFETIME'};
-       $confighash{$cgiparams{'KEY'}}[21] = $cgiparams{'ESP_ENCRYPTION'};
-       $confighash{$cgiparams{'KEY'}}[22] = $cgiparams{'ESP_INTEGRITY'};
-       $confighash{$cgiparams{'KEY'}}[23] = $cgiparams{'ESP_GROUPTYPE'};
-       $confighash{$cgiparams{'KEY'}}[17] = $cgiparams{'ESP_KEYLIFE'};
-       $confighash{$cgiparams{'KEY'}}[12] = 'off'; #$cgiparams{'AGGRMODE'};
-       $confighash{$cgiparams{'KEY'}}[13] = $cgiparams{'COMPRESSION'};
-       $confighash{$cgiparams{'KEY'}}[24] = $cgiparams{'ONLY_PROPOSED'};
-       $confighash{$cgiparams{'KEY'}}[28] = $cgiparams{'PFS'};
-       $confighash{$cgiparams{'KEY'}}[14] = $cgiparams{'VHOST'};
-       $confighash{$cgiparams{'KEY'}}[27] = $cgiparams{'DPD_ACTION'};
-       $confighash{$cgiparams{'KEY'}}[30] = $cgiparams{'DPD_TIMEOUT'};
-       $confighash{$cgiparams{'KEY'}}[31] = $cgiparams{'DPD_DELAY'};
-       $confighash{$cgiparams{'KEY'}}[32] = $cgiparams{'FORCE_MOBIKE'};
-       &General::writehasharray("${General::swroot}/vpn/config", \%confighash);
-       &writeipsecfiles();
-       if (&vpnenabled) {
-           system('/usr/local/bin/ipsecctrl', 'S', $cgiparams{'KEY'});
-           sleep $sleepDelay;
-       }
-       goto ADVANCED_END;
-    } else {
-    $cgiparams{'IKE_VERSION'}    = $confighash{$cgiparams{'KEY'}}[29];
-       $cgiparams{'IKE_ENCRYPTION'} = $confighash{$cgiparams{'KEY'}}[18];
-       $cgiparams{'IKE_INTEGRITY'}  = $confighash{$cgiparams{'KEY'}}[19];
-       $cgiparams{'IKE_GROUPTYPE'}  = $confighash{$cgiparams{'KEY'}}[20];
-       $cgiparams{'IKE_LIFETIME'}   = $confighash{$cgiparams{'KEY'}}[16];
-       $cgiparams{'ESP_ENCRYPTION'} = $confighash{$cgiparams{'KEY'}}[21];
-       $cgiparams{'ESP_INTEGRITY'}  = $confighash{$cgiparams{'KEY'}}[22];
-       $cgiparams{'ESP_GROUPTYPE'}  = $confighash{$cgiparams{'KEY'}}[23];
-       if ($cgiparams{'ESP_GROUPTYPE'} eq "") {
-               $cgiparams{'ESP_GROUPTYPE'} = $cgiparams{'IKE_GROUPTYPE'};
-       }
-       $cgiparams{'ESP_KEYLIFE'}    = $confighash{$cgiparams{'KEY'}}[17];
-       $cgiparams{'COMPRESSION'}    = $confighash{$cgiparams{'KEY'}}[13];
-       $cgiparams{'ONLY_PROPOSED'}  = $confighash{$cgiparams{'KEY'}}[24];
-       $cgiparams{'PFS'}            = $confighash{$cgiparams{'KEY'}}[28];
-       $cgiparams{'VHOST'}          = $confighash{$cgiparams{'KEY'}}[14];
-       $cgiparams{'DPD_ACTION'}     = $confighash{$cgiparams{'KEY'}}[27];
-       $cgiparams{'DPD_TIMEOUT'}    = $confighash{$cgiparams{'KEY'}}[30];
-       $cgiparams{'DPD_DELAY'}      = $confighash{$cgiparams{'KEY'}}[31];
-       $cgiparams{'FORCE_MOBIKE'}   = $confighash{$cgiparams{'KEY'}}[32];
+       foreach my $key (@temp) {$checked{'ESP_GROUPTYPE'}{$key} = "selected='selected'"; }
 
-       if (!$cgiparams{'DPD_DELAY'}) {
-               $cgiparams{'DPD_DELAY'} = 30;
-       }
+       $checked{'COMPRESSION'} = $cgiparams{'COMPRESSION'} eq 'on' ? "checked='checked'" : '' ;
+       $checked{'FORCE_MOBIKE'} = $cgiparams{'FORCE_MOBIKE'} eq 'on' ? "checked='checked'" : '' ;
+       $checked{'ONLY_PROPOSED'} = $cgiparams{'ONLY_PROPOSED'} eq 'on' ? "checked='checked'" : '' ;
+       $checked{'PFS'} = $cgiparams{'PFS'} eq 'on' ? "checked='checked'" : '' ;
 
-       if (!$cgiparams{'DPD_TIMEOUT'}) {
-               $cgiparams{'DPD_TIMEOUT'} = 120;
-       }
+       $selected{'IKE_VERSION'}{'ikev1'} = '';
+       $selected{'IKE_VERSION'}{'ikev2'} = '';
+       $selected{'IKE_VERSION'}{$cgiparams{'IKE_VERSION'}} = "selected='selected'";
 
-       if ($confighash{$cgiparams{'KEY'}}[3] eq 'net' || $confighash{$cgiparams{'KEY'}}[10]) {
-           $cgiparams{'VHOST'}            = 'off';
-       }
-    }
-
-    ADVANCED_ERROR:
-    $checked{'IKE_ENCRYPTION'}{'aes256'} = '';
-    $checked{'IKE_ENCRYPTION'}{'aes192'} = '';
-    $checked{'IKE_ENCRYPTION'}{'aes128'} = '';
-    $checked{'IKE_ENCRYPTION'}{'aes256gcm128'} = '';
-    $checked{'IKE_ENCRYPTION'}{'aes192gcm128'} = '';
-    $checked{'IKE_ENCRYPTION'}{'aes128gcm128'} = '';
-    $checked{'IKE_ENCRYPTION'}{'aes256gcm96'} = '';
-    $checked{'IKE_ENCRYPTION'}{'aes192gcm96'} = '';
-    $checked{'IKE_ENCRYPTION'}{'aes128gcm96'} = '';
-    $checked{'IKE_ENCRYPTION'}{'aes256gcm64'} = '';
-    $checked{'IKE_ENCRYPTION'}{'aes192gcm64'} = '';
-    $checked{'IKE_ENCRYPTION'}{'aes128gcm64'} = '';
-    $checked{'IKE_ENCRYPTION'}{'3des'} = '';
-    $checked{'IKE_ENCRYPTION'}{'camellia256'} = '';
-    $checked{'IKE_ENCRYPTION'}{'camellia192'} = '';
-    $checked{'IKE_ENCRYPTION'}{'camellia128'} = '';
-    my @temp = split('\|', $cgiparams{'IKE_ENCRYPTION'});
-    foreach my $key (@temp) {$checked{'IKE_ENCRYPTION'}{$key} = "selected='selected'"; }
-    $checked{'IKE_INTEGRITY'}{'sha2_512'} = '';
-    $checked{'IKE_INTEGRITY'}{'sha2_384'} = '';
-    $checked{'IKE_INTEGRITY'}{'sha2_256'} = '';
-    $checked{'IKE_INTEGRITY'}{'sha'} = '';
-    $checked{'IKE_INTEGRITY'}{'md5'} = '';
-    $checked{'IKE_INTEGRITY'}{'aesxcbc'} = '';
-    @temp = split('\|', $cgiparams{'IKE_INTEGRITY'});
-    foreach my $key (@temp) {$checked{'IKE_INTEGRITY'}{$key} = "selected='selected'"; }
-    $checked{'IKE_GROUPTYPE'}{'768'} = '';
-    $checked{'IKE_GROUPTYPE'}{'1024'} = '';
-    $checked{'IKE_GROUPTYPE'}{'1536'} = '';
-    $checked{'IKE_GROUPTYPE'}{'2048'} = '';
-    $checked{'IKE_GROUPTYPE'}{'3072'} = '';
-    $checked{'IKE_GROUPTYPE'}{'4096'} = '';
-    $checked{'IKE_GROUPTYPE'}{'6144'} = '';
-    $checked{'IKE_GROUPTYPE'}{'8192'} = '';
-    @temp = split('\|', $cgiparams{'IKE_GROUPTYPE'});
-    foreach my $key (@temp) {$checked{'IKE_GROUPTYPE'}{$key} = "selected='selected'"; }
-
-    # 768 is not supported by strongswan
-    $checked{'IKE_GROUPTYPE'}{'768'} = '';
-
-    $checked{'ESP_ENCRYPTION'}{'aes256'} = '';
-    $checked{'ESP_ENCRYPTION'}{'aes192'} = '';
-    $checked{'ESP_ENCRYPTION'}{'aes128'} = '';
-    $checked{'ESP_ENCRYPTION'}{'aes256gcm128'} = '';
-    $checked{'ESP_ENCRYPTION'}{'aes192gcm128'} = '';
-    $checked{'ESP_ENCRYPTION'}{'aes128gcm128'} = '';
-    $checked{'ESP_ENCRYPTION'}{'aes256gcm96'} = '';
-    $checked{'ESP_ENCRYPTION'}{'aes192gcm96'} = '';
-    $checked{'ESP_ENCRYPTION'}{'aes128gcm96'} = '';
-    $checked{'ESP_ENCRYPTION'}{'aes256gcm64'} = '';
-    $checked{'ESP_ENCRYPTION'}{'aes192gcm64'} = '';
-    $checked{'ESP_ENCRYPTION'}{'aes128gcm64'} = '';
-    $checked{'ESP_ENCRYPTION'}{'3des'} = '';
-    $checked{'ESP_ENCRYPTION'}{'camellia256'} = '';
-    $checked{'ESP_ENCRYPTION'}{'camellia192'} = '';
-    $checked{'ESP_ENCRYPTION'}{'camellia128'} = '';
-    @temp = split('\|', $cgiparams{'ESP_ENCRYPTION'});
-    foreach my $key (@temp) {$checked{'ESP_ENCRYPTION'}{$key} = "selected='selected'"; }
-    $checked{'ESP_INTEGRITY'}{'sha2_512'} = '';
-    $checked{'ESP_INTEGRITY'}{'sha2_384'} = '';
-    $checked{'ESP_INTEGRITY'}{'sha2_256'} = '';
-    $checked{'ESP_INTEGRITY'}{'sha1'} = '';
-    $checked{'ESP_INTEGRITY'}{'md5'} = '';
-    $checked{'ESP_INTEGRITY'}{'aesxcbc'} = '';
-    @temp = split('\|', $cgiparams{'ESP_INTEGRITY'});
-    foreach my $key (@temp) {$checked{'ESP_INTEGRITY'}{$key} = "selected='selected'"; }
-    $checked{'ESP_GROUPTYPE'}{'768'} = '';
-    $checked{'ESP_GROUPTYPE'}{'1024'} = '';
-    $checked{'ESP_GROUPTYPE'}{'1536'} = '';
-    $checked{'ESP_GROUPTYPE'}{'2048'} = '';
-    $checked{'ESP_GROUPTYPE'}{'3072'} = '';
-    $checked{'ESP_GROUPTYPE'}{'4096'} = '';
-    $checked{'ESP_GROUPTYPE'}{'6144'} = '';
-    $checked{'ESP_GROUPTYPE'}{'8192'} = '';
-    $checked{'ESP_GROUPTYPE'}{'none'} = '';
-    @temp = split('\|', $cgiparams{'ESP_GROUPTYPE'});
-    foreach my $key (@temp) {$checked{'ESP_GROUPTYPE'}{$key} = "selected='selected'"; }
-
-    $checked{'COMPRESSION'} = $cgiparams{'COMPRESSION'} eq 'on' ? "checked='checked'" : '' ;
-    $checked{'FORCE_MOBIKE'} = $cgiparams{'FORCE_MOBIKE'} eq 'on' ? "checked='checked'" : '' ;
-    $checked{'ONLY_PROPOSED'} = $cgiparams{'ONLY_PROPOSED'} eq 'on' ? "checked='checked'" : '' ;
-    $checked{'PFS'} = $cgiparams{'PFS'} eq 'on' ? "checked='checked'" : '' ;
-    $checked{'VHOST'} = $cgiparams{'VHOST'} eq 'on' ? "checked='checked'" : '' ;
-
-    $selected{'IKE_VERSION'}{'ikev1'} = '';
-    $selected{'IKE_VERSION'}{'ikev2'} = '';
-    $selected{'IKE_VERSION'}{$cgiparams{'IKE_VERSION'}} = "selected='selected'";
-
-    $selected{'DPD_ACTION'}{'clear'} = '';
-    $selected{'DPD_ACTION'}{'hold'} = '';
-    $selected{'DPD_ACTION'}{'restart'} = '';
-    $selected{'DPD_ACTION'}{'none'} = '';
-    $selected{'DPD_ACTION'}{$cgiparams{'DPD_ACTION'}} = "selected='selected'";
-
-    &Header::showhttpheaders();
-    &Header::openpage($Lang::tr{'ipsec'}, 1, '');
-    &Header::openbigbox('100%', 'left', '', $errormessage);
-
-    if ($errormessage) {
-       &Header::openbox('100%', 'left', $Lang::tr{'error messages'});
-       print "<class name='base'>$errormessage";
-       print "&nbsp;</class>";
-       &Header::closebox();
-    }
+       $selected{'DPD_ACTION'}{'clear'} = '';
+       $selected{'DPD_ACTION'}{'hold'} = '';
+       $selected{'DPD_ACTION'}{'restart'} = '';
+       $selected{'DPD_ACTION'}{'none'} = '';
+       $selected{'DPD_ACTION'}{$cgiparams{'DPD_ACTION'}} = "selected='selected'";
 
-    if ($warnmessage) {
-       &Header::openbox('100%', 'left', $Lang::tr{'warning messages'});
-       print "<class name='base'>$warnmessage";
-       print "&nbsp;</class>";
-       &Header::closebox();
-    }
+       &Header::showhttpheaders();
+       &Header::openpage($Lang::tr{'ipsec'}, 1, '');
+       &Header::openbigbox('100%', 'left', '', $errormessage);
+
+       if ($errormessage) {
+               &Header::openbox('100%', 'left', $Lang::tr{'error messages'});
+               print "<class name='base'>$errormessage";
+               print "&nbsp;</class>";
+               &Header::closebox();
+       }
 
-    &Header::openbox('100%', 'left', "$Lang::tr{'advanced'}:");
-    print <<EOF
-    <form method='post' enctype='multipart/form-data' action='$ENV{'SCRIPT_NAME'}'>
-    <input type='hidden' name='ADVANCED' value='yes' />
-    <input type='hidden' name='KEY' value='$cgiparams{'KEY'}' />
+       if ($warnmessage) {
+               &Header::openbox('100%', 'left', $Lang::tr{'warning messages'});
+               print "<class name='base'>$warnmessage";
+               print "&nbsp;</class>";
+               &Header::closebox();
+       }
 
-    <table width='100%'>
+       &Header::openbox('100%', 'left', "$Lang::tr{'advanced'}:");
+       print <<EOF
+       <form method='post' enctype='multipart/form-data' action='$ENV{'SCRIPT_NAME'}'>
+       <input type='hidden' name='ADVANCED' value='yes' />
+       <input type='hidden' name='KEY' value='$cgiparams{'KEY'}' />
+
+       <table width='100%'>
        <thead>
                <tr>
                        <th width="15%"></th>
@@ -2564,14 +2557,14 @@ if(($cgiparams{'ACTION'} eq $Lang::tr{'advanced'}) ||
                        </td>
                </tr>
        </tbody>
-    </table>
+       </table>
 
        <br><br>
 
        <h2>$Lang::tr{'dead peer detection'}</h2>
 
-    <table width="100%">
-    <tr>
+       <table width="100%">
+       <tr>
                <td width="15%">$Lang::tr{'dpd action'}:</td>
                <td>
                        <select name='DPD_ACTION'>
@@ -2594,11 +2587,11 @@ if(($cgiparams{'ACTION'} eq $Lang::tr{'advanced'}) ||
                        <input type='text' name='DPD_DELAY' size='5' value='$cgiparams{'DPD_DELAY'}' />
                </td>
        </tr>
-    </table>
+       </table>
 
-    <hr>
+       <hr>
 
-    <table width="100%">
+       <table width="100%">
        <tr>
                <td>
                        <label>
@@ -2632,18 +2625,9 @@ if(($cgiparams{'ACTION'} eq $Lang::tr{'advanced'}) ||
                </td>
        </tr>
 EOF
-    ;
-    if ($confighash{$cgiparams{'KEY'}}[3] eq 'net') {
-       print "<tr><td><input type='hidden' name='VHOST' value='off' /></td></tr>";
-    } elsif ($confighash{$cgiparams{'KEY'}}[10]) {
-       print "<tr><td><label><input type='checkbox' name='VHOST' $checked{'VHOST'} disabled='disabled' />";
-       print " $Lang::tr{'vpn vhost'}</label></td></tr>";
-    } else {
-       print "<tr><td><label><input type='checkbox' name='VHOST' $checked{'VHOST'} />";
-       print " $Lang::tr{'vpn vhost'}</label></td></tr>";
-    }
-
-    print <<EOF;
+;
+
+       print <<EOF;
        <tr>
                <td align='left' colspan='1'><img src='/blob.gif' align='top' alt='*' />&nbsp;$Lang::tr{'required field'}</td>
                <td align='right' colspan='2'>
@@ -2651,58 +2635,58 @@ EOF
                        <input type='submit' name='ACTION' value='$Lang::tr{'cancel'}' />
                </td>
        </tr>
-    </table></form>
+       </table></form>
 EOF
 
-    &Header::closebox();
-    &Header::closebigbox();
-    &Header::closepage();
-    exit(0);
+       &Header::closebox();
+       &Header::closebigbox();
+       &Header::closepage();
+       exit(0);
 
-    ADVANCED_END:
+       ADVANCED_END:
 }
 
 ###
 ### Default status page
 ###
-    %cgiparams = ();
-    %cahash = ();
-    %confighash = ();
-    &General::readhash("${General::swroot}/vpn/settings", \%cgiparams);
-    &General::readhasharray("${General::swroot}/vpn/caconfig", \%cahash);
-    &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
-    $cgiparams{'CA_NAME'} = '';
-
-    my @status = `/usr/local/bin/ipsecctrl I 2>/dev/null`;
-
-    # suggest a default name for this side
-    if ($cgiparams{'VPN_IP'} eq '' && -e "${General::swroot}/red/active") {
-       if (open(IPADDR, "${General::swroot}/red/local-ipaddress")) {
-           my $ipaddr = <IPADDR>;
-           close IPADDR;
-           chomp ($ipaddr);
-           $cgiparams{'VPN_IP'} = (gethostbyaddr(pack("C4", split(/\./, $ipaddr)), 2))[0];
-           if ($cgiparams{'VPN_IP'} eq '') {
-               $cgiparams{'VPN_IP'} = $ipaddr;
-           }
-       }
-    }
-    # no IP found, use %defaultroute
-    $cgiparams{'VPN_IP'} ='%defaultroute' if ($cgiparams{'VPN_IP'} eq '');
-    
-    $cgiparams{'VPN_DELAYED_START'} = 0 if (! defined ($cgiparams{'VPN_DELAYED_START'}));
-    $checked{'ENABLED'} = $cgiparams{'ENABLED'} eq 'on' ? "checked='checked'" : '';
-
-    &Header::showhttpheaders();
-    &Header::openpage($Lang::tr{'ipsec'}, 1, '');
-    &Header::openbigbox('100%', 'left', '', $errormessage);
-
-    if ($errormessage) {
-       &Header::openbox('100%', 'left', $Lang::tr{'error messages'});
-       print "<class name='base'>$errormessage\n";
-       print "&nbsp;</class>\n";
-       &Header::closebox();
-    }
+       %cgiparams = ();
+       %cahash = ();
+       %confighash = ();
+       &General::readhash("${General::swroot}/vpn/settings", \%cgiparams);
+       &General::readhasharray("${General::swroot}/vpn/caconfig", \%cahash);
+       &General::readhasharray("${General::swroot}/vpn/config", \%confighash);
+       $cgiparams{'CA_NAME'} = '';
+
+       my @status = `/usr/local/bin/ipsecctrl I 2>/dev/null`;
+
+       # suggest a default name for this side
+       if ($cgiparams{'VPN_IP'} eq '' && -e "${General::swroot}/red/active") {
+               if (open(IPADDR, "${General::swroot}/red/local-ipaddress")) {
+                       my $ipaddr = <IPADDR>;
+                       close IPADDR;
+                       chomp ($ipaddr);
+                       $cgiparams{'VPN_IP'} = (gethostbyaddr(pack("C4", split(/\./, $ipaddr)), 2))[0];
+                       if ($cgiparams{'VPN_IP'} eq '') {
+                               $cgiparams{'VPN_IP'} = $ipaddr;
+                       }
+               }
+       }
+       # no IP found, use %defaultroute
+       $cgiparams{'VPN_IP'} ='%defaultroute' if ($cgiparams{'VPN_IP'} eq '');
+
+       $cgiparams{'VPN_DELAYED_START'} = 0 if (! defined ($cgiparams{'VPN_DELAYED_START'}));
+       $checked{'ENABLED'} = $cgiparams{'ENABLED'} eq 'on' ? "checked='checked'" : '';
+
+       &Header::showhttpheaders();
+       &Header::openpage($Lang::tr{'ipsec'}, 1, '');
+       &Header::openbigbox('100%', 'left', '', $errormessage);
+
+       if ($errormessage) {
+               &Header::openbox('100%', 'left', $Lang::tr{'error messages'});
+               print "<class name='base'>$errormessage\n";
+               print "&nbsp;</class>\n";
+               &Header::closebox();
+       }
 
        if ($warnmessage) {
                &Header::openbox('100%', 'left', $Lang::tr{'warning messages'});
@@ -2714,61 +2698,61 @@ EOF
                exit 0;
        }
 
-    &Header::openbox('100%', 'left', $Lang::tr{'global settings'});
-    print <<END
-    <form method='post' action='$ENV{'SCRIPT_NAME'}'>
-    <table width='100%'>
-    <tr>
+       &Header::openbox('100%', 'left', $Lang::tr{'global settings'});
+       print <<END
+       <form method='post' action='$ENV{'SCRIPT_NAME'}'>
+       <table width='100%'>
+       <tr>
        <td width='20%' class='base' nowrap='nowrap'>$Lang::tr{'vpn red name'}:&nbsp;<img src='/blob.gif' alt='*' /></td>
        <td width='20%'><input type='text' name='VPN_IP' value='$cgiparams{'VPN_IP'}' /></td>
        <td width='20%' class='base'>$Lang::tr{'enabled'}<input type='checkbox' name='ENABLED' $checked{'ENABLED'} /></td>
-    </tr>
+       </tr>
 END
-    ;
+;
 print <<END
-    <tr>
-       <td  class='base' nowrap='nowrap'>$Lang::tr{'vpn delayed start'}:&nbsp;<img src='/blob.gif' alt='*' /><img src='/blob.gif' alt='*' /></td>
+       <tr>
+       <td class='base' nowrap='nowrap'>$Lang::tr{'vpn delayed start'}:&nbsp;<img src='/blob.gif' alt='*' /><img src='/blob.gif' alt='*' /></td>
        <td ><input type='text' name='VPN_DELAYED_START' value='$cgiparams{'VPN_DELAYED_START'}' /></td>
-    </tr>
-    <tr>
-       <td  class='base' nowrap='nowrap'>$Lang::tr{'host to net vpn'}:</td>
+       </tr>
+       <tr>
+       <td class='base' nowrap='nowrap'>$Lang::tr{'host to net vpn'}:</td>
        <td ><input type='text' name='RW_NET' value='$cgiparams{'RW_NET'}' /></td>
-    </tr>
+       </tr>
 </table>
 <br>
 <hr />
 <table width='100%'>
 <tr>
-    <td class='base' valign='top'><img src='/blob.gif' alt='*' /></td>
-    <td width='70%' class='base' valign='top'>$Lang::tr{'required field'}</td><td width='30%' align='right' class='base'><input type='submit' name='ACTION' value='$Lang::tr{'save'}' /></td>
+       <td class='base' valign='top'><img src='/blob.gif' alt='*' /></td>
+       <td width='70%' class='base' valign='top'>$Lang::tr{'required field'}</td><td width='30%' align='right' class='base'><input type='submit' name='ACTION' value='$Lang::tr{'save'}' /></td>
 </tr>
 <tr>
-    <td class='base' valign='top' nowrap='nowrap'><img src='/blob.gif' alt='*' /><img src='/blob.gif' alt='*' />&nbsp;</td>
-    <td class='base'>  <font class='base'>$Lang::tr{'vpn delayed start help'}</font></td>
-    <td></td>
+       <td class='base' valign='top' nowrap='nowrap'><img src='/blob.gif' alt='*' /><img src='/blob.gif' alt='*' />&nbsp;</td>
+       <td class='base'>       <font class='base'>$Lang::tr{'vpn delayed start help'}</font></td>
+       <td></td>
 </tr>
 </table>
 END
-;              
-    print "</form>";
-    &Header::closebox();
-
-    &Header::openbox('100%', 'left', $Lang::tr{'connection status and controlc'});
-    print <<END
-    <table width='100%' cellspacing='1' cellpadding='0' class='tbl'>
-    <tr>
+;
+       print "</form>";
+       &Header::closebox();
+
+       &Header::openbox('100%', 'left', $Lang::tr{'connection status and controlc'});
+       print <<END
+       <table width='100%' cellspacing='1' cellpadding='0' class='tbl'>
+       <tr>
        <th width='10%' class='boldbase' align='center'><b>$Lang::tr{'name'}</b></th>
        <th width='22%' class='boldbase' align='center'><b>$Lang::tr{'type'}</b></th>
        <th width='23%' class='boldbase' align='center'><b>$Lang::tr{'common name'}</b></th>
        <th width='30%' class='boldbase' align='center'><b>$Lang::tr{'remark'}</b></th>
        <th width='10%' class='boldbase' align='center'><b>$Lang::tr{'status'}</b></th>
        <th class='boldbase' align='center' colspan='6'><b>$Lang::tr{'action'}</b></th>
-    </tr>
+       </tr>
 END
-    ;
-    my $id = 0;
-    my $gif;
-    foreach my $key (sort { ncmp ($confighash{$a}[1],$confighash{$b}[1]) } keys %confighash) {
+;
+       my $id = 0;
+       my $gif;
+       foreach my $key (sort { ncmp ($confighash{$a}[1],$confighash{$b}[1]) } keys %confighash) {
        if ($confighash{$key}[0] eq 'on') { $gif = 'on.gif'; } else { $gif = 'off.gif'; }
 
        if ($id % 2) {
@@ -2781,302 +2765,304 @@ END
        print "<td align='center' nowrap='nowrap' $col>$confighash{$key}[1]</td>";
        print "<td align='center' nowrap='nowrap' $col>" . $Lang::tr{"$confighash{$key}[3]"} . " (" . $Lang::tr{"$confighash{$key}[4]"} . ") $confighash{$key}[29]</td>";
        if ($confighash{$key}[2] eq '%auth-dn') {
-           print "<td align='left' nowrap='nowrap' $col>$confighash{$key}[9]</td>";
+               print "<td align='left' nowrap='nowrap' $col>$confighash{$key}[9]</td>";
        } elsif ($confighash{$key}[4] eq 'cert') {
-           print "<td align='left' nowrap='nowrap' $col>$confighash{$key}[2]</td>";
+               print "<td align='left' nowrap='nowrap' $col>$confighash{$key}[2]</td>";
        } else {
-           print "<td align='left' $col>&nbsp;</td>";
+               print "<td align='left' $col>&nbsp;</td>";
        }
        print "<td align='center' $col>$confighash{$key}[25]</td>";
        my $col1="bgcolor='${Header::colourred}'";
        # get real state
        my $active = "<b><font color='#FFFFFF'>$Lang::tr{'capsclosed'}</font></b>";
        foreach my $line (@status) {
-           if (($line =~ /\"$confighash{$key}[1]\".*IPsec SA established/) ||
-              ($line =~ /$confighash{$key}[1]\{.*INSTALLED/))
-           {
-               $col1="bgcolor='${Header::colourgreen}'";
-               $active = "<b><font color='#FFFFFF'>$Lang::tr{'capsopen'}</font></b>";
-           }
-       }
-       # move to blueif really down
+               if (($line =~ /\"$confighash{$key}[1]\".*IPsec SA established/) ||
+               ($line =~ /$confighash{$key}[1]\{.*INSTALLED/)) {
+                       $col1="bgcolor='${Header::colourgreen}'";
+                       $active = "<b><font color='#FFFFFF'>$Lang::tr{'capsopen'}</font></b>";
+               }
+       }
+       # move to blue if really down
        if ($confighash{$key}[0] eq 'off' && $col1 =~ /${Header::colourred}/ ) {
                $col1="bgcolor='${Header::colourblue}'";
-           $active = "<b><font color='#FFFFFF'>$Lang::tr{'capsclosed'}</font></b>";
+               $active = "<b><font color='#FFFFFF'>$Lang::tr{'capsclosed'}</font></b>";
        }
        print <<END
        <td align='center' $col1>$active</td>
        <td align='center' $col>
-           <form method='post' action='$ENV{'SCRIPT_NAME'}'>
-           <input type='image'  name='$Lang::tr{'restart'}' src='/images/reload.gif' alt='$Lang::tr{'restart'}' title='$Lang::tr{'restart'}' />
-           <input type='hidden' name='ACTION' value='$Lang::tr{'restart'}' />
-           <input type='hidden' name='KEY' value='$key' />
-           </form>
+               <form method='post' action='$ENV{'SCRIPT_NAME'}'>
+               <input type='image' name='$Lang::tr{'restart'}' src='/images/reload.gif' alt='$Lang::tr{'restart'}' title='$Lang::tr{'restart'}' />
+               <input type='hidden' name='ACTION' value='$Lang::tr{'restart'}' />
+               <input type='hidden' name='KEY' value='$key' />
+               </form>
        </td>
 END
-       ;
+;
        if (($confighash{$key}[4] eq 'cert') && ($confighash{$key}[2] ne '%auth-dn')) {
-           print <<END
-           <td align='center' $col>
-           <form method='post' action='$ENV{'SCRIPT_NAME'}'>
+               print <<END
+               <td align='center' $col>
+               <form method='post' action='$ENV{'SCRIPT_NAME'}'>
                <input type='image' name='$Lang::tr{'show certificate'}' src='/images/info.gif' alt='$Lang::tr{'show certificate'}' title='$Lang::tr{'show certificate'}' />
                <input type='hidden' name='ACTION' value='$Lang::tr{'show certificate'}' />
                <input type='hidden' name='KEY' value='$key' />
-           </form>
-           </td>
+               </form>
+               </td>
 END
-       ; } else {
-           print "<td width='2%' $col>&nbsp;</td>";
+;
+       } else {
+               print "<td width='2%' $col>&nbsp;</td>";
        }
-       if ($confighash{$key}[4] eq 'cert' && -f "${General::swroot}/certs/$confighash{$key}[1].p12") { 
-           print <<END
-           <td align='center' $col>
-           <form method='post' action='$ENV{'SCRIPT_NAME'}'>
+       if ($confighash{$key}[4] eq 'cert' && -f "${General::swroot}/certs/$confighash{$key}[1].p12") {
+               print <<END
+               <td align='center' $col>
+               <form method='post' action='$ENV{'SCRIPT_NAME'}'>
                <input type='image' name='$Lang::tr{'download pkcs12 file'}' src='/images/floppy.gif' alt='$Lang::tr{'download pkcs12 file'}' title='$Lang::tr{'download pkcs12 file'}' />
                <input type='hidden' name='ACTION' value='$Lang::tr{'download pkcs12 file'}' />
                <input type='hidden' name='KEY' value='$key' />
-           </form>
+               </form>
        </td>
 END
-       ; } elsif (($confighash{$key}[4] eq 'cert') && ($confighash{$key}[2] ne '%auth-dn')) {
-           print <<END
-           <td align='center' $col>
-           <form method='post' action='$ENV{'SCRIPT_NAME'}'>
+;
+       } elsif (($confighash{$key}[4] eq 'cert') && ($confighash{$key}[2] ne '%auth-dn')) {
+               print <<END
+               <td align='center' $col>
+               <form method='post' action='$ENV{'SCRIPT_NAME'}'>
                <input type='image' name='$Lang::tr{'download certificate'}' src='/images/floppy.gif' alt='$Lang::tr{'download certificate'}' title='$Lang::tr{'download certificate'}' />
                <input type='hidden' name='ACTION' value='$Lang::tr{'download certificate'}' />
                <input type='hidden' name='KEY' value='$key' />
-           </form>
+               </form>
        </td>
 END
-       ; } else {
-           print "<td width='2%' $col>&nbsp;</td>";
+;
+       } else {
+               print "<td width='2%' $col>&nbsp;</td>";
        }
        print <<END
        <td align='center' $col>
-           <form method='post' action='$ENV{'SCRIPT_NAME'}'>
-           <input type='image' name='$Lang::tr{'toggle enable disable'}' src='/images/$gif' alt='$Lang::tr{'toggle enable disable'}' title='$Lang::tr{'toggle enable disable'}' />
-           <input type='hidden' name='ACTION' value='$Lang::tr{'toggle enable disable'}' />
-           <input type='hidden' name='KEY' value='$key' />
-           </form>
+               <form method='post' action='$ENV{'SCRIPT_NAME'}'>
+               <input type='image' name='$Lang::tr{'toggle enable disable'}' src='/images/$gif' alt='$Lang::tr{'toggle enable disable'}' title='$Lang::tr{'toggle enable disable'}' />
+               <input type='hidden' name='ACTION' value='$Lang::tr{'toggle enable disable'}' />
+               <input type='hidden' name='KEY' value='$key' />
+               </form>
        </td>
 
        <td align='center' $col>
-           <form method='post' action='$ENV{'SCRIPT_NAME'}'>
-           <input type='hidden' name='ACTION' value='$Lang::tr{'edit'}' />
-           <input type='image' name='$Lang::tr{'edit'}' src='/images/edit.gif' alt='$Lang::tr{'edit'}' title='$Lang::tr{'edit'}' />
-           <input type='hidden' name='KEY' value='$key' />
-           </form>
+               <form method='post' action='$ENV{'SCRIPT_NAME'}'>
+               <input type='hidden' name='ACTION' value='$Lang::tr{'edit'}' />
+               <input type='image' name='$Lang::tr{'edit'}' src='/images/edit.gif' alt='$Lang::tr{'edit'}' title='$Lang::tr{'edit'}' />
+               <input type='hidden' name='KEY' value='$key' />
+               </form>
        </td>
        <td align='center' $col>
-           <form method='post' action='$ENV{'SCRIPT_NAME'}'>
-           <input type='hidden' name='ACTION' value='$Lang::tr{'remove'}' />
-           <input type='image'  name='$Lang::tr{'remove'}' src='/images/delete.gif' alt='$Lang::tr{'remove'}' title='$Lang::tr{'remove'}' />
-           <input type='hidden' name='KEY' value='$key' />
-           </form>
+               <form method='post' action='$ENV{'SCRIPT_NAME'}'>
+               <input type='hidden' name='ACTION' value='$Lang::tr{'remove'}' />
+               <input type='image' name='$Lang::tr{'remove'}' src='/images/delete.gif' alt='$Lang::tr{'remove'}' title='$Lang::tr{'remove'}' />
+               <input type='hidden' name='KEY' value='$key' />
+               </form>
        </td>
        </tr>
 END
-       ;
+;
        $id++;
-    }
-    print "</table>";
-
-    # If the config file contains entries, print Key to action icons
-    if ( $id ) {
-    print <<END
-    <table>
-    <tr>
-       <td class='boldbase'>&nbsp; <b>$Lang::tr{'legend'}:</b></td>
-       <td>&nbsp; <img src='/images/on.gif' alt='$Lang::tr{'click to disable'}' /></td>
-       <td class='base'>$Lang::tr{'click to disable'}</td>
-       <td>&nbsp; &nbsp; <img src='/images/info.gif' alt='$Lang::tr{'show certificate'}' /></td>
-       <td class='base'>$Lang::tr{'show certificate'}</td>
-       <td>&nbsp; &nbsp; <img src='/images/edit.gif' alt='$Lang::tr{'edit'}' /></td>
-       <td class='base'>$Lang::tr{'edit'}</td>
-       <td>&nbsp; &nbsp; <img src='/images/delete.gif' alt='$Lang::tr{'remove'}' /></td>
-       <td class='base'>$Lang::tr{'remove'}</td>
-    </tr>
-    <tr>
-       <td>&nbsp; </td>
-       <td>&nbsp; <img src='/images/off.gif' alt='?OFF' /></td>
-       <td class='base'>$Lang::tr{'click to enable'}</td>
-       <td>&nbsp; &nbsp; <img src='/images/floppy.gif' alt='?FLOPPY' /></td>
-       <td class='base'>$Lang::tr{'download certificate'}</td>
-       <td>&nbsp; &nbsp; <img src='/images/reload.gif' alt='?RELOAD'/></td>
-       <td class='base'>$Lang::tr{'restart'}</td>
-    </tr>
-    </table>
+       }
+       print "</table>";
+
+       # If the config file contains entries, print Key to action icons
+       if ( $id ) {
+               print <<END
+               <table>
+               <tr>
+               <td class='boldbase'>&nbsp; <b>$Lang::tr{'legend'}:</b></td>
+               <td>&nbsp; <img src='/images/on.gif' alt='$Lang::tr{'click to disable'}' /></td>
+               <td class='base'>$Lang::tr{'click to disable'}</td>
+               <td>&nbsp; &nbsp; <img src='/images/info.gif' alt='$Lang::tr{'show certificate'}' /></td>
+               <td class='base'>$Lang::tr{'show certificate'}</td>
+               <td>&nbsp; &nbsp; <img src='/images/edit.gif' alt='$Lang::tr{'edit'}' /></td>
+               <td class='base'>$Lang::tr{'edit'}</td>
+               <td>&nbsp; &nbsp; <img src='/images/delete.gif' alt='$Lang::tr{'remove'}' /></td>
+               <td class='base'>$Lang::tr{'remove'}</td>
+               </tr>
+               <tr>
+               <td>&nbsp; </td>
+               <td>&nbsp; <img src='/images/off.gif' alt='?OFF' /></td>
+               <td class='base'>$Lang::tr{'click to enable'}</td>
+               <td>&nbsp; &nbsp; <img src='/images/floppy.gif' alt='?FLOPPY' /></td>
+               <td class='base'>$Lang::tr{'download certificate'}</td>
+               <td>&nbsp; &nbsp; <img src='/images/reload.gif' alt='?RELOAD'/></td>
+               <td class='base'>$Lang::tr{'restart'}</td>
+               </tr>
+               </table>
 END
-    ;
-    }
+;
+       }
 
-    print <<END
-    <table width='100%'>
-    <tr><td align='right' colspan='9'>
+       print <<END
+       <table width='100%'>
+       <tr><td align='right' colspan='9'>
        <form method='post' action='$ENV{'SCRIPT_NAME'}'>
        <input type='submit' name='ACTION' value='$Lang::tr{'add'}' />
        </form>
-    </td></tr>
-    </table>
+       </td></tr>
+       </table>
 END
-    ;
-    &Header::closebox();
+;
+       &Header::closebox();
 
-    &Header::openbox('100%', 'left', "$Lang::tr{'certificate authorities'}");
-    print <<EOF
-    <table width='100%' cellspacing='1' cellpadding='0' class='tbl'>
-    <tr>
+       &Header::openbox('100%', 'left', "$Lang::tr{'certificate authorities'}");
+       print <<EOF
+       <table width='100%' cellspacing='1' cellpadding='0' class='tbl'>
+       <tr>
        <th width='25%' class='boldbase' align='center'><b>$Lang::tr{'name'}</b></th>
        <th width='65%' class='boldbase' align='center'><b>$Lang::tr{'subject'}</b></th>
        <th width='10%' class='boldbase' colspan='3' align='center'><b>$Lang::tr{'action'}</b></th>
-    </tr>
+       </tr>
 EOF
-    ;
-    my $col1="bgcolor='$color{'color22'}'";
+;
+       my $col1="bgcolor='$color{'color22'}'";
        my $col2="bgcolor='$color{'color20'}'";
-    if (-f "${General::swroot}/ca/cacert.pem") {
-       my $casubject = &Header::cleanhtml(getsubjectfromcert ("${General::swroot}/ca/cacert.pem"));
-       print <<END
-       <tr>
-       <td class='base' $col1>$Lang::tr{'root certificate'}</td>
-       <td class='base' $col1>$casubject</td>
-       <td width='3%' align='center' $col1>
-           <form method='post' action='$ENV{'SCRIPT_NAME'}'>
-           <input type='hidden' name='ACTION' value='$Lang::tr{'show root certificate'}' />
-           <input type='image' name='$Lang::tr{'edit'}' src='/images/info.gif' alt='$Lang::tr{'show root certificate'}' title='$Lang::tr{'show root certificate'}' />
-           </form>
-       </td>
-       <td width='3%' align='center' $col1>
-           <form method='post' action='$ENV{'SCRIPT_NAME'}'>
-           <input type='image' name='$Lang::tr{'download root certificate'}' src='/images/floppy.gif' alt='$Lang::tr{'download root certificate'}' title='$Lang::tr{'download root certificate'}' />
-           <input type='hidden' name='ACTION' value='$Lang::tr{'download root certificate'}' />
-           </form>
-       </td>
-       <td width='4%' $col1>&nbsp;</td></tr>
+       if (-f "${General::swroot}/ca/cacert.pem") {
+               my $casubject = &Header::cleanhtml(getsubjectfromcert ("${General::swroot}/ca/cacert.pem"));
+               print <<END
+               <tr>
+               <td class='base' $col1>$Lang::tr{'root certificate'}</td>
+               <td class='base' $col1>$casubject</td>
+               <td width='3%' align='center' $col1>
+                       <form method='post' action='$ENV{'SCRIPT_NAME'}'>
+                       <input type='hidden' name='ACTION' value='$Lang::tr{'show root certificate'}' />
+                       <input type='image' name='$Lang::tr{'edit'}' src='/images/info.gif' alt='$Lang::tr{'show root certificate'}' title='$Lang::tr{'show root certificate'}' />
+                       </form>
+               </td>
+               <td width='3%' align='center' $col1>
+                       <form method='post' action='$ENV{'SCRIPT_NAME'}'>
+                       <input type='image' name='$Lang::tr{'download root certificate'}' src='/images/floppy.gif' alt='$Lang::tr{'download root certificate'}' title='$Lang::tr{'download root certificate'}' />
+                       <input type='hidden' name='ACTION' value='$Lang::tr{'download root certificate'}' />
+                       </form>
+               </td>
+               <td width='4%' $col1>&nbsp;</td></tr>
 END
-       ;
-    } else {
-       # display rootcert generation buttons
-       print <<END
-       <tr>
-       <td class='base' $col1>$Lang::tr{'root certificate'}:</td>
-       <td class='base' $col1>$Lang::tr{'not present'}</td>
-       <td colspan='3' $col1>&nbsp;</td></tr>
+;
+       } else {
+               # display rootcert generation buttons
+               print <<END
+               <tr>
+               <td class='base' $col1>$Lang::tr{'root certificate'}:</td>
+               <td class='base' $col1>$Lang::tr{'not present'}</td>
+               <td colspan='3' $col1>&nbsp;</td></tr>
 END
-       ;
-    }
+;
+       }
 
-    if (-f "${General::swroot}/certs/hostcert.pem") {
-       my $hostsubject = &Header::cleanhtml(getsubjectfromcert ("${General::swroot}/certs/hostcert.pem"));
+       if (-f "${General::swroot}/certs/hostcert.pem") {
+               my $hostsubject = &Header::cleanhtml(getsubjectfromcert ("${General::swroot}/certs/hostcert.pem"));
 
-       print <<END
-       <tr>
-       <td class='base' $col2>$Lang::tr{'host certificate'}</td>
-       <td class='base' $col2>$hostsubject</td>
-       <td width='3%' align='center' $col2>
-           <form method='post' action='$ENV{'SCRIPT_NAME'}'>
-           <input type='hidden' name='ACTION' value='$Lang::tr{'show host certificate'}' />
-           <input type='image' name='$Lang::tr{'show host certificate'}' src='/images/info.gif' alt='$Lang::tr{'show host certificate'}' title='$Lang::tr{'show host certificate'}' />
-           </form>
-       </td>
-       <td width='3%' align='center' $col2>
-           <form method='post' action='$ENV{'SCRIPT_NAME'}'>
-           <input type='image' name="$Lang::tr{'download host certificate'}" src='/images/floppy.gif' alt="$Lang::tr{'download host certificate'}" title="$Lang::tr{'download host certificate'}" />
-           <input type='hidden' name='ACTION' value="$Lang::tr{'download host certificate'}" />
-           </form>
-       </td>
-       <td width='4%' $col2>&nbsp;</td></tr>
+               print <<END
+               <tr>
+               <td class='base' $col2>$Lang::tr{'host certificate'}</td>
+               <td class='base' $col2>$hostsubject</td>
+               <td width='3%' align='center' $col2>
+                       <form method='post' action='$ENV{'SCRIPT_NAME'}'>
+                       <input type='hidden' name='ACTION' value='$Lang::tr{'show host certificate'}' />
+                       <input type='image' name='$Lang::tr{'show host certificate'}' src='/images/info.gif' alt='$Lang::tr{'show host certificate'}' title='$Lang::tr{'show host certificate'}' />
+                       </form>
+               </td>
+               <td width='3%' align='center' $col2>
+                       <form method='post' action='$ENV{'SCRIPT_NAME'}'>
+                       <input type='image' name="$Lang::tr{'download host certificate'}" src='/images/floppy.gif' alt="$Lang::tr{'download host certificate'}" title="$Lang::tr{'download host certificate'}" />
+                       <input type='hidden' name='ACTION' value="$Lang::tr{'download host certificate'}" />
+                       </form>
+               </td>
+               <td width='4%' $col2>&nbsp;</td></tr>
 END
-       ;
-    } else {
-       # Nothing
-       print <<END
-       <tr>
-       <td width='25%' class='base' $col2>$Lang::tr{'host certificate'}:</td>
-       <td class='base' $col2>$Lang::tr{'not present'}</td>
-       <td colspan='3' $col2>&nbsp;</td></tr>
+;
+       } else {
+               # Nothing
+               print <<END
+               <tr>
+               <td width='25%' class='base' $col2>$Lang::tr{'host certificate'}:</td>
+               <td class='base' $col2>$Lang::tr{'not present'}</td>
+               <td colspan='3' $col2>&nbsp;</td></tr>
 END
-       ;
-    }
+;
+       }
+
        my $rowcolor = 0;
        if (keys %cahash > 0) {
                foreach my $key (keys %cahash) {
-                       if ($rowcolor++ % 2) {
-                               print "<tr>";
-                               $col="bgcolor='$color{'color20'}'";
-                       } else {
-                               print "<tr>";
-                               $col="bgcolor='$color{'color22'}'";
-                       }
-           print "<td class='base' $col>$cahash{$key}[0]</td>\n";
-           print "<td class='base' $col>$cahash{$key}[1]</td>\n";
-           print <<END
-           <td align='center' $col>
-               <form method='post' name='cafrm${key}a' action='$ENV{'SCRIPT_NAME'}'>
-               <input type='image' name='$Lang::tr{'show ca certificate'}' src='/images/info.gif' alt='$Lang::tr{'show ca certificate'}' title='$Lang::tr{'show ca certificate'}' />
-               <input type='hidden' name='ACTION' value='$Lang::tr{'show ca certificate'}' />
-               <input type='hidden' name='KEY' value='$key' />
-               </form>
-           </td>
-           <td align='center' $col>
-               <form method='post' name='cafrm${key}b' action='$ENV{'SCRIPT_NAME'}'>
-               <input type='image' name='$Lang::tr{'download ca certificate'}' src='/images/floppy.gif' alt='$Lang::tr{'download ca certificate'}' title='$Lang::tr{'download ca certificate'}' />
-               <input type='hidden' name='ACTION' value='$Lang::tr{'download ca certificate'}' />
-               <input type='hidden' name='KEY' value='$key' />
-               </form>
-           </td>
-           <td align='center' $col>
-               <form method='post' name='cafrm${key}c' action='$ENV{'SCRIPT_NAME'}'>
-               <input type='hidden' name='ACTION' value='$Lang::tr{'remove ca certificate'}' />
-               <input type='image'  name='$Lang::tr{'remove ca certificate'}' src='/images/delete.gif' alt='$Lang::tr{'remove ca certificate'}' title='$Lang::tr{'remove ca certificate'}' />
-               <input type='hidden' name='KEY' value='$key' />
-               </form>
-           </td>
-           </tr>
+                               if ($rowcolor++ % 2) {
+                                       print "<tr>";
+                                       $col="bgcolor='$color{'color20'}'";
+                               } else {
+                                       print "<tr>";
+                                       $col="bgcolor='$color{'color22'}'";
+                               }
+                       print "<td class='base' $col>$cahash{$key}[0]</td>\n";
+                       print "<td class='base' $col>$cahash{$key}[1]</td>\n";
+                       print <<END
+                       <td align='center' $col>
+                       <form method='post' name='cafrm${key}a' action='$ENV{'SCRIPT_NAME'}'>
+                       <input type='image' name='$Lang::tr{'show ca certificate'}' src='/images/info.gif' alt='$Lang::tr{'show ca certificate'}' title='$Lang::tr{'show ca certificate'}' />
+                       <input type='hidden' name='ACTION' value='$Lang::tr{'show ca certificate'}' />
+                       <input type='hidden' name='KEY' value='$key' />
+                       </form>
+                       </td>
+                       <td align='center' $col>
+                       <form method='post' name='cafrm${key}b' action='$ENV{'SCRIPT_NAME'}'>
+                       <input type='image' name='$Lang::tr{'download ca certificate'}' src='/images/floppy.gif' alt='$Lang::tr{'download ca certificate'}' title='$Lang::tr{'download ca certificate'}' />
+                       <input type='hidden' name='ACTION' value='$Lang::tr{'download ca certificate'}' />
+                       <input type='hidden' name='KEY' value='$key' />
+                       </form>
+                       </td>
+                       <td align='center' $col>
+                       <form method='post' name='cafrm${key}c' action='$ENV{'SCRIPT_NAME'}'>
+                       <input type='hidden' name='ACTION' value='$Lang::tr{'remove ca certificate'}' />
+                       <input type='image' name='$Lang::tr{'remove ca certificate'}' src='/images/delete.gif' alt='$Lang::tr{'remove ca certificate'}' title='$Lang::tr{'remove ca certificate'}' />
+                       <input type='hidden' name='KEY' value='$key' />
+                       </form>
+                       </td>
+                       </tr>
 END
-           ;
+;
+               }
        }
-    }
-    print "</table>";
-
-    # If the file contains entries, print Key to action icons
-    if ( -f "${General::swroot}/ca/cacert.pem") {
-       print <<END
-       <table><tr>
-       <td class='boldbase'>&nbsp; <b>$Lang::tr{'legend'}:</b></td>
-       <td>&nbsp; &nbsp; <img src='/images/info.gif' alt='$Lang::tr{'show certificate'}' /></td>
-       <td class='base'>$Lang::tr{'show certificate'}</td>
-       <td>&nbsp; &nbsp; <img src='/images/floppy.gif' alt='$Lang::tr{'download certificate'}' /></td>
-       <td class='base'>$Lang::tr{'download certificate'}</td>
-       </tr></table>
+       print "</table>";
+
+       # If the file contains entries, print Key to action icons
+       if ( -f "${General::swroot}/ca/cacert.pem") {
+               print <<END
+               <table><tr>
+               <td class='boldbase'>&nbsp; <b>$Lang::tr{'legend'}:</b></td>
+               <td>&nbsp; &nbsp; <img src='/images/info.gif' alt='$Lang::tr{'show certificate'}' /></td>
+               <td class='base'>$Lang::tr{'show certificate'}</td>
+               <td>&nbsp; &nbsp; <img src='/images/floppy.gif' alt='$Lang::tr{'download certificate'}' /></td>
+               <td class='base'>$Lang::tr{'download certificate'}</td>
+               </tr></table>
 END
-       ;
-    }
-    my $createCA = -f "${General::swroot}/ca/cacert.pem" ? '' : "<tr><td colspan='3'></td><td><input type='submit' name='ACTION' value='$Lang::tr{'generate root/host certificates'}' /></td></tr>";
-    print <<END
-    <br>
-    <hr />
-    <form method='post' enctype='multipart/form-data' action='$ENV{'SCRIPT_NAME'}'>
-    <table width='100%' border='0' cellspacing='1' cellpadding='0'>
-    $createCA
-    <tr>
+;
+       }
+       my $createCA = -f "${General::swroot}/ca/cacert.pem" ? '' : "<tr><td colspan='3'></td><td><input type='submit' name='ACTION' value='$Lang::tr{'generate root/host certificates'}' /></td></tr>";
+       print <<END
+       <br>
+       <hr />
+       <form method='post' enctype='multipart/form-data' action='$ENV{'SCRIPT_NAME'}'>
+       <table width='100%' border='0' cellspacing='1' cellpadding='0'>
+       $createCA
+       <tr>
        <td class='base' nowrap='nowrap'>$Lang::tr{'ca name'}:&nbsp;<img src='/blob.gif' alt='*' /></td>
        <td nowrap='nowrap'><input type='text' name='CA_NAME' value='$cgiparams{'CA_NAME'}' size='15' /> </td>
        <td nowrap='nowrap'><input type='file' name='FH' size='30' /></td>
        <td nowrap='nowrap'><input type='submit' name='ACTION' value='$Lang::tr{'upload ca certificate'}' /></td>
-    </tr>
-    <tr>
+       </tr>
+       <tr>
        <td colspan='3'>$Lang::tr{'resetting the vpn configuration will remove the root ca, the host certificate and all certificate based connections'}:</td>
        <td align='right'><input type='submit' name='ACTION' value='$Lang::tr{'remove x509'}' /></td>
-    </tr>
-    </table>
-    </form>
+       </tr>
+       </table>
+       </form>
 END
-    ;
-    &Header::closebox();
-    &Header::closebigbox();
-    &Header::closepage();
+;
+       &Header::closebox();
+       &Header::closebigbox();
+       &Header::closepage();
 
 sub array_unique($) {
        my $array = shift;
@@ -3132,3 +3118,16 @@ sub make_algos($$$$$) {
 
        return &array_unique(\@algos);
 }
+
+sub make_subnets($) {
+       my $subnets = shift;
+
+       my @nets = split(/\|/, $subnets);
+       my @cidr_nets = ();
+       foreach my $net (@nets) {
+               my $cidr_net = &General::ipcidr($net);
+               push(@cidr_nets, $cidr_net);
+       }
+
+       return join(",", @cidr_nets);
+}
index c21bac54abce6b7fee657a57585e6307de24e2c0..cf04d3d5a827f3515c42526ae4bac756875f5e13 100644 (file)
 'dhcp bootp pxe data' => 'Geben Sie optionale BOOTP PXE-Daten für diese feste Zuordnung ein',
 'dhcp configuration' => 'DHCP-Konfiguration',
 'dhcp create fixed leases' => 'Feste Zuordnungen erzeugen',
+'dhcp dns enable update' => 'DNS-Update (RFC2136) aktivieren:',
+'dhcp dns key name' => 'Schlüsselname:',
+'dhcp dns update' => 'DNS-Update',
+'dhcp dns update algo' => 'Algorithmus:',
+'dhcp dns update secret' => 'Schlüssel:',
 'dhcp fixed lease err1' => 'Für eine feste Zuordnung müssen entweder die Hardware Adresse (MAC-Adresse) oder der Hostname oder beide eingetragen werden.',
 'dhcp fixed lease help1' => 'IP Adressen können als FQDN angegeben werden.',
 'dhcp mode' => 'DHCP',
 'urlfilter whitelist always allowed' => 'Erlaube angepasste Whitelist für gesperrte Clients',
 'urlfilter wrong filetype' => 'Die Datei hat nicht die Erweiterung .tar.gz',
 'use' => 'Einsatz',
-'use a pre-shared key' => 'Verwenden Sie einen Pre-Shared Schlüssel:',
+'use a pre-shared key' => 'Pre-Shared-Key verwenden:',
 'use dov' => 'DOV (Data Over Voice) benutzen:',
 'use ibod' => 'Bandwidth on Demand (iBOD) benutzen:',
 'use ipfire red ip' => 'Die klassische ROTE IP, welche von IPFire während der Verbindung verwendet wird',
-'use only proposed settings' => 'Verwenden Sie nur die vorgeschlagenen Einstellungen.',
+'use only proposed settings' => 'Nur die vorgeschlagenen Einstellungen verwenden',
 'used' => 'Benutzt',
 'used memory' => 'Genutzter Speicher',
 'used swap' => 'Genutzter Swap',
 'vpn statistic n2n' => 'OpenVPN-Netz-zu-Netz-Statistik',
 'vpn statistic rw' => 'OpenVPN-Roadwarrior-Statistik',
 'vpn subjectaltname' => 'Subjekt Alternativer Name',
-'vpn vhost' => 'Roadwarrior virtuelle IP (manchmal auch Inner-IP genannt)',
 'vpn watch' => 'Netz-zu-Netz VPN neu starten, wenn sich Remote-IP ändert (DynDNS).',
 'waiting to synchronize clock' => 'Bitte warten, die Uhr wird synchronisiert',
 'warn when traffic reaches' => 'Warnen wenn Traffic x % erreicht',
index 783fd0f52aa847b9c0f017d28bbcacdc09cc80fe..56238ed3e11c671a2301a68b62a0108d99a3a447 100644 (file)
 'dhcp bootp pxe data' => 'Enter optional bootp pxe data for this fixed lease',
 'dhcp configuration' => 'DHCP configuration',
 'dhcp create fixed leases' => 'Create fixed leases',
+'dhcp dns enable update' => 'Enable DNS Update (RFC2136):',
+'dhcp dns key name' => 'Key Name:',
+'dhcp dns update' => 'DNS Update',
+'dhcp dns update algo' => 'Algorithm:',
+'dhcp dns update secret' => 'Secret:',
 'dhcp fixed lease err1' => 'For a fix lease you have to enter the MAC address or the hostname, or you enter both.',
 'dhcp fixed lease help1' => 'IP Addresses might be entered as FQDN',
 'dhcp mode' => 'DHCP',
 'vpn statistic n2n' => 'OpenVPN Net-to-Net Statistics',
 'vpn statistic rw' => 'OpenVPN Roadwarrior Statistics',
 'vpn subjectaltname' => 'Subject Alt Name',
-'vpn vhost' => 'Roadwarrior virtual IP (sometimes called Inner-IP)',
 'vpn watch' => 'Restart net-to-net vpn when remote peer IP changes (dyndns).',
 'waiting to synchronize clock' => 'Waiting to synchronize clock',
 'warn when traffic reaches' => 'Warn when traffic reaches x %',
index c0422b1fecb23951866f098f4be2327b630ae04e..e24e75e56b99886129d478ddf777653ace6a3c3b 100644 (file)
 'vpn red name' => 'Dirección IP pública o FQDN para la interfaz RED o<%defaultroute>',
 'vpn remote id' => 'ID Remoto',
 'vpn subjectaltname' => 'Nombre alternativo en Asunto',
-'vpn vhost' => 'IP virtual Roadwarris (también referida como ip-interior)',
 'vpn watch' => 'Reinciar vpn net-to-net cuando la ip remota cambie (dyndns)',
 'waiting to synchronize clock' => 'Esperando sincronización con el reloj',
 'warn when traffic reaches' => 'Advertir cuando el tráfico alcance x %',
index 43e69a7e21bde83111f5c5fc350df6c5e3ede61c..0d173aef34f5ae17af6decd9bf9d5e16576b0390 100644 (file)
 'vpn red name' => 'IP publique ou nom de domaine complet pour l\'interface ROUGE ou <%defaultroute>',
 'vpn remote id' => 'ID Distant',
 'vpn subjectaltname' => 'Subject Alt Name',
-'vpn vhost' => 'IP Virtuelle Roadwarrior (parfois appelée Inner-IP)',
 'vpn watch' => 'Redémarrer net-to-net VPN si IP hôte distant change (dyndns).',
 'waiting to synchronize clock' => 'Attendre la synchronisation de l\'horloge',
 'warn when traffic reaches' => 'Avertir lorsque le trafic atteint x %',
index 0623bd5abad102c166d2342237277d05398c8d22..950f70026713b0d8264d9bc90c138ce7e8b38cab 100644 (file)
 'vpn red name' => 'IP pubblico o il nome di dominio completo per l\'interfaccia RED o <%defaultroute>',
 'vpn remote id' => 'Remote ID',
 'vpn subjectaltname' => 'Subject Alt Name',
-'vpn vhost' => 'Roadwarrior virtual IP (sometimes called Inner-IP)',
 'vpn watch' => 'Restart net-to-net vpn when remote peer IP changes (dyndns).',
 'waiting to synchronize clock' => 'Waiting to synchronize clock',
 'warn when traffic reaches' => 'Warn when traffic reaches x %',
index f748b74cbfc2e0356a326f5d6c56c267a0ad82f7..9d90a0815c94094e4be3a1ef83b89ec8738c7148 100644 (file)
 'vpn red name' => 'Publiek IP of FQDN voor RODE interface of <%defaultroute>',
 'vpn remote id' => 'Remote ID',
 'vpn subjectaltname' => 'Onderwerp Alt Naam',
-'vpn vhost' => 'Roadwarrior virtual IP (Ook wel Inner-IP genoemd)',
 'vpn watch' => 'Herstart net-to-net vpn wanneer remote peer IP verandert (dyndns).',
 'waiting to synchronize clock' => 'Wachten op synchronisatie van klok',
 'warn when traffic reaches' => 'Waarschuw wanneer verkeer x % bereikt',
index 30cc81edbc340d47bc512796fb0c066b2a1a8e31..47abf2c5f48e682c944fb8978780032c8538afb3 100644 (file)
 'vpn red name' => 'Publiczne IP lub FQDN interfejsu RED lub <%defaultroute>',
 'vpn remote id' => 'Zdalne ID',
 'vpn subjectaltname' => 'Subject Alt Name',
-'vpn vhost' => 'Roadwarrior virtual IP (sometimes called Inner-IP)',
 'vpn watch' => 'Uruchom ponownie vpn net-to-net kiedy zmieni się IP zdalnej końcówki (dyndns).',
 'waiting to synchronize clock' => 'Oczekiwanie na synchronizację zegara',
 'warn when traffic reaches' => 'Ostrzegaj kiedy ruch osiągnie x %',
index 8cf985bd33a6bd5b3a02ba5d9cd9ad4cb1e65cbb..6840f81207146cf630a442b3bc4428ec239e50d6 100644 (file)
 'vpn red name' => 'Внешний IP или FQDN для RED интерфейса или <%defaultroute>',
 'vpn remote id' => 'Удалённый ID',
 'vpn subjectaltname' => 'Subject Alt Name',
-'vpn vhost' => 'Roadwarrior virtual IP (sometimes called Inner-IP)',
 'vpn watch' => 'Перезапускать net-to-net vpn когда удалённый IP меняется (dyndns).',
 'waiting to synchronize clock' => 'Ожидается синхронизация',
 'warn when traffic reaches' => 'Предупреждать когда трафик возрастает до x %',
index 5426a063b234813d4d4bc46d685b22b10a566f9b..782bc007e808f15a53fc2cefdab1f0b2b8ac09d1 100644 (file)
 'vpn red name' => 'KIRMIZI arabirim veya <%defaultroute> için gerçek IP veya FQDN',
 'vpn remote id' => 'Uzak kimlik (ID)',
 'vpn subjectaltname' => 'Alternatif konu adı',
-'vpn vhost' => 'Roadwarrior sanal IP (bazen iç IP olarakta adlandırılır)',
 'vpn watch' => 'Karşı eş IP değiştirdiğinde (dyndns) ağdan-ağa VPN bağlantısını yeniden başlat. Bu DPD ye yardımcı olur.',
 'waiting to synchronize clock' => 'Saat eşleştirmesi bekleniyor',
 'warn when traffic reaches' => 'Trafik x % değere ulaştığında uyar',
index 154fe77f083a0c939f17b87ad8ef808dd5c47248..91dc4fd881b962b17c1421601c539634b0445c3a 100755 (executable)
@@ -20,7 +20,7 @@
 
 include Config
 
-VER        = 11.18.0
+VER        = 11.20.0
 
 THISAPP    = asterisk-$(VER)
 DL_FILE    = $(THISAPP).tar.gz
@@ -28,7 +28,7 @@ DL_FROM    = $(URL_IPFIRE)
 DIR_APP    = $(DIR_SRC)/$(THISAPP)
 TARGET     = $(DIR_INFO)/$(THISAPP)
 PROG       = asterisk
-PAK_VER    = 17
+PAK_VER    = 18
 
 DEPS       = "libsrtp"
 
@@ -46,7 +46,7 @@ asterisk-extra-sounds-en-gsm-1.4.15.tar.gz = $(URL_IPFIRE)/asterisk-extra-sounds
 asterisk-moh-opsound-gsm-2.03.tar.gz = $(URL_IPFIRE)/asterisk-moh-opsound-gsm-2.03.tar.gz
 asterisk-1.4-de-prompts.tar.gz = $(URL_IPFIRE)/asterisk-1.4-de-prompts.tar.gz
 
-$(DL_FILE)_MD5 = 3ddb42b54db200faccd68906df210a40
+$(DL_FILE)_MD5 = d15759b05862250073e2708394ad2f4c
 asterisk-extra-sounds-en-gsm-1.4.15.tar.gz_MD5 = 5099fc65f49008e33ba7fb043a4ec995
 asterisk-moh-opsound-gsm-2.03.tar.gz_MD5 = 09066f55f1358f298bc1a6e4678a3ddf
 asterisk-1.4-de-prompts.tar.gz_MD5 = 626a2b95071a5505851e43874dfbfd5c
index 0bc64474198ba02c16b7f004d40a08dd7e4b16a6..ab6fbdccd9784922ef80ca67150e20b8026ad41d 100644 (file)
@@ -82,9 +82,13 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
        cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/backports-3.18.1-1-ipfire-build.patch
        cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/backports-3.18.1-1-grsecurity.patch
        cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/backports-3.18.1-1-add_usbnet_modules.patch
+ifeq "$(MACHINE)" "x86_64"
+       cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/backports-3.18.1-1_no_dma_sgtable_on_x86_64.patch
+endif
 
        # DVB patches
        cd $(DIR_APP) && patch -Np2 < $(DIR_SRC)/src/patches/v4l-dvb_fix_tua6034_pll.patch
+       cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/linux-3.10-dvb_tevi_s482.patch
 
        # Wlan patches
        cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/compat-drivers-3.8.3-ath_ignore_eeprom_regdomain.patch
index b692d9aa7afe70d8350230ea5e664e0f2c540ba2..750c728c5a0d1ba14d7f86d29559520d6e7b1c30 100644 (file)
--- a/lfs/ddns
+++ b/lfs/ddns
@@ -24,7 +24,7 @@
 
 include Config
 
-VER        = 008
+VER        = 009
 
 THISAPP    = ddns-$(VER)
 DL_FILE    = $(THISAPP).tar.xz
@@ -40,7 +40,7 @@ objects = $(DL_FILE)
 
 $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
 
-$(DL_FILE)_MD5 = f8b9441f18c2667d440d5416ec2e0011
+$(DL_FILE)_MD5 = 31f949d9f417ee7f801cf8aac849a92e
 
 install : $(TARGET)
 
index d23369c569b88da2e81b11df8feeff411c9d9a36..095ab312e3ca27b112607655f85eb320a110c1d5 100644 (file)
@@ -1,7 +1,7 @@
 ###############################################################################
 #                                                                             #
 # IPFire.org - A linux based firewall                                         #
-# Copyright (C) 2007-2014  IPFire Team <info@ipfire.org>                      #
+# Copyright (C) 2007-2015  IPFire Team <info@ipfire.org>                      #
 #                                                                             #
 # This program is free software: you can redistribute it and/or modify        #
 # it under the terms of the GNU General Public License as published by        #
@@ -27,7 +27,7 @@ include Config
 VERSUFIX = ipfire$(KCFG)
 MODPATH = /lib/modules/$(KVER)-$(VERSUFIX)/kernel/drivers/net/ethernet/intel/e1000e
 
-VER        = 3.1.0.2
+VER        = 3.2.4.2
 
 THISAPP    = e1000e-$(VER)
 DL_FILE    = $(THISAPP).tar.gz
@@ -43,7 +43,7 @@ objects = $(DL_FILE)
 
 $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
 
-$(DL_FILE)_MD5 = b8d770160691edd247a90070f45642ce
+$(DL_FILE)_MD5 = da331c268e1b928e896dfa4c71fbe4d9
 
 install : $(TARGET)
 
diff --git a/lfs/igb b/lfs/igb
index fa762e093f20b773405d5da8332db85493067670..85d228c40c564a822b6a92726606771cca012eac 100644 (file)
--- a/lfs/igb
+++ b/lfs/igb
@@ -1,7 +1,7 @@
 ###############################################################################
 #                                                                             #
 # IPFire.org - A linux based firewall                                         #
-# Copyright (C) 2007-2014  IPFire Team <info@ipfire.org>                      #
+# Copyright (C) 2007-2015  IPFire Team <info@ipfire.org>                      #
 #                                                                             #
 # This program is free software: you can redistribute it and/or modify        #
 # it under the terms of the GNU General Public License as published by        #
@@ -27,7 +27,7 @@ include Config
 VERSUFIX   = ipfire$(KCFG)
 MODPATH = /lib/modules/$(KVER)-$(VERSUFIX)/kernel/drivers/net/ethernet/intel/igb/
 
-VER        = 5.2.9.3
+VER        = 5.3.3.2
 
 THISAPP    = igb-$(VER)
 DL_FILE    = $(THISAPP).tar.gz
@@ -43,7 +43,7 @@ objects = $(DL_FILE)
 
 $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
 
-$(DL_FILE)_MD5 = 814395d3b76090f378002bddecfd2dfc
+$(DL_FILE)_MD5 = 2d753a0bd03c949ec08d68c27540044d
 
 install : $(TARGET)
 
index 400594136230363a5ea32c29bab06658cffbe7bb..141fd66d8dd2caf9bd81b82a7397e0adcdb605b1 100755 (executable)
@@ -177,7 +177,6 @@ $(TARGET) :
        ln -sf ../init.d/localnet    /etc/rc.d/rcsysinit.d/S80localnet
        ln -sf ../init.d/firewall    /etc/rc.d/rcsysinit.d/S85firewall
        ln -sf ../init.d/network-trigger /etc/rc.d/rcsysinit.d/S90network-trigger
-       ln -sf ../init.d/network-vlans /etc/rc.d/rcsysinit.d/S91network-vlans
        ln -sf ../init.d/rngd        /etc/rc.d/rcsysinit.d/S92rngd
        ln -sf ../init.d/wlanclient  /etc/rc.d/rc0.d/K82wlanclient
        ln -sf ../init.d/wlanclient  /etc/rc.d/rc3.d/S19wlanclient
index 68be46c8054e6a64053d73feeb017b5e9b54bb03..30119823964b31ccd119d85698d08ee63b22bb23 100644 (file)
--- a/lfs/krb5
+++ b/lfs/krb5
@@ -93,8 +93,8 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
                --enable-dns-for-realm \
                CPPFLAGS="-I/usr/include/et"
 
-       cd $(DIR_APP) && make $(MAKETUNING) $(EXTRA_MAKE)
-       cd $(DIR_APP) && make $(EXTRA_INSTALL) install
+       cd $(DIR_APP) && make #$(MAKETUNING)
+       cd $(DIR_APP) && make install
 
        for LIB in gssapi_krb5 gssrpc k5crypto kadm5clnt kadm5srv \
                        kdb5 kdb_ldap krad krb5 krb5support verto; do \
index b603b48f237702c012f64f8a79daa5dff22b4e73..85b4060d3f005fad499f7cf0d27df45606a9003a 100644 (file)
--- a/lfs/linux
+++ b/lfs/linux
 
 include Config
 
-VER        = 3.14.43
+VER         = 3.14.54
+RPI_PATCHES = 3.14.54-grsec-ipfire1
+A7M_PATCHES = 3.14.54-grsec-ipfire1
+GRS_PATCHES = grsecurity-3.1ipfire-3.14.54-v1.patch.xz
 
-RPI_PATCHES = 3.14.43-grsec-ipfire1
-A7M_PATCHES = 3.14.43-grsec-ipfire1
-GRS_PATCHES = grsecurity-3.1-3.14.43-201505191737.patch.xz
 
 THISAPP    = linux-$(VER)
 DL_FILE    = linux-$(VER).tar.xz
@@ -37,7 +37,7 @@ DIR_APP    = $(DIR_SRC)/$(THISAPP)
 CFLAGS     =
 CXXFLAGS   =
 
-PAK_VER    = 62
+PAK_VER    = 63
 DEPS      = ""
 
 KERNEL_ARCH = $(MACHINE)
@@ -83,10 +83,10 @@ rpi-patches-$(RPI_PATCHES).patch.xz         = $(URL_IPFIRE)/rpi-patches-$(RPI_PATCHES).
 arm7-multi-patches-$(A7M_PATCHES).patch.xz     = $(URL_IPFIRE)/arm7-multi-patches-$(A7M_PATCHES).patch.xz
 $(GRS_PATCHES)                                 = $(URL_IPFIRE)/$(GRS_PATCHES)
 
-$(DL_FILE)_MD5                                 = 927f2343f298dfe531a8371f81356e53
-rpi-patches-$(RPI_PATCHES).patch.xz_MD5                = b5ba925ae1d4279d3ac0f03c27dd16eb
-arm7-multi-patches-$(A7M_PATCHES).patch.xz_MD5 = b9c696fe4f22b05b81c168329ca33c94
-$(GRS_PATCHES)_MD5                             = 35e26b1214b1b0b515ee67e5ce50633a
+$(DL_FILE)_MD5                                 = 61a0568abd96bef9b682d0d46977fbdd
+rpi-patches-$(RPI_PATCHES).patch.xz_MD5                = db92bc85979895efdc6d9da2877ce0ae
+arm7-multi-patches-$(A7M_PATCHES).patch.xz_MD5 = 9092711bcac325c5d0dac5eed98f1c5d
+$(GRS_PATCHES)_MD5                             = 0c1e505cf87177bfb7d62c95e67f10ef
 
 install : $(TARGET)
 
@@ -134,6 +134,9 @@ ifneq "$(KCFG)" "-headers"
        cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/linux-3.7-disable-compat_vdso.patch
 endif
 
+       # Fix ip route list hang introduced with linux 3.14.54
+       cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/linux-3.14.54_fix_ip_route_list.patch
+
        # DVB Patches
        cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/linux-3.14.22-dvbsky.patch
        cd $(DIR_APP) && patch -Np2 < $(DIR_SRC)/src/patches/v4l-dvb_fix_tua6034_pll.patch
@@ -167,8 +170,6 @@ endif
        # r8169 L23 patch
        cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/linux-3.14.32-r8169_disable_L23.patch
 
-       # SuperSSpeed S238 NOTRIM patch
-       cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/linux-3.14.43_SuperSSpeed_NOTRIM.patch
        # update the queued trim blacklist from kernel 4.2rc1
        cd $(DIR_APP) && patch -Np1 < $(DIR_SRC)/src/patches/linux-3.14.43_new_qtrim_blacklist.patch
 
index 92e0760023b1780efd930dd44220d442e977d2e4..453ad0376a08342ad9c7216cf70e40ffdb7eef20 100644 (file)
--- a/lfs/monit
+++ b/lfs/monit
@@ -24,7 +24,7 @@
 
 include Config
 
-VER        = 5.12.1
+VER        = 5.14
 
 THISAPP    = monit-$(VER)
 DL_FILE    = $(THISAPP).tar.gz
@@ -32,7 +32,7 @@ DL_FROM    = $(URL_IPFIRE)
 DIR_APP    = $(DIR_SRC)/$(THISAPP)
 TARGET     = $(DIR_INFO)/$(THISAPP)
 PROG       = monit
-PAK_VER    = 6
+PAK_VER    = 7
 
 DEPS       = ""
 
@@ -44,7 +44,7 @@ objects = $(DL_FILE)
 
 $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
 
-$(DL_FILE)_MD5 = 1ffde79207270925f6f7df787d19100a
+$(DL_FILE)_MD5 = 1b3ae1eb08a0914402a8764e5689c1c5
 
 install : $(TARGET)
 
diff --git a/lfs/sox b/lfs/sox
index 378429d4d198ef082b0bf3db6310f4f257551fe7..de60c90369a65251db90234a11399a7e4ace9aef 100644 (file)
--- a/lfs/sox
+++ b/lfs/sox
@@ -79,7 +79,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
        @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar zxf $(DIR_DL)/$(DL_FILE)
        cd $(DIR_APP) && ./configure --prefix=/usr --disable-alsa-dsp --disable-oss-dsp \
                                --disable-sun-audio --disable-mad
-       cd $(DIR_APP) && make $(MAKETUNING) $(EXTRA_MAKE)
+       cd $(DIR_APP) && make $(EXTRA_MAKE)
        cd $(DIR_APP) && make install
        @rm -rf $(DIR_APP)
        @$(POSTBUILD)
index 3244fa36fa79afc8b946a100173c9ce9784ee5c9..ec5d1170d972eb587045e954ae27bcaff3d1fbe9 100644 (file)
@@ -114,6 +114,8 @@ endif
                /usr/lib/firewall/rules.pl
        install -m 644 $(DIR_SRC)/config/firewall/firewall-lib.pl \
                /usr/lib/firewall/firewall-lib.pl
+       install -m 755 $(DIR_SRC)/config/firewall/ipsec-block \
+               /usr/lib/firewall/ipsec-block
 
        # Nobody user
        -mkdir -p /home/nobody
index b4438dda50dd867a2e6109c166982dc03bf73318..2a181a3304ed21eda8a6daf30f32e97ede97f735 100644 (file)
@@ -24,7 +24,7 @@
 
 include Config
 
-VER        = 5.3.2
+VER        = 5.3.3
 
 THISAPP    = strongswan-$(VER)
 DL_FILE    = $(THISAPP).tar.bz2
@@ -48,7 +48,7 @@ objects = $(DL_FILE)
 
 $(DL_FILE) = $(DL_FROM)/$(DL_FILE)
 
-$(DL_FILE)_MD5 = fab014be1477ef4ebf9a765e10f8802c
+$(DL_FILE)_MD5 = 5a25f3d1c31a77ef44d14a2e7b3eaad0
 
 install : $(TARGET)
 
@@ -99,6 +99,7 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
                --enable-eap-peap \
                --enable-eap-mschapv2 \
                --enable-eap-identity \
+               --disable-chapoly \
                $(CONFIGURE_OPTIONS)
 
        cd $(DIR_APP) && make $(MAKETUNING)
diff --git a/lfs/tor b/lfs/tor
index c21e4b4de8cc27b4382f43fe704b526a54afcead..91eab09b9f19855d6233f90592526e952d71cbab 100644 (file)
--- a/lfs/tor
+++ b/lfs/tor
@@ -32,7 +32,7 @@ DL_FROM    = $(URL_IPFIRE)
 DIR_APP    = $(DIR_SRC)/$(THISAPP)
 TARGET     = $(DIR_INFO)/$(THISAPP)
 PROG       = tor
-PAK_VER    = 14
+PAK_VER    = 15
 
 DEPS       = ""
 
index e58839c405e93a214b37774d3cb06cf83fe1a996..7d5bdbca19106b427367a7f1903aff517536f6d0 100644 (file)
--- a/lfs/udev
+++ b/lfs/udev
@@ -107,6 +107,8 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
        # Install network rules.
        install -v -m 755 $(DIR_SRC)/config/udev/network-hotplug-rename \
                /lib/udev/network-hotplug-rename
+       install -v -m 755 $(DIR_SRC)/config/udev/network-hotplug-vlan \
+               /lib/udev/network-hotplug-vlan
        install -v -m 644 $(DIR_SRC)/config/udev/60-net.rules \
                /lib/udev/rules.d
 
diff --git a/make.sh b/make.sh
index f3072586965fa2e4192a84ef49f6370974c84dfb..ed902c9cc501dc4c584b5bc2a899635a77aeccc3 100755 (executable)
--- a/make.sh
+++ b/make.sh
@@ -25,7 +25,7 @@
 NAME="IPFire"                                                  # Software name
 SNAME="ipfire"                                                 # Short name
 VERSION="2.17"                                                 # Version number
-CORE="94"                                                      # Core Level (Filename)
+CORE="95"                                                      # Core Level (Filename)
 PAKFIRE_CORE="94"                                              # Core Level (PAKFIRE)
 GIT_BRANCH=`git rev-parse --abbrev-ref HEAD`                   # Git Branch
 SLOGAN="www.ipfire.org"                                                # Software slogan
@@ -421,7 +421,7 @@ buildipfire() {
   case "${TARGET_ARCH}" in
        x86_64)
                ipfiremake linux                        KCFG=""
-#              ipfiremake backports                    KCFG=""
+               ipfiremake backports                    KCFG=""
                ipfiremake cryptodev                    KCFG=""
                ipfiremake e1000e                       KCFG=""
                ipfiremake igb                          KCFG=""
@@ -435,7 +435,7 @@ buildipfire() {
                ipfiremake backports                    KCFG="-pae"
                ipfiremake cryptodev                    KCFG="-pae"
                ipfiremake e1000e                       KCFG="-pae"
-#              ipfiremake igb                          KCFG="-pae"
+               ipfiremake igb                          KCFG="-pae"
                ipfiremake ixgbe                        KCFG="-pae"
                ipfiremake xtables-addons               KCFG="-pae"
                ipfiremake linux-initrd                 KCFG="-pae"
@@ -445,7 +445,7 @@ buildipfire() {
                ipfiremake backports                    KCFG=""
                ipfiremake cryptodev                    KCFG=""
                ipfiremake e1000e                       KCFG=""
-#              ipfiremake igb                          KCFG=""
+               ipfiremake igb                          KCFG=""
                ipfiremake ixgbe                        KCFG=""
                ipfiremake xtables-addons               KCFG=""
                ipfiremake linux-initrd                 KCFG=""
@@ -464,7 +464,7 @@ buildipfire() {
                ipfiremake backports                    KCFG="-multi"
                ipfiremake cryptodev                    KCFG="-multi"
                ipfiremake e1000e                       KCFG="-multi"
-#              ipfiremake igb                          KCFG="-multi"
+               ipfiremake igb                          KCFG="-multi"
                ipfiremake ixgbe                        KCFG="-multi"
                ipfiremake xtables-addons               KCFG="-multi"
                ipfiremake linux-initrd                 KCFG="-multi"
@@ -474,7 +474,7 @@ buildipfire() {
                ipfiremake backports                    KCFG="-kirkwood"
                ipfiremake cryptodev                    KCFG="-kirkwood"
                ipfiremake e1000e                       KCFG="-kirkwood"
-#              ipfiremake igb                          KCFG="-kirkwood"
+               ipfiremake igb                          KCFG="-kirkwood"
                ipfiremake ixgbe                        KCFG="-kirkwood"
                ipfiremake xtables-addons               KCFG="-kirkwood"
                ipfiremake linux-initrd                 KCFG="-kirkwood"
index ce7689f4e1ed874d666bf46cb58f3673bcc5916f..059ffacdd8e92abd3bab4f8e93969378afe60531 100644 (file)
@@ -55,6 +55,21 @@ function dns_forward_args() {
        echo "${cmdline}"
 }
 
+function dns_leases_args() {
+       eval $(/usr/local/bin/readhash /var/ipfire/dhcp/settings)
+
+       # If the DHCP server is enabled and DNS Update (RFC2136) is
+       # enabled, too, we won't overlay the internal domain with
+       # the dynamic/static leases.
+
+       if ([ "${ENABLE_GREEN}" = "on" ] || [ "${ENABLE_BLUE}" = "on" ]) \
+                       && [ "${DNS_UPDATE_ENABLED}" = "on" ]; then
+               return
+       fi
+
+       echo "-l /var/state/dhcp/dhcpd.leases"
+}
+
 case "${1}" in
        start)
                # kill already running copy of dnsmasq...
@@ -65,7 +80,10 @@ case "${1}" in
                eval $(/usr/local/bin/readhash /var/ipfire/ethernet/settings)
                ARGS="$CUSTOM_ARGS"
                [ "$DOMAIN_NAME_GREEN" != "" ] && ARGS="$ARGS -s $DOMAIN_NAME_GREEN"
-               
+
+               # DHCP configuration
+               ARGS="${ARGS} $(dns_leases_args)"
+
                echo > /var/ipfire/red/resolv.conf # Clear it
                if [ -e "/var/ipfire/red/dns1" ]; then
                    DNS1=$(cat /var/ipfire/red/dns1 2>/dev/null)
@@ -95,7 +113,7 @@ case "${1}" in
                        ARGS="${ARGS} --cache-size=${CACHE_SIZE}"
                fi
 
-               loadproc /usr/sbin/dnsmasq -l /var/state/dhcp/dhcpd.leases $ARGS
+               loadproc /usr/sbin/dnsmasq ${ARGS}
                
                if [ "${SHOW_SRV}" -eq 1 ] && [ "${DNS1}" != "" -o "${DNS2}" != "" ]; then
                    boot_mesg "Using DNS server(s): ${DNS1} ${DNS2}"
index 8ca02bc9d1932b4530556d5baf29ef0053eb090d..2d462d786d1bf31cb82756d164cac4f7d6bf6abd 100644 (file)
@@ -115,6 +115,11 @@ iptables_init() {
        iptables -A INPUT -j GUARDIAN
        iptables -A FORWARD -j GUARDIAN
 
+       # Block non-established IPsec networks
+       iptables -N IPSECBLOCK
+       iptables -A FORWARD -m policy --dir out --pol none -j IPSECBLOCK
+       iptables -A OUTPUT  -m policy --dir out --pol none -j IPSECBLOCK
+
        # Block OpenVPN transfer networks
        iptables -N OVPNBLOCK
        iptables -A INPUT   -i tun+ -j OVPNBLOCK
@@ -270,6 +275,9 @@ iptables_init() {
        iptables -t nat -N REDNAT
        iptables -t nat -A POSTROUTING -j REDNAT
 
+       # Populate IPsec block chain
+       /usr/lib/firewall/ipsec-block
+
        # Apply OpenVPN firewall rules
        /usr/local/bin/openvpnctrl --firewall-rules
 
index e99202d9fa33cb5ab35121d09ff59f9ed633fd10..7499e94c9a7f384e6d0fd809203d32163cb84e96 100644 (file)
@@ -144,6 +144,9 @@ void turn_connection_on(char *name, char *type) {
                 "/usr/sbin/ipsec down %s >/dev/null", name);
         safe_system(command);
 
+       // Reload the IPsec block chain
+       safe_system("/usr/lib/firewall/ipsec-block >/dev/null");
+
        // Reload the configuration into the daemon (#10339).
        ipsec_reload();
 
@@ -302,6 +305,7 @@ int main(int argc, char *argv[]) {
 
         // start the system
         if ((argc == 2) && strcmp(argv[1], "S") == 0) {
+               safe_system("/usr/lib/firewall/ipsec-block >/dev/null");
                safe_system("/usr/sbin/ipsec restart >/dev/null");
                 exit(0);
         }
diff --git a/src/patches/backports-3.18.1-1_no_dma_sgtable_on_x86_64.patch b/src/patches/backports-3.18.1-1_no_dma_sgtable_on_x86_64.patch
new file mode 100644 (file)
index 0000000..5a2d04e
--- /dev/null
@@ -0,0 +1,26 @@
+diff -Naur backports-4.1.1-1.org/compat/dma-shared-helpers.c backports-4.1.1-1/compat/dma-shared-helpers.c
+--- backports-4.1.1-1.org/compat/dma-shared-helpers.c  2015-07-01 23:10:37.000000000 +0200
++++ backports-4.1.1-1/compat/dma-shared-helpers.c      2015-09-25 13:29:14.006762269 +0200
+@@ -20,22 +20,3 @@
+ #endif /* LINUX_VERSION_CODE <= KERNEL_VERSION(3,6,0) */
+ #endif /* LINUX_VERSION_CODE >= KERNEL_VERSION(3,3,0) */
+-#if RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(7,0)
+-/*
+- * Create scatter-list for the already allocated DMA buffer.
+- */
+-int dma_common_get_sgtable(struct device *dev, struct sg_table *sgt,
+-               void *cpu_addr, dma_addr_t handle, size_t size)
+-{
+-      struct page *page = virt_to_page(cpu_addr);
+-      int ret;
+-
+-      ret = sg_alloc_table(sgt, 1, GFP_KERNEL);
+-      if (unlikely(ret))
+-              return ret;
+-
+-      sg_set_page(sgt->sgl, page, PAGE_ALIGN(size), 0);
+-      return 0;
+-}
+-EXPORT_SYMBOL_GPL(dma_common_get_sgtable);
+-#endif /* RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(7,0) */
diff --git a/src/patches/linux-3.10-dvb_tevi_s482.patch b/src/patches/linux-3.10-dvb_tevi_s482.patch
new file mode 100644 (file)
index 0000000..fed875d
--- /dev/null
@@ -0,0 +1,240 @@
+diff --git a/drivers/media/usb/dvb-usb/dw2102.c b/drivers/media/usb/dvb-usb/dw2102.c
+index 1a3df10..82d35c6 100644
+--- a/drivers/media/usb/dvb-usb/dw2102.c
++++ b/drivers/media/usb/dvb-usb/dw2102.c
+@@ -31,6 +31,9 @@
+ #include "m88rs2000.h"
+ #include "tda18271.h"
+ #include "cxd2820r.h"
++#include "m88ds3103.h"
++#include "m88ts2022.h"
++
+ /* Max transfer size done by I2C transfer functions */
+ #define MAX_XFER_SIZE  64
+@@ -71,6 +74,14 @@
+ #define USB_PID_TEVII_S480_2 0xd482
+ #endif
++#ifndef USB_PID_TEVII_S482_1
++#define USB_PID_TEVII_S482_1 0xd483
++#endif
++
++#ifndef USB_PID_TEVII_S482_2
++#define USB_PID_TEVII_S482_2 0xd484
++#endif
++
+ #ifndef USB_PID_PROF_1100
+ #define USB_PID_PROF_1100 0xb012
+ #endif
+@@ -1117,6 +1128,19 @@ static struct tda18271_config tda18271_config = {
+       .gate = TDA18271_GATE_DIGITAL,
+ };
++static const struct m88ds3103_config s482_m88ds3103_config = {
++      .i2c_addr = 0x68,
++      .clock = 27000000,
++      .i2c_wr_max = 33,
++      .clock_out = 0,
++      .ts_mode = M88DS3103_TS_CI,
++      .ts_clk = 16000,
++      .ts_clk_pol = 0,
++      .agc = 0x99,
++      .lnb_hv_pol = 1,
++      .lnb_en_pol = 1,
++       };
++
+ static u8 m88rs2000_inittab[] = {
+       DEMOD_WRITE, 0x9a, 0x30,
+       DEMOD_WRITE, 0x00, 0x01,
+@@ -1386,6 +1410,83 @@ static int su3000_frontend_attach(struct dvb_usb_adapter *d)
+       return -EIO;
+ }
++static int m88ds3103_frontend_attach(struct dvb_usb_adapter *d)
++{
++      u8 obuf[3] = { 0xe, 0x80, 0 };
++      u8 ibuf[] = { 0 };
++
++      /* demod I2C adapter */
++      struct i2c_adapter *i2c_adapter;
++      struct i2c_client *client;
++      struct i2c_board_info info;
++      struct m88ts2022_config m88ts2022_config = {
++              .clock = 27000000,
++               };
++      memset(&info, 0, sizeof(struct i2c_board_info));
++      if (dvb_usb_generic_rw(d->dev, obuf, 3, ibuf, 1, 0) < 0)
++              err("command 0x0e transfer failed.");
++
++      obuf[0] = 0xe;
++      obuf[1] = 0x02;
++      obuf[2] = 1;
++
++      if (dvb_usb_generic_rw(d->dev, obuf, 3, ibuf, 1, 0) < 0)
++              err("command 0x0e transfer failed.");
++      msleep(300);
++
++      obuf[0] = 0xe;
++      obuf[1] = 0x83;
++      obuf[2] = 0;
++
++      if (dvb_usb_generic_rw(d->dev, obuf, 3, ibuf, 1, 0) < 0)
++              err("command 0x0e transfer failed.");
++
++      obuf[0] = 0xe;
++      obuf[1] = 0x83;
++      obuf[2] = 1;
++
++      if (dvb_usb_generic_rw(d->dev, obuf, 3, ibuf, 1, 0) < 0)
++              err("command 0x0e transfer failed.");
++
++      obuf[0] = 0x51;
++
++      if (dvb_usb_generic_rw(d->dev, obuf, 1, ibuf, 1, 0) < 0)
++              err("command 0x51 transfer failed.");
++      d->fe_adap[0].fe = dvb_attach(m88ds3103_attach,
++              &s482_m88ds3103_config,
++              &d->dev->i2c_adap,
++              &i2c_adapter);
++      if (d->fe_adap[0].fe == NULL)
++              return -EIO;
++      /* attach tuner */
++      m88ts2022_config.fe = d->fe_adap[0].fe;
++      strlcpy(info.type, "m88ts2022", I2C_NAME_SIZE);
++      info.addr = 0x60;
++      info.platform_data = &m88ts2022_config;
++      request_module("m88ts2022");
++      client = i2c_new_device(i2c_adapter, &info);
++      if (client == NULL || client->dev.driver == NULL) {
++              dvb_frontend_detach(d->fe_adap[0].fe);
++              goto fail_attach;
++      }
++      if (!try_module_get(client->dev.driver->owner)) {
++                      i2c_unregister_device(client);
++                              dvb_frontend_detach(d->fe_adap[0].fe);
++                      goto fail_attach;
++      }
++      info("attached m88ds3103/m88ts2022!\n");
++
++      /* delegate signal strength measurement to tuner */
++
++      d->fe_adap[0].fe->ops.read_signal_strength =
++              d->fe_adap[0].fe->ops.tuner_ops.get_rf_strength;
++
++      return 0;
++fail_attach:
++      info("Failed to attach m88ds3103/m88ts2022!\n");
++      return -EIO;
++}
++
+ static int t220_frontend_attach(struct dvb_usb_adapter *d)
+ {
+       u8 obuf[3] = { 0xe, 0x87, 0 };
+@@ -1557,6 +1658,8 @@ enum dw2102_table_entry {
+       TEVII_S480_2,
+       X3M_SPC1400HD,
+       TEVII_S421,
++      TEVII_S482_1,
++      TEVII_S482_2,
+       TEVII_S632,
+       TERRATEC_CINERGY_S2_R2,
+       GOTVIEW_SAT_HD,
+@@ -1580,7 +1683,9 @@ static struct usb_device_id dw2102_table[] = {
+       [TEVII_S480_2] = {USB_DEVICE(0x9022, USB_PID_TEVII_S480_2)},
+       [X3M_SPC1400HD] = {USB_DEVICE(0x1f4d, 0x3100)},
+       [TEVII_S421] = {USB_DEVICE(0x9022, USB_PID_TEVII_S421)},
+-      [TEVII_S632] = {USB_DEVICE(0x9022, USB_PID_TEVII_S632)},
++      [TEVII_S482_1] = { USB_DEVICE(0x9022, USB_PID_TEVII_S482_1) },
++      [TEVII_S482_2] = { USB_DEVICE(0x9022, USB_PID_TEVII_S482_2) },
++      [TEVII_S632] = { USB_DEVICE(0x9022, USB_PID_TEVII_S632) },
+       [TERRATEC_CINERGY_S2_R2] = {USB_DEVICE(USB_VID_TERRATEC, 0x00b0)},
+       [GOTVIEW_SAT_HD] = {USB_DEVICE(0x1FE1, USB_PID_GOTVIEW_SAT_HD)},
+       [GENIATECH_T220] = {USB_DEVICE(0x1f4d, 0xD220)},
+@@ -2012,6 +2117,59 @@ static struct dvb_usb_device_properties su3000_properties = {
+       }
+ };
++static struct dvb_usb_device_properties m88ds3103_properties = {
++      .caps = DVB_USB_IS_AN_I2C_ADAPTER,
++      .usb_ctrl = DEVICE_SPECIFIC,
++      .size_of_priv = sizeof(struct su3000_state),
++      .power_ctrl = su3000_power_ctrl,
++      .num_adapters = 1,
++      .identify_state = su3000_identify_state,
++      .i2c_algo = &su3000_i2c_algo,
++
++      .rc.core = {
++              .rc_interval = 150,
++              .rc_codes = RC_MAP_TEVII_NEC,
++              .module_name = "dw2102",
++              .allowed_protos = RC_BIT_NEC,
++              .rc_query = dw2102_rc_query,
++      },
++
++      .read_mac_address = su3000_read_mac_address,
++
++      .generic_bulk_ctrl_endpoint = 0x01,
++
++      .adapter = {
++              {
++                      .num_frontends = 1,
++                      .fe = { {
++                                      .streaming_ctrl = su3000_streaming_ctrl,
++                                      .frontend_attach = m88ds3103_frontend_attach,
++                                      .stream = {
++                                              .type = USB_BULK,
++                                              .count = 8,
++                                              .endpoint = 0x82,
++                                              .u = {
++                                                      .bulk = {
++                                                              .buffersize = 4096,
++                                                      }
++                                              }
++                                      }
++                              } },
++              }
++              },
++              .num_device_descs = 2,
++              .devices = {
++                      { "TeVii S482.1 USB",
++                      { &dw2102_table[TEVII_S482_1], NULL },
++                      { NULL },
++                      },
++                      { "TeVii S482.2 USB",
++                      { &dw2102_table[TEVII_S482_2], NULL },
++                      { NULL },
++                      },
++                      }
++};
++
+ static struct dvb_usb_device_properties t220_properties = {
+       .caps = DVB_USB_IS_AN_I2C_ADAPTER,
+       .usb_ctrl = DEVICE_SPECIFIC,
+@@ -2131,11 +2289,13 @@ static int dw2102_probe(struct usb_interface *intf,
+           0 == dvb_usb_device_init(intf, p7500,
+                       THIS_MODULE, NULL, adapter_nr) ||
+           0 == dvb_usb_device_init(intf, s421,
+-                      THIS_MODULE, NULL, adapter_nr) ||
+-          0 == dvb_usb_device_init(intf, &su3000_properties,
+-                       THIS_MODULE, NULL, adapter_nr) ||
++                      THIS_MODULE, NULL, adapter_nr)  ||
+           0 == dvb_usb_device_init(intf, &t220_properties,
+-                       THIS_MODULE, NULL, adapter_nr))
++                      THIS_MODULE, NULL, adapter_nr) ||
++              0 == dvb_usb_device_init(intf, &m88ds3103_properties,
++                      THIS_MODULE, NULL, adapter_nr) ||
++              0 == dvb_usb_device_init(intf, &su3000_properties,
++                      THIS_MODULE, NULL, adapter_nr))
+               return 0;
+       return -ENODEV;
+@@ -2153,7 +2313,7 @@ module_usb_driver(dw2102_driver);
+ MODULE_AUTHOR("Igor M. Liplianin (c) liplianin@me.by");
+ MODULE_DESCRIPTION("Driver for DVBWorld DVB-S 2101, 2102, DVB-S2 2104,"
+                       " DVB-C 3101 USB2.0,"
+-                      " TeVii S600, S630, S650, S660, S480, S421, S632"
++                      " TeVii S600, S630, S650, S660, S480, S482, S421, S632"
+                       " Prof 1100, 7500 USB2.0,"
+                       " Geniatech SU3000, T220 devices");
+ MODULE_VERSION("0.1");
diff --git a/src/patches/linux-3.14.54_fix_ip_route_list.patch b/src/patches/linux-3.14.54_fix_ip_route_list.patch
new file mode 100644 (file)
index 0000000..6613d15
--- /dev/null
@@ -0,0 +1,12 @@
+diff -Naur a/net/core/fib_rules.c b/net/core/fib_rules.c
+--- a/net/core/fib_rules.c     2015-10-19 16:40:32.000000000 +0200
++++ b/net/core/fib_rules.c     2015-10-19 16:54:37.836777983 +0200
+@@ -631,7 +631,7 @@
+               err = fib_nl_fill_rule(skb, rule, NETLINK_CB(cb->skb).portid,
+                                      cb->nlh->nlmsg_seq, RTM_NEWRULE,
+                                      NLM_F_MULTI, ops);
+-              if (err)
++              if (err < 0)
+                       break;
+ skip:
+               idx++;