DNS Forwarding: Let UI accept hostnames, too

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

diff --git a/doc/language_issues.en b/doc/language_issues.en
index 392490cb098f2f57892c5cf957b85a4154109449..72a56b96d6d2fd1a60182d7a1a089b930c48afb4 100644 (file)
--- a/doc/language_issues.en
+++ b/doc/language_issues.en
@@ -1121,6 +1121,7 @@ WARNING: untranslated string: invalid input for remote host/ip = Invalid input f
 WARNING: untranslated string: invalid input for state or province = Invalid input for state or province.
 WARNING: untranslated string: invalid input for valid till days = Invalid input for Valid till (days).
 WARNING: untranslated string: invalid ip = Invalid IP Address
+WARNING: untranslated string: invalid ip or hostname = Invalid IP Address or Hostname
 WARNING: untranslated string: invalid keep time = Keep time must be a valid number
 WARNING: untranslated string: invalid key = Invalid key.
 WARNING: untranslated string: invalid local-remote id = local & remote id must not be equal and begin with a "@" sign. These are leftid and rightid in strongswan terminology.

diff --git a/doc/language_issues.es b/doc/language_issues.es
index 581b99a0ab62d1fc6f40bd06a911baf24027e500..caf8fc497c9dd1d9d9957f3ef9a85ff5d9f3de7c 100644 (file)
--- a/doc/language_issues.es
+++ b/doc/language_issues.es
@@ -1029,6 +1029,7 @@ WARNING: untranslated string: invalid input for dpd delay = Invalid input for DP
 WARNING: untranslated string: invalid input for dpd timeout = Invalid input for DPD timeout
 WARNING: untranslated string: invalid input for inactivity timeout = Invalid input for Inactivity Timeout
 WARNING: untranslated string: invalid input for valid till days = Invalid input for Valid till (days).
+WARNING: untranslated string: invalid ip or hostname = Invalid IP Address or Hostname
 WARNING: untranslated string: invalid logserver protocol = Invalid syslogd server protocol
 WARNING: untranslated string: ipsec = IPsec
 WARNING: untranslated string: ipsec network = IPsec network

diff --git a/doc/language_issues.fr b/doc/language_issues.fr
index 368f66648e30f40331c7e54632e0434a62e5dce4..7b9119764f6fb170308924db38597c1ad48e694d 100644 (file)
--- a/doc/language_issues.fr
+++ b/doc/language_issues.fr
@@ -782,6 +782,7 @@ WARNING: untranslated string: guardian service = unknown string
 WARNING: untranslated string: guardian watch snort alertfile = unknown string
 WARNING: untranslated string: ike lifetime should be between 1 and 8 hours = unknown string
 WARNING: untranslated string: info messages = unknown string
+WARNING: untranslated string: invalid ip or hostname = Invalid IP Address or Hostname
 WARNING: untranslated string: no data = unknown string
 WARNING: untranslated string: ovpn warning rfc3280 = Your host certificate is not RFC3280 compliant. <br>Please update to the latest IPFire version and generate as soon as possible a new root and host certificate.</br><br>All OpenVPN clients needs then to be renewed!</br>
 WARNING: untranslated string: pakfire ago = ago.

diff --git a/doc/language_issues.it b/doc/language_issues.it
index 010b6cead244631663784ae57ad9a650111ae10b..301c0c28ddefc5ff86866af948d677ac4ef476bf 100644 (file)
--- a/doc/language_issues.it
+++ b/doc/language_issues.it
@@ -857,6 +857,7 @@ WARNING: untranslated string: incoming overhead in bytes per second = Incoming O
 WARNING: untranslated string: info messages = unknown string
 WARNING: untranslated string: invalid input for inactivity timeout = Invalid input for Inactivity Timeout
 WARNING: untranslated string: invalid input for valid till days = Invalid input for Valid till (days).
+WARNING: untranslated string: invalid ip or hostname = Invalid IP Address or Hostname
 WARNING: untranslated string: invalid logserver protocol = Invalid syslogd server protocol
 WARNING: untranslated string: log server protocol = protocol:
 WARNING: untranslated string: masquerade blue = Masquerade BLUE

diff --git a/doc/language_issues.nl b/doc/language_issues.nl
index 336a75a061594d3a905db73593595ba0b8c29c32..bbd78eeeb44f0c5351fd74b56ebc6cd67d343bd4 100644 (file)
--- a/doc/language_issues.nl
+++ b/doc/language_issues.nl
@@ -873,6 +873,7 @@ WARNING: untranslated string: incoming overhead in bytes per second = Incoming O
 WARNING: untranslated string: info messages = unknown string
 WARNING: untranslated string: invalid input for inactivity timeout = Invalid input for Inactivity Timeout
 WARNING: untranslated string: invalid input for valid till days = Invalid input for Valid till (days).
+WARNING: untranslated string: invalid ip or hostname = Invalid IP Address or Hostname
 WARNING: untranslated string: invalid logserver protocol = Invalid syslogd server protocol
 WARNING: untranslated string: log server protocol = protocol:
 WARNING: untranslated string: masquerade blue = Masquerade BLUE

diff --git a/doc/language_issues.pl b/doc/language_issues.pl
index 581b99a0ab62d1fc6f40bd06a911baf24027e500..caf8fc497c9dd1d9d9957f3ef9a85ff5d9f3de7c 100644 (file)
--- a/doc/language_issues.pl
+++ b/doc/language_issues.pl
@@ -1029,6 +1029,7 @@ WARNING: untranslated string: invalid input for dpd delay = Invalid input for DP
 WARNING: untranslated string: invalid input for dpd timeout = Invalid input for DPD timeout
 WARNING: untranslated string: invalid input for inactivity timeout = Invalid input for Inactivity Timeout
 WARNING: untranslated string: invalid input for valid till days = Invalid input for Valid till (days).
+WARNING: untranslated string: invalid ip or hostname = Invalid IP Address or Hostname
 WARNING: untranslated string: invalid logserver protocol = Invalid syslogd server protocol
 WARNING: untranslated string: ipsec = IPsec
 WARNING: untranslated string: ipsec network = IPsec network

diff --git a/doc/language_issues.ru b/doc/language_issues.ru
index ae25fb2a29a9a148b7f61037e2c4136b8fe73475..d5a2fc3366f8446d3559a19a8868508124463ca8 100644 (file)
--- a/doc/language_issues.ru
+++ b/doc/language_issues.ru
@@ -1031,6 +1031,7 @@ WARNING: untranslated string: invalid input for dpd delay = Invalid input for DP
 WARNING: untranslated string: invalid input for dpd timeout = Invalid input for DPD timeout
 WARNING: untranslated string: invalid input for inactivity timeout = Invalid input for Inactivity Timeout
 WARNING: untranslated string: invalid input for valid till days = Invalid input for Valid till (days).
+WARNING: untranslated string: invalid ip or hostname = Invalid IP Address or Hostname
 WARNING: untranslated string: invalid logserver protocol = Invalid syslogd server protocol
 WARNING: untranslated string: ipsec = IPsec
 WARNING: untranslated string: ipsec network = IPsec network

diff --git a/doc/language_issues.tr b/doc/language_issues.tr
index 38d8a3fdeaf3e1fa31f325920f879607ed534ccc..b32d216b5c3defbbbfd74fa77f9988ea26b334ae 100644 (file)
--- a/doc/language_issues.tr
+++ b/doc/language_issues.tr
@@ -784,6 +784,7 @@ WARNING: untranslated string: guardian service = unknown string
 WARNING: untranslated string: guardian watch snort alertfile = unknown string
 WARNING: untranslated string: ike lifetime should be between 1 and 8 hours = unknown string
 WARNING: untranslated string: info messages = unknown string
+WARNING: untranslated string: invalid ip or hostname = Invalid IP Address or Hostname
 WARNING: untranslated string: no data = unknown string
 WARNING: untranslated string: ovpn error dh = The Diffie-Hellman parameter needs to be in minimum 2048 bit! <br>Please generate or upload a new Diffie-Hellman parameter, this can be made below in the section "Diffie-Hellman parameters options".</br>
 WARNING: untranslated string: ovpn error md5 = You host certificate uses MD5 for the signature which is not accepted anymore. <br>Please update to the latest IPFire version and generate a new root and host certificate.</br><br>All OpenVPN clients needs then to be renewed!</br>

diff --git a/doc/language_missings b/doc/language_missings
index 84e955d0136f43389056889162c3b7cb8e1a8e36..188455681d52b0ca4f2252807a3119b755596869 100644 (file)
--- a/doc/language_missings
+++ b/doc/language_missings
@@ -494,6 +494,7 @@
 < invalid input for dpd timeout
 < invalid input for inactivity timeout
 < invalid input for valid till days
+< invalid ip or hostname
 < invalid logserver protocol
 < ipsec
 < ipsec network
@@ -782,6 +783,7 @@
 # Checking cgi-bin translations for language: fr                           #
 ############################################################################
 < dnsforward forward_servers
+< invalid ip or hostname
 < ovpn warning rfc3280
 < wlanap neighbor scan
 < wlanap neighbor scan warning
@@ -921,6 +923,7 @@
 < incoming overhead in bytes per second
 < invalid input for inactivity timeout
 < invalid input for valid till days
+< invalid ip or hostname
 < invalid logserver protocol
 < log server protocol
 < masquerade blue
@@ -1156,6 +1159,7 @@
 < incoming overhead in bytes per second
 < invalid input for inactivity timeout
 < invalid input for valid till days
+< invalid ip or hostname
 < invalid logserver protocol
 < log server protocol
 < masquerade blue
@@ -1712,6 +1716,7 @@
 < invalid input for dpd timeout
 < invalid input for inactivity timeout
 < invalid input for valid till days
+< invalid ip or hostname
 < invalid logserver protocol
 < ipsec
 < ipsec network
@@ -2430,6 +2435,7 @@
 < invalid input for dpd timeout
 < invalid input for inactivity timeout
 < invalid input for valid till days
+< invalid ip or hostname
 < invalid logserver protocol
 < ipsec
 < ipsec network
@@ -2705,6 +2711,7 @@
 < crypto warning
 < dnsforward forward_servers
 < fwdfw all subnets
+< invalid ip or hostname
 < ovpn error dh
 < ovpn error md5
 < ovpn warning rfc3280

diff --git a/html/cgi-bin/dnsforward.cgi b/html/cgi-bin/dnsforward.cgi
index 9091ee1db938620c815f66d1ddb8e28c1eee6bc4..521a7a20b4279103b328aa4f167e2f8a0a47aca6 100644 (file)
--- a/html/cgi-bin/dnsforward.cgi
+++ b/html/cgi-bin/dnsforward.cgi
@@ -70,8 +70,8 @@ if ($cgiparams{'ACTION'} eq $Lang::tr{'add'})
        my @forward_servers = split(/\,/, $cgiparams{'FORWARD_SERVERS'});
        foreach my $forward_server (@forward_servers) {
                # Check if the settings for the forward server are valid.
-               unless(&General::validip($forward_server)) {
-                       $errormessage = "$Lang::tr{'invalid ip'}: $forward_server";
+               unless(&General::validip($forward_server) || &General::validfqdn($forward_server)) {
+                       $errormessage = "$Lang::tr{'invalid ip or hostname'}: $forward_server";
                        last;
                }
        }

diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl
index a6fcfea7e93e2e5b43647260f33a94ea7b2b2e89..0ca760f52f8d64c0709e43f55dc750009f45e155 100644 (file)
--- a/langs/de/cgi-bin/de.pl
+++ b/langs/de/cgi-bin/de.pl
@@ -1405,6 +1405,7 @@
 'invalid input for state or province' => 'Ungültige Eingabe für Bundesstaat oder Provinz.',
 'invalid input for valid till days' => 'Ungültige Eingabe für Gültig bis (Tage).',
 'invalid ip' => 'Ungültige IP-Adresse',
+'invalid ip or hostname' => 'Ungültige IP-Addresse oder Hostname',
 'invalid keep time' => 'Die Aufbewahrungszeit muss eine gültige Zahl sein',
 'invalid key' => 'Ungültiger Schlüssel.',
 'invalid loaded file' => 'Ungültige geladene Datei',

diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
index 5bbd0c345da653817a3ff7ae3a62c65bb95a6995..465738b96c1d0f3287d61c3f3068d7073c343a71 100644 (file)
--- a/langs/en/cgi-bin/en.pl
+++ b/langs/en/cgi-bin/en.pl
@@ -1436,6 +1436,7 @@
 'invalid input for state or province' => 'Invalid input for state or province.',
 'invalid input for valid till days' => 'Invalid input for Valid till (days).',
 'invalid ip' => 'Invalid IP Address',
+'invalid ip or hostname' => 'Invalid IP Address or Hostname',
 'invalid keep time' => 'Keep time must be a valid number',
 'invalid key' => 'Invalid key.',
 'invalid loaded file' => 'Invalid loaded file',