]> git.ipfire.org Git - people/pmueller/ipfire-2.x.git/commitdiff
dns.cgi: Only perform reverse lookup if DNS is working.
authorStefan Schantl <stefan.schantl@ipfire.org>
Sat, 11 Jan 2020 18:34:12 +0000 (19:34 +0100)
committerStefan Schantl <stefan.schantl@ipfire.org>
Sat, 11 Jan 2020 18:34:12 +0000 (19:34 +0100)
Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
html/cgi-bin/dns.cgi

index cb6f16f67ac17818238a202da7ad85b09c60dd19..69ab7bb7b8f0a40c5aa8b6758ef48cdc43d4cd18 100755 (executable)
@@ -411,6 +411,7 @@ sub show_nameservers () {
 
        my $dns_status_string;
        my $dns_status_col;
+       my $dns_working;
 
        # Test if the DNS system is working.
        #
@@ -421,6 +422,7 @@ sub show_nameservers () {
        if ($dns_status_ret eq "2") {
                $dns_status_string = "$Lang::tr{'working'}";
                $dns_status_col = "${Header::colourgreen}";
+               $dns_working = 1;
        } else {
                $dns_status_string = "$Lang::tr{'broken'}";
                $dns_status_col = "${Header::colourred}";
@@ -577,7 +579,7 @@ END
                                my $rdns;
 
                                # Only do the reverse lookup if the system is online.
-                               if (&red_is_active()) {
+                               if ($dns_working) {
                                        my $iaddr = inet_aton($nameserver);
                                        $rdns = gethostbyaddr($iaddr, AF_INET);
                                }