From: Stefan Schantl <stefan.schantl@ipfire.org>
Date: Wed, 26 Sep 2018 11:02:28 +0000 (+0200)
Subject: ids.cgi: Only write oinkmaster-modify-sids.conf if neccessary.
X-Git-Url: http://git.ipfire.org/?p=people%2Fpmueller%2Fipfire-2.x.git;a=commitdiff_plain;h=dae534f2ca7172a1171d77fe6acd034591233d58

ids.cgi: Only write oinkmaster-modify-sids.conf if neccessary.

Only write to the file if the runmode of the IDS has been changed.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---

diff --git a/html/cgi-bin/ids.cgi b/html/cgi-bin/ids.cgi
index edf67963b2..f451c5ed45 100644
--- a/html/cgi-bin/ids.cgi
+++ b/html/cgi-bin/ids.cgi
@@ -517,23 +517,23 @@ if ($cgiparams{'RULESET'} eq $Lang::tr{'update'}) {
 	# Generate file to store the home net.
 	&generate_home_net_file();
 
-	# Open modify sid's file for writing.
-	open(FILE, ">$modify_sids_file") or die "Could not write to $modify_sids_file. $!\n";
+	# Check if the runmode has been changed.
+	if($cgiparams{'RUN_MODE'} ne $oldidssettings{'RUN_MODE'}) {
+		# Open modify sid's file for writing.
+		open(FILE, ">$modify_sids_file") or die "Could not write to $modify_sids_file. $!\n";
 
-	# Write file header.
-	print FILE "#Autogenerated file. Any custom changes will be overwritten!\n";
+		# Write file header.
+		print FILE "#Autogenerated file. Any custom changes will be overwritten!\n";
 
-	# Check if the configured runmode is IPS.
-	if ($cgiparams{'RUN_MODE'} eq 'IPS') {
-		# Tell oinkmaster to switch all rules from alert to drop.
-		print FILE "modifysid \* \"alert\" \| \"drop\"\n";
-	}
+		# Check if the configured runmode is IPS.
+		if ($cgiparams{'RUN_MODE'} eq 'IPS') {
+			# Tell oinkmaster to switch all rules from alert to drop.
+			print FILE "modifysid \* \"alert\" \| \"drop\"\n";
+		}
 
-	# Close file handle.
-	close(FILE);
+		# Close file handle.
+		close(FILE);
 
-	# Check if the runmode has been changed.
-	if($cgiparams{'RUN_MODE'} ne $oldidssettings{'RUN_MODE'}) {
 		# Check if a ruleset exists.
 		if (%idsrules) {
 			# Lock the webpage and print message.