From 157d64250a170b905cb440dd6968f7ba6cbaf988 Mon Sep 17 00:00:00 2001 From: Michael Tremer Date: Thu, 7 Jan 2021 12:13:30 +0000 Subject: [PATCH] misc-progs: addonctrl: Replace all sprintf() with snprintf() Signed-off-by: Michael Tremer --- src/misc-progs/addonctrl.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/misc-progs/addonctrl.c b/src/misc-progs/addonctrl.c index c90eb79522..9645cee189 100644 --- a/src/misc-progs/addonctrl.c +++ b/src/misc-progs/addonctrl.c @@ -15,9 +15,8 @@ #define BUFFER_SIZE 1024 -char command[BUFFER_SIZE]; - int main(int argc, char *argv[]) { + char command[BUFFER_SIZE]; if (!(initsetuid())) exit(1); @@ -48,29 +47,29 @@ int main(int argc, char *argv[]) { fprintf(stderr, "\nAddon '%s' not found.\n\naddonctrl addon (start|stop|restart|reload|status|enable|disable)\n\n", name); exit(1); } - + if (strcmp(argv[2], "start") == 0) { - sprintf(command,"/etc/rc.d/init.d/%s start", name); + snprintf(command, BUFFER_SIZE - 1, "/etc/rc.d/init.d/%s start", name); safe_system(command); } else if (strcmp(argv[2], "stop") == 0) { - sprintf(command,"/etc/rc.d/init.d/%s stop", name); + snprintf(command, BUFFER_SIZE - 1, "/etc/rc.d/init.d/%s stop", name); safe_system(command); } else if (strcmp(argv[2], "restart") == 0) { - sprintf(command,"/etc/rc.d/init.d/%s restart", name); + snprintf(command, BUFFER_SIZE - 1, "/etc/rc.d/init.d/%s restart", name); safe_system(command); } else if (strcmp(argv[2], "reload") == 0) { - sprintf(command,"/etc/rc.d/init.d/%s reload", name); + snprintf(command, BUFFER_SIZE - 1, "/etc/rc.d/init.d/%s reload", name); safe_system(command); } else if (strcmp(argv[2], "status") == 0) { - sprintf(command,"/etc/rc.d/init.d/%s status", name); + snprintf(command, BUFFER_SIZE - 1, "/etc/rc.d/init.d/%s status", name); safe_system(command); } else if (strcmp(argv[2], "enable") == 0) { - sprintf(command,"mv -f /etc/rc.d/rc3.d/off/S??%s /etc/rc.d/rc3.d" , name); + snprintf(command, BUFFER_SIZE - 1, "mv -f /etc/rc.d/rc3.d/off/S??%s /etc/rc.d/rc3.d" , name); safe_system(command); } else if (strcmp(argv[2], "disable") == 0) { - sprintf(command,"mkdir -p /etc/rc.d/rc3.d/off"); + snprintf(command, BUFFER_SIZE - 1, "mkdir -p /etc/rc.d/rc3.d/off"); safe_system(command); - sprintf(command,"mv -f /etc/rc.d/rc3.d/S??%s /etc/rc.d/rc3.d/off" , name); + snprintf(command, BUFFER_SIZE - 1, "mv -f /etc/rc.d/rc3.d/S??%s /etc/rc.d/rc3.d/off" , name); safe_system(command); } else { fprintf(stderr, "\nBad argument given.\n\naddonctrl addon (start|stop|restart|reload|enable|disable)\n\n"); -- 2.39.2