cgi-bin: Use readonly="readonly" attribute on html input elements
authorAlf Høgemark <alf@i100.no>
Tue, 18 Feb 2014 17:48:57 +0000 (18:48 +0100)
committerAlf Høgemark <alf@i100.no>
Tue, 18 Feb 2014 17:48:57 +0000 (18:48 +0100)
The proper way to mark readonly is to use readonly="readonly", not
readonly="true", like it was done some places.

html/cgi-bin/fireinfo.cgi
html/cgi-bin/gpl.cgi
html/cgi-bin/mdstat.cgi
html/cgi-bin/ovpnmain.cgi
html/cgi-bin/proxy.cgi
html/cgi-bin/samba.cgi

index 5eec4ba..0060a11 100644 (file)
@@ -156,7 +156,7 @@ print <<END;
        </tr>
        <tr>
                <td colspan='2'>
-                       <textarea rows="25" cols="75" readonly="true">$profile</textarea>
+                       <textarea rows="25" cols="75" readonly="readonly">$profile</textarea>
                </td>
        </tr>
 </table>
index 7589054..5cfbebd 100644 (file)
@@ -58,7 +58,7 @@ print <<END;
 END
 ;      
 if ( -e "/usr/share/doc/licenses/GPLv3" ) {
-       print '<textarea rows=\'25\' cols=\'75\' readonly=\'true\'>';
+       print '<textarea rows=\'25\' cols=\'75\' readonly=\'readonly\'>';
        print `cat /usr/share/doc/licenses/GPLv3`;
        print '</textarea>';
 }
index 35c7deb..e22856f 100644 (file)
@@ -41,7 +41,7 @@ my %mainsettings = ();
 
 &Header::openbox('100%', 'left',"MD Raid State");
 
-print '<textarea rows="25" cols="80" readonly="true">';
+print '<textarea rows="25" cols="80" readonly="readonly">';
 print `cat "/proc/mdstat"`;
 print '</textarea>';
 
index 1ff2bf9..557cf72 100644 (file)
@@ -2488,7 +2488,7 @@ if ($cgiparams{'ACTION'} eq "edit"){
     <table width='100%' border='0'>
     <tr><form method='post'>
        <td width='10%' nowrap='nowrap'>$Lang::tr{'ccd name'}:</td><td><input type='TEXT' name='ccdname' value='$cgiparams{'ccdname'}' /></td>
-       <td width='8%'>$Lang::tr{'ccd subnet'}:</td><td><input type='TEXT' name='ccdsubnet' value='$cgiparams{'ccdsubnet'}' readonly /></td></tr>
+       <td width='8%'>$Lang::tr{'ccd subnet'}:</td><td><input type='TEXT' name='ccdsubnet' value='$cgiparams{'ccdsubnet'}' readonly='readonly' /></td></tr>
        <tr><td colspan='4' align='right'><hr><input type='submit' value='$Lang::tr{'save'}' /><input type='hidden' name='ACTION' value='editsave'/>
        <input type='hidden' name='ccdname' value='$cgiparams{'ccdname'}'/><input type='submit' value='$Lang::tr{'cancel'}' />
        </td></tr>
index c8f0dca..c4cff47 100644 (file)
@@ -2236,7 +2236,7 @@ print <<END
        <td width='25%'><input type='text' name='NCSA_USERNAME' value='$proxysettings{'NCSA_USERNAME'}' size='12'
 END
 ;
-       if ($proxysettings{'ACTION'} eq $Lang::tr{'edit'}) { print " readonly "; }
+       if ($proxysettings{'ACTION'} eq $Lang::tr{'edit'}) { print " readonly='readonly' "; }
        print <<END
         /></td>
        <td width='25%' class='base'>$Lang::tr{'advproxy NCSA group'}:</td>
index d48edf8..cdc9664 100644 (file)
@@ -816,7 +816,7 @@ END
                <form method='post' action='$ENV{'SCRIPT_NAME'}#$Lang::tr{'accounting'}'>
                <table width='95%' cellspacing='0'>
                <tr bgcolor='$color{'color20'}'><td colspan='2' align='left'><b>$Lang::tr{'change passwords'}</b></td></tr>
-               <tr><td align='left'>$Lang::tr{'username'}</td><td><input type='text' name='USERNAME' value='$username' size='30' readonly /></td></tr>
+               <tr><td align='left'>$Lang::tr{'username'}</td><td><input type='text' name='USERNAME' value='$username' size='30' readonly='readonly' /></td></tr>
                <tr><td align='left'>$Lang::tr{'password'}</td><td><input type='password' name='PASSWORD' value='$password' size='30' /></td></tr>
                <tr><td colspan='2' align='center'><input type='hidden' name='ACTION' value='smbchangepw' />
                                                                                                                                                                <input type='image' alt=$Lang::tr{'save'} title=$Lang::tr{'save'} src='/images/media-floppy.png' /></td></tr>