webgui menus: Make top menu item clickable on mobile safari

The menus in the new default theme does not work properly on
ipad and I guess other devices using mobile safari.

The reason is that <a> tags without href is not marked as
clickable by ios, and therefore no css hover effect is applied.

The fix is either to add a href="#" attribute
or a onclick="return true;" atribute on the <a> tag.
I prefer the href solution, since it is a no javascript solution.

diff --git a/html/html/themes/ipfire/include/functions.pl b/html/html/themes/ipfire/include/functions.pl
index 44ed9b75841600cdc1703ca6702ed6c8b5575ef0..f4c241a55252bd75ed192eed2a05113f6a18b81e 100644 (file)
--- a/html/html/themes/ipfire/include/functions.pl
+++ b/html/html/themes/ipfire/include/functions.pl
@@ -80,7 +80,7 @@ EOF
        foreach my $k1 ( sort keys %$menu ) {
                $link = getlink($menu->{$k1});
                next if (!is_menu_visible($link) or $link eq '');
-               print '<li class="has-sub "><a><span>'.$menu->{$k1}->{'caption'}.'</span></a>';
+               print '<li class="has-sub "><a href="#"><span>'.$menu->{$k1}->{'caption'}.'</span></a>';
                my $submenus = $menu->{$k1}->{'subMenu'};
                &showsubmenu($submenus) if ($submenus);
                print "</li>";