From 896eb2d69354221b2a13770b60a61c5b454126a7 Mon Sep 17 00:00:00 2001
From: Alexander Marx <alexander.marx@ipfire.org>
Date: Fri, 21 Mar 2014 12:54:12 +0100
Subject: [PATCH] Firewall: Allow DNAT with target firewall

---
 html/cgi-bin/firewall.cgi | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/html/cgi-bin/firewall.cgi b/html/cgi-bin/firewall.cgi
index d69d8217f..164e7cbac 100644
--- a/html/cgi-bin/firewall.cgi
+++ b/html/cgi-bin/firewall.cgi
@@ -584,8 +584,10 @@ sub checktarget
 				}
 			}
 		}else{
-			$errormessage=$Lang::tr{'fwdfw dnat error'}."<br>";
-			return $errormessage;
+			if ($fwdfwsettings{'grp2'} ne 'ipfire'){
+				$errormessage=$Lang::tr{'fwdfw dnat error'}."<br>";
+				return $errormessage;
+			}
 		}
 	}
 	if ($fwdfwsettings{'tgt_addr'} eq $fwdfwsettings{$fwdfwsettings{'grp2'}} && $fwdfwsettings{'tgt_addr'} ne ''){
@@ -2564,8 +2566,7 @@ END
 					my @src_addresses=&fwlib::get_addresses(\%$hash,$key,'src');
 					my @nat_ifaces;
 					foreach my $val (@src_addresses){
-						my ($ip,$sub)=split("/",$val);
-						push (@nat_ifaces,&fwlib::get_nat_address($$hash{$key}[29],$ip));
+						push (@nat_ifaces,&fwlib::get_nat_address($$hash{$key}[29],$val));
 					}
 					@nat_ifaces=&del_double(@nat_ifaces);
 					$natstring = join(', ', @nat_ifaces);
-- 
2.39.2