]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit - gdb/ChangeLog
gdb: fix -Wtautological-overlap-compare warning in mips-linux-tdep.c
authorSimon Marchi <simon.marchi@efficios.com>
Sat, 16 May 2020 15:21:41 +0000 (11:21 -0400)
committerSimon Marchi <simon.marchi@efficios.com>
Sat, 16 May 2020 15:21:41 +0000 (11:21 -0400)
commit59f7bd8d2b855162db6784c9724ead9e2377f32c
tree032afd1f753c755bf0b5f19e0ce67727aa53410a
parent56770bdab2585be4d3171b3512d2167106dca53e
gdb: fix -Wtautological-overlap-compare warning in mips-linux-tdep.c

When building with clang 11, I get:

  CXX    mips-linux-tdep.o
/home/smarchi/src/binutils-gdb/gdb/mips-linux-tdep.c:643:30: error: overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare]
      if (insn != 0x03e07821 || insn != 0x03e07825)
          ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
/home/smarchi/src/binutils-gdb/gdb/mips-linux-tdep.c:636:30: error: overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare]
      if (insn != 0x03e0782d || insn != 0x03e07825)
          ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~

Indeed, given two different values, `insn` will always be different to
one of them, and these conditions always be true.

This code is meant to return if `insn` isn't one of these two values, so
the `||` should be replaced with `&&`.

gdb/ChangeLog:

* mips-linux-tdep.c (mips_linux_in_dynsym_stub): Fix condition.
gdb/ChangeLog
gdb/mips-linux-tdep.c