]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit - gdb/gdbserver/ChangeLog
Convert fatal to gdb_assert in both i386_dr_low_set_addr
authorGary Benson <gbenson@redhat.com>
Wed, 6 Aug 2014 13:00:14 +0000 (14:00 +0100)
committerGary Benson <gbenson@redhat.com>
Thu, 28 Aug 2014 14:06:46 +0000 (15:06 +0100)
commitf7160e97410b4b65330e5f23d82e8879c908de50
treecc38b2636046f15e9eda8bcc2c564503264e8b6f
parent38e08fcac0966f52dac0ec97870fdea4de304d86
Convert fatal to gdb_assert in both i386_dr_low_set_addr

This commit converts if..fatal checks in both i386_dr_low_set_addr
implementations to gdb_asserts.  It's not obvious from the context,
but the conditional in both cases is changed to match the equivalent
conditional in the i386_dr_low_get_addr implementations.  Nothing
fundamental has changed because DR_FIRSTADDR is zero.  This commit
also removes a vague comment in Linux i386_dr_low_get_addr.  I could
have reworded the comment (and replicated it three times for the other
identical assertions) but I think the existence of specific functions
for the status and control registers makes it fairly obvious what is
going on.

gdb/gdbserver/ChangeLog:

* linux-x86-low.c (i386_dr_low_set_addr): Replace check with
gdb_assert.
(i386_dr_low_get_addr): Remove vague comment.
* win32-i386-low.c (i386_dr_low_set_addr): Replace check with
gdb_assert.
gdb/gdbserver/ChangeLog
gdb/gdbserver/linux-x86-low.c
gdb/gdbserver/win32-i386-low.c