]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
Fix "list" when control characters are seen
authorTom Tromey <tromey@adacore.com>
Tue, 9 Apr 2019 18:52:46 +0000 (12:52 -0600)
committerTom Tromey <tromey@adacore.com>
Fri, 19 Apr 2019 19:01:54 +0000 (13:01 -0600)
commit62160ec9547cdd21ac7334d9a378ca2930aac61c
tree55873c12bd4acb1b1f7434524a1a2c0d10c3dc49
parentee3c5f8968e7b43854204898fa46933b3a1b5991
Fix "list" when control characters are seen

PR symtab/24423 points out that control characters in a source file
cause a hang in the "list" command, a regression introduced by the
styling changes.

This patch, from the PR, fixes the bug.  I've included a minimal
change to the "list" test that exercises this code.

I recall that this bug was discussed on gdb-patches, and I thought
there was a patch there as well, but I was unable to find it.

gdb/ChangeLog
2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>

PR symtab/24423:
* source.c (print_source_lines_base): Advance "iter" when a
control character is seen.

gdb/testsuite/ChangeLog
2019-04-19  Tom Tromey  <tromey@adacore.com>

PR symtab/24423:
* gdb.base/list0.h (foo): Add a control-l character.
gdb/ChangeLog
gdb/source.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.base/list0.h