]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
sim/aarch64: Fix register ordering bug in blr (PR sim/25318)
authorCarlo Bramini <carlo_bramini@users.sourceforge.net>
Thu, 6 Feb 2020 22:50:26 +0000 (22:50 +0000)
committerAndrew Burgess <andrew.burgess@embecosm.com>
Thu, 6 Feb 2020 22:50:26 +0000 (22:50 +0000)
commit69b1ffdb01106ed84a41a80f6ad2d9c26c4f45a9
tree284c914e9ea392b7d0c682e09a9838d0b53b6f30
parent1d5d29e73f4b5f1af4df5b6e39ccf2fa722acead
sim/aarch64: Fix register ordering bug in blr (PR sim/25318)

A comment in the implementation of blr says:

  /* The pseudo code in the spec says we update LR before fetching.
     the value from the rn.  */

With 'rn' being the register holding the destination address.

This may have been true at one point, but the ISA manual now clearly
shows the destination register being read before the link register is
written.

This commit updates the implementation of blr to match.

sim/aarch64/ChangeLog:

PR sim/25318
* simulator.c (blr): Read destination register before calling
aarch64_save_LR.

Change-Id: Icb1c556064e3d9c807ac28440475caa205ab1064
sim/aarch64/ChangeLog
sim/aarch64/simulator.c