]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
gdb: remove unnecessary NULL checks before xfree
authorSimon Marchi <simon.marchi@efficios.com>
Thu, 21 May 2020 17:12:29 +0000 (13:12 -0400)
committerSimon Marchi <simon.marchi@efficios.com>
Thu, 21 May 2020 17:12:29 +0000 (13:12 -0400)
commit84d53fa9d281f057af5916f8663bc9a2872c5f6e
treef6b7498d254e80fcd821b61642ff3f834be7953c
parent0490dd41ae89e66efd8b3cee122c189a481269de
gdb: remove unnecessary NULL checks before xfree

I was inspired by a series of patches merged by Alan Modra in the other
projects, so I did the same in GDB with a bit of Coccinelle and grep.

This patch removes the unnecessary NULL checks before calls to xfree.
They are unnecessary because xfree already does a NULL check.  Since
free is supposed to handle NULL values correctly, the NULL check in
xfree itself is also questionable, but I've left it there for now.

gdb/ChangeLog:

* coffread.c (patch_type): Remove NULL check before xfree.
* corefile.c (set_gnutarget): Likewise.
* cp-abi.c (set_cp_abi_as_auto_default): Likewise.
* exec.c (build_section_table): Likewise.
* remote.c (remote_target::pass_signals): Likewise.
* utils.c (n_spaces): Likewise.
* cli/cli-script.c (document_command): Likewise.
* i386-windows-tdep.c (core_process_module_section): Likewise.
* linux-fork.c (struct fork_info) <~fork_info>: Likewise.
gdb/ChangeLog
gdb/cli/cli-script.c
gdb/coffread.c
gdb/corefile.c
gdb/cp-abi.c
gdb/exec.c
gdb/i386-windows-tdep.c
gdb/linux-fork.c
gdb/remote.c
gdb/symfile.c
gdb/utils.c