]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
Avoid expect's buffer overflow in info-var.exp test.
authorPhilippe Waroquiers <philippe.waroquiers@skynet.be>
Sat, 31 Aug 2019 15:25:54 +0000 (17:25 +0200)
committerPhilippe Waroquiers <philippe.waroquiers@skynet.be>
Wed, 4 Sep 2019 20:16:56 +0000 (22:16 +0200)
commit98b0ebab0a1eb0c1f179ebe633250e7201d35bce
tree634d07e6e3b2dd0a944d2a371a2227c5edba47bc
parentee6d95574b4ebf6a9e791eb6eda495ad78a92dc9
Avoid expect's buffer overflow in info-var.exp test.

Once the executable is started, info variables can show thousands
of variables belonging to glibc (see below).

This long list of variables then causes the test to fail, due
to expect's buffer overflow:
  Running /bd/home/philippe/gdb/git/build_binutils-gdb/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/info-var.exp ...
  ERROR: internal buffer is full.
  ERROR: internal buffer is full.
  ERROR: internal buffer is full.

Fix this by testing 'info variables' without running the executable.

gdb ./info-var
...
Reading symbols from ./info-var...
(gdb) |info variables|wc
     27      54     971
(gdb) start
Temporary breakpoint 1 at 0x1129: file /bd/home/philippe/gdb/git/build_binutils-gdb/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/info-var-f1.c, line 23.
Starting program: /bd/home/philippe/gdb/git/build_binutils-gdb/gdb/testsuite/outputs/gdb.base/info-var/info-var

Temporary breakpoint 1, main ()
    at /bd/home/philippe/gdb/git/build_binutils-gdb/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/info-var-f1.c:23
23   return global_var + get_offset() + f1_var;
(gdb) |info variables|wc
   4334   14581  130738
(gdb)

gdb/testsuite/ChangeLog
2019-09-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>

* gdb.base/info-var.exp: Test info variables without running
to main, to avoid expect's buffer overflow.
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.base/info-var.exp