]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
gdbsupport, gdbserver, gdb: use -Wno-vla-cxx-extension
authorSimon Marchi <simon.marchi@efficios.com>
Fri, 12 Apr 2024 17:51:54 +0000 (13:51 -0400)
committerSimon Marchi <simon.marchi@polymtl.ca>
Wed, 17 Apr 2024 14:49:32 +0000 (10:49 -0400)
commitcbb97c5be367123a00846d4dacb6a042fff87901
tree93bf7b474fb77fb86468ad795bfe395a5c8c1bb0
parent1992aeb29ee6f14b0db3801538363ca606a9e687
gdbsupport, gdbserver, gdb: use -Wno-vla-cxx-extension

When building with clang 18, I see:

      CXX    aarch64-linux-tdep.o
    /home/smarchi/src/binutils-gdb/gdb/aarch64-linux-tdep.c:1299:26: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-cxx-extension]
     1299 |       gdb_byte za_zeroed[za_bytes];
          |                          ^~~~~~~~
    /home/smarchi/src/binutils-gdb/gdb/aarch64-linux-tdep.c:1299:26: note: read of non-const variable 'za_bytes' is not allowed in a constant expression
    /home/smarchi/src/binutils-gdb/gdb/aarch64-linux-tdep.c:1282:10: note: declared here
     1282 |   size_t za_bytes = std::pow (sve_vl_from_vg (svg), 2);
          |          ^

Since we are using VLAs right now, that warning doesn't make sense for
us.  add `-Wno-vla-cxx-extension` to the list of warning flags we try to
enable.  If we ever choose to disallow VLAs, we can remove that flag.

Change-Id: Ie41feafc50c343f6e75333d4f836ce32fbeb6d8c
gdb/configure
gdbserver/configure
gdbsupport/configure
gdbsupport/warning.m4