]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
libctf, ld: handle nonrepresentable types better
authorNick Alcock <nick.alcock@oracle.com>
Mon, 25 Oct 2021 10:17:02 +0000 (11:17 +0100)
committerNick Alcock <nick.alcock@oracle.com>
Mon, 25 Oct 2021 10:17:05 +0000 (11:17 +0100)
commiteb5323fdf88aff59afca0a545877c4d777ff2726
treebacc4ebe4f83df36805d5a30ec1f890be3e89295
parenta0cc569d599f92c3a9168fcd23a0b18f7ff42f1d
libctf, ld: handle nonrepresentable types better

ctf_type_visit (used, among other things, by the type dumping code) was
aborting when it saw a nonrepresentable type anywhere: even a single
structure member with a nonrepresentable type caused an abort with
ECTF_NONREPRESENTABLE.  This is not useful behaviour, given that the
abort comes from a type-resolution we are only doing in order to
determine whether the type is a structure or union.  We know
nonrepresentable types can't be either, so handle that case and
pass the nonrepresentable type down.

(The added test verifies that the dumper now handles this case and
prints nonrepresentable structure members as it already does
nonrepresentable top-level types, rather than skipping the whole
structure -- or, without the previous commit, skipping the whole types
section.)

ld/ChangeLog
2021-10-25  Nick Alcock  <nick.alcock@oracle.com>

* testsuite/ld-ctf/nonrepresentable-member.*: New test.

libctf/ChangeLog
2021-10-25  Nick Alcock  <nick.alcock@oracle.com>

* ctf-types.c (ctf_type_rvisit): Handle nonrepresentable types.
ld/ChangeLog
ld/testsuite/ld-ctf/nonrepresentable-member.c [new file with mode: 0644]
ld/testsuite/ld-ctf/nonrepresentable-member.d [new file with mode: 0644]
libctf/ChangeLog
libctf/ctf-types.c