]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
testsuite: Fix cc-with-tweaks.sh being executed in the wrong shell
authorSimon Marchi <simon.marchi@ericsson.com>
Wed, 20 Jun 2018 16:46:28 +0000 (12:46 -0400)
committerSimon Marchi <simon.marchi@ericsson.com>
Wed, 20 Jun 2018 16:46:28 +0000 (12:46 -0400)
commitf00674fe074f6ea778503a50132c3214a9c6aec8
tree0171b4dedf5fb6708243138f23dcffdb1464db9a
parent19f3f25f370fbf7f5c2aa12a909d57f6e38ee2da
testsuite: Fix cc-with-tweaks.sh being executed in the wrong shell

The cc-with-tweaks.sh script needs to be executed with bash.  When
trying to run this:

  make check RUNTESTFLAGS="--target_board=dwarf4-gdb-index" TESTS="gdb.base/return.exp"

I get:

  gdb compile failed, /home/emaisin/src/binutils-gdb/gdb/contrib/cc-with-tweaks.sh: 174: /home/emaisin/src/binutils-gdb/gdb/contrib/cc-with-tweaks.sh: Bad substitution

The reason is that the board files execute cc-with-tweaks.sh using
/bin/sh, which points to dash on my machine.  Remove the /bin/sh part
and let the shebang choose the right interpreter.

gdb/testsuite/ChangeLog:

* boards/cc-with-tweaks.exp: Don't call cc-with-tweaks.sh
through /bin/sh.
* boards/dwarf4-gdb-index.exp: Likewise.
* boards/fission-dwp.exp: Likewise.
gdb/testsuite/ChangeLog
gdb/testsuite/boards/cc-with-tweaks.exp
gdb/testsuite/boards/dwarf4-gdb-index.exp
gdb/testsuite/boards/fission-dwp.exp