]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
Fix GDBserver build failure when $development is false
authorYao Qi <yao.qi@linaro.org>
Mon, 8 Jan 2018 10:09:33 +0000 (10:09 +0000)
committerYao Qi <yao.qi@linaro.org>
Mon, 8 Jan 2018 10:16:35 +0000 (10:16 +0000)
commitf464485579f8e0a22e87aaa568b7ed4b3ec13ee3
tree85dc03f2d60a01d5ee9634f6726ca94fe8af75a7
parent6caf4baae5fc2ea553b981eeb9533ce287e7b86c
Fix GDBserver build failure when $development is false

When we set bfd/development.sh:$development to false, GDBserver failed to
build,

selftest.o: In function `selftests::run_tests(char const*)':
binutils-gdb/gdb/gdbserver/../common/selftest.c:97:undefined reference to `selftests::reset()'
collect2: error: ld returned 1 exit status

selftest.o shouldn't be compiled and linked when $development is false.
With this patch, in release mode, GDBserver doesn't nothing with option
--selftest,

$ ./gdbserver --selftest=foo
Selftests are not available in a non-development build.
$ ./gdbserver --selftest
Selftests are not available in a non-development build.

gdb/gdbserver:

2018-01-08  Yao Qi  <yao.qi@linaro.org>
    Simon Marchi  <simon.marchi@ericsson.com>

* Makefile.in (OBS): Remove selftest.o.
* configure.ac: Set srv_selftest_objs if $development is true.
(GDBSERVER_DEPFILES): Append $srv_selftest_objs.
* configure: Re-generated.
* server.c (captured_main): Wrap variable selftest_filter with
GDB_SELF_TEST.

gdb/testsuite:

2018-01-08  Simon Marchi  <simon.marchi@ericsson.com>

* gdb.server/unittest.exp: Match the output in non-development
mode.
gdb/gdbserver/ChangeLog
gdb/gdbserver/Makefile.in
gdb/gdbserver/configure
gdb/gdbserver/configure.ac
gdb/gdbserver/server.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.server/unittest.exp