]> git.ipfire.org Git - thirdparty/bird.git/commit
Nest: Prevent withdraws from propagation back to source protocol
authorOndrej Zajicek (work) <santiago@crfreenet.org>
Wed, 30 Jan 2019 16:25:21 +0000 (17:25 +0100)
committerOndrej Zajicek (work) <santiago@crfreenet.org>
Wed, 30 Jan 2019 16:25:21 +0000 (17:25 +0100)
commite84c81b76ff6af88041b55c4ed25c208f78d4826
tree7845be5ce5d8f741f271631fed65e83e1fce5f62
parentee95f281f038684a4a2613a0c54af7389afe64da
Nest: Prevent withdraws from propagation back to source protocol

The earlier fix loosen conditions for not running filters on old
route when deciding about route propagation to a protocol to avoid
issues with ghost routes in some race conditions.

Unfortunately, the fix also caused back-propagation of withdraws. For
regular updates, back-propagation is prevented in import_control hooks,
but these are not called on withdraws. For them, import_control hooks
are called on old routes instead, changing (old, NULL) notification
to (NULL, NULL), which is ignored. By not calling export processing
in some cases, the withdraw is not ignored and is back-propagated.

This patch fixes that by contract conditions so the earlier fix is not
applied to back-propagated updates.
nest/rt-table.c