From: Ondrej Zajicek (work) <santiago@crfreenet.org>
Date: Mon, 17 Dec 2018 16:01:08 +0000 (+0100)
Subject: OSPF: Fix wrong LSA collisions detection
X-Git-Tag: v2.0.3~11
X-Git-Url: http://git.ipfire.org/?p=thirdparty%2Fbird.git;a=commitdiff_plain;h=cea2e25f417866129ce7e78f1c078e993743173c

OSPF: Fix wrong LSA collisions detection

In some circumstances (old LSA flushed but not acknowledged and not
removed) origination of a new LSA may wrongly triggers LSA collision
code. The patch fixes that.

Thanks to Asbjorn Mikkelsen for the bugreport and @mdelagueronniere
for the original patch.
---

diff --git a/proto/ospf/topology.c b/proto/ospf/topology.c
index 03b773499..e58f13753 100644
--- a/proto/ospf/topology.c
+++ b/proto/ospf/topology.c
@@ -404,6 +404,8 @@ ospf_refresh_lsa(struct ospf_proto *p, struct top_hash_entry *en)
 void
 ospf_flush_lsa(struct ospf_proto *p, struct top_hash_entry *en)
 {
+  en->nf = NULL;
+
   if (en->next_lsa_body)
   {
     mb_free(en->next_lsa_body);