]> git.ipfire.org Git - thirdparty/collectd.git/commit
Pass strcmp() to c_avl_create() as function pointer, not data one
authorEero Tamminen <eero.t.tamminen@intel.com>
Wed, 17 Jan 2024 15:19:16 +0000 (17:19 +0200)
committerEero Tamminen <eero.t.tamminen@intel.com>
Fri, 19 Jan 2024 17:07:16 +0000 (19:07 +0200)
commit42c3871e2d340f98032df303a5e82173bdc1b357
treef6574cb3c51dc9d84d664c1af849e3b7428f7d35
parent153678dc18f8f1759c311b2cdf7c4d3f14c3c898
Pass strcmp() to c_avl_create() as function pointer, not data one

Matches how strcmp() is passed to c_avl_create() elsewhere.

Reported by -Wpendantic:
------------------------------------
write_prometheus.c: In function ‘prom_init’:
write_prometheus.c:900:28: error: ISO C forbids conversion of function pointer to object pointer type [-Werror=pedantic]
  900 |     metrics = c_avl_create((void *)strcmp);
      |                            ^
write_prometheus.c:900:28: error: ISO C forbids passing argument 1 of ‘c_avl_create’ between function pointer and ‘void *’ [-Werror=pedantic]
  900 |     metrics = c_avl_create((void *)strcmp);
      |                            ^~~~~~~~~~~~~~
In file included from write_prometheus.c:30:
utils/avltree/avltree.h:54:34: note: expected ‘int (*)(const void *, const void *)’ but argument is of type ‘void *’
   54 | c_avl_tree_t *c_avl_create(int (*compare)(const void *, const void *));
      |
                                   ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
------------------------------------

Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
src/redfish.c
src/utils/format_stackdriver/format_stackdriver.c
src/write_prometheus.c