The cups-exec helper program could fail randomly on OS X due to sandbox

violations when closing excess file descriptors (<rdar://problem/14421943>)

The scheduler incorrectly did not use the kqueue interface on OS X.

git-svn-id: svn+ssh://src.apple.com/svn/cups/cups.org/trunk@11142 a1ca3aef-8c08-0410-bb20-df032aa958be

diff --git a/CHANGES.txt b/CHANGES.txt
index 25640ec595921e359222fb64892ec3b76b03f3de..342483b981e475fea16f172f0317068087189bc8 100644 (file)
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,5 +1,13 @@
-CHANGES.txt - 1.7rc1 - 2013-07-10
----------------------------------
+CHANGES.txt - 1.7.0 - 2013-07-16
+--------------------------------
+
+CHANGES IN CUPS V1.7.0
+
+       - The cups-exec helper program could fail randomly on OS X due to
+         sandbox violations when closing excess file descriptors
+         (<rdar://problem/14421943>)
+       - The scheduler incorrectly did not use the kqueue interface on OS X.
+
 
 CHANGES IN CUPS V1.7rc1
 

diff --git a/scheduler/cups-exec.c b/scheduler/cups-exec.c
index 1541a785f019bd7b35696ef757d0238fc9c5b882..c90b648735eb982c5176de63264bb052a846f80d 100644 (file)
--- a/scheduler/cups-exec.c
+++ b/scheduler/cups-exec.c
@@ -3,7 +3,7 @@
  *
  *   Sandbox helper for CUPS.
  *
- *   Copyright 2007-2012 by Apple Inc.
+ *   Copyright 2007-2013 by Apple Inc.
  *
  *   These coded instructions, statements, and computer programs are the
  *   property of Apple Inc. and are protected by Federal copyright
@@ -75,20 +75,6 @@ main(int  argc,                              /* I - Number of command-line args */
   }
 #endif /* HAVE_SANDBOX_H */
 
- /*
-  * Close file descriptors we don't need (insurance):
-  *
-  * 0   = stdin
-  * 1   = stdout
-  * 2   = stderr
-  * 3   = back-channel
-  * 4   = side-channel
-  * 5-N = unused
-  */
-
-  for (i = 5; i < 1024; i ++)
-    close(i);
-
  /*
   * Execute the program...
   */

diff --git a/scheduler/select.c b/scheduler/select.c
index 44fa20b4c3b5815f52e79224769754c3924caaaf..16061d95eb54a6b4c75c1a0a1c830b3e1c85cac4 100644 (file)
--- a/scheduler/select.c
+++ b/scheduler/select.c
@@ -3,7 +3,7 @@
  *
  *   Select abstraction functions for the CUPS scheduler.
  *
- *   Copyright 2007-2012 by Apple Inc.
+ *   Copyright 2007-2013 by Apple Inc.
  *   Copyright 2006-2007 by Easy Software Products.
  *
  *   These coded instructions, statements, and computer programs are the
@@ -30,7 +30,6 @@
  */
 
 #include "cupsd.h"
-#undef HAVE_KQUEUE
 
 #ifdef HAVE_EPOLL
 #  include <sys/epoll.h>