From 606cfe8cb99395c1a868946c7716288c693889a8 Mon Sep 17 00:00:00 2001 From: Michael R Sweet Date: Thu, 21 Feb 2019 11:14:12 -0500 Subject: [PATCH] The lpadmin command would hang with a bad PPD file (rdar://41495016) --- CHANGES.md | 1 + systemv/lpadmin.c | 1 + 2 files changed, 2 insertions(+) diff --git a/CHANGES.md b/CHANGES.md index 57bd5f85c..7a9c1350e 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -27,6 +27,7 @@ Changes in CUPS v2.2.11 - Added a USB quirks rule for Xerox printers (Issue #5523) - The scheduler's self-signed certificate did not include all of the alternate names for the server when using GNU TLS (Issue #5525) +- The lpadmin command would hang with a bad PPD file (rdar://41495016) - Fixed a potential crash bug in cups-driverd (rdar://46625579) - Fixed a performance regression with large PPDs (rdar://47040759) - The scheduler did not always idle exit as quickly as it could. diff --git a/systemv/lpadmin.c b/systemv/lpadmin.c index 85604ac40..cb9a9ba81 100644 --- a/systemv/lpadmin.c +++ b/systemv/lpadmin.c @@ -1450,6 +1450,7 @@ set_printer_options( /* Status code */ _cupsLangPrintf(stderr, _("lpadmin: Unable to open PPD \"%s\": %s on line %d."), ppdfile, ppdErrorString(status), linenum); + return (1); } ppdMarkDefaults(ppd); -- 2.39.2