From dbdf8a2a45e57588b358c60154b94e2b33632da5 Mon Sep 17 00:00:00 2001 From: Michael R Sweet Date: Fri, 13 Dec 2019 09:38:13 -0500 Subject: [PATCH] Fix some new compiler warnings (Issue #5700) --- CHANGES.md | 3 ++- backend/ipp.c | 3 +-- backend/lpd.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 78ca1f98a..5959407ea 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -31,8 +31,9 @@ Changes in CUPS v2.3.1 Issue #5683, Issue #5684) - Fixed an error in the jobs web interface template (Issue #5694) - Fixed an off-by-one error in `ippEnumString` (Issue #5695) -- The IPP backend did not detect all cases where a job should be retried using +- Fixed some new compiler warnings (Issue #5700) - Fixed a few issues with the Apple Raster support (rdar://55301114) +- The IPP backend did not detect all cases where a job should be retried using a raster format (rdar://56021091) - Fixed spelling of "fold-accordion". - Fixed the default common name for TLS certificates used by `ippeveprinter`. diff --git a/backend/ipp.c b/backend/ipp.c index 60a4ef20f..3f3e1867d 100644 --- a/backend/ipp.c +++ b/backend/ipp.c @@ -233,7 +233,6 @@ main(int argc, /* I - Number of command-line args */ int waitjob, /* Wait for job complete? */ waitjob_tries = 0, /* Number of times we've waited */ waitprinter; /* Wait for printer ready? */ - time_t waittime; /* Wait time for held jobs */ _cups_monitor_t monitor; /* Monitoring data */ ipp_attribute_t *job_id_attr; /* job-id attribute */ int job_id; /* job-id value */ @@ -2009,7 +2008,7 @@ main(int argc, /* I - Number of command-line args */ _cupsLangPrintFilter(stderr, "INFO", _("Waiting for job to complete.")); - for (delay = _cupsNextDelay(0, &prev_delay), waittime = time(NULL) + 30; !job_canceled;) + for (delay = _cupsNextDelay(0, &prev_delay); !job_canceled;) { /* * Check for side-channel requests... diff --git a/backend/lpd.c b/backend/lpd.c index efc7a9acc..c4aab8b98 100644 --- a/backend/lpd.c +++ b/backend/lpd.c @@ -1046,7 +1046,7 @@ lpd_queue(const char *hostname, /* I - Host to connect to */ * Send the control file... */ - if (lpd_command(fd, "\002%d cfA%03.3d%.15s\n", (int)strlen(control), + if (lpd_command(fd, "\002%d cfA%03d%.15s\n", (int)strlen(control), (int)getpid() % 1000, localhost)) { close(fd); @@ -1096,7 +1096,7 @@ lpd_queue(const char *hostname, /* I - Host to connect to */ * Send the print file... */ - if (lpd_command(fd, "\003" CUPS_LLFMT " dfA%03.3d%.15s\n", + if (lpd_command(fd, "\003" CUPS_LLFMT " dfA%03d%.15s\n", CUPS_LLCAST filestats.st_size, (int)getpid() % 1000, localhost)) { @@ -1179,7 +1179,7 @@ lpd_queue(const char *hostname, /* I - Host to connect to */ * Send control file... */ - if (lpd_command(fd, "\002%d cfA%03.3d%.15s\n", (int)strlen(control), + if (lpd_command(fd, "\002%d cfA%03d%.15s\n", (int)strlen(control), (int)getpid() % 1000, localhost)) { close(fd); -- 2.39.2