From: Petr Menšík <pemensik@redhat.com>
Date: Mon, 4 Oct 2021 19:23:02 +0000 (+0200)
Subject: [(no branch, rebasing pemensik/dhcp-ldap-gssapi-principal)] Do not report missed... 
X-Git-Tag: v4_4_3~17
X-Git-Url: http://git.ipfire.org/?p=thirdparty%2Fdhcp.git;a=commitdiff_plain;h=8b3c6d83e73963f35f1b1429ff83b2e8eda04238

[(no branch, rebasing pemensik/dhcp-ldap-gssapi-principal)] Do not report missed ldap-gssapi-pricipal as error

If DHCP is built with ldap_gssapi support but ldap-gssapi-principal
is not set error level messages is written in the logs.  This is
totally OK to not have the parameter set. Report names of required
options, not internal code variables.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1831332

Signed-off-by: Pavel Zhukov <pzhukov@redhat.com>
Signed-off-by: Petr Menšík <pemensik@redhat.com>
---

diff --git a/server/ldap.c b/server/ldap.c
index 0b128c97..9af83445 100644
--- a/server/ldap.c
+++ b/server/ldap.c
@@ -1375,13 +1375,13 @@ ldap_start (void)
                                                              SV_LDAP_GSSAPI_PRINCIPAL);
 
       if (ldap_gssapi_principal == NULL) {
-          log_error("ldap_gssapi_principal is not set,"
+          log_info("ldap-gssapi-principal is not set,"
                    "GSSAPI Authentication for LDAP will not be used");
       } else {        
         ldap_gssapi_keytab = _do_lookup_dhcp_string_option (options,
                                                           SV_LDAP_GSSAPI_KEYTAB);
         if (ldap_gssapi_keytab == NULL) {
-          log_fatal("ldap_gssapi_keytab must be specified");
+          log_fatal("ldap-gssapi-keytab must be specified");
         } 
 
       	running = strdup(ldap_gssapi_principal);