]> git.ipfire.org Git - thirdparty/gcc.git/commit
ada: Remove explicit decoration of wrapper created in freezing
authorPiotr Trojanek <trojanek@adacore.com>
Mon, 17 Apr 2023 10:14:28 +0000 (12:14 +0200)
committerMarc Poulhiès <poulhies@adacore.com>
Tue, 13 Jun 2023 07:31:42 +0000 (09:31 +0200)
commit230fef15abbbd37ae2ee339839f7b478d1ce2ab3
tree8f58d924a62e18480bcc05a3f2228d0393245a17
parent95e2a51685d5ce977c332735ddc5ef39e777639e
ada: Remove explicit decoration of wrapper created in freezing

We create wrapper functions associated with inherited functions with
controlling results which are not overridden during freezing. We partly
decorated them explicitly, even though they would be fully decorated
later anyway.

This early decoration didn't work as expected, because flag
In_Private_Part that is read by Override_Dispatching_Operation it not
set reliably while freezing (as explained in the comment of
Is_Private_Declaration). In effect, we were getting a circularity
between Alias and Overridden_Operation, which was causing GNATprove to
loop infinitely.

Apparently the cleanest fix is to not decorate the wrapper with an early
call to Override_Dispatching_Operation.

gcc/ada/

* exp_ch3.adb (Make_Controlling_Function_Wrappers): Remove early
decoration.
gcc/ada/exp_ch3.adb