]> git.ipfire.org Git - thirdparty/gcc.git/commit
[PATCH v3] libiberty: Use posix_spawn in pex-unix when available.
authorBrendan Shanks <bshanks@codeweavers.com>
Fri, 10 Nov 2023 04:01:07 +0000 (21:01 -0700)
committerJeff Law <jlaw@ventanamicro.com>
Fri, 10 Nov 2023 04:01:58 +0000 (21:01 -0700)
commit879cf9ff45d94065d89e24b71c6b27c7076ac518
treee1665520ddbc438d86aa2da8874fa8a61f21629e
parent5a410860640f0fbd0a744dd89130d7d709a0ef07
[PATCH v3] libiberty: Use posix_spawn in pex-unix when available.

Hi,

This patch implements pex_unix_exec_child using posix_spawn when
available.

This should especially benefit recent macOS (where vfork just calls
fork), but should have equivalent or faster performance on all
platforms.
In addition, the implementation is substantially simpler than the
vfork+exec code path.

Tested on x86_64-linux.

v2: Fix error handling (previously the function would be run twice in
case of error), and don't use a macro that changes control flow.

v3: Match file style for error-handling blocks, don't close
in/out/errdes on error, and check close() for errors.

libiberty/
* configure.ac (AC_CHECK_HEADERS): Add spawn.h.
(checkfuncs): Add posix_spawn, posix_spawnp.
(AC_CHECK_FUNCS): Add posix_spawn, posix_spawnp.
* aclocal.m4, configure, config.in: Rebuild.
* pex-unix.c [HAVE_POSIX_SPAWN] (pex_unix_exec_child): New function.
libiberty/aclocal.m4
libiberty/config.in
libiberty/configure
libiberty/configure.ac
libiberty/pex-unix.c